workflows.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Dave Hansen <dave@sr71.net>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
	Kees Cook <kees@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Miguel Ojeda <ojeda@kernel.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	SeongJae Park <sj@kernel.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	NeilBrown <neilb@ownmail.net>, Theodore Ts'o <tytso@mit.edu>,
	Sasha Levin <sashal@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	Vlastimil Babka <vbabka@suse.cz>,
	workflows@vger.kernel.org, ksummit@lists.linux.dev
Subject: Re: [PATCH] [v3] Documentation: Provide guidelines for tool-generated content
Date: Wed, 7 Jan 2026 21:15:17 +0000	[thread overview]
Message-ID: <1c74353c-40de-4d0b-a517-92a94f8b4af8@lucifer.local> (raw)
In-Reply-To: <93aadf2b-0df4-49eb-91fd-b401b44ce3af@sr71.net>

On Wed, Jan 07, 2026 at 11:18:52AM -0800, Dave Hansen wrote:
> On 1/7/26 10:12, Lorenzo Stoakes wrote:
> ...
> > I know Linus had the cute interpretation of it 'just being another tool'
> > but never before have people been able to do this.
>
> I respect your position here. But I'm not sure how to reconcile:
>
> 	LLMs are just another tool
> and
> 	LLMs are not just another tool
>
> :)

Well I'm not asking you to reconcile that, I'm providing my point of view
which disagrees with the first position and makes a case for the
second. Isn't review about feedback both positive and negative?

Obviously if this was intended to simply inform the community of the
committee's decision then apologies for misinterpreting it.

I would simply argue that LLMs are not another tool on the basis of the
drastic negative impact its had in very many areas, for which you need only
take a cursory glance at the world to observe.

Thinking LLMs are 'just another tool' is to say effectively that the kernel
is immune from this. Which seems to me a silly position.

>
> Let's look at it another way: What we all *want* for the kernel is
> simplicity. Simple rules, simple documentation, simple code. The
> simplest way to deal with the LLM onslaught is to pray that our existing
> rules will suffice.

I'm not sure we really have rules quite as clearly as you say, as
subsystems differ greatly in what they do.

For one mm merges patches unless averse review is received. Which means a
sudden influx of LLM series is likely to lead to real problems. Not all
subsystems are alike like this.

One rule that seems consistent is that arbitrary dismissal of series is
seriously frowned upon.

The document claims otherwise.

>
> For now, I think the existing rules are holding. We have the luxury of

We're noticing a lot more LLM slop than we used to. It is becoming more and
more of an issue.

Secondly, as I said in my MS thread and maybe even in a previous version of
this one (can't remember) - I fear that once it becomes public that we are
open to LLM patches, the floodgates will open.

The kernel has a thorny reputation of people pushing back, which probably
plays some role in holding that off.

And it's not like I'm asking for much, I'm not asking you to rewrite the
document, or take an entirely different approach, I'm just saying that we
should highlight that :

1. LLMs _allow you to send patches end-to-end without expertise_.

2. As a result, even though the community (rightly) strongly disapproves of
   blanket dismissals of series, if we suspect AI slop [I think it's useful
   to actually use that term], maintains can reject it out of hand.

Point 2 is absolutely a new thing in my view.

> treating LLMs like any other tool. That could change any day because
> some new tool comes along that's better at spamming patches at us. I
> think that's the point you're trying to make is that the dam might break
> any day and we should be prepared for it.
>
> Is that what it boils down to?

I feel I've answered that above.

>
> >> +As with all contributions, individual maintainers have discretion to
> >> +choose how they handle the contribution. For example, they might:
> >> +
> >> + - Treat it just like any other contribution.
> >> + - Reject it outright.
> >
> > This is really not correct, it's simply not acceptable in the community to
> > reject series outright without justification. Yes perhaps people do that,
> > but it's really not something that's accepted.
>
> I'm not quite sure how this gives maintainers a new ability to reject
> things without justification, or encourages them to reject
> tool-generated code in a new way.
>
> Let's say something generated by "checkpatch.pl --fix" that's trying to
> patch arch/x86/foo.c lands in my inbox. I personally think it's OK for
> me as a maintainer to say: "No thanks, checkpatch has burned me too many
> times in foo.c and I don't trust its output there." To me, that's
> rejecting it outright.
>
> Could you explain a bit how this might encourage bad maintainer behavior?

I really don't understand your question or why you're formulating this to
be about bad maintainer behaviour?

It's generally frowned upon in the kernel to outright reject series without
technical justification. I really don't see how you can say that is not the
case?

LLM generated series won't be a trivial checkpatch.pl --fix change, you've
given a trivially identifiable case that you could absolutely justify.

Again, I'm not really asking for much here. As a maintainer I am (very)
concerned about the asymmetry between what can be submitted vs. review
resource.

And to me being able to reference this document and to say 'sorry this
appears to be AI slop so we can't accept it' would be really useful.

Referencing a document that tries very hard to say 'NOP' isn't quite so
useful.

Thanks, Lorenzo

  reply	other threads:[~2026-01-07 21:15 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-06 20:51 Dave Hansen
2026-01-07 17:56 ` Paul E. McKenney
2026-01-07 18:12 ` Lorenzo Stoakes
2026-01-07 19:18   ` Dave Hansen
2026-01-07 21:15     ` Lorenzo Stoakes [this message]
2026-01-07 21:58       ` Steven Rostedt
2026-01-08 11:29         ` Lorenzo Stoakes
2026-01-08 18:19           ` Steven Rostedt
2026-01-08 18:30             ` Lorenzo Stoakes
2026-01-07 22:39       ` James Bottomley
2026-01-08 10:32         ` Lorenzo Stoakes
2026-01-07 23:50       ` dan.j.williams
2026-01-08 10:29         ` Lorenzo Stoakes
2026-01-08 11:43           ` Miguel Ojeda
2026-01-08 11:53             ` Lorenzo Stoakes
2026-01-08  0:06       ` Linus Torvalds
2026-01-08 10:03         ` Lorenzo Stoakes
2026-01-08  0:20       ` Dave Hansen
2026-01-08 10:14         ` Lorenzo Stoakes
2026-01-08 11:56         ` Lorenzo Stoakes
2026-01-08 13:17           ` James Bottomley
2026-01-08 13:56             ` Lorenzo Stoakes
2026-01-08 15:58               ` James Bottomley
2026-01-08 16:35                 ` Lorenzo Stoakes
2026-01-08 19:10                   ` Dave Hansen
2026-01-08 19:23                     ` Lorenzo Stoakes
2026-01-08 19:50                       ` Dave Hansen
2026-01-08 20:14                         ` Steven Rostedt
2026-01-09  5:42                           ` Dan Carpenter
2026-01-09  7:28                             ` Lorenzo Stoakes
2026-01-09 15:28                               ` Steven Rostedt
2026-01-09 15:35                                 ` Lorenzo Stoakes
2026-01-09  7:48                           ` Lorenzo Stoakes
2026-01-09 11:00                             ` Dan Carpenter
2026-01-09 11:25                               ` Lorenzo Stoakes
2026-01-09 15:39                                 ` Steven Rostedt
2026-01-09 15:48                                   ` Lorenzo Stoakes
2026-01-09 16:03                                     ` Steven Rostedt
2026-01-09 16:05                                       ` Lorenzo Stoakes
2026-01-12 15:06                                     ` Dave Hansen
2026-01-09 18:34                               ` Andrew Morton
2026-01-09 19:08                                 ` Steven Rostedt
2026-01-08 20:45                       ` Jens Axboe
2026-01-08 21:04                         ` Liam R. Howlett
2026-01-09  5:29                           ` Dan Carpenter
2026-01-09  7:54                             ` Lorenzo Stoakes
2026-01-09  8:54                               ` Laurent Pinchart
2026-01-09 15:51                                 ` Steven Rostedt
2026-01-09 15:55                                   ` Lorenzo Stoakes
2026-01-09 16:07                                     ` Steven Rostedt
2026-01-09 16:33                                   ` Miguel Ojeda
2026-01-10 15:25                               ` Serge E. Hallyn
2026-01-10 15:52                                 ` Matthew Wilcox
2026-01-10 16:02                                   ` James Bottomley
2026-01-10 16:07                                     ` Steven Rostedt
2026-01-12 19:02                                     ` Dan Carpenter
2026-01-08 14:01             ` Michael S. Tsirkin
2026-01-08 14:24               ` Lorenzo Stoakes
2026-01-08 14:28                 ` Michael S. Tsirkin
2026-01-08 14:35                   ` Lorenzo Stoakes
2026-01-08 14:48               ` Julia Lawall
2026-01-08 15:01                 ` Michael S. Tsirkin
2026-01-08 16:42           ` Sasha Levin
2026-01-08 17:40             ` Lorenzo Stoakes
2026-01-08 18:27             ` Miguel Ojeda
2026-01-08 19:28               ` Lorenzo Stoakes
2026-01-08 19:30                 ` Lorenzo Stoakes
2026-01-09 16:30                 ` Miguel Ojeda
2026-01-09 16:37                   ` Lorenzo Stoakes
2026-01-08 19:16             ` Dave Hansen
     [not found]       ` <42192F04-2C46-4734-8CF6-DEA8739989C3@hohndel.org>
2026-01-08 10:40         ` Lorenzo Stoakes
2026-01-08 13:41       ` Andrew Lunn
2026-01-08 13:53         ` Lorenzo Stoakes
2026-01-08  0:00 ` SeongJae Park
  -- strict thread matches above, loose matches on Subject: below --
2025-11-14 18:35 Dave Hansen
2025-11-14 20:08 ` Luis Chamberlain
2025-11-14 22:52   ` Dave Hansen
2025-11-14 20:17 ` SeongJae Park
2025-11-14 22:53   ` Dave Hansen
2025-11-14 23:19 ` dan.j.williams
2025-11-15 15:22 ` Thomas Gleixner
2025-11-15 19:05   ` Steven Rostedt
2025-11-15 19:07     ` Steven Rostedt
2025-11-15 23:30       ` Thomas Gleixner
2025-11-16 12:38         ` Rafael J. Wysocki
2025-11-16 15:25           ` Kees Cook
2025-11-16 16:17             ` Steven Rostedt
2025-12-23 16:55               ` Greg Kroah-Hartman
2025-12-23 17:10                 ` Jonathan Corbet
2025-12-23 20:56                   ` Steven Rostedt
2025-12-24 15:41                     ` Dave Hansen
2025-12-24 16:23                       ` Simon Glass
2025-11-16 16:01           ` Steven Rostedt
2025-11-17 19:13         ` Dave Hansen
2025-11-15 19:02 ` Steven Rostedt
2025-11-15 20:10 ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c74353c-40de-4d0b-a517-92a94f8b4af8@lucifer.local \
    --to=lorenzo.stoakes@oracle.com \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=dave@sr71.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kees@kernel.org \
    --cc=ksummit@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=neilb@ownmail.net \
    --cc=ojeda@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=sashal@kernel.org \
    --cc=shuah@kernel.org \
    --cc=sj@kernel.org \
    --cc=tytso@mit.edu \
    --cc=vbabka@suse.cz \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox