From: Nikolai Kondrashov <Nikolai.Kondrashov@redhat.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
workflows@vger.kernel.org, Joe Perches <joe@perches.com>,
Andy Whitcroft <apw@canonical.com>, Theodore Ts'o <tytso@mit.edu>,
David Gow <davidgow@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Mark Brown <broonie@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
"Darrick J . Wong" <djwong@kernel.org>,
Charles Han <hanchunchao@inspur.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Linux Kernel Unit Tests <kunit-dev@googlegroups.com>,
Linux Kernel Self Tests <linux-kselftest@vger.kernel.org>,
Veronika Kabatova <vkabatov@redhat.com>,
CKI <cki-project@redhat.com>,
kernelci@lists.linux.dev
Subject: Re: [PATCH 1/3] MAINTAINERS: Introduce V: field for required tests
Date: Thu, 16 Nov 2023 15:41:22 +0200 [thread overview]
Message-ID: <0f517de6-9eea-4641-a1dd-4631360fbe5f@redhat.com> (raw)
In-Reply-To: <ZVYXEry40HTCis00@archie.me>
On 11/16/23 15:20, Bagas Sanjaya wrote:
> On Wed, Nov 15, 2023 at 07:43:49PM +0200, Nikolai Kondrashov wrote:
>> Make scripts/checkpatch.pl ensure any added V: fields reference
>> documented test suites only, and output a warning if a change to a
>> subsystem doesn't certify the required test suites were executed,
>> if any.
>>
>> If the test suite description includes a "Command", then checkpatch.pl
>> will output it as the one executing the suite. The command should run
>> with only the kernel tree and the regular developer environment set up.
>> But, at the same time, could simply output instructions for installing
>> any extra dependencies (or pull some automatically). The idea is to
>> get the developer into feedback loop quicker and easier, so they have
>> something to run and iterate on, even if it involves installing some
>> more stuff first. Therefore it's a good idea to add such wrappers to the
>> kernel tree proper and refer to them from the tests.rst.
>
> Does it also apply to trivial patches (e.g. spelling or checkpatch fixes
> as seen on drivers/staging/)?
Do you mean, will checkpatch.pl suggest executing test suites for trivial
patches as well? If so, then yes, of course. These are inevitable victims of
such mechanisms in general, and it's hard to make an exception for them, but
we have to consider the overall benefit of having more uniform testing vs.
making trivial changes a bit more difficult.
Nick
next prev parent reply other threads:[~2023-11-16 13:41 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 17:43 [RFC PATCH 0/3] " Nikolai Kondrashov
2023-11-15 17:43 ` [PATCH 1/3] " Nikolai Kondrashov
2023-11-15 18:31 ` Joe Perches
2023-11-15 20:01 ` Mark Brown
2023-11-16 12:00 ` Nikolai Kondrashov
2023-11-15 20:14 ` Mark Brown
2023-11-16 12:09 ` Nikolai Kondrashov
2023-11-15 20:38 ` Konstantin Ryabitsev
2023-11-16 12:14 ` Nikolai Kondrashov
2023-11-16 13:26 ` Mark Brown
2023-11-16 13:52 ` Nikolai Kondrashov
2023-11-20 12:40 ` Gustavo Padovan
2023-11-20 13:31 ` Mark Brown
2023-11-22 17:41 ` Nikolai Kondrashov
2023-11-16 13:20 ` Bagas Sanjaya
2023-11-16 13:41 ` Nikolai Kondrashov [this message]
2023-11-16 13:43 ` Bagas Sanjaya
2023-11-16 13:59 ` Greg Kroah-Hartman
2023-11-16 14:21 ` Geert Uytterhoeven
2023-11-20 13:30 ` Ricardo Cañuelo
2023-11-20 20:51 ` Theodore Ts'o
2023-11-20 22:27 ` Mark Brown
2023-11-21 6:04 ` Theodore Ts'o
2023-11-21 10:37 ` David Gow
2023-11-21 13:27 ` Mark Brown
2023-11-22 16:16 ` Theodore Ts'o
2023-11-21 18:24 ` Nikolai Kondrashov
2023-11-21 18:02 ` Nikolai Kondrashov
2023-11-21 10:36 ` David Gow
2023-11-21 20:48 ` Mark Brown
2023-11-22 17:19 ` Nikolai Kondrashov
2023-11-22 1:08 ` kernel test robot
2023-11-15 17:43 ` [PATCH 2/3] MAINTAINERS: Require kvm-xfstests smoke for ext4 Nikolai Kondrashov
2023-11-15 18:58 ` Darrick J. Wong
2023-11-16 16:33 ` Nikolai Kondrashov
2023-11-17 7:09 ` Chandan Babu R
2023-11-19 22:54 ` Theodore Ts'o
2023-11-22 14:44 ` Nikolai Kondrashov
2023-11-22 16:17 ` Darrick J. Wong
2023-11-22 17:44 ` Nikolai Kondrashov
2023-11-22 20:51 ` Dave Chinner
2023-11-15 17:43 ` [PATCH 3/3] MAINTAINERS: Require kunit core tests for framework changes Nikolai Kondrashov
2023-11-20 18:48 ` Daniel Latypov
2023-11-22 17:38 ` Nikolai Kondrashov
2023-12-05 18:02 ` [RFC PATCH v2 00/10] MAINTAINERS: Introduce V: entry for tests Nikolai Kondrashov
2023-12-05 18:02 ` [RFC PATCH v2 01/10] get_maintainer: Survive querying missing files Nikolai Kondrashov
2023-12-05 18:55 ` Joe Perches
2023-12-06 16:16 ` Nikolai Kondrashov
2024-01-31 13:55 ` Nikolai Kondrashov
2023-12-05 18:02 ` [RFC PATCH v2 02/10] MAINTAINERS: Introduce V: entry for tests Nikolai Kondrashov
2023-12-05 18:58 ` Joe Perches
2023-12-06 16:21 ` Nikolai Kondrashov
2023-12-06 8:12 ` David Gow
2023-12-06 16:23 ` Nikolai Kondrashov
2023-12-06 16:38 ` Joe Perches
2023-12-06 16:57 ` Nikolai Kondrashov
2023-12-05 18:02 ` [RFC PATCH v2 03/10] MAINTAINERS: Propose kunit core tests for framework changes Nikolai Kondrashov
2023-12-05 18:03 ` [RFC PATCH v2 04/10] docs: submitting-patches: Introduce Tested-with: Nikolai Kondrashov
2023-12-05 18:59 ` Jonathan Corbet
2023-12-05 19:07 ` Joe Perches
2023-12-06 10:07 ` Geert Uytterhoeven
2023-12-06 16:46 ` Nikolai Kondrashov
2023-12-06 16:31 ` Nikolai Kondrashov
2023-12-05 18:03 ` [RFC PATCH v2 05/10] checkpatch: Propose tests to execute Nikolai Kondrashov
2023-12-05 18:03 ` [RFC PATCH v2 06/10] MAINTAINERS: Support referencing test docs in V: Nikolai Kondrashov
2023-12-06 8:03 ` David Gow
2023-12-06 16:54 ` Nikolai Kondrashov
2023-12-05 18:03 ` [RFC PATCH v2 07/10] MAINTAINERS: Propose kvm-xfstests smoke for ext4 Nikolai Kondrashov
2023-12-05 18:03 ` [RFC PATCH v2 08/10] docs: tests: Document kunit in general Nikolai Kondrashov
2023-12-05 18:03 ` [RFC PATCH v2 09/10] MAINTAINERS: Propose kunit tests for regmap Nikolai Kondrashov
2023-12-05 18:03 ` [RFC PATCH v2 10/10] MAINTAINERS: Add proposal strength to V: entries Nikolai Kondrashov
2024-01-08 10:42 ` [RFC PATCH v2 00/10] MAINTAINERS: Introduce V: entry for tests Nikolai Kondrashov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f517de6-9eea-4641-a1dd-4631360fbe5f@redhat.com \
--to=nikolai.kondrashov@redhat.com \
--cc=apw@canonical.com \
--cc=bagasdotme@gmail.com \
--cc=broonie@kernel.org \
--cc=cki-project@redhat.com \
--cc=davidgow@google.com \
--cc=djwong@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hanchunchao@inspur.com \
--cc=joe@perches.com \
--cc=kernelci@lists.linux.dev \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
--cc=tytso@mit.edu \
--cc=vkabatov@redhat.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox