From: Krzysztof Kozlowski <krzk@kernel.org>
To: Miguel Ojeda <ojeda@kernel.org>, Jonathan Corbet <corbet@lwn.net>
Cc: workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
Neal Gompa <neal@gompa.dev>,
Sami Tolvanen <samitolvanen@google.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
tech-board@groups.linuxfoundation.org,
Steven Rostedt <rostedt@goodmis.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH 1/3] docs: submitting-patches: clarify Acked-by and introduce "# Suffix"
Date: Mon, 13 Jan 2025 12:52:04 +0100 [thread overview]
Message-ID: <0ec44dbc-97a1-4bce-860e-a9627cd9111e@kernel.org> (raw)
In-Reply-To: <20250112152946.761150-2-ojeda@kernel.org>
On 12/01/2025 16:29, Miguel Ojeda wrote:
> Acked-by is typically used by maintainers. However, sometimes it is
> useful to be able to accept the tag from other stakeholders that may not
> have done a deep technical review or may not be kernel developers. For
> instance:
>
> - People with domain knowledge, such as the original author of the
> code being modified.
>
> - Userspace-side reviewers for a kernel uAPI patch, like in DRM --
> see Documentation/gpu/drm-uapi.rst:
>
> > The userspace-side reviewer should also provide an Acked-by on the
> > kernel uAPI patch indicating that they believe the proposed uAPI
> > is sound and sufficiently documented and validated for userspace's
> > consumption.
>
> - Key users of a feature, such as in [1].
>
> Thus clarify that Acked-by may be used by other stakeholders (but most
> commonly by maintainers).
>
> Since, in these cases, it may be confusing why an Acked-by is/was
> provided, allow and suggest to provide a "# Suffix" explaining it.
>
> The "# Suffix" for Acked-by is already being used to clarify what part
> of the patch a maintainer is acknowledging, thus also mention "# Suffix"
> in the relevant paragraph.
>
> Link: https://lore.kernel.org/rust-for-linux/CANiq72m4fea15Z0fFZauz8N2madkBJ0G7Dc094OwoajnXmROOA@mail.gmail.com/ [1]
> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
> Acked-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> ---
> Documentation/process/submitting-patches.rst | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-13 11:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-12 15:29 [PATCH 0/3] Clarifications around Acked-by and "# Suffix" proposal Miguel Ojeda
2025-01-12 15:29 ` [PATCH 1/3] docs: submitting-patches: clarify Acked-by and introduce "# Suffix" Miguel Ojeda
2025-01-12 15:52 ` Neal Gompa
2025-01-12 17:24 ` Greg Kroah-Hartman
2025-01-13 11:52 ` Krzysztof Kozlowski [this message]
2025-01-12 15:29 ` [PATCH 2/3] docs: submitting-patches: clarify difference between Acked-by and Reviewed-by Miguel Ojeda
2025-01-12 15:50 ` Neal Gompa
2025-01-12 16:31 ` Miguel Ojeda
2025-01-12 16:35 ` Neal Gompa
2025-01-12 17:10 ` Miguel Ojeda
2025-01-12 19:59 ` Jonathan Corbet
2025-01-12 20:13 ` Neal Gompa
2025-01-13 14:13 ` Theodore Ts'o
2025-01-13 11:48 ` Krzysztof Kozlowski
2025-01-13 12:38 ` Jani Nikula
2025-01-13 15:15 ` Steven Rostedt
2025-01-14 23:13 ` Darrick J. Wong
2025-01-12 17:25 ` Greg Kroah-Hartman
2025-01-13 11:50 ` Krzysztof Kozlowski
2025-01-12 15:29 ` [PATCH 3/3] docs: submitting-patches: clarify that signers may use their discretion on tags Miguel Ojeda
2025-01-12 15:47 ` Neal Gompa
2025-01-12 16:33 ` Miguel Ojeda
2025-01-12 17:24 ` Greg Kroah-Hartman
2025-01-13 13:36 ` Mark Brown
2025-01-13 14:22 ` Theodore Ts'o
2025-01-13 15:36 ` Steven Rostedt
2025-01-12 17:22 ` Greg Kroah-Hartman
2025-01-13 11:51 ` Krzysztof Kozlowski
2025-01-13 17:47 ` [PATCH 0/3] Clarifications around Acked-by and "# Suffix" proposal Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ec44dbc-97a1-4bce-860e-a9627cd9111e@kernel.org \
--to=krzk@kernel.org \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=neal@gompa.dev \
--cc=ojeda@kernel.org \
--cc=patches@lists.linux.dev \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=skhan@linuxfoundation.org \
--cc=tech-board@groups.linuxfoundation.org \
--cc=torvalds@linux-foundation.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox