From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD76ED10BE3 for ; Sat, 26 Oct 2024 06:21:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC6006B0082; Sat, 26 Oct 2024 02:21:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E76426B0083; Sat, 26 Oct 2024 02:21:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D170B6B0085; Sat, 26 Oct 2024 02:21:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B2EE06B0082 for ; Sat, 26 Oct 2024 02:21:03 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3F5E741303 for ; Sat, 26 Oct 2024 06:20:52 +0000 (UTC) X-FDA: 82714754850.25.26616FD Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) by imf18.hostedemail.com (Postfix) with ESMTP id 4BD4C1C000F for ; Sat, 26 Oct 2024 06:20:52 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wOcYS5Ae; spf=pass (imf18.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.179 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729923505; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yHAwo+JHtR0FwFONME6zc+Rb8ODXdGUmI/r0NvGK1AQ=; b=S5KWWDWnBR7vhNkEwL5/b0W+UocXcmRDc69xK+hjQqnJFo1P0fJo89TQjCS5qHWgdPP1q1 rdoOqnqwffzxhHRmPOmyHyDTaUSEEQC7nlxZnKRi4RHUHBzplKF0EEqhKfoaSoXjjmb6KU ZwaHvriX4w4Di57+NdEmj4rchXLtOJA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729923505; a=rsa-sha256; cv=none; b=QkU7Ti0egZuBe27y8jBOJDeR8yPbZGFmoPmskXmgS20q34MckxksSfMTisrNzmHtcliN+v gEmX/zM0947Gp37cLIGOuVPjH29sqRMj2suGcBRdbP4EqAvoZ2VbASN+HQnsOMiqN3I9DA DeL0hPY9OoG3x56U1HwD0bDJAQCF644= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wOcYS5Ae; spf=pass (imf18.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.179 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Fri, 25 Oct 2024 23:20:52 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1729923659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yHAwo+JHtR0FwFONME6zc+Rb8ODXdGUmI/r0NvGK1AQ=; b=wOcYS5AeAxHZybTQ4tG6y7dgLM71ARuhUQ+7lbNhmGKgYAagc61eRREX3dcRLz0ZjuwE09 ORrfNh6zQFFvU3+6cG+kuaiv+YlAV7GIoM8s5Z/1wrIxKy8H0YAJujRv+O8AbKNX0+U614 shsB3NWF094pDlWoLg+ChAXA2Oo5ec0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Yu Zhao Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Hugh Dickins , Yosry Ahmed , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, Meta kernel team Subject: Re: [PATCH v1 5/6] memcg-v1: no need for memcg locking for MGLRU Message-ID: References: <20241025012304.2473312-1-shakeel.butt@linux.dev> <20241025012304.2473312-6-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: eqxnkgxzf6nnbuj83amzt4c3447mca5t X-Rspamd-Queue-Id: 4BD4C1C000F X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1729923652-377673 X-HE-Meta: U2FsdGVkX1/z3HGZw6frRxsmKYjv8Anog1Hm9c6dEQni6PMwSbha3Cd4cc1bzcP1+TihuDjObs5NO5swTGuVmBz5Zqav9bHofi7Hid4DDa7IIgwO8bEPsuHtLZgu1bjGiJP471OmNqZkJ3KWX59fBZv0j5kOowjNuBdz5PKKtqesrmNiYkyfBAwVrzV1JFPCsFYU1tZKpFsLC9FC4edUuldbg3iu8kMiGjVkbZm5kOHLI+GKU+HeI3+XJeH8ItNjfM3AWSd38u30WrO2lJkES1zdEAO8LFLGtAkUwgkwXTeMw8eWZJG26kxjDl8mcPIwxUd57605jgdNo+oiqnbWTkLTuSUsJ5HPVzVnyWml+twwkWiwt5wyg99Z/O+Z6lAtgjrbJ8ZWlW8pYqNsgCFT2Iskmqa902tm095O9Rbd+RKVX62xqGzE1T64Hk2IQaFmYWg5TqS03MAMMbCciQcK9qQJyZuyAR/svaZ0VF1+LB4TaDV/GwtfblJ8FWt+xaoFuIUv3YUwEl4RHu9CLDh4UtgnN4F5rFvRGWu7cVwVZNnCR99DtsDnegO1ujVmp87GFm2OaV4FiCR4zo6A7hzWl+h8z0gXJnAX0vBn1VyUOkhK42peBuxxHcgNoJTSa1zzrwaHWGX8/chA/Dxjucsyl9uqCnSMmELiDgAEDqwNvTvK5rec1bHpeRtXdUU/QRXYPRWqLAaDJbxer5rOusGh0NEdp0Pyfi5KKjVx8/5qb8xixEnNhGq5Jv/hEFjQZyqLefp4Kk2VYPrC9JrPBtTw51eZNTIg4m16zFsS4c3nDpQZq+Hlsy2TT5ZOIVwsdx4EENmSYFQgKIaCjz2y1KJ2/D5j/kryc75rkYIYhVYwMdFxUIEOspr7E3fh5RBMmDFVFEM0p6awB9eLfvT5XhBPeg2VHdcq91gHZvbFZNjynpPS17SEWu3YWruF8QlxHoNJ5+bH5GtBWlVF45rRKju +qRm50cC pQgMtf9ew5mPepCw0b4ZrcgFHdvTJ3fufA1j0qJwgi1HLpnFtUOAwBpUoPpHoQCJ40gn+Nmn7EseeRbAlIm3U9p7wIcb/vQHe4woOCUtGD3Ij42jkS/2qpw6YhdZ+T+L+RhfGMO2ZGkp5Wz19edBESwVNvfQ/1T5a+W7R+5XDjuAAXAU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 25, 2024 at 09:55:38PM GMT, Yu Zhao wrote: > On Thu, Oct 24, 2024 at 7:23 PM Shakeel Butt wrote: > > > > While updating the generation of the folios, MGLRU requires that the > > folio's memcg association remains stable. With the charge migration > > deprecated, there is no need for MGLRU to acquire locks to keep the > > folio and memcg association stable. > > > > Signed-off-by: Shakeel Butt > > --- > > mm/vmscan.c | 11 ----------- > > 1 file changed, 11 deletions(-) > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index 29c098790b01..fd7171658b63 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -3662,10 +3662,6 @@ static void walk_mm(struct mm_struct *mm, struct lru_gen_mm_walk *walk) > > if (walk->seq != max_seq) > > break; > > Please remove the lingering `struct mem_cgroup *memcg` as well as > folio_memcg_rcu(). Otherwise it causes both build and lockdep > warnings. > Thanks for catching this. The unused warning is already fixed by Andrew, I will fix the folio_memcg_rcu() usage.