From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FAC8C47422 for ; Sat, 27 Jan 2024 01:10:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 943656B0074; Fri, 26 Jan 2024 20:10:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F2786B0075; Fri, 26 Jan 2024 20:10:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E0BB6B0078; Fri, 26 Jan 2024 20:10:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6AEEF6B0074 for ; Fri, 26 Jan 2024 20:10:04 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 195911C0EB9 for ; Sat, 27 Jan 2024 01:10:04 +0000 (UTC) X-FDA: 81723309528.15.B62179F Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) by imf07.hostedemail.com (Postfix) with ESMTP id 21FA64000E for ; Sat, 27 Jan 2024 01:10:01 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=EVA6yrb0; spf=pass (imf07.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.183 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706317802; a=rsa-sha256; cv=none; b=I+U/PxaoWN02XikslkOWqP9x5/9c1NtX5eiFpHsGPrTY7h+ODluIkvlK0gVekJNGgA2zgd i+Yfbqt5+FdKIziSjMItnuuBC4q3MvKBcKRPFJxKoZCivVKDLg+eDGH0Saa/ITgkxDevI2 wwZaJb7qWF4Lyc7MSftN8nsFf5z7j4Y= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=EVA6yrb0; spf=pass (imf07.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.183 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706317802; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X5Z+zvrj4aAqrEptlwLOzGsTYdIUNZGmOXG9NolY9xU=; b=aiueNHtFVNXGgxg30NxCru4auBlyS59A7BzdgSGfDrouNN8gfdOEB5kC5cC5zzv/oiOoiZ ULZl3RU1FRVA9pezvVLYHmPwsGkCMsICEXWcoeFsiPsPHpcg+DbAiAjnD+uf55RViCOCbr kKPSnAkAU9O+qkP5Eep4FI2zBZZdcGg= Date: Fri, 26 Jan 2024 20:09:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1706317799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X5Z+zvrj4aAqrEptlwLOzGsTYdIUNZGmOXG9NolY9xU=; b=EVA6yrb0r4Oo0JFSNJKemqFJjEa+G0m1jAh5LXa3UtcljI9C3g6Hs6QVSyKwVOBZGWRd+9 pq819wlAAwOxY9As7LtgqWrllYrtuvUExfjcP7UAcxkd5j4FPxnmzCDmSY469KzbwrZY+2 TttwVlbrK4807d7qnuLJbNrKpYFfa7o= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Christoph Hellwig Cc: Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 20/21] xfs: convert xfarray_pagesort to deal with large folios Message-ID: References: <20240126132903.2700077-1-hch@lst.de> <20240126132903.2700077-21-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240126132903.2700077-21-hch@lst.de> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 21FA64000E X-Stat-Signature: urgcwcrtb5tuauramhgs88rnrhe9kb7a X-Rspam-User: X-HE-Tag: 1706317801-95567 X-HE-Meta: U2FsdGVkX1/LG/wbocZCdacr432f7yhB31kBHPHhHg+xWfuAq9wbk5LjM9i8a+rj77PRAJTes2/sxQd/fEjkBOIpm10j7lWB3ZF7PmzPQlabXUrW+IIVfoXq37k/aEjX5HeE5kXEuIm1JGuL0/blb2+eirRKMrJIeRkMUh8tv/ZqOMYtrX1AMmUCFPMu/cwoUakC7RvxG5T+wXOlABKgwVSjBxLJBv6Gx75RUC6uIJQm5UT0fwq4AkyKIUDohOcgBxF1GvvKZjoZ91fsppDv6ProXJjNhQy8eL9EyZn6dPa01iDjPMgOxmVGt1uFJaxnMATH6owjRoaeWeelxoFrNoU79A7htiLN24KJP7SXecR48LF7YJEpLdzKxpaOVuPdXteT7Q4PmdU61htQRqSSZwwcJKUG0iYfHHl1S6bC3Eq/shfxSREP2MgfZZwuhbJ+F4rnJCClOy5ZVDz9Kn8wAQG3TpbCQOnXCJ446LnqoRRVF8IU6Ra9XhVnqzqXxUujUGjBsuVECaHF0+f8Fnrbi1nh2qY5txcYaH7VTpMfO8+HEUSgcirSaa8KA0KznHpPEKr4M0XXtfR5LtSTYSiNCejDab8713RCeFOIAujp/1VTIQd7JvsFXMtsFr0llJBFrYEW9vjS2F2gt8QUOl3cOW152+d1uoMBbdE+5MrX9utS5kHQL4ltV5j4gWjUR1lDXLUA81ehIW2cq5XHLxSOKh1SXpL+rPKHIjOtXI7Z+nIFMnn6BCmgS3XGvV+J+PlGihZMQI2dHzVYvR3o2TbUolGAY2X7iFCD0Pr5kSg7NhO5hQTftsBHikXOp5GzFqhx0zL/m1e9Zm4GIzcnBFkMS+vo7Ma6k38WaaBfsHnloUsKfMAdl5D91wWCWsqfz/RD4VBzz9XyFyb+tn/HXS7BG2VagFnISAsiIyis5iMdZ3OzmP6nEWnVZQaYLevBsU29dyFPWQ92UxsuQppxHYv AXOC6h3l gSpitoCQHNW8ygDD9nk8NjxjmM3BR8c1FXtO/Q1TLsUFcnl7HXKkmlqz2yUTGP3O3rwl0wZLkruPXkct143FMY/iGibeGosk0Os6maFNhXDcmHtZXtZB/RpA9Hl7oT45sPrcjlgRjpJZtl0ojeMCtE7BtoeLQICfzmJ7V8StLjscJbLEXbiaVLWfkKcdKusaNUL0pYDEvL4cYLRJamBnEZ2VD19zuTF3KbA9CnMXfJb6k4Eo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 26, 2024 at 02:29:02PM +0100, Christoph Hellwig wrote: > From: "Darrick J. Wong" > > Convert xfarray_pagesort to handle large folios by introducing a new > xfile_get_folio routine that can return a folio of arbitrary size, and > using heapsort on the full folio. This also corrects an off-by-one bug > in the calculation of len in xfarray_pagesort that was papered over by > xfarray_want_pagesort. > > Signed-off-by: Darrick J. Wong > Signed-off-by: Christoph Hellwig not the fastest way this could be done - but it was performance tested and according to Darrick was only 2x slower than the "use a normal sort routine on a contiguously mapped buffer" version, which really isn't that bad. So - Reviewed-by: Kent Overstreet