From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B883C54F30 for ; Tue, 27 May 2025 16:54:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE97F6B00E3; Tue, 27 May 2025 12:54:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9A7F6B00E4; Tue, 27 May 2025 12:54:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB15B6B00E5; Tue, 27 May 2025 12:54:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 990DA6B00E3 for ; Tue, 27 May 2025 12:54:22 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 51BAEC11FE for ; Tue, 27 May 2025 16:54:22 +0000 (UTC) X-FDA: 83489285964.23.AE28948 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) by imf10.hostedemail.com (Postfix) with ESMTP id CE000C0003 for ; Tue, 27 May 2025 16:54:18 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=V3LAt2cT; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748364860; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X7Eb1eNV+fnCUrZVOjpa1doj7OVOazrVC783oZlElww=; b=v7UWRtqW+wkQqv6TvsvIKLymjCbhZobjY3KToH1fwvL6STqJzJk7pCC2KLlKeQXxZYcaoq KKSFEscBdQy21H45OgbvRuPi4QuLj96BwSTRpkIQ4NZKVOGe6k+aMHvcRb+ny3odQR/G3O aB8w5JZlDC3oBNnFceN2Yy8vNwOslmI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=V3LAt2cT; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748364860; a=rsa-sha256; cv=none; b=tQ/HiieAw6aCOpQmqUwEELL/vdX/pIyYCmUcMgtzCLSEMPJiNeOYLSb1wa/fh3ONFg3Qq1 MuhYkDyWr4Tw0SmTEV4Ul9Cb6Zgz8ekKpc4p+k7O62RZILL1NVHj7qKsjPE41pB219TPBu naa+epEP2RuHgC1/cT0Z8hvo6xWutZo= Date: Tue, 27 May 2025 09:54:10 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1748364856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X7Eb1eNV+fnCUrZVOjpa1doj7OVOazrVC783oZlElww=; b=V3LAt2cT1G77bgMqInkvtG2L0r9PGJojdIuvBjSb9ErjNwewzXtEzEI5joRteaHtu35Dh0 EGIYZhxAhIsP8OSxVCaW/v7FGW6j+KPBo4BP/zhN9GwU9IY33M6LMZPgPnnP7sWFrQqAPf dfEpZnqX5bpdqU+784fLRfdX4/P5NSc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Breno Leitao Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , Chen Ridong , Greg Kroah-Hartman , Michal Hocko , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, Michael van der Westhuizen , Usama Arif , Pavel Begunkov , Rik van Riel Subject: Re: [PATCH] memcg: Always call cond_resched() after fn() Message-ID: References: <20250523-memcg_fix-v1-1-ad3eafb60477@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: xnorqn7eaxm8zg5z6o8pmopxgqsokaw5 X-Rspamd-Queue-Id: CE000C0003 X-Rspamd-Server: rspam11 X-HE-Tag: 1748364858-925571 X-HE-Meta: U2FsdGVkX1/Gsmn9nO7VgaxTRXSfLo9+fTVMI24tZgXq9ywSjD/mFOkRdyfIXj+WXV3IqOWkYh/AfOn9+PNMi8gZz2i3Ka3AbLQoXAGIBNfyadnfaGXIVkvuE8dSFf3hDw3ukzgdi/psOFhfwLJGA9xww5Xs1kIHuXkAkzESjrWHvIvNssg/8dvNyBxN39PUAD+hqp/0BMQ/qWpvbAomxeqNblXX1tdHAgRRVhLIa08nbUK/EN66rk1PMUr5nF4Qy3AoHqdpE2khGEGl00UBxY2jBGHRXJuQq1fEjlCNVth+ivnpZDwTI5IctemFFIBvj7Krvd6htobPFXGArm6krFI/XnjstwnStzed8t9JFppWf4jYG2faYgafZJHELDcznTUZX9hklAur0A2bJ3dTqPBUcya24yHqaitWznnxMKoyT9kMwfvp4RprhD936KiANGFkMqmC2Lv4T1ZfRaCc2DDMabvo2b5wSPa6cSIQv8SrttfzuMgUrmep4kAhsM9Dis3DjHtEcPh3aQoqitv4Id9S8Bh4rHYuKeKiZTc1h2e6p4ID59VBgQMstnIH0XUYZcgepFkQ3QWpJEI347Mf+kHnN65nG33+1eFL1V6WeFxJiItRwXRNN2Qe1vLUAF9JZR23y+wlaiO1O/JRx9ADl8tHGcSZOHsZz+DA1dCo0S6O3IVtY6wTRg6wtHjcTmDlJhTKZfpthvEA6qtXjKS9C/rcMHZbYb9hwENFtxAXkMieP2+Tt5RK/2aHmv12w9m8temeELVsql4eb0velZfxvO1F4Hur07/wQfMGNXhMydbWQu1Fca9RHSHFbqz7HYNkCe7w7SFYinKdpZcK9TiF3Ab/f7TWM/Z2Ivv4o41yCExK5m3wwa1EmLh9FArEi/Xs9kyylDVkcsDSGL847yyr1TIa0Q17ZP7AnKIm5zW8QEwMUwc0yovNMgfQPyNAmkefm1CXfN07TMxygtoY0BO 0WxXHIw8 Vll4uzPJ4r14v6OeyMzwCsicSi0AndT6veh/XXTxsYPfp2PYEgPg+oDmPEGWW2P2VtvINWLYJBhQZVHKd1KKd03qf89HvCjDfIbg4GnKVGWKNEqc4JjRPTOBOLzTDqZxdzrP7Z9A2YerQ561Ws+YUjWdG2Ck1IJywQUURgOszTFU6xqcLm+Fp4D/agBbDPfE+pAuUoVo/zbyfXM0ca6eZHbMHRe8SlEmhg1rvwoDxEkhoXtjLWhc3gpjJPMQzTSJmKkztNUfiD7tAm45QTHnuEmq4Spr/5FUGMbhrD8zY8FoI1XRzpy8WZtDx6UJCbOmXoXqSfk4y42ohCTwbrNm7yQ/2Pw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 27, 2025 at 03:03:34AM -0700, Breno Leitao wrote: > > Not sure I followed you here. __oom_kill_process is doing the following: > > static void __oom_kill_process(struct task_struct *victim, const char *message) > { > ... > pr_err("%s: Killed process %d (%s) total-vm:%lukB, anon-rss:%lukB, file-rss:%lukB, shmem-rss:%lukB, UID:%u pgtables:%lukB oom_score_adj:%hd\n", > > > Would you use a buffer to print to, and them flush it at the same time > (with pr_err()?) > Something similar to what mem_cgroup_print_oom_meminfo() does with seq_buf.