From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01F30C77B7F for ; Sun, 14 May 2023 15:08:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16ABA6B0071; Sun, 14 May 2023 11:08:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F3E76B0072; Sun, 14 May 2023 11:08:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED7956B0074; Sun, 14 May 2023 11:08:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DAED66B0071 for ; Sun, 14 May 2023 11:08:24 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8EBB21A1215 for ; Sun, 14 May 2023 15:08:24 +0000 (UTC) X-FDA: 80789191728.14.EF47789 Received: from azure-sdnproxy.icoremail.net (azure-sdnproxy.icoremail.net [52.237.72.81]) by imf26.hostedemail.com (Postfix) with ESMTP id D1A3F14000F for ; Sun, 14 May 2023 15:08:20 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=pku.edu.cn header.s=dkim header.b=DE6z7Mdk; spf=pass (imf26.hostedemail.com: domain of lrh2000@pku.edu.cn designates 52.237.72.81 as permitted sender) smtp.mailfrom=lrh2000@pku.edu.cn; dmarc=pass (policy=none) header.from=pku.edu.cn ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684076902; a=rsa-sha256; cv=none; b=v6v7XtnWkGdyL6ILCuQ3D8pB6adRjFP5jSy+2biGga/BuSBgVe2omo0kGpqgE43SIjkMK6 Ugon9TQlqUPlIOZcMZJ6Wo3aVzBOgdfRJSK8EioR0/1P633qsclO8TspseiznUog8afi0q TaTcFPXtE3p1NPu+CJEJhI73BGMQRbM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=pku.edu.cn header.s=dkim header.b=DE6z7Mdk; spf=pass (imf26.hostedemail.com: domain of lrh2000@pku.edu.cn designates 52.237.72.81 as permitted sender) smtp.mailfrom=lrh2000@pku.edu.cn; dmarc=pass (policy=none) header.from=pku.edu.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684076902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ni4GctG6j2JiKGvnSbCcZe/JfZsDB8hY8dsw53qz1zI=; b=NWxlWY0GjOJVR2IXvsmJqYnjxhL4IWMbd+l2fwqBv00hnLQWxuA8bjXt4O/VHTGaie0IG9 rd36qxN5dooVGML208an5K2Pe5YQwFLsU2AGdzL1msTFN0g6g2utVfagszwi+2t34Km/C8 csXgr13r5IO/BqujfKTkpWAMMpzk42o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pku.edu.cn; s=dkim; h=Received:Date:From:To:Cc:Subject: Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; bh=Ni4GctG6j2JiKGvnSbCcZe/JfZsD B8hY8dsw53qz1zI=; b=DE6z7MdkJsS+bHcnlf7igxWIoUzmIn3KFRIiCBGjR/Rl XDJcF3y6fuCf/riHiMLxrxrTNifVzSGT7k7DQGKSQPiPlLTuDVKmNPg7B6MYoBoH nvualjmSTFxe6uFXkqFzwg0a7IS7BrU+mtwE4VLHtvBiKYu0gNHUiT9mgnjhpAU= Received: from localhost (unknown [10.7.98.243]) by front01 (Coremail) with SMTP id 5oFpogAHnTxb+WBkkWwfAw--.45456S2; Sun, 14 May 2023 23:08:15 +0800 (CST) Date: Sun, 14 May 2023 23:08:11 +0800 From: Ruihan Li To: Greg Kroah-Hartman Cc: Christoph Hellwig , linux-mm@kvack.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Pasha Tatashin , David Hildenbrand , Matthew Wilcox , Andrew Morton , Ruihan Li Subject: Re: [PATCH 0/4] Fix type confusion in page_table_check Message-ID: References: <20230510085527.57953-1-lrh2000@pku.edu.cn> <2023051108-lens-unsocial-8425@gregkh> <2023051324-attentive-footwork-9dec@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023051324-attentive-footwork-9dec@gregkh> X-CM-TRANSID:5oFpogAHnTxb+WBkkWwfAw--.45456S2 X-Coremail-Antispam: 1UD129KBjvJXoWxJr4xuF45Wr1xKw45GF1Utrb_yoW8Xr4Dpa y3tayDta1ktwn3Aw1Ivw1xu34rt3yfKryUW34Yq34fC3ZIgry3KrsrKr4a9F9xCr1kW3W7 XF4jvasxZ3WYy3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUB01xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AE w4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2 IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2 z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0DM2vYz4IE04k24V AvwVAKI4IrM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xf McIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7 v_Jr0_Gr1lF7xvr2IY64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E 8cxan2IY04v7MxkIecxEwVCm-wCF04k20xvY0x0EwIxGrwCF04k20xvE74AGY7Cv6cx26w 4UJr1UMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCj r7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6x IIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAI w20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x 0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjfUOlksUUUUU X-CM-SenderInfo: yssqiiarrvmko6sn3hxhgxhubq/1tbiAgEJBVPy773nzgACsX X-Rspam-User: X-Stat-Signature: ur8gca9u69zx5b7dunazgytkmg3qgrp4 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D1A3F14000F X-HE-Tag: 1684076900-5806 X-HE-Meta: U2FsdGVkX1/owJgOULq7V+8TJI4o8ouLznoDBT7A7kvU8u5k2LIJce1WEBHzwMdq54pI0RsBIRkUPsLokPPid+kACVMJHPiHpAEZ63y5EOn0zMgOB1yhaHiZj8QQNl3hxIrVP00q9shHUB9LvgQtWY8JNTCETvnZ61JeTHXxb3OdS4DByUURAVNvu2ccOpj6Q5/yp+yxNv5yqTkXQNI83dG47/+rjvs9Z7WxrpUgEfS0TF4LlAu74dsZ1u5XvGDg4vil7VAp+jR2gkzo558XYi5ck6zuOeHoertVQnNcFc1IJv/e6yIG8aCNym+uJDaUfe7sW6Y6sSeUALtX4tc+beeFoqu9JImWaipfmmfAIzWk1diafE97kCJBe5WQwLBvuOhzrBLcveEaxnTx/91JBA6hhZujvhN868bFSXk9vy0UzUzaX7UGLC/YaU/ITELnsUNyMCzgB1v7sPBp/I9DDBkOcEQKxhw1HLyiZE83s06maBeKKtihPaEWgmwCsX73E6wdTq5OBVC595p2fCkHdq5FjWjONwqvEdsLRrpx9HeIM/DqvlW2KDGJlIwmNQ3u5va+tDLngqj0qkwxtlCd1MI5KUzNREBfEisGxaQiXy5nbBPFhds5Z9WAEx+v/a9y7oXrBIqDy8jIA90ua2kg/1NzB6mmIvCo3Kz0287BdHzoux/UPvMgw8abulDY9EH1is97pbuNQeDpdNdxkhgtthRcMCmD4g7vfM67MQdTUu/9qqDm4XkR58FQ/uuKF3xzRHXnFvd6s60zqnh4T9+Rjt81/7TxHlFTZvnZBNJLWXXrVA6ueJShLS1MyZhple8v+4t73J5MBASwUYrLgSa+s9A3E3dFfHyMpV6XeaiMGLSnd0jrNJZVMDCazoXWJjwEITPaqjoodAP0lUqQcypFZOGHoEmKMINxpnLs4UQ85ei3Ca7JiF3QgSVyFyN8Wg7STxcRoXuEXfjhLROR49L 1UNXkSK6 3EEUHqPBv66b01Yrk46SBR7VlozImQskhhBWoL6DxbRAjX+Wo5+W+udq97giHFxnNU7QL79Q0qekeCRa+kv2+sd8jWELioMsLPUePJz3QyL/ZMMs6z5i91W9NyaY8TZKl8jrP29jrq+TaV7hIZ3bdxCfRoyGqH+VJKKI2Q+vGjNAm/rVo1mpR5oeOwg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 13, 2023 at 06:37:52PM +0900, Greg Kroah-Hartman wrote: > > On Fri, May 12, 2023 at 12:19:09AM +0800, Ruihan Li wrote: > > On Thu, May 11, 2023 at 08:32:01AM -0700, Christoph Hellwig wrote: > > > On Thu, May 11, 2023 at 09:44:55PM +0800, Ruihan Li wrote: > > > > Christoph's patch perfectly fixes _one_ problem: kmalloc'ed memory > > > > cannot be mapped to user space. However, as I detailed in the commit > > > > message, this series of patches fixes _three_ problems. > > > > > > FYI, I agree with you. My simple patch was sent before reading > > > your new series, and is a strict subset of it. > > > > Thank you for the clarification. > > > > > > I have to say that the original code is quite buggy. In the > > > > gen_pool_dma_alloc path, there is no guarantee of page alignment. > > > > > > I also find this whole interface very problematic to start with, > > > but that's a separate discussion for later. > > > > Yes. I don't think hybrid allocation of DMA memory and normal memory in > > one function is a good thing, but currently there is no clear way to fix > > this. Mixing memory allocation and page allocation is another bad thing, > > and at least, my patch can (hopefully) solve the second (and much > > easier) issue. > > Ok, I'll take these through the usb tree if I can get an ack for the > mm-specific patches. Or were you going to send a v2 series? > > thanks, > > greg k-h There are some comments from Alan and David, so I'll send a v2 series to address them (probably tomorrow). Thanks, Ruihan Li