From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A7ACC2BD09 for ; Sat, 29 Jun 2024 00:39:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 054E06B0096; Fri, 28 Jun 2024 20:39:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 004906B0098; Fri, 28 Jun 2024 20:39:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0F296B0099; Fri, 28 Jun 2024 20:39:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C42F96B0096 for ; Fri, 28 Jun 2024 20:39:20 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 441EA4080D for ; Sat, 29 Jun 2024 00:39:20 +0000 (UTC) X-FDA: 82282067280.02.BB5DF37 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) by imf03.hostedemail.com (Postfix) with ESMTP id 1DC942000E for ; Sat, 29 Jun 2024 00:39:17 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=U+SH5Su3; spf=pass (imf03.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719621548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hIdydIh8IPqBxhIl4IxBT7Ivfc2Q11iUcAGfKoD33k0=; b=AIEkyXjD5of755S59hkwH9svMpCG7Egr5y5r3OxL4J9RWm7+N/gByN5qkNIzVCYj63yuNl s4tE8f2K9Sb7Cx43efghb0IeB/EqoNSzRLiNn3ovbCeQdAzt/bR+b+/YeL98c1RCYH6Cf3 2qNfGUtJ0Q+myo34iWen77QTVR8WOpA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=U+SH5Su3; spf=pass (imf03.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719621548; a=rsa-sha256; cv=none; b=hyvlxbtct9si34ccnTNaKUBHOhuyN8rjEIh0dd64EhjIhJP0sv1hgLKWxO9M1TOfPj4YzH R9FOrMIf6gR1gRrT6FKZhQsWGhsXLFGR3qoX6Pon+JIumtpwhIhs/cEVYsa2XfywqUok6k vW0+TJJVOf1mU5/xM7OL9yV1hED8j9Y= X-Envelope-To: roman.gushchin@linux.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1719621556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hIdydIh8IPqBxhIl4IxBT7Ivfc2Q11iUcAGfKoD33k0=; b=U+SH5Su3LNu+1GZDNYbRDrroW1s6BE8CZdgdXyvVNOc8oSFIPbfgYZhIZH24MFM/JamihC iJOzAtqBn4JqiO+gyJGVCDs5YLHxZJ/EonEJtuLLAeUMwGhVgNusqXNi79NJYBHP4GHgi6 sR3eq7XYJHYaqGijvRB2YqcRf5at2sk= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: muchun.song@linux.dev Date: Fri, 28 Jun 2024 17:39:11 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Muchun Song Subject: Re: [PATCH v1 2/9] mm: memcg: factor out legacy socket memory accounting code Message-ID: References: <20240628210317.272856-1-roman.gushchin@linux.dev> <20240628210317.272856-3-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240628210317.272856-3-roman.gushchin@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 1DC942000E X-Stat-Signature: 7d1z71qgjwk3c4kxjhr6nynctnnyqt63 X-Rspam-User: X-HE-Tag: 1719621557-229560 X-HE-Meta: U2FsdGVkX1+RFsYTlYs6Qicy+amHbOR/q6Ua0zXDrqWO89b2y5rpqbwKFb+RVsml4AMYUIYkea06zmVF21221XaWktyJjD5C/RHws8cI4iQS6AjvwkZhWGF6i82tKwiYxaQ/raujaaXSh27nu64PL0IRN69WKsPkhjcct6U/Z8ABEVQXviCjObwh1abB3qhM9iVR6rh9HKyMuLRRsN0PSUX6XPKdSuAZ7uu7PfuxI8gvrIVIw4qBEx/XqhaNCDqTVzVGMp39KPyWkRVbuZg6Aiw8zU42gK4KscENDGcBDg1edguLLIDOyiyaRmwdRZXLNc1GRyOfSG1zjN4lv0Mr5PkWCQj3YAI5XXwuhQAYk13W/ahsNbrpFRl8Bd7kzwGBOCOWcetfNGitm8ZIfB1aRsDcoJvXphMHoHDs9iFnraJ2vkOT7qfO2rHMdU3+EJEKtyGKNam/CiYoZS6Mwf4RZNhTdSMQJLA2GeXZJrxE52I+qSAFdTt91Cj8n8SNAJ1iJvSjcX+SD8zhX+KiiyMrxSmOY0YSVblYPPKZeZAgNAzYcWrWaLPHdceoEZhqxDUf2F76u57LuGJ2LqpQy9dF+IBKKyjjqTY6ydSMZOWwOpXANdYvG3ZXZX8ZzSMxRzW2ymPelKrIkE/vQmEIkuMB1PyYMx/quSsu2O+iTXwdldhUonGpD6Rgp2QLsREfgRWtgZN4eyE/GRk3h+UxcMIoq9/6npbMLzvEtF6Qb1usePYOKjJctYjzNxiqho8HXuOPwPZrUwh+r4xoW/+2954qnjQOTADj0FJ2Rd0S2TxGrKFlyFDE/cgUBTI3fLzMmw1YAZw2jSZ01Z5P6500vhbIG9dcJkAGzlDPjm2H7aQK4Q/fgxHsCYhLRQvUpoZYsPQwBaq4R8GUKpNLUGWrTESV1X82CEH1KYk1o4gQPBlki2zv7jFc5aSaDLnSGeCmpcXthOF+XNOW+sn3P8QIv4n PFJyTfSf EVWP65W8QTrSlEt3TA2/Ye7iNFMDbhaooRskUIfIrrvULK0WFHceiPVLFLddlJ6kkyaad9vAodK8yX5y9A9iypbIQso0ESx7OKBw/2+IEdQHRETuTPNxtQxN5aA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 28, 2024 at 09:03:10PM GMT, Roman Gushchin wrote: > Move out the legacy cgroup v1 socket memory accounting code into > mm/memcontrol-v1.c. > > This commit introduces three new functions: memcg1_tcpmem_active(), > memcg1_charge_skmem() and memcg1_uncharge_skmem(), which contain > all cgroup v1-specific code and become trivial if CONFIG_MEMCG_V1 > isn't set. > > Note, that !!memcg->tcpmem_pressure check in > mem_cgroup_under_socket_pressure() can't be easily moved into > memcontrol-v1.h without including memcontrol-v1.h from memcontrol.h > which isn't a good idea, so it's better to just #ifdef it. > > Signed-off-by: Roman Gushchin Acked-by: Shakeel Butt [...] > +static inline bool memcg1_charge_skmem(struct mem_cgroup *memcg, unsigned int nr_pages, > + gfp_t gfp_mask) { return true; } I wonder if it really matters if we return true or false from above. If CONFIG_MEMCG_V1=n then cgroup_subsys_on_dfl() is always true, so memcg1_charge_skmem() should never be called. Anyways just wanted to point this out, nothing actionable. [...] > + if (!cgroup_subsys_on_dfl(memory_cgrp_subsys)) > + return memcg1_charge_skmem(memcg, nr_pages, gfp_mask);