From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41149C71136 for ; Thu, 12 Jun 2025 10:01:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 898A26B007B; Thu, 12 Jun 2025 06:01:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8709A6B0088; Thu, 12 Jun 2025 06:01:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 787866B0089; Thu, 12 Jun 2025 06:01:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5AE846B007B for ; Thu, 12 Jun 2025 06:01:18 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CF9F51D76DB for ; Thu, 12 Jun 2025 10:01:17 +0000 (UTC) X-FDA: 83546305794.03.A7CE45D Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf25.hostedemail.com (Postfix) with ESMTP id 9F2FEA000E for ; Thu, 12 Jun 2025 10:01:15 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=oB10xmED; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=CCQfAkcf; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=oB10xmED; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=CCQfAkcf; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf25.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=pfalcato@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749722476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MfDva740sbD7wBeTOlrPtgcsAi2TWLZrQwwMYisXkR8=; b=vEBf8ErLIxsNdIz0yU/npeP3kXmMZjtMtLXuAFPXsnyVzUz5SyQFB3V+2XSuz8mnVG+rQ0 2lKKhrO6uSnAJR/tBHBKvJ+V2KLyJs7dGj8r40UIYKZvAb12pFfIeAAMbhRbxME0dIB35z i63FoMWh9rwBd8pOpnQfuyJjNpu05ow= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749722476; a=rsa-sha256; cv=none; b=2LWSM4zGCJhEaWCvY4St7TO4urXJQUNh5sWD9eB/MTTmhegyHt/UuqLPENbAkSYAKIbEq0 NvGqW8PWDjGBgrtO1x8hSpjKq4pXPYtVhE9tiCDGtenOHvWd/lElybvkRh7w1OTcd7pUL2 lbWWWTwO6Ub9s/eaaHEp1eKBzUFcgBc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=oB10xmED; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=CCQfAkcf; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=oB10xmED; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=CCQfAkcf; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf25.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=pfalcato@suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1AC621F78E; Thu, 12 Jun 2025 10:01:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749722474; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MfDva740sbD7wBeTOlrPtgcsAi2TWLZrQwwMYisXkR8=; b=oB10xmEDnnQCgl7Ov5+3Z/w2op1djNanlBxzXo4xZK79GJdzAcQ9L4mIWQ7PfllEKlNHTo VQxcwSdg1iy/F0cKMKYwBJATaZEDnyqoEcpunZuXt0V84pl12QrsmjaapE5/3t0OsTBItt G4J8dEEYMBLDD8k4wj1lcx7uVXiuJKU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749722474; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MfDva740sbD7wBeTOlrPtgcsAi2TWLZrQwwMYisXkR8=; b=CCQfAkcfmqyL/JwRt0+58QGcb4i5sA9J2V2eC4V9QTbny0fpirayYOGXmv0Eui/CzBHk/W aqZ3kC+n1RE894CA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749722474; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MfDva740sbD7wBeTOlrPtgcsAi2TWLZrQwwMYisXkR8=; b=oB10xmEDnnQCgl7Ov5+3Z/w2op1djNanlBxzXo4xZK79GJdzAcQ9L4mIWQ7PfllEKlNHTo VQxcwSdg1iy/F0cKMKYwBJATaZEDnyqoEcpunZuXt0V84pl12QrsmjaapE5/3t0OsTBItt G4J8dEEYMBLDD8k4wj1lcx7uVXiuJKU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749722474; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MfDva740sbD7wBeTOlrPtgcsAi2TWLZrQwwMYisXkR8=; b=CCQfAkcfmqyL/JwRt0+58QGcb4i5sA9J2V2eC4V9QTbny0fpirayYOGXmv0Eui/CzBHk/W aqZ3kC+n1RE894CA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 81D6D132D8; Thu, 12 Jun 2025 10:01:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id USolHGmlSmjRSgAAD6G6ig (envelope-from ); Thu, 12 Jun 2025 10:01:13 +0000 Date: Thu, 12 Jun 2025 11:01:03 +0100 From: Pedro Falcato To: Baochen Qiang Cc: Sergey Senozhatsky , akpm@linux-foundation.org, Jeff Johnson , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2] wifi: ath11k: mark reset srng lists as uninitialized Message-ID: References: <20250529035708.3136232-1-senozhatsky@chromium.org> <5857380e-ced9-4118-b9a0-ce926b25c11c@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9F2FEA000E X-Stat-Signature: ouy9n7fyiymekndsijcndssg3qwb6t9q X-Rspam-User: X-HE-Tag: 1749722475-178528 X-HE-Meta: U2FsdGVkX18cQEhb6pdghmzoUq2adC1MaBpg0/8menIYQi4OIUaIbrImxbttdPp71esShd3Ips7ZRYxQhstP9DBNG3e+cUzPWOJbsiZgkWoOIl+nBjyb9yPOcBdeBsgnwbVAm8auITzpUf7DcVOXdCNSxmtpCaXPOWWC4nUWHi+xXWTPiuEgawwfsvXA9k5s3U4O8eiAygkPx7IemGCyBeEdHMuElrQ3N0JvDxRk+cy3ONDi3G2fX/glV1qiU7K6iQ7rew3/NLzvkwT08HIqoVUFYVuv069iE/Pzsb+TwaS/4TUZXgVwDQTHoGMFJ6CH9vu9iLkxR8tX+Uf0VsyuVI2CRHBSSgRkxctFtRMxosR42XvaJ/QLVzl6vtVflfNOjS+me029l7XHfdneSbKBN1hIXIxfYvQnTU6dlFMholAnIokdb3YSFd8kQiXXNZDEnhhy/WkkSJZ5jcLvNuJMeaLv9KU7+VKkoy+5RLAUqmg67h3l3c9/I1G42209Wv//gos2pXwAlcCU5TzdSQ/pUbGk3GY7i811MCkAX1zwr10mqJwg1JJ33iYte0U4UGcXGh9Mq8/J/ChAOIS4RRIIYiTzi6ZYdAAk20M2Ol3YFjdY34Kz+nzE+DPuGj4u27kLnvL8popz+2uJcze5TPBv6MZTyoHIJJlM+RN7niwoNWSbyRbO3v66O4zJmwKa3FqEVNdhsUpIIWGQXJ7UOL3JKlskqeuZfh9COe8pU68o9t87MJcCg9QiSPGdBt834TjGLB53vd6F3U2jzsY/R3SaNHa+ppzOvI6XDqjgwklAJGHARbY5heij1JgU32Bg2Wsr/TnY9pRO5CWsKKP4SCEPeodcpti8V/t87wIDy7M12BvEvuHSf+RrhE6IDTgwjpXkRfNs82qhMdwsPk3vk2SqgvxCnl+HhDn3YYLx578b9rO3QHS7SE4omxmhdQAIqKvYwBCzkmI/UVSB+zQCdhF QCUcLb+U UGCsZabS4xeNJsJM1h0+hMLUSxDm7tHMv/LlRzpHry4FSDxC3CI0Fkk5OSuzOwtu2QmTZ3pXKnwkN3721d4ZvD0jCqlUKB5waa4fx57h4H6v+iwvlBkDdEk1HbOv5hwg+3W3fohIitz5nXR7VA0lPpMFc7akF79dEvo5vZtHn7O/IoxwvrFepbsyLOe7sRCzqDjbKYuuBBsWYiGRvteumBAMLFIO5iSAD9lcP6pf4/WcuWmgd2ZU3KH4oPVKoSC3mGceW3FyGGrVz453hq6M7QuT36NlvwB+qLyHGCCli2SNMYuA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 12, 2025 at 04:01:49PM +0800, Baochen Qiang wrote: > [+ kernel mm list] > > On 6/12/2025 1:04 PM, Sergey Senozhatsky wrote: > > On (25/06/12 11:30), Baochen Qiang wrote: > >> On 5/29/2025 11:56 AM, Sergey Senozhatsky wrote: > >>> ath11k_hal_srng_deinit() frees rdp and wrp which are used > >>> by srng lists. Mark srng lists as not-initialized. This > >>> makes sense, for instance, when device fails to resume > >>> and the driver calls ath11k_hal_srng_deinit() from > >>> ath11k_core_reconfigure_on_crash(). > >> > >> Did you see any issue without your change? > > > > We do see some issues, yes, on LTS kernels. > > > > [..] > >>> diff --git a/drivers/net/wireless/ath/ath11k/hal.c b/drivers/net/wireless/ath/ath11k/hal.c > >>> index 8cb1505a5a0c..cab11a35f911 100644 > >>> --- a/drivers/net/wireless/ath/ath11k/hal.c > >>> +++ b/drivers/net/wireless/ath/ath11k/hal.c > >>> @@ -1346,6 +1346,10 @@ EXPORT_SYMBOL(ath11k_hal_srng_init); > >>> void ath11k_hal_srng_deinit(struct ath11k_base *ab) > >>> { > >>> struct ath11k_hal *hal = &ab->hal; > >>> + int i; > >>> + > >>> + for (i = 0; i < HAL_SRNG_RING_ID_MAX; i++) > >>> + ab->hal.srng_list[i].initialized = 0; > >> > >> With this flag reset, srng stats would not be dumped in ath11k_hal_dump_srng_stats(). > > > > I think un-initialized lists should not be dumped. > > > > ath11k_hal_srng_deinit() releases wrp.vaddr and rdp.vaddr, which are > > accessed, as far as I understand it, in ath11k_hal_dump_srng_stats() > > as *srng->u.src_ring.tp_addr and *srng->u.dst_ring.hp_addr, presumably, > > causing things like: > > > > <1>[173154.396775] BUG: unable to handle page fault for address: ffffb4e4c046f010 > > <1>[173154.396778] #PF: supervisor read access in kernel mode > > <1>[173154.396781] #PF: error_code(0x0000) - not-present page > > I am confused here: if the root cause is driver trying to read a freed memory, it should > not result in a PF issue. Because even if freed, the page is there and still mapped in > kernel page table. > Any memory that is virtually-mapped (read: vmalloc, vmap, vm_map_ram, and others) will be unmapped on its subsequent free. I'm not familiar with the DMA subsystem, but the address ffffb4e4c046f010 is vmalloc-like. > > > <4>[173154.396824] RIP: 0010:ath11k_hal_dump_srng_stats+0x2b4/0x3b0 [ath11k] > > <4>[173154.396839] Code: 88 c0 44 89 f2 89 c1 e8 3a 14 06 00 41 be e8 25 00 00 eb 6e 42 0f b6 84 33 78 ff ff ff 89 45 d0 46 8b 7c 33 d8 4a 8b 44 33 e0 <44> 8b 20 46 8b 6c 33 e8 42 8b 04 33 48 89 45 c8 48 8b 3d 45 a3 a0 > > <4>[173154.396842] RSP: 0018:ffffb4e4dceefc50 EFLAGS: 00010246 > > <4>[173154.396846] RAX: ffffb4e4c046f010 RBX: ffff90d1c3040000 RCX: a0009634a5d28c00 > > <4>[173154.396849] RDX: ffffffffb0279d80 RSI: ffffffffb0279d80 RDI: ffff90d2e5d17488 > > <4>[173154.396851] RBP: ffffb4e4dceefc90 R08: ffffffffb0249d80 R09: 0000000000003b82 > > <4>[173154.396854] R10: 0000000000000004 R11: 00000000ffffffea R12: ffff90d1c3041c90 > > <4>[173154.396856] R13: ffff90d1c3040000 R14: 0000000000002828 R15: 0000000000000000 > > <4>[173154.396859] FS: 0000000000000000(0000) GS:ffff90d2e5d00000(0000) knlGS:0000000000000000 > > <4>[173154.396862] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > <4>[173154.396865] CR2: ffffb4e4c046f010 CR3: 000000005ca24000 CR4: 0000000000750ee0 > > <4>[173154.396868] PKRU: 55555554 > > <4>[173154.396870] Call Trace: > > <4>[173154.396874] > > <4>[173154.396883] ? __die_body+0xae/0xb0 > > <4>[173154.396890] ? page_fault_oops+0x381/0x3e0 > > <4>[173154.396896] ? exc_page_fault+0x69/0xa0 > > <4>[173154.396901] ? asm_exc_page_fault+0x22/0x30 > > <4>[173154.396908] ? ath11k_hal_dump_srng_stats+0x2b4/0x3b0 [ath11k (HASH:3de7 4)] > > <4>[173154.396923] ath11k_qmi_driver_event_work+0xbd/0x1050 [ath11k (HASH:3de7 4)] > > <4>[173154.396942] worker_thread+0x390/0x960 > > <4>[173154.396949] kthread+0x149/0x170 > -- Pedro