From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B7C9C36002 for ; Wed, 9 Apr 2025 10:41:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65A6228006B; Wed, 9 Apr 2025 06:41:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E144280068; Wed, 9 Apr 2025 06:41:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4809828006B; Wed, 9 Apr 2025 06:41:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 27306280068 for ; Wed, 9 Apr 2025 06:41:12 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BC2A6120505 for ; Wed, 9 Apr 2025 10:41:13 +0000 (UTC) X-FDA: 83314163226.14.8D5F489 Received: from fout-b3-smtp.messagingengine.com (fout-b3-smtp.messagingengine.com [202.12.124.146]) by imf20.hostedemail.com (Postfix) with ESMTP id BB0721C0003 for ; Wed, 9 Apr 2025 10:41:11 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="B xemSW+"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=qmrfegVI; dmarc=none; spf=pass (imf20.hostedemail.com: domain of kirill@shutemov.name designates 202.12.124.146 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744195271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f0l92MIb0cqa/PUzSb/Jx1hmxmUjD6QSmCjY/b46Z9M=; b=5gqd6sQ/xj7hrzG0LOl3znxqHxBT1xJznqh96lt0XM6PXpWngHsvMZRsTCkWOMVCzKzVK2 f6VRBCrX3Wu1KTjuh2nHRwRqt+oXuSRWOhhdCkHC+Ue6HrqJlqwlhmSgCXmUbIXueYrH9G yC4gJYof54cZ7fSf4bGippqCxG2W7s0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="B xemSW+"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=qmrfegVI; dmarc=none; spf=pass (imf20.hostedemail.com: domain of kirill@shutemov.name designates 202.12.124.146 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744195271; a=rsa-sha256; cv=none; b=vO4Ofx8sVt6mXV+dOP29RygBtNVHuN9qNmwGtygfAYmdl8Q4pOx2vTUbQfywnOCkhOQldc K5flG1tt4vDu8zALsaJyOodz2TUIerJJ91CKpMi7rIGPlaZxUYxj2D68l+9j1eBldUwAXE q1tYEYaffDJfIyiifg7v+sCx0hF2VKc= Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfout.stl.internal (Postfix) with ESMTP id D1F0B1140094; Wed, 9 Apr 2025 06:41:10 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Wed, 09 Apr 2025 06:41:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1744195270; x= 1744281670; bh=f0l92MIb0cqa/PUzSb/Jx1hmxmUjD6QSmCjY/b46Z9M=; b=B xemSW+dZeUTXIsJxu8mPCNGj+H4E1tyaXN2k4RsyZYovC0gK1OhyuaRjbjMV6rg3 UHYS1M3xNw3Ay76p1izdC7Jz/czLbVBYiuPrXN9xuvemWGNM6iGJTS8+CY4otGjj 5KcH2mtz09rAs0ar5LNcRRoGy6+A46m9375z0S+wMk4j512Gj+ZoxoRuwmZv/LIC 5TvTaIZcfITaDOpdhrNpg9FnDu/xa5rsuKMbTK3aBrEn04LlcpENR3qgllB8vXPF XH22H08eGyczinWyEiQW0keQyJtNpdOTTVVHmdsnKq/r3qd0v0ZRHwLqqALlC6r3 NYeRjd1kOwklgsdN5Sw4Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1744195270; x=1744281670; bh=f0l92MIb0cqa/PUzSb/Jx1hmxmUjD6QSmCj Y/b46Z9M=; b=qmrfegVIN8iM9nWMYEf/4nSJMJFh4GA99o3VQOMrRne1qM0L5hw wBY+DakU/xs6BpaFwVs4NTumkNDBmzQbp/6WL+wQMLLtjQ/7Wc50XG3/vNIgYQ2s HgKR211iLKcWyk+rPlOMmKg2whDDyeKQ0ZpFzsEjXjz1Q/kmCYdS7BLSP59OmmCb 9eR+6+Q8zuFdg0Jl6KmaVhhgYUUsXmaXKf+ulToj4dcuUPsRMoknvyh3dHdjXnSF na/qVdASGmod4QtRkf1K9CgTNdRqZB4fK/N8rNwSkKEXb4Uao2l6+FzbbCidMopY daCOgD++lRk60kXI6BI1kCb4K8lWyRD+LdQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvtdehjeekucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtsfdttddt vdenucfhrhhomhepfdfmihhrihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilh hlsehshhhuthgvmhhovhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeffvdevueetudfh hfffveelhfetfeevveekleevjeduudevvdduvdelteduvefhkeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehkihhrihhllhesshhhuhhtvghm ohhvrdhnrghmvgdpnhgspghrtghpthhtohepjedpmhhouggvpehsmhhtphhouhhtpdhrtg hpthhtohepuggrvhhiugesrhgvughhrghtrdgtohhmpdhrtghpthhtohepkhhirhhilhhl rdhshhhuthgvmhhovheslhhinhhugidrihhnthgvlhdrtghomhdprhgtphhtthhopegrkh hpmheslhhinhhugidqfhhouhhnuggrthhiohhnrdhorhhgpdhrtghpthhtohepvhgsrggs khgrsehsuhhsvgdrtgiipdhrtghpthhtoheplhhinhhugidqmhhmsehkvhgrtghkrdhorh hgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdho rhhgpdhrtghpthhtohepughjrgesrgigthgvnhhsrdhnvght X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 9 Apr 2025 06:41:07 -0400 (EDT) Date: Wed, 9 Apr 2025 13:41:03 +0300 From: "Kirill A. Shutemov" To: David Hildenbrand Cc: "Kirill A. Shutemov" , Andrew Morton , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Daniel Axtens Subject: Re: [PATCH] mm: fix apply_to_existing_page_range() Message-ID: References: <20250409094043.1629234-1-kirill.shutemov@linux.intel.com> <00a37819-b2ae-4399-b21d-86339059c46a@redhat.com> <54aymye7ctvyoaxdoge3h756tnhd57kzy4lnpggvydohtrxy45@ruwh3ni4yttq> <297fdd97-d53b-4018-bd15-50235e235561@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <297fdd97-d53b-4018-bd15-50235e235561@redhat.com> X-Rspamd-Server: rspam01 X-Stat-Signature: euphp6jdfc4ot338yk5s9c36xdqhfqnf X-Rspam-User: X-Rspamd-Queue-Id: BB0721C0003 X-HE-Tag: 1744195271-275905 X-HE-Meta: U2FsdGVkX1++rKed1Jt8xG24baM1ZyQdpo2llEP/7xe5bOUFZrLxXJh9FLWyuwFCJGmFS+0SwFZZGGRebMIKUMn2DCqFrIvnZr/t8xDEAeinO8WGHVttw0WMFFt0MzAymWKs05iCux+Bq2LUCcszkn9aIq57xIA3qsS9NCm7Mo3MzNKYM8G+hpmRw6ImhXYcpPADuycyI8139hK8rvzOBn7Pa7vJYrp5J7lEI2alSRtvSSYatPu8fm57Nz33n96ZEMxl0QN0DY6pwBCVcma5s2Z9DEnf4EKV3NLvI34Zq97DEDQAkRw3XaDQtV0Xlr4I3JkutfO2b29uwMDs0cZUFro25rO3CToo00xgXSaPxflRUCj9Tkm9g2rFsvjOqZN+lwm0UAjz2xuMjD5glqEEjrBVyJeylrH5aXRHmF04bs1QbYIR8jNHrsHtwWYjsZ1e/HB+KHVBj/awChw/aKHpZ7ngPiHOmjToKF5XkFv9bpPpGuJyepGRaUnt5pRlESA5CV8vy4C7TsMXjA01XMuCTkuot0kBxnV+Ss2nS5RapO9us0ujrqDfR50mMRnlbcfoQfGMEWY0/uIhuEOteFHcKzRKo8YwVHuCVP27pQDpD20iSlzbE1I+zXPIN1gY3uCkl0CvXPuWarR+O87ERIaTSS6AbM/6Gfp3CcJDMI/787Qttgeml2fDT+vlfju+Z2kOLHXJUwzldP2JFVMLdxOJZ2XLf4B0djAcQdNZMBkm+PTcuP7W+QOEfSElRJoOPcaUkbiu6nVkrOkvf3RVgOPNX4Drh++7+Mm/RwCFonOrW/pOWYglGqZ2X+/2rP2A5t80Io+tLxQGxy8iMepRbZHf2wHs7nsli9pNk3A9KoPPtiZF01loEveWIH0te7Quq4FpCFPvqhGes69ep8wmEiXEbszrfj/6PY5AR4m748vgpiefiKk03/ZwCsSAd1TXwYmsk7guEnUigLWWtrnLRgv c+txbHCd 1a35P4zTp281+stLFocubFl9gIAWJEK/JZW9l9l5pF+ScUaBZBo5wasQJ3lwtR5Aev0BByzAqWvXa0Qhs2FhipQdI9aSUPwm1CboaAqlgUp/eh6GHC8jo/8IijpgZJPpfTAc7Zk/1YpoPuLFnawdL3rQ6Yze66+aVM304da9leWW1qqiKkj/YK2Ytm7ZDvmVn3cPLlFsZ0WyWa7JgtV+hZvO2hdHE6A2ZI3kex8k4tO351PH51KQCwlQ45R7g10FNJHmYtmzyCt73UMC1L+Cl0PWSXJK3cX84jzBkANmkdLYtiuJBLdsxfRAMc4ZlvpDum0QhRbISg3EyqBwDuYct+LNu04Pn2tXNKqC89JKwrfLfu5ISdgallqF7VaV/00Q+HIMuJROpvLtdDgJZFtMeSXiILbBZgNgDb0kqY0gDZnsAjBy7cTy8asmlfCYnkMedSEQbxn3uVSDRze4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 09, 2025 at 12:26:09PM +0200, David Hildenbrand wrote: > > > It should affect apply_to_existing_page_range() users where create==false. > > > There are not many, and likely most PTEs in the range they are passing are > > > all non-none. > > > > Or we just silently leak memory :P > > That's exactly what I am trying to figure out: is there something upstream > that could actually run into this such that we should CC stable? >From a quick glance, I don't see any of them to have a problem, but the fix is trivial enough for stable@ even without a known buggy user. -- Kiryl Shutsemau / Kirill A. Shutemov