From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: David Hildenbrand <david@redhat.com>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Daniel Axtens <dja@axtens.net>
Subject: Re: [PATCH] mm: fix apply_to_existing_page_range()
Date: Wed, 9 Apr 2025 13:41:03 +0300 [thread overview]
Message-ID: <zfzh7665tzqmludh6ic5oaxidm44ewkel7t2nj5hvg6qppepnl@mj7dp7rkprcy> (raw)
In-Reply-To: <297fdd97-d53b-4018-bd15-50235e235561@redhat.com>
On Wed, Apr 09, 2025 at 12:26:09PM +0200, David Hildenbrand wrote:
> > > It should affect apply_to_existing_page_range() users where create==false.
> > > There are not many, and likely most PTEs in the range they are passing are
> > > all non-none.
> >
> > Or we just silently leak memory :P
>
> That's exactly what I am trying to figure out: is there something upstream
> that could actually run into this such that we should CC stable?
From a quick glance, I don't see any of them to have a problem, but the
fix is trivial enough for stable@ even without a known buggy user.
--
Kiryl Shutsemau / Kirill A. Shutemov
prev parent reply other threads:[~2025-04-09 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250409094043.1629234-1-kirill.shutemov@linux.intel.com>
2025-04-09 9:52 ` David Hildenbrand
2025-04-09 10:23 ` Kirill A. Shutemov
2025-04-09 10:26 ` David Hildenbrand
2025-04-09 10:41 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=zfzh7665tzqmludh6ic5oaxidm44ewkel7t2nj5hvg6qppepnl@mj7dp7rkprcy \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=dja@axtens.net \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox