From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B83DCF8547 for ; Wed, 2 Oct 2024 23:09:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB85D4401C7; Wed, 2 Oct 2024 19:09:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A682D4401B5; Wed, 2 Oct 2024 19:09:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 930CF4401C7; Wed, 2 Oct 2024 19:09:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6D8DC4401B5 for ; Wed, 2 Oct 2024 19:09:23 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 12966120CC1 for ; Wed, 2 Oct 2024 23:09:23 +0000 (UTC) X-FDA: 82630205406.27.8D524E4 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) by imf27.hostedemail.com (Postfix) with ESMTP id 3C55C40002 for ; Wed, 2 Oct 2024 23:09:18 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Dfhddu4o; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf27.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727910538; a=rsa-sha256; cv=none; b=nizYKjaykKJxf4pWEcGHFdGV0S7Ha5L9X0MMVyrZphR9wiYZL6INvtifXrZPhzx22NbuAp Z0gAhdnTAtLUS76y6vM6Ac59TkjdyzDJPygQiQHcUfcjacqBPpN249aMNEPLQjQrJkS/rM lw5hhekR+/vbvEUaEmNmAnNQUN5DRQA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Dfhddu4o; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf27.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727910538; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=24Y9sBYzc7//kYNIJDx4hME+s6CyiY68wj/PqtM7k5U=; b=PrEU7ZnMq/xQCDwMAJq/Pk5KCfGm41PsobugwwdxoNIm1O8M/78c+8OfNqjtNc1jCwgkJt vBwrkJ618BZ9g6ciBfbAqbndb0H5f/aaoA3GhJ8kTiMfe1rHteOBaPoPkFTHm7BEv9BYAa JSzKJGXqoKcvx8QUBI5LbaXnVk33TpI= Date: Wed, 2 Oct 2024 16:09:11 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1727910556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=24Y9sBYzc7//kYNIJDx4hME+s6CyiY68wj/PqtM7k5U=; b=Dfhddu4oV5hRXi3eExN19YvHIvk8qF9I/X5krVBec64Jl0UpFpyLNRFbwaisWOfXj5UGiC VVilH2vRZzeDA25R5k8jF0h5IgnJhJ0Rh+8G9d1AgPQxuU22rtKOHnzHjKCppHLoaxVQbr 8dZS2zwXGVKHbe0NbRcd4h//4Bv29Wo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Andrew Morton Cc: Johannes Weiner , Matthew Wilcox , Yu Zhao , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH] mm/truncate: reset xa_has_values flag on each iteration Message-ID: References: <20241002225150.2334504-1-shakeel.butt@linux.dev> <20241002155555.7fc4c6e294c75e2510426598@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241002155555.7fc4c6e294c75e2510426598@linux-foundation.org> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: zxkyfy3dpbwuuk3ff4qc9mnk4m7mtt6o X-Rspamd-Queue-Id: 3C55C40002 X-Rspamd-Server: rspam02 X-HE-Tag: 1727910558-678356 X-HE-Meta: U2FsdGVkX1/7SXewR0lGfDJkpo/NGyFB4i7lu8N6zXM8n8njXHD3npmRVWFHWiH0fUoaAy/nAvIMaUU0AftgJJLj2WwsVCmv1DYyy8DsZPjkGqPNYO9aXF34BbkpzeV5w9J84TsAw7fP2SMk9HZQnEMgl850ixjTkx24TdrgBYYS9YsLdIG+u2ay0okecU3ijdHiET0nsp1Ms6OaYHt4+blPGEsFOD6tl8wec8BP4QDLsjtABwdwPTDqjiDs+zy2b/Q2VK3arqZS7ucIS22ylNDsKBBCACDzYXUAkucld/A1bbcrgg5GNIdUKYgZO2TrlVASQiqqjvhQbdojZEh1Em9JMFjUYhqo56nc0l8KlN9bQmqHIN5VwnxlRauBp9FVe7sglAGykBq5bwreTZ0bncuKyn+tqKdhTWByEcwb/uuHVzMhncqNlhVKZGLT5BrvOlLjT8H6TkPXEKOQPqQOVKORN12MrJjIg2mroYtMnOiU6ln71dIBkhVs1K5C95/JF37YW11FoIzDpdJVg8kwf51MYLhnX+DoFnGsqMR6sknbdnrYKcoLezXhPgPCKkmKTrT6pWOeTRNUq3Bs/nbY6HJYn3CsNu4sxOR4M7OEdcwDJZVwXDcEqLMfXeh2nit31F7xXxV3JmVTQ5P8Wg9l8VwTnq/wk40acFdsTHF9AsI1CQ/Da2y0yI31MFR97Ci+Tc4RedgML24p1cwAoiTubjRL+TehezrW8jRlPzJ4EZNOSR1tMnNckcbAq8e+EdSif3jytcUAGdpCzmA0CmwLsUecOOpRto2jYbUJOPquzn20rs44WF+5fIJxGHfHTTcplpGGClYIzXpGaZ3ErJzuP0/feBcIo5ViqFgvdAzjXhIoZCqUThV0Jiv3C7M6pobjOzSmxKnYc8nIRRdGtIbGepdPElLcB7hY6J+LoYAEZ3jOuZVlax5WkmDPKSoiTC34g4515l/ujFFeMrpJYxd Bc6+zVAO D516Q2071UktyZ+i5i6BCQ/QZNFv5u6Af9IYqLqo42Du48z+LXLwtdDN69ANz/qFw9SLgPw885bC0zf/1rT2YCyj7xmx6PZ8k8Mc3DAhossG85D71L270gst+x2fjGLAvAOgkzcsLE8q8kIWVO0sp0lG3NveBodN5VjoklTmAYqOMaJKcOQg/vrfE6oNo1ZDrxS+l X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 02, 2024 at 03:55:55PM GMT, Andrew Morton wrote: > On Wed, 2 Oct 2024 15:51:50 -0700 Shakeel Butt wrote: > > > Currently mapping_try_invalidate() and invalidate_inode_pages2_range() > > traverses the xarray in batches and then for each batch, maintains and > > set the flag named xa_has_values if the batch has a shadow entry to > > clear the entries at the end of the iteration. However they forgot to > > reset the flag at the end of the iteration which cause them to always > > try to clear the shadow entries in the subsequent iterations where > > there might not be any shadow entries. Fixing it. > > > > So this is an efficiency thing, no other effects expected? > Correct, just an efficiency thing.