From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73972C369B2 for ; Mon, 14 Apr 2025 12:12:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E6C128004C; Mon, 14 Apr 2025 08:12:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9471F280036; Mon, 14 Apr 2025 08:12:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E56A28004C; Mon, 14 Apr 2025 08:12:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 602CA280036 for ; Mon, 14 Apr 2025 08:12:46 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2A3D2C18EE for ; Mon, 14 Apr 2025 12:12:47 +0000 (UTC) X-FDA: 83332537974.05.7567C59 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf06.hostedemail.com (Postfix) with ESMTP id B1CEA18000A for ; Mon, 14 Apr 2025 12:12:44 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1LN99dSc; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CQ0hOObU; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1LN99dSc; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CQ0hOObU; dmarc=none; spf=pass (imf06.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744632765; a=rsa-sha256; cv=none; b=2DS04v6kDFfmTmLz+lfOrgRvi7kk36+FjEcaXDBHnnNRn+IcxgRy6j9r4HGYFM/DXjdVs8 Ov2RNn+YAVb+rSte/CgRI+z4ALFtALFtMt1UpHIfTdPb4kUe9480j7oBXRhYkEAmCqTe4W APwImE3PS2jqwufaWfM7wviEhDff8HE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1LN99dSc; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CQ0hOObU; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1LN99dSc; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CQ0hOObU; dmarc=none; spf=pass (imf06.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744632765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rlkFtnpwAE5if8bFapspa1/JYvm/8UmbZU4eZJLXFyk=; b=HMOaOd3t1ntC82YpmFTLs7gOA7iNPpXeDYDH2XYeOLFKR6vxcip/s48nwUFzWMLRgavoig gLfgLNPUP7vw0REKfWT0avxw24THFjqhWMy4AkzNdPRuJZD0LhEAM6ZcSALZlzxJXWJqTd GvJLWuRab75QH3V9JKpQlbzEtQKLppQ= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D0BFE1F45F; Mon, 14 Apr 2025 12:12:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744632762; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rlkFtnpwAE5if8bFapspa1/JYvm/8UmbZU4eZJLXFyk=; b=1LN99dScidLHokALd1dYOCoP6pg5+3SHk8UsZlQ6jVIOj/6MHHc98uNzfsoXDolATz7LLU TmpC/ZAvOdBBb6T6oNVo9xepgvHHK5+A+aiJEA3WHpGHD0Vau9xzuSOspFECvUdgLuVJ+i djXk1+EB3qU2IaoktpT0PJqsWYEh/aw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744632762; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rlkFtnpwAE5if8bFapspa1/JYvm/8UmbZU4eZJLXFyk=; b=CQ0hOObUL2hJ7Snkhjc2uGrVq8/AekYCwp83R8mzgoz4s8vy/rzomKMErDu/vl7wAwTl9O Q8sUErgWfN3IiIDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744632762; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rlkFtnpwAE5if8bFapspa1/JYvm/8UmbZU4eZJLXFyk=; b=1LN99dScidLHokALd1dYOCoP6pg5+3SHk8UsZlQ6jVIOj/6MHHc98uNzfsoXDolATz7LLU TmpC/ZAvOdBBb6T6oNVo9xepgvHHK5+A+aiJEA3WHpGHD0Vau9xzuSOspFECvUdgLuVJ+i djXk1+EB3qU2IaoktpT0PJqsWYEh/aw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744632762; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rlkFtnpwAE5if8bFapspa1/JYvm/8UmbZU4eZJLXFyk=; b=CQ0hOObUL2hJ7Snkhjc2uGrVq8/AekYCwp83R8mzgoz4s8vy/rzomKMErDu/vl7wAwTl9O Q8sUErgWfN3IiIDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C0F59136A7; Mon, 14 Apr 2025 12:12:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id KsAYL7r7/GdlYwAAD6G6ig (envelope-from ); Mon, 14 Apr 2025 12:12:42 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 4B4CAA094B; Mon, 14 Apr 2025 14:12:42 +0200 (CEST) Date: Mon, 14 Apr 2025 14:12:42 +0200 From: Jan Kara To: Davidlohr Bueso Cc: Jan Kara , Luis Chamberlain , brauner@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, riel@surriel.com, willy@infradead.org, hannes@cmpxchg.org, oliver.sang@intel.com, david@redhat.com, axboe@kernel.dk, hare@suse.de, david@fromorbit.com, djwong@kernel.org, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com Subject: Re: [PATCH v2 7/8] mm/migrate: enable noref migration for jbd2 Message-ID: References: <20250410014945.2140781-1-mcgrof@kernel.org> <20250410014945.2140781-8-mcgrof@kernel.org> <20250410173028.2ucbsnlut2bpupm3@offworld> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250410173028.2ucbsnlut2bpupm3@offworld> X-Rspamd-Action: no action X-Rspamd-Queue-Id: B1CEA18000A X-Stat-Signature: cs9irh6w6qj7if6e7ogb41t3g63zbg4m X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1744632764-837418 X-HE-Meta: U2FsdGVkX1/0uhdROlErhSypKAJG9WOPNcb0lyYVsr0/EEnQphRxTv0vYtn4VJ5XVFJgLkCUAu/M4DFJwmsAeUjY7ke3yJ9yGgR02g35P5OkUYpU9aEQYHYTkBdpbkii2DJ2UfUTNmdIKQx/PVSCq9DpF5mBtwSdbAkWvc0dXqt5m/1B7Pl3mFdDZafo1ZAqlYQNnE8Ajb2JL7QEim25Dp+jEiM2P6YXsTS3lGAd13+EXdkCgRTQV147HwouEaWD7SeL/ud9phQOanTFy0SAb+P73Y78hK4vz2PtgrnmOe1D7ifX6I2DreXgKdBF+WnCU9B1gmbJddYhv5VJ6oH1aLnc3J0YC2d6mT0M23VMTEGLj9iFCWQ6X+LHzmc+8eeo/JVI/NwSxiorUEMqLuy+axiXsGDwCpODQX3wdaiPViZqjjwbKkK/95WWzIRWp1LhkAjlbe0ZyC1fp2uf8QhilDzOrFSKLBY76DjISfZhnE320UWb0NjdeEsyKGgNu9jczzn6utOy0xWixqqOZja/TmT/NCJ3/b5Eh+9pP6hubc8uWS+RruMEB7QI3gtY3ITbbufaPDdevzkb+dlX8pHYGYFRjswuYZEoghV8QHtyScqPDk6UTIJzU7nHsrnfCWZb5phJBoY81vhg7zbpK4nMAwYmxWUM19+lhimk7tHGOhCoHPb4/yg7vufOeqx++w28mYXH9S4ncrqk5ZEHWycxJut9m+IKJx4xhTsoXiog2304XywPtclX67BT+dKMoHoYP2X4HjOZC1Bc0PacYluE7Hd/4EMnBZjHY5JsCI3NCAfnvCEG3fQEf4W++MP4zlBHGWKG8MVwL3xmno81D7FxuuxFhoselioeUIPmgF4s6BrgCBXC7RR1/8WLF8OjwrVrbWlcTfSS6TB4QzEzj8WHWjaABtyCtWwx0PgTT4qW5VXww4jsk9n6TKqCT2dhs4rfe9N9qJxA782EN3IpdBm ktvbPjef hOl+QaLJ4eGujGj38sYhqv3oM9nQfPMS4MeOQRaF34IIy51SX6hz+v7SQz3NxdXySEPRFMKa6g9gpszKdn9N6kw95HvJLke48popqKFT3g/cx1ZZ2XHRmXa9BmUyF2G1CA8NoyLBVCYJXx45zmabm5tuYVmxJ7KUJjKXfWWFgWywrKOwJ6rqHka0k31tylUks7AJQZtcd4N53AzcmBLvjn/xjlv6hZ3ZCX+qZ7U/muY7qwEwDaufk4CoB59mFYGrmrkHXJDipiV181YluCLufj6b1AnMCe0OGjdZotARkaGWkNO+diHnbmqvmwUz3RckSUvzChd37UcXo0GS/QGJWUZ2Zp5g5pfIBcOkA2qOlhDoFg/uQjDylUb8nYZP9xqd9AGLVmCTKJhVj30vYDxaKeV54V2HhAgrlUF8q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 10-04-25 10:30:28, Davidlohr Bueso wrote: > On Thu, 10 Apr 2025, Jan Kara wrote: > > > > @@ -851,6 +851,8 @@ static int __buffer_migrate_folio(struct address_space *mapping, > > > bool busy; > > > bool invalidated = false; > > > > > > + VM_WARN_ON_ONCE(test_and_set_bit_lock(BH_Migrate, > > > + &head->b_state)); > > > > Careful here. This breaks the logic with !CONFIG_DEBUG_VM. > > Ok, I guess just a WARN_ON_ONCE() here then. Or just: bool migrating = test_and_set_bit_lock(BH_Migrate, &head->b_state); VM_WARN_ON_ONCE(migrating); Frankly, I find statements with side-effects in WARN_ON / BUG_ON statements rather confusing practice... Honza -- Jan Kara SUSE Labs, CR