From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1464EC369B1 for ; Wed, 16 Apr 2025 09:34:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4A636B0082; Wed, 16 Apr 2025 05:34:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD1F8280001; Wed, 16 Apr 2025 05:34:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A25486B024E; Wed, 16 Apr 2025 05:34:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 80BD76B0082 for ; Wed, 16 Apr 2025 05:34:04 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 030411C8CE8 for ; Wed, 16 Apr 2025 09:34:05 +0000 (UTC) X-FDA: 83339395692.25.949171A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf21.hostedemail.com (Postfix) with ESMTP id C175B1C000B for ; Wed, 16 Apr 2025 09:34:02 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Q+yMIUL7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="Eue1KnD/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Q+yMIUL7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="Eue1KnD/"; dmarc=none; spf=pass (imf21.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744796043; a=rsa-sha256; cv=none; b=cswyb53PFo6K+e7js8KNaib6f1tNNwo+Az+5ESGxhoJBp4j+Uu5U15jVuv82LNrN5J/hue VSXJQrZS8a6NEKPcKGCt4Xm5v6px2NO+kGMiIo6wBwVbksXzoIvIfNdtVDOtdWS3NS2qIx xrOpg5V59CbnsX4dhTI6PFxvEo1UjAs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744796043; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2RqkhFh3zjAioord6et/QZOcDBsM49nuGROtbOH1d5A=; b=Nz63cR7ogI1Si+M7w1/KOacnRcDK4TK52ompQF3VIxK/9TE9y1WqaExLsBvJU0LZ122ktX Mi1lV5PgIK2f2LKshZlUD1LT0U4tazEUmkB/vkej74d5A3s6X19CCajTFMGTvGUPonNVc4 Q/+X+KWY5Fgk1MNKkDUOk1IKvRZQKdk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Q+yMIUL7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="Eue1KnD/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Q+yMIUL7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="Eue1KnD/"; dmarc=none; spf=pass (imf21.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7EDF41F445; Wed, 16 Apr 2025 09:34:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744796041; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2RqkhFh3zjAioord6et/QZOcDBsM49nuGROtbOH1d5A=; b=Q+yMIUL7ExpF6meXa/ng1JqnKgxk8KGd3nbiAdJnp8Al5g3Pwj8fyTp+I47Pjv8Hx9zxWD k7L7ovjd0ANIvYHy+9QSLuW0FRU1/WP+9giCIy/W1bkSfugvxBhrlrVaV9VmOwrWGdL6sn vuZJQhfqo+O5u47teb0ZYfANgGOkrLo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744796041; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2RqkhFh3zjAioord6et/QZOcDBsM49nuGROtbOH1d5A=; b=Eue1KnD/UO1IU/FP8ZdilT0mdIPLFlyWjRqQaox2ulkHiQYJS6wKYy4pKkQSeH1oftPVB2 TYh1GTsZeUiv6mAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744796041; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2RqkhFh3zjAioord6et/QZOcDBsM49nuGROtbOH1d5A=; b=Q+yMIUL7ExpF6meXa/ng1JqnKgxk8KGd3nbiAdJnp8Al5g3Pwj8fyTp+I47Pjv8Hx9zxWD k7L7ovjd0ANIvYHy+9QSLuW0FRU1/WP+9giCIy/W1bkSfugvxBhrlrVaV9VmOwrWGdL6sn vuZJQhfqo+O5u47teb0ZYfANgGOkrLo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744796041; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2RqkhFh3zjAioord6et/QZOcDBsM49nuGROtbOH1d5A=; b=Eue1KnD/UO1IU/FP8ZdilT0mdIPLFlyWjRqQaox2ulkHiQYJS6wKYy4pKkQSeH1oftPVB2 TYh1GTsZeUiv6mAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6940C13976; Wed, 16 Apr 2025 09:34:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id CbWwGYl5/2focwAAD6G6ig (envelope-from ); Wed, 16 Apr 2025 09:34:01 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 297C8A0947; Wed, 16 Apr 2025 11:33:53 +0200 (CEST) Date: Wed, 16 Apr 2025 11:33:53 +0200 From: Jan Kara To: Davidlohr Bueso Cc: jack@suse.cz, tytso@mit.edu, adilger.kernel@dilger.ca, brauner@kernel.org, mcgrof@kernel.org, willy@infradead.org, hare@suse.de, djwong@kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/7] fs/buffer: use sleeping version of __find_get_block() Message-ID: References: <20250415231635.83960-1-dave@stgolabs.net> <20250415231635.83960-4-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250415231635.83960-4-dave@stgolabs.net> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C175B1C000B X-Stat-Signature: 1sgf4tjbqoqeeqoji85zttzw66i8tsn4 X-Rspam-User: X-HE-Tag: 1744796042-243545 X-HE-Meta: U2FsdGVkX1+b6YTAwgIyh28qQHLOyA7BUoKHW8gUJumDYx1orWVi8g9ct84uZNw9YaWKN8aULXNWIpZ8W/Gc9HF+vN0sLAq1u2mhKsPpigDKvnrMWmjaXFlylphEbg2CKE8r2KDSOKyIQceNAE+nAFyFP6xNsjLWlwivi5LHCB1Ptz+TCP+dk3UZvG/L6FYm0P2YBxwi9xGZiCIvcjCkl4gZhafxzX5kTrIkzh2POTvv3R7vII+42CiGSb8Qy6UFYar8ly80cbCdwO8q14tgnaKhv9ObILv8to/PoYtLBjc0/HrYvmDj+Wg8V8eyNOStLA1S+YjpqZ3ChQI6qAG8w0tm5b08r5zpYmBQOkCDQLrPabS2bsMbGKF8QKidIcaUU2yoA+sCQ+KmW6h9qXeczIC+7c7ZWkRMTHvg05FZ6Q9xKsrpPU/ShpNKLWioW3k4GUID57P8wFPjEMmUYkMD/0/iDTeFELElHztku2OVxFNA7rI18QOU+MSH/oWmFpamaef1fWyf2UJC2HCHcoD1GNW2JhbyNibmA5dj95FHqRHaKENNDda7YYaRmyxAfqyU0ShJtWEYqX3dHWKuWFuOgkRhYKBEPajBkQKWS1d9HWV7dSEjhuDiwN+9+LrQibnLR2TTVp/0dcUGGbkgbU7UJvac7mjybAyIituKPKaZ0GWHrNn4f3bW6WZi9mOZBjH9EVgQAGymvXNp3Vhsw4XINsBYrbmxDpYqeGNcHGA+0DJakM+r5crGWdCmCv9rNE+s3lHz+EZ9PmNq4kT8CS0nys0G5xKRGUTcwERXsEEiuHjXIsGOyjQDb/Y7qKSHoRtSxNW2AnwOTDxVwb/reinh6rQeK6VktOYSah8skgK5vbFWlLjmQ9XZSHRmlxSn4KV9zKstAWB3GhBieKdGq0xwVlWkaHGfphLJpbHTOSjAiQAYDqtjQI8b3ETjNKCy+FRijV+A2q3OR8fpoH4Bh3Z SvoV8MEc Cgfaxl+rxv15hid0K/+0MmniGZUZHC10J0SjbF17qmGubgfzaCS3SdPDsjocnamLGr3SlnBq4TQR08ROIa/fS7nNOas1iGwdhwB96V11xheDez0ylr0l+X/WlnNt2JLl/vwtYn4XH/Cshf4ixtQdX3mEd4Av8kMucaOYd2MDKyOCvvg62Lj25kTz/GFthNgzdZgZ1VCMmMzIwHn3kajh0zv/MF3at7X1aJ9kXWlf2skIaJ9AIocndaQNXAow/65mSW1wh/3uMB9MNawcABBVQK348L895ptKG3FJE+ViA+QFeWagSyuEFP7EklXLQ9qfAqz3p7Xya+wrvrNdMgpuAyiw6q0MoBR87/FHB+GIHKw00hksBjjXg3LDR1C02iCBVar5ClmB1zhUSNXe7xHYjIoa7RBjyxvu0YiGU54gLAOkWUQXbes7L3BnbuQN6WfKPppLQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 15-04-25 16:16:31, Davidlohr Bueso wrote: > Convert to the new nonatomic flavor to benefit from potential performance > benefits and adapt in the future vs migration such that semantics > are kept. > > Convert write_boundary_block() which already takes the buffer > lock as well as bdev_getblk() depending on the respective gpf flags. > There are no changes in semantics. > > Suggested-by: Jan Kara > Signed-off-by: Davidlohr Bueso Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/buffer.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/fs/buffer.c b/fs/buffer.c > index 64034638ee2c..f8e63885604b 100644 > --- a/fs/buffer.c > +++ b/fs/buffer.c > @@ -658,7 +658,9 @@ EXPORT_SYMBOL(generic_buffers_fsync); > void write_boundary_block(struct block_device *bdev, > sector_t bblock, unsigned blocksize) > { > - struct buffer_head *bh = __find_get_block(bdev, bblock + 1, blocksize); > + struct buffer_head *bh; > + > + bh = __find_get_block_nonatomic(bdev, bblock + 1, blocksize); > if (bh) { > if (buffer_dirty(bh)) > write_dirty_buffer(bh, 0); > @@ -1440,8 +1442,12 @@ EXPORT_SYMBOL(__find_get_block_nonatomic); > struct buffer_head *bdev_getblk(struct block_device *bdev, sector_t block, > unsigned size, gfp_t gfp) > { > - struct buffer_head *bh = __find_get_block(bdev, block, size); > + struct buffer_head *bh; > + > + if (gfpflags_allow_blocking(gfp)) > + bh = __find_get_block_nonatomic(bdev, block, size); > + else > + bh = __find_get_block(bdev, block, size); > > might_alloc(gfp); > if (bh) > -- > 2.39.5 > -- Jan Kara SUSE Labs, CR