From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE82C02180 for ; Wed, 15 Jan 2025 23:16:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 549EE6B0085; Wed, 15 Jan 2025 18:16:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FA4A6B0088; Wed, 15 Jan 2025 18:16:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C1B06B0089; Wed, 15 Jan 2025 18:16:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1BDD46B0085 for ; Wed, 15 Jan 2025 18:16:44 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 452A01C6CA2 for ; Wed, 15 Jan 2025 23:16:43 +0000 (UTC) X-FDA: 83011247886.10.C556B2F Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) by imf13.hostedemail.com (Postfix) with ESMTP id 3693820006 for ; Wed, 15 Jan 2025 23:16:40 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=GmzTUVI+; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf13.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736983001; a=rsa-sha256; cv=none; b=rT1uA4jKRnimZHIzWT0YL85RlbBmyK/pp5x+VzE/ZXMiBJPPwQYhMJw7ML5mUIc6SZM7TR lI+9RmMy+iIAPBDxI3f96GvFX43+lkukqesgcoxzrsofdX9cmGg2i7pQ1uYiLVFhqPpMW5 Agk7XRZhAbIauSgnGNw2ByCLAw3DUr4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=GmzTUVI+; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf13.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736983001; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=axF+f7tzSqusWtb6U7ffYDPSYLjV3pC91g+FQtc03MU=; b=8EZYxE7RC4TJ3Q64SJx9dLqj6lJVAU2FRQz54o9vGadA5/5q1VhksAtjC3Dw0FG+OgwUS0 FR3YrpnDeCL8GoY3uvuD+9/lA36h6mxNBLWBuqQanbd/w5K6CPUNy4LpUSOhOySWdHY1j6 HQYKj5tNm0YkVdX/FFor0B8Rqfv9v0g= Date: Wed, 15 Jan 2025 15:16:32 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1736982999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=axF+f7tzSqusWtb6U7ffYDPSYLjV3pC91g+FQtc03MU=; b=GmzTUVI+MtUT8zdo2uwaMDl1gpHXwSwFFyIX4leoZUwA8PBruXddyB8z14iMD47iL50YXY spJwUeGTQ9hQEekzfIp5mhuaXktNXTdfY30dlGeb3Ikl1VH/P9PoKUbQi9bsNHywJAWi6c 0dm7D7u2C0TiS0EDiFUX+Wu6b1LW9Pc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Vlastimil Babka Cc: Alexei Starovoitov , bpf@vger.kernel.org, andrii@kernel.org, memxor@gmail.com, akpm@linux-foundation.org, peterz@infradead.org, bigeasy@linutronix.de, rostedt@goodmis.org, houtao1@huawei.com, hannes@cmpxchg.org, mhocko@suse.com, willy@infradead.org, tglx@linutronix.de, jannh@google.com, tj@kernel.org, linux-mm@kvack.org, kernel-team@fb.com Subject: Re: [PATCH bpf-next v5 1/7] mm, bpf: Introduce try_alloc_pages() for opportunistic page allocation Message-ID: References: <20250115021746.34691-1-alexei.starovoitov@gmail.com> <20250115021746.34691-2-alexei.starovoitov@gmail.com> <9fb94763-69b2-45bd-bc54-aef82037a68c@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9fb94763-69b2-45bd-bc54-aef82037a68c@suse.cz> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: 3693820006 X-Rspamd-Server: rspam10 X-Stat-Signature: i1aazm98oig9feheumpo15hqz33ywpwz X-HE-Tag: 1736983000-95267 X-HE-Meta: U2FsdGVkX1+8Y0iQIz//bVK0AiRgRRHQCxa0L87xL22Ae1Oipb5m4CFz1N5xce6pOgVa8Lgt1a1p28c+L5ctaBkWvgYCCpM4ayWcQGB0W+dn+ZP+qAcKh1XNX0B/uA5+Lxb7+hHgDd8ylcplcQiAg5vYeDRcAR7tEoOToHWQCcKZOo6xPA9aFqVNqoz+V5ekMVKE4pIt855jiYvd9UKEQYHwww2ZoTgXsNR8W9h7iCGd2ML4xXavnhFbwyQNX5xx8LGlfG42gzBGyNQ4PiVOeGDl9MkAM5O3KByl/uxS8lkiQ+fOFmuhs5thv8uiVFsZd+GdWmKjdwOociltWXAgvkiiRvEFhmGdYpeqgagYS8L/INYlXDpV7tOm9mXrMDMEw9c/6MtF1JgPxM8HxEyZZFY4FOZjZmwbzRMdkgDLnRAt1W6yvyWdtdigqV4p3LVcwXS+qStAOGtBajEVgdyBs+nZyzxTYpzxkY2ENhZCTQNO+IDKL2n2iFgXZA2S7FwlxWOZVc+bQgdVC3pHatDBT3fvS9jupTT6h76FwkuhGhcoOtPBM3rZIwq70Cg6gRShM1c7O0RT5TTCuJa78SQFN+mAYByfsohgQYJHmQveVix+Sm93knS4GihzHR+w8RkKtU/QmaN4yH9CjK/a4YLWxa34Hs+n915F1QXBvtj2zNY1KrJYZh6GaSwFD2PLkLHRfTyYb/QG+Lo+vBwemkBYkxceRzSqWc06PSbVPzS8nSFSfAvz1zk2If1eFnAxO0v77ijWzl1hxDGTfHwXk1dnm8H7o78hgmV4JH6bUe+Ub3paJkZVazH+0d/hlZ1+9CgT4RKjyh1Fw6OpomNZ6Ks751cBon9ziQSuKE/Dsi4aDLsHptyGJkpKRbGDK3xkjThpT3JDA3ToAGMqxM3Iq4iI0fWSmD0+YzCT0AYONcFVBnmDjJPFlorXbhVE/G4S4D8y0LTHe8m/2wtW2/bqArx HOU/DUjW CqXZT7FhenOCI6mpv1gT9oqLvIlGWOOW/LvMhm8x2Xm9pQvkRHnh7qX9ZYiNa1oU+ypeBcMKKZGXM1u51dx+EIKfGYOpWDnuHPWWlRxdcG4wuINXGLJ3ygOBA+q9NNeWxwC+MQJ1+qD3BG/CLQT2hnhlSflgpCW/V6s1FmeOXI/uJn3tY7ogr53dOj0Ab9Eo8li5jsX2ueUSnawK1C/90ndBjzP7muI0LpC6FCKZVkmgp2nsmmE0kSOR42KTnxTmoasqOg0ZsFEQi2IyvhO0pIDwOZw3wj0R1KUvAogbng7hkHK4SZvmOnlfMD5BqQzv0mmR0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 15, 2025 at 12:19:26PM +0100, Vlastimil Babka wrote: > On 1/15/25 03:17, Alexei Starovoitov wrote: > > From: Alexei Starovoitov > > [...] > > + > > + if (nid == NUMA_NO_NODE) > > + nid = numa_node_id(); > > + > > + prepare_alloc_pages(alloc_gfp, order, nid, NULL, &ac, > > + &alloc_gfp, &alloc_flags); > > + > > + /* > > + * Best effort allocation from percpu free list. > > + * If it's empty attempt to spin_trylock zone->lock. > > + */ > > + page = get_page_from_freelist(alloc_gfp, order, alloc_flags, &ac); > > What about set_page_owner() from post_alloc_hook() and it's stackdepot > saving. I guess not an issue until try_alloc_pages() gets used later, so > just a mental note that it has to be resolved before. Or is it actually safe? > stack_depot_save() does not seem safe here. > > + > > + /* Unlike regular alloc_pages() there is no __alloc_pages_slowpath(). */ > > + > > + trace_mm_page_alloc(page, order, alloc_gfp, ac.migratetype); > > + kmsan_alloc_page(page, order, alloc_gfp); > > + return page; > > +} >