From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0AD3C83F38 for ; Thu, 17 Jul 2025 19:47:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 643BA8D000C; Thu, 17 Jul 2025 15:47:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 61B118D0002; Thu, 17 Jul 2025 15:47:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 558238D000C; Thu, 17 Jul 2025 15:47:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 43C748D0002 for ; Thu, 17 Jul 2025 15:47:47 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 167D510CA09 for ; Thu, 17 Jul 2025 19:47:47 +0000 (UTC) X-FDA: 83674791774.09.11164A1 Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) by imf10.hostedemail.com (Postfix) with ESMTP id 3D15BC0003 for ; Thu, 17 Jul 2025 19:47:44 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="qUZnas5/"; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752781665; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LTcOOeh9jbiQH0ZRsc0tYHUQUX5dHK6KVzy+NE67bU8=; b=7ztgUuf48td/cLaKNrAI1xcThc8aaFifPBAdoRJL3rcP4eeLr0fvOIXbP470jVVbHo1ho4 qy1JAkmeQGCVbc3ZV6OfPMkdWOW02IUIcht5hKBd3El6tc5TMZwbXX5TDQov+onZJnesjK iVa92EbSqPpinZxL3chmkPkSm0+y/I8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752781665; a=rsa-sha256; cv=none; b=l2EhYKwWld98RyB4MyjbLCzg7bvS1EQ0w5CgN3BJDrweNWjQIJ7WyUAKoZrPhBgbbwAXSn pabA7oqODtlIhhUbAzazmoSUYL7Ym2dapchICt3gyb/Iqbd6kixCMjw2uQMlVBnzsfC+DR oL66NyPLJV+BsLe/3Y1KtCMVGg651dY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="qUZnas5/"; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Thu, 17 Jul 2025 12:47:32 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1752781662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LTcOOeh9jbiQH0ZRsc0tYHUQUX5dHK6KVzy+NE67bU8=; b=qUZnas5/mlZVVjUq09//K0yKxN2SRkikK55pb6rmgTkA8J814VUvfVWKVjuvTLD9QY3PDA ruzGslTxL3bfzg+V8wuHU/KpCywwXa7XcG9+74q/fBWrqKESJ8aXUWYzZ2+gBU9zhldWPa +kJz/7OCXmayHIIq9onEBU0tYSdMwKk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Hao Jia Cc: akpm@linux-foundation.org, yuzhao@google.com, yuanchu@google.com, mhocko@kernel.org, lorenzo.stoakes@oracle.com, kinseyho@google.com, hannes@cmpxchg.org, gthelen@google.com, david@redhat.com, axelrasmussen@google.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hao Jia Subject: Re: [PATCH] mm/mglru: Update MG-LRU proactive reclaim statistics only to memcg Message-ID: References: <20250717082845.34673-1-jiahao.kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250717082845.34673-1-jiahao.kernel@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 3D15BC0003 X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: z8pj9qfxdk4e98ntngicz1y865zbahjo X-HE-Tag: 1752781664-484425 X-HE-Meta: U2FsdGVkX195oo8Px0kXLzKdbjZ8O3VeAWQoeZRu+pxYUuRrgyPtR4TCba8sKlkqf+m8hYdFPSweknxvzt3XsFED6tpZd0eC27ggh3/ya6gkeHCWtVpssqMmqZZlPdsWLkVOf/E85Ifi9VW07/Rd0shYdT+vLJmaAZk7P39IblvoizEz+cqs4+ohKuqt0WICbjYE9af4JixJA1ZN1ReFi/CenXKwxJDxvIERnDbs3uh6OWiSRNHDN0W02A7x/XPvhzr2I14DNka/deMRF22jR2Z2Wx+gaiMqxhxrEZvGxbU31C93PgxMh5YtsJbpkoQlXY5JLmz+4NIa89owSYpOKd1D8zq0b+OaD7/WaZMW9tbWOIYteDyxctnrDYL+Jk1Kqb5ZxzCRuK6l9Wbzihmo/DTam8WIqoKzlOQXtLEnW0ydpqWNs3jpn0Qp+7pPJU4NQmeKFTAZvLg64MwXW+jS+1QXn7RY++jmtwObLHx3Jdpm0qqAb2cYPH3+WpmZKEY6W3Aim33cjOi0q90nBD7V02ZYoWdQ6Ww5MQ0oRodYab5Uc9uc53BFUwUt5MmWyQaJedKdpHf6DX5DEJmbUb5YKLuGGnICZffw9MZgL+4s6kLXsvA/l1X04o3H5KLBZnxH3ICNqfhDnHfqWlWJ/IjA7H4ecBJx/PuFjxw02KeQImQ5FE4MYNhuKNU0jIsmll8ekzLQdS/TAqOLg3fqRzAQOTpHNmfwySn7PD81HmsfTWo4QDZCjjov1Ez/iYmJPrW0T3ZTCsNyMQfzvpVrvvqOwL9B2aYaiy+VHtjqjiQRKqmCK2GrfUqBaGxc/10XrGqxqTh0ag4NZNhaMFTTt48fqaIQddWrFwpqeeQkwkD37rrPqYaqvMypACV5PCvm1+sRhPvIabJETvs+7rDBzSzoiYockpD3+FBqpxuzyQi7S2RvxVvZeRu1DA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Hao, On Thu, Jul 17, 2025 at 04:28:45PM +0800, Hao Jia wrote: > From: Hao Jia > > Users can use /sys/kernel/debug/lru_gen to trigger proactive memory reclaim > of a specified memcg. Are you using this interface for proactively reclaiming a specific memcg? I see run_cmd() using mem_cgroup_from_id() to get memcg from a given id but I don't think we expose ids from mem_cgroup_ids to the userspace. Usually we use cgroup_id which is just an inode number for the cgroup folder. I wonder if the current users of this interface are providing memcg id. > Currently, statistics such as pgrefill, pgscan and > pgsteal will be updated to the /proc/vmstat system memory statistics. > > This will confuse some system memory pressure monitoring tools, making > it difficult to determine whether pgscan and pgsteal are caused by > system-level pressure or by proactive memory reclaim of some specific > memory cgroup. > > Therefore, make this interface behave similarly to memory.reclaim. > Update proactive memory reclaim statistics only to its memory cgroup. > > Signed-off-by: Hao Jia The patch looks fine though. > --- > mm/vmscan.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index f8dfd2864bbf..bc92ec338065 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -5545,6 +5545,7 @@ static int run_cmd(char cmd, int memcg_id, int nid, unsigned long seq, > if (memcg_id != mem_cgroup_id(memcg)) > goto done; > > + sc->target_mem_cgroup = memcg; > lruvec = get_lruvec(memcg, nid); > > if (swappiness < MIN_SWAPPINESS) > @@ -5581,6 +5582,7 @@ static ssize_t lru_gen_seq_write(struct file *file, const char __user *src, > .may_swap = true, > .reclaim_idx = MAX_NR_ZONES - 1, > .gfp_mask = GFP_KERNEL, > + .proactive = true, > }; > > buf = kvmalloc(len + 1, GFP_KERNEL); > -- > 2.34.1 >