From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 579CBC021B1 for ; Thu, 20 Feb 2025 17:06:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 794FB2802DA; Thu, 20 Feb 2025 12:06:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7451D2802D6; Thu, 20 Feb 2025 12:06:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60D642802DA; Thu, 20 Feb 2025 12:06:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 441922802D6 for ; Thu, 20 Feb 2025 12:06:53 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B7005162679 for ; Thu, 20 Feb 2025 17:06:52 +0000 (UTC) X-FDA: 83140952664.03.CC4F3EA Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) by imf13.hostedemail.com (Postfix) with ESMTP id E894320033 for ; Thu, 20 Feb 2025 17:06:50 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=EVsc3N7a; spf=pass (imf13.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740071211; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PeOiPofC0Wf/SoLeRvk4/6gQcNmvxbVkQrbXQBS3smY=; b=6WheRdHbvHZhPG6EHD6kHCO8Mli/dIHrUh7x4+unIknCebuAPlfJQHoq0HShcCFd0saxQZ WokGr9ViQD6gE3mmRcgfQBepE45kFgBz+Sk0s4mN1S3Vrb/TddN+ODMq4lialclNbjVBSf hmIbFG/DrfrliCx7H+HKOwPIUc52m8A= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=EVsc3N7a; spf=pass (imf13.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740071211; a=rsa-sha256; cv=none; b=FLZzebAMSfRXTKZtI73ZCZkpHvHKhFwrS404yGnAOup+bGLYE+PzNfT/v+IjZne8mE84// 9co5b7JRN4jAQmAeX9RL1+rQMEZAFD6L6KwP52YcKA/118gZIQ/V7U+kFBNkIn7E/ZkCzX KHdHl7YBu0xVzkn6izWL3vjc4RORFm8= Date: Thu, 20 Feb 2025 09:06:44 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1740071208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PeOiPofC0Wf/SoLeRvk4/6gQcNmvxbVkQrbXQBS3smY=; b=EVsc3N7aYu9iU1Oyhu84fxdNxh8mv871Ivx9S+7vP1nspverlLlZ2e4pSU4aZJinqyHLAB XZTRzgfLdiGJ/p1KBG8N8g4XdPJSU7P/N8R3Dl4gY3xNxCcSRqHBJAIY7E71sC/1KWCps4 bvpYsGH4q4L13aO6gxVdEtlikRt3I6c= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: JP Kobryn Cc: tj@kernel.org, mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 03/11] cgroup: move cgroup_rstat from cgroup to cgroup_subsys_state Message-ID: References: <20250218031448.46951-1-inwardvessel@gmail.com> <20250218031448.46951-4-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250218031448.46951-4-inwardvessel@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: E894320033 X-Stat-Signature: moz7m6p5gphp4ihqspszz518art91taf X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740071210-430137 X-HE-Meta: U2FsdGVkX19Jm3g+7YkWsLlJYqf0CZzb1y6l5SxnwPsFu8yDdApiKpsT9aZCN1rkFB4kPPXYkuGM07CEyth3oVOpaV800Xpsc5HvFpKXbcsL24I575FbP2GtJQNhCsf3qoqbVf3PmOuO7pLtKOZ3NRoitkUZmw6F/v1Xa6Dy8mGLF7uHdbwwVZO4RsExDdsodD1Hiyxg/tCNA+Hr0DPT35B/p+8ZGXParkaewhppx6HVMyHEYnp9uI22CAFscMDkK8cK/5U0x97gKmybsyINd0hb+i2PhFCif21n3cCBQn778UTSySzWoqyoANwLXwStcXymbcFw8Qd3V4V36biGtRZXF/fFXijvd9DuoDxEG/u+PNrW1rDuZpywXeiB/cI41T/ZmkTUYNIIlmw3DXga0qVtkvRrrLRYp004jUAArfj9dsF/16F6yCGhTtOkxHc1CCgLxpmw4l2N0wMhUVXdhUvH62kHnO8VywJT6vqt92vZrBb4LAk+LTApqo0onqpdA7OuTevmxs/LIjzvkGR64l+/EVmG9GOlsenRY7mLEsEdQ6ZcsCVJ7xuamGWi4kmNw4YYIyeqQZiJ1Almd3Hw3u7u8crin8cARjffWPgyGjrm2uNV2ETEQIwW2k0RkuDw+ekGGHb5gWiMIS+vxx2FKGBrHA8vx7QgBv3I8WcGqy1TXc6hXkLZ9W+9C3lFrka/9icWEby0QUk8SqJ5x0dUf8CleA0g2kTx1Fi7q3MutAZTaPsgbbvWiuQv+TwZFZWipLwsySrekrp/QD8GOk7PRqiosVO8M3uWafLlpJA6o567O0ildapisFZ3998rSNQ+yLLXw4RXxxv0AwNxcvwT3irc7vpzkMf2zQcJo6tRWCJEN3033EiOl5QljwtyDwg7A6wb8bXX1IwUueQ9K3oM1hyj9zOSudIASCpCqpQf8PvHN8gAYLHlDVB/fBuYkjfLAv79kpTwvxhwRAX/k8N ERMBOMoM ezDeOtC6OMjrHFsa5yE0F/0t8j5znAHRXTiM3rILr75J3nFyvwn4UjvjUgRsOvIjDslGmBNP6N4+7t/Y2KKob7MQBizHN147zNAWvNByN0sFM7xDc/kpCr1yIPj1epjN+ct6abjTQs89ForPE7BOLAAtl1+qlPq7ffowWHtfc6gIGWl2jsFUdqgRfLTJZAdY+cOVq+gjpAjCL9/LGx+NVg87Mr9yG0RW/9JRk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 07:14:40PM -0800, JP Kobryn wrote: [...] > @@ -3240,6 +3234,12 @@ static int cgroup_apply_control_enable(struct cgroup *cgrp) > css = css_create(dsct, ss); > if (IS_ERR(css)) > return PTR_ERR(css); Since rstat is part of css, why not cgroup_rstat_init() inside css_create()? > + > + if (css->ss && css->ss->css_rstat_flush) { > + ret = cgroup_rstat_init(css); > + if (ret) > + goto err_out; > + } > } > > WARN_ON_ONCE(percpu_ref_is_dying(&css->refcnt)); > @@ -3253,6 +3253,21 @@ static int cgroup_apply_control_enable(struct cgroup *cgrp) > } > > return 0; Why not the following cleanup in css_kill()? If you handle it in css_kill(), you don't need this special handling. > + > +err_out: > + cgroup_for_each_live_descendant_pre(dsct, d_css, cgrp) { > + for_each_subsys(ss, ssid) { > + struct cgroup_subsys_state *css = cgroup_css(dsct, ss); > + > + if (!(cgroup_ss_mask(dsct) & (1 << ss->id))) > + continue; > + > + if (css && css->ss && css->ss->css_rstat_flush) > + cgroup_rstat_exit(css); > + } > + } > + > + return ret; > }