From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AA48C3ABDD for ; Fri, 16 May 2025 06:02:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B96A06B00AD; Fri, 16 May 2025 02:02:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B47DF6B00AE; Fri, 16 May 2025 02:02:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A34A46B00AF; Fri, 16 May 2025 02:02:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7DECF6B00AD for ; Fri, 16 May 2025 02:02:41 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9F3DA5F852 for ; Fri, 16 May 2025 06:02:41 +0000 (UTC) X-FDA: 83447726922.13.5A0CA46 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf14.hostedemail.com (Postfix) with ESMTP id 83964100009 for ; Fri, 16 May 2025 06:02:39 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=INh5d7ar; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf14.hostedemail.com: domain of shung-hsi.yu@suse.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=shung-hsi.yu@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747375359; a=rsa-sha256; cv=none; b=PM7YdC7nM5Dj3SnkcoCQtNfH27j+NCRcNaTXG23TQ2RiOuoS065aA6XOwSGyOPcPENVDVg LRGeQ/7Mc+IE45qDyeQS6Afsog3a5ao2jyY7C0D3m9QhOmCUbBV76JZYcTSC0jMayIqQ/Y jemjwAJGNmOfmZ6G0fELID+d5I6EeI4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=INh5d7ar; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf14.hostedemail.com: domain of shung-hsi.yu@suse.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=shung-hsi.yu@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747375359; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YRCpYLM2KigShkSCMx1Qo6LnPBeFu9CM55DsyR/vk34=; b=ZOGfYugPJDWOBWKFdyzKuZBNpgmf4Mc4e9CbWvqTC0UTPFLsQ/vZmfOTdvsTEkjH4izcMU OSBV2l62e2DF6ryacZG5UzwQXDuO9JDeA75rMobT738wpxgNpkXh2hS2JEtAwQg7x4tV9P /EMSLvJ7TO7zEtLKEa6f5ycl1uSXp44= Received: by mail-wr1-f66.google.com with SMTP id ffacd0b85a97d-3a1d8c09683so1123998f8f.0 for ; Thu, 15 May 2025 23:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1747375358; x=1747980158; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YRCpYLM2KigShkSCMx1Qo6LnPBeFu9CM55DsyR/vk34=; b=INh5d7arsCJce1w9YWMjztkz0nvMxPPlvlpqDr86cVU2lxIlu8E8KWmrllbOjQ+0pm 45hzfbu8IC6kF/GsjxRDepmpLqVAjJhPV7dSza2/kV3sKISpWgZGAJMjv7qhEMXE/hS9 hvH7VRzzDNT/mp1HsAmE0gLp43IznHgnYtgWnR3bvWrvraPRdfZ+XFB9FaMwasukxyc1 qRHWMIqH98i2dOG1KMAmLDfbIgq+VAEGtZvjZN7dQpQT3AEY0T8Nb5KSFYjvNacyZMJ4 nHu9q+rm3vZE8kP3RsDqWYkYrqCkVTkIETiKCeC6gijeCCP9YMAlfxnzOPMod9lJqIJ1 2Bmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747375358; x=1747980158; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YRCpYLM2KigShkSCMx1Qo6LnPBeFu9CM55DsyR/vk34=; b=Qwhr0HIF+6IAcGZo1n0Tv+JBbTnnZPN8vRR+u9/zPHD87+METXiqXYiUVRCILRADRD Ho1Wezx/oBNn4X34nbje1j4eV1ibTW1oab/h6DPFOCpJ2FRMnwdWd3sp2ZBQgBBHF3T9 ANKYmByH91clQor+XcrmR2o6utMC3Ol/PIDBzZSUXb352Gxtb/c7fOQGxyfKUN7Z655t +th8lSYeE2W6TMw3dnZnWw9Cd/EAKnZwx+Q0wL8+oX6aqjGDOWd27z5U6MJirYjlbsTL v69i18PSqztYcdwFgbeRJ0BtCnu9J0jSF/DGvwCgFY/bX42uxJ7rMHHcLl/FHquKIcy4 iX/A== X-Forwarded-Encrypted: i=1; AJvYcCXb2iSojvRR396wvSjF4yluK80A+CsqSAW5q0kZYqNKi5IUkYzX4hFXGu60QWEGK+LDy8qEvLS4mA==@kvack.org X-Gm-Message-State: AOJu0YyoA36z/tgZSZuc1kcRDWZnWjshNfwgSjRQ7kPP5p8DUsFDoSu0 Ygvep4kZEuGBKh4f0Fi/BVu94EYshv3RUleqX25TDTLfZFlHm9cD1xwYgX2a2ceBnt0= X-Gm-Gg: ASbGncuMzwGt3ONaGrfsRpjRiOb/9MIDFe5cDCZGLN7/3vIRoLa9cjXIksrqX7cYU2n M/7b+D/m0uoxu5yKZhN7hpmY6JY89KDYtU5AsnUxtdll85JqJ1kRkggjPOHI7IfB65wBVeVuIvq lcc9Ly9BHodStZ/KPNKjjHrNb7PpnIz4lTO+EpWl6iFhWp4LxlgqBiSGReqg4QnBo/iUcuXmwYI fKhhPChc+1XI0DDd7S/nw7rZPstpslFf53Sa6NNqRnDBr7hFz5vQk9qQfYhtpZMBkQFrar/DjY5 1u/7jbageraEAJLoGLDhC2XFwCUhbGaYM49PZJPjedmpi4hud4eQAesV0+NPcUkzeUxnscI= X-Google-Smtp-Source: AGHT+IExAX5L6jhpudxoopt/jOxKXl18l7eevqO0BjrQScjyjlt4zB8dW0pf982EIRtAZl2LOgjSqw== X-Received: by 2002:a5d:4567:0:b0:391:4999:778b with SMTP id ffacd0b85a97d-3a35c84428fmr1663501f8f.28.1747375357714; Thu, 15 May 2025 23:02:37 -0700 (PDT) Received: from u94a (27-51-34-195.adsl.fetnet.net. [27.51.34.195]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-87bec12287esm1112560241.10.2025.05.15.23.02.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 May 2025 23:02:37 -0700 (PDT) Date: Fri, 16 May 2025 14:02:22 +0800 From: Shung-Hsi Yu To: Kees Cook Cc: Andrew Morton , Eduard Zingerman , Pawan Gupta , Uladzislau Rezki , Erhard Furtner , Danilo Krummrich , linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 0/2] mm: vmalloc: Actually use the in-place vrealloc region Message-ID: References: <20250515214020.work.519-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250515214020.work.519-kees@kernel.org> X-Stat-Signature: ybw6cq9yok4gedazeid8bq3jffgsz7ir X-Rspam-User: X-Rspamd-Queue-Id: 83964100009 X-Rspamd-Server: rspam06 X-HE-Tag: 1747375359-584091 X-HE-Meta: U2FsdGVkX18EL2AdJWzrHVkuBRVYE9Wg3Cq9GTMMNMAcNTdjWkk/+92ELxdyuqzevpLNBdfVn87WuEGOWGjNHm7n65iGxANek0KKhCR6MFuB0hrzJBcC7uiZHBrP5wc1t95AOA2HI/e16Dhu8V/qzhxtyQOnD1RKLlHDA9k2msR0VlNecLJxFx6fyTNt+SjDKDM38fhDMM++rTd79Y5z/MBkRIdL/yDaWxxMwpdHqBbRCIgH6vjD3yCZISfTIngwYR3HcSruMk5LOcjm8Q92BSxiygwBbPenpJUEahBzgqDwkjQW4he7psPN3qdGuoWCFElWZOqAcmI/kTrgUgnvPCZbsL65tryryWq1HkA9UL3JenaNEwPsxq+FlTf2mueuSjRSYjISmkj3xBzbraxp9WQga6lnqtfmHncICtUO9MM/aCOfpy8jmcIN/bH9PNOQv9Sud7/C8Xos5ASbH6YogoaoDTXaQXK5ErdyrSYH1p9PRo67DhcUBR/LiH6YQmgk+qNJyCaQqwanprNiK7KjVqkEmM89DingOAPM9RZ4MmNuRQRrQ+XuJ7PSdQ0lBm2udBq9gYKutKLPXQ8y4exd6L+o6a87X7W4NM5hgf75NPkKMr6RCISZYn9z01o6q7uc7HgxCbBIpzwrB/IocR/u3MEkfuDkJt1zZMLttVtexrVU7UocZEZCzaAL0ahFRG9hbgwh0WedhlCI/nWDQXGX9xaxvUr6Zt8Yc4y4gbWHfCaOUHtRdy6X/jA5xORTHzF5ned0TikGTNAaJwFnB8bC+ZBkV2Mj4A81MZF5hZMJLFwIyup4wxLTSvX/R4yOrwUoIAenKyMccLyC8BV9B83fSJKcXYhA005rtAtn21e8HOBBzUhz+af4T2mBZdLtIKVo2n9ISUQCTgtzs43I2k3qiZGvpB3IPjOUY64DUXh9mwk4G7fnLifi41lQgDBAxUjCmN++nI7skFz/JZsMoqo IzYMw82z W795/c/gLpiF6Cq7LZelnqwfXNOa8qdQcZGBX/FaIImik6Gge+OndWtN+bWWghNQR25rGworpZSvJdD0jl2HskX027qfNUnSVnyh9EiMlROIrvpRvUe3Kd5V0rivPpsHyEnfTiqV1VFolmXtDBnI1N46KLotuiMvGemJPFn919bSLhMqMapioEyWBXJrNYjW6BLl+fa/sdLOfLmkaeCIv7gVEIgp4S5Lio8QciPITXp1nzjMegJw8ejEYuW1ypST8g/ADfwvZbBJ7sKJl11x495+uuZx11SmusLSZxNmFPgiWI0zILrfFircQQSsVSRMrfRfQMeZBdSmT8r2yadvhV4feDWTvhVIFKzj2WLPnteH4c4yDydntdVLI5/svUJ+6U7FoLeCZJvUICCCTGiJHyvuKWg8bfj/q4eFt7/CO+cEaeFlDoqiwOCKGp7zX6TC821A4CmLtITOgNUrtvvoD+et28nkO4KYKkRGr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 15, 2025 at 02:42:14PM -0700, Kees Cook wrote: > Hi, > > This fixes a performance regression[1] with vrealloc(). This needs to > get into v6.15, which is where the regression originates, and then it'll > get backport to the -stable releases as well. > > Thanks! > > -Kees > > [1] https://lore.kernel.org/lkml/20250515-bpf-verifier-slowdown-vwo2meju4cgp2su5ckj@6gi6ssxbnfqg/ > > Kees Cook (2): > mm: vmalloc: Actually use the in-place vrealloc region > mm: vmalloc: Only zero-init on vrealloc shrink Thank you for the prompt fix! I'll remember to include a more thorough note on reproducing the issue next time. With the patchset applied, BPF selftests on both 6.15-rc6 and 6.14.7-rc2 passes successfully. Tested-by: Shung-Hsi Yu