From: "Måns Rullgård" <mans@mansr.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: fix insert_pfn() return value
Date: Tue, 27 Nov 2018 15:20:24 +0000 [thread overview]
Message-ID: <yw1x8t1elf7r.fsf@mansr.com> (raw)
In-Reply-To: <20181127150852.GA10377@bombadil.infradead.org> (Matthew Wilcox's message of "Tue, 27 Nov 2018 07:08:52 -0800")
Matthew Wilcox <willy@infradead.org> writes:
> On Tue, Nov 27, 2018 at 02:43:51PM +0000, Mans Rullgard wrote:
>> Commit 9b5a8e00d479 ("mm: convert insert_pfn() to vm_fault_t") accidentally
>> made insert_pfn() always return an error. Fix this.
>
> Umm. VM_FAULT_NOPAGE is not an error. It's saying "I inserted the PFN,
> there's no struct page for the core VM to do anything with". Which is
> the correct response from a device driver which has called insert_pfn().
>
> Could you explain a bit more what led you to think there's a problem here?
Apparently some (not in mainline) driver code had been hastily converted
to the vm_fault_t codes, and that is where the error is. Sorry for the
noise. Please disregard this.
(The quickest way to get the correct answer is still to send a bad
patch.)
> Also, rather rude of you not to cc the patch author when you claim to
> be fixing a bug in their patch.
Sorry about that. Blame the get-maintainers script.
--
Måns Rullgård
prev parent reply other threads:[~2018-11-27 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 14:43 Mans Rullgard
2018-11-27 15:08 ` Matthew Wilcox
2018-11-27 15:20 ` Måns Rullgård [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1x8t1elf7r.fsf@mansr.com \
--to=mans@mansr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox