From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2378BC282EC for ; Wed, 5 Mar 2025 21:02:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5147280005; Wed, 5 Mar 2025 16:02:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 98BEB280003; Wed, 5 Mar 2025 16:02:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80532280005; Wed, 5 Mar 2025 16:02:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 57A8A280003 for ; Wed, 5 Mar 2025 16:02:21 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E8FDBB747D for ; Wed, 5 Mar 2025 21:02:23 +0000 (UTC) X-FDA: 83188720566.28.EE5B388 Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) by imf07.hostedemail.com (Postfix) with ESMTP id BC46640002 for ; Wed, 5 Mar 2025 21:02:21 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=owCJQQxZ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741208542; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XSbL5BTlBryknrie6rGMy93ptcUDNtuaohyluRdJqMk=; b=qR4e6zGAUFBmGV1gDg3j7a4VfhgR7bVDEhHWmCSO4H6H4XwgASLAwloORQ3txPSJFs99VS 3FVAs0+jruYV6PgGfZqslNjmB/uYVV2/n1c9ZxRszaogkOe/rCaqybHvGK5jeeT//DPYZk c2idFKmlj5NxD6NucA8oa//zZLpLKU4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741208542; a=rsa-sha256; cv=none; b=GgmbrP7+zDATA77nQ9IvpIlCq042A3dPBFiCGKz5M6kWD38W9vKC+9Rserq7PzIk3VeZkX 1grI8WDWFUKTxtJ+R47AZYAMwmOAugwcI4lZq3x0x8aT9SrbIqPZAsC5IYudlnamErWRQn rX9q94zUCOGxu50Ahcj2fuFSTyP86G0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=owCJQQxZ; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev Date: Wed, 5 Mar 2025 13:02:15 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741208539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XSbL5BTlBryknrie6rGMy93ptcUDNtuaohyluRdJqMk=; b=owCJQQxZHdGWT16SwifzDuZzpTExYSMi/D6Ehs51ZWHDaAlZ24Cb4Yc24yMsIv5OiQuVo7 dQvAuU22U6jRtCvFid2XdpgSRF7CjdmpItoVpDvFEr5nkbpHk5ffnZuNAdkJRw9WaMnOSt d54tlvfzbBBEhiS2OOiUQFVUsLiek+M= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: SeongJae Park Cc: "Liam R. Howlett" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 05/16] mm/madvise: define and use madvise_behavior struct for madvise_do_behavior() Message-ID: References: <20250305181611.54484-1-sj@kernel.org> <20250305181611.54484-6-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250305181611.54484-6-sj@kernel.org> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BC46640002 X-Stat-Signature: 97w9s5i7hhuhre35mg1psspf3jj36zo7 X-HE-Tag: 1741208541-333803 X-HE-Meta: U2FsdGVkX1+xtkr4MRxRzGuNGXZA2W85IHopaOQ30j9exYpotKDyHWWWxTz66y74mq2FSW7/RpWh75nsAPM5vr5VuKNHcVozdtPTdm4/DwpQT4aAYRebpr1Bgg92Yn/TgWWc9DCF+08sJ9Aa9cJGtGH2nMKxezrbBHraeSaNcLxOQY53wRXtEsxRMpx2u9CnUmiRrH19Qn7zCHFd8+aA3uIw8aQqMdf86WVfWtiZG9h8lSilPNS+hjXFhi1kNgxC3QP0jXZ3xmWTfYRu3WZoESa6wgglrkXZYzgaKGTNHYoLMC4wW+jc55gG6uxHVMqKVn9iJG+fgeoMMKjhqaHRpMe6QGHVsfCch8Tm5aCuCPBx5nq6ImOcmMPMHDvl6PA9NJFF1NhRqpWX93oT4rLzAlnv4Q4C4rfe2rm9ARKtRRfpKQTlXVHfrzkVP4FQggjV4IJoWKyrJQPVvlbsTjibqDXil//XcA9m3+nRCHah2HyDUi5YLRf9QvbtEMxt/lPFjyMfTX79+ecc1Nxw1PIio2aFr5EDzKK0GRQ2cwMklMx5upLJ94nMn7KX2tvYhcgKRcl1XxaFSeRIxjhM5eV+6AL8nGNIRpSwDDtJmFAX4pc/ENFuJJ+1gt9fz5sejzLPQCIzXgvUUflKAKFBTcn8RyCiA8hGRjnH1Fon9UyrEgVxeLRjJfR80E1ePK6ITy/u/j9eq7HVVjE6fx/AVUQbWrJNTIdwP2WHo3qhRw5AJvHAzqRp/bmZPe3lYQkuDvEM/fZQqO+SZDymBVfKjQcAkGsAOv0nQ0oVfsJSvPivt13KkzsWEf2cd1Rx7UZAOigOdoMoLiBovWftpWeFcJWy6QBxydoydR+8qLMJU5DnZ9DJQux+1I7RwdGBwTp6sa78b/ZihJlzTNA1uuUej7vNcZJCGda62Eoz0yPyxo4wYk3x4hFbj4+71r3gXuVy3WeDnV8PWydqT0tYITUgy3c 9pZL2T2f /+EJW0IAp6TAvYUAy4jDsLamU4/jTQCsSxs0a8i4fEoG7pne630INX/fqxldVfN2B3UAgis14bc94msi110FmpLu1s26Vf8lNkUZYr+AM72IUw1K547D9wPCam6L92PxlEzK0o4ncPcJEXrN3aM894zRSb88tF4aRCrkcWaoBk+Y9YUtihrGk4OP0hzA/EmzkBk11oS72SjFf4h7IztnkpTlzJAg8Gw2kCrM5PidEgra3CkUKrIahXbS5xEaftHAZ0jFB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 05, 2025 at 10:16:00AM -0800, SeongJae Park wrote: > To implement batched tlb flushes for MADV_DONTNEED[_LOCKED] and > MADV_FREE, an mmu_gather object in addition to the behavior integer need > to be passed to the internal logics. Define a struct for passing such > information together with the behavior value without increasing number > of parameters of all code paths towards the internal logic. > > Signed-off-by: SeongJae Park > --- > mm/madvise.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index c5e1a4d1df72..3346e593e07d 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -1665,9 +1665,15 @@ static bool is_memory_populate(int behavior) > } > } > > +struct madvise_behavior { > + int behavior; > +}; I think the patch 5 to 8 are just causing churn and will be much better to be a single patch. Also why not make the above struct a general madvise visit param struct which can be used by both madvise_vma_anon_name() and madvise_vma_behavior()?