From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FB80CD4F4D for ; Thu, 5 Sep 2024 06:48:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA81A6B00BB; Thu, 5 Sep 2024 02:48:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C31886B011C; Thu, 5 Sep 2024 02:48:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A842E6B031D; Thu, 5 Sep 2024 02:48:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7F4096B00BB for ; Thu, 5 Sep 2024 02:48:16 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0B2F31A1976 for ; Thu, 5 Sep 2024 06:48:16 +0000 (UTC) X-FDA: 82529755392.14.B04734D Received: from flow4-smtp.messagingengine.com (flow4-smtp.messagingengine.com [103.168.172.139]) by imf17.hostedemail.com (Postfix) with ESMTP id 116B740016 for ; Thu, 5 Sep 2024 06:48:13 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b="Q 8crL5E"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=OU81mlQL; spf=pass (imf17.hostedemail.com: domain of kirill@shutemov.name designates 103.168.172.139 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725518817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mf2wLWEzbgEDGO9xDiUM7qVc6lrNS1Frm04RYEBk1sI=; b=u7g0L3zE3S2figxeM1CYywN52BxkmTPShnulx+PWV/JJKhWmDIjvssZVHrg7V2/Md/f54w pqd6KTjOdN8RX1MwEvR5x+K+toqI9Lotd6YAoNaDmq+yLpnfvtlMSo2EtQ8yHt2YM8B0v4 GH9he/7FYIJsAkWyWdCv49jHGyPOlpQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b="Q 8crL5E"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=OU81mlQL; spf=pass (imf17.hostedemail.com: domain of kirill@shutemov.name designates 103.168.172.139 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725518817; a=rsa-sha256; cv=none; b=ywO+mlhMpgbPT7HCILYJ+ft8C7Y4Sn5S9LAC8E+EvzVMTsI+H2tXWMrQ0hGYkGbIXaX7yQ /0dKyfvDPPRARQrBEiUukZFkEWClEJiZeIz1QwZJ5DEZz31hMZBgG5mErwdl4K685H2z/L Ol2/yWW3u+qaiTXeoDmjdhN9BLNMnro= Received: from phl-compute-07.internal (phl-compute-07.phl.internal [10.202.2.47]) by mailflow.phl.internal (Postfix) with ESMTP id 2A50C200312; Thu, 5 Sep 2024 02:48:13 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-07.internal (MEProxy); Thu, 05 Sep 2024 02:48:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1725518893; x= 1725526093; bh=Mf2wLWEzbgEDGO9xDiUM7qVc6lrNS1Frm04RYEBk1sI=; b=Q 8crL5ELpizMZj53aZEPPP8KupjNzGuUtN+S5Eql/8fjeevh2FEI8C/KRzBgjisY8 ios3Pgjc7SkHZNFrwTBdbN9vLV0hQOPZ0eGAbRLWcSFDhE/k/dFK/6686hm06Qc7 j+d1+irVVZvEWixrzNwCK0W0NFAOLfexqwJSuWjLycECHToeCwRE/1nGc1l53s4y bTxHKlADHmHXtzGUzzaiGYjtQhWPUZPI1/USh3xl6u1Sv+0nc2TPrbw6UIkv/TH5 o0fe/l4uJKU0W7HYU3dmXPK5TN/niHwvbSVEfHyU6/SyMLvAiqJybTS8Vdvh4PKb H+eYihXIcEOzrl4xD0b/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1725518893; x=1725526093; bh=Mf2wLWEzbgEDGO9xDiUM7qVc6lrN S1Frm04RYEBk1sI=; b=OU81mlQLPJz3hQL5seRxaoll2jedmTxaU/rc98Aelm4E LAxjKKoyXT3sGMCDk5gVUo9sxMNF10KBdu8zNR469iNU+zb+tCPxEiRvZRViIIGY 4fRFF6UlbxvVpD5zNmimnvrmkdHBLjbsEEMeFENIAWyU688aW4sL4S7nK33Ed+/W TyoXbq/qhCQqfRaAUgcJL4Qlr9Fj3Kdw1fErx8TN92mDg+L0IfsQjqkdjZyqKyoX xxZY1zHYiN3d8+EpCTErHeTz8LagFsN6v0fROg/TqD03KtfFlVXL4OQSdmSkjWEs 7+FNGRNxSZmK+xVN+gK5oYOL0OpwypHDNQIa583pLA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudehkedguddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtuggjsehttdfstddttddv necuhfhrohhmpedfmfhirhhilhhlucetrdcuufhhuhhtvghmohhvfdcuoehkihhrihhllh esshhhuhhtvghmohhvrdhnrghmvgeqnecuggftrfgrthhtvghrnhepffdvveeuteduhffh ffevlefhteefveevkeelveejudduvedvuddvleetudevhfeknecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepkhhirhhilhhlsehshhhuthgvmhho vhdrnhgrmhgvpdhnsggprhgtphhtthhopeehjedpmhhouggvpehsmhhtphhouhhtpdhrtg hpthhtoheptghhrghrlhhivgesrhhivhhoshhinhgtrdgtohhmpdhrtghpthhtoheprghr nhgusegrrhhnuggsrdguvgdprhgtphhtthhopehrihgthhgrrhgurdhhvghnuggvrhhsoh hnsehlihhnrghrohdrohhrghdprhgtphhtthhopehinhhksehjuhhrrghsshhitgdrphgr rhhkrdhmshhurdhruhdprhgtphhtthhopehmrghtthhsthekkeesghhmrghilhdrtghomh dprhgtphhtthhopehvghhuphhtrgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhi nhhugiesrghrmhhlihhnuhigrdhorhhgrdhukhdprhgtphhtthhopehguhhorhgvnheskh gvrhhnvghlrdhorhhgpdhrtghpthhtoheptghhvghnhhhurggtrghisehkvghrnhgvlhdr ohhrgh X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 5 Sep 2024 02:47:52 -0400 (EDT) Date: Thu, 5 Sep 2024 09:47:47 +0300 From: "Kirill A. Shutemov" To: Charlie Jenkins Cc: Arnd Bergmann , Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Guo Ren , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Muchun Song , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Shuah Khan , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH RFC v2 0/4] mm: Introduce MAP_BELOW_HINT Message-ID: References: <20240829-patches-below_hint_mmap-v2-0-638a28d9eae0@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240829-patches-below_hint_mmap-v2-0-638a28d9eae0@rivosinc.com> X-Stat-Signature: ik3nmpkgihicysq7zfjeuau1qkbfyyho X-Rspam-User: X-Rspamd-Queue-Id: 116B740016 X-Rspamd-Server: rspam02 X-HE-Tag: 1725518893-296301 X-HE-Meta: U2FsdGVkX1+Lh4OX/sYLJO9XmH5AZYcoQHRmRApj/w7IMWAh76hNfGK1C6TWVNQVhPgBkTaAUnpqm2g04LUyPXRq/0w5WqSgQdpkd2wWByV8QIERR0tSzb+bPwsRcAx5Oki/4F4icIu3Ma42bIXWGSL4OIKcRYXmSrLwvaiHA038EME1VN+gIlBnrmnTOlrxNyGFaMMpiStStC68WNl2QPcd7RPIrmahamZqQZLBjm4p1WisqIPAZgLRpXvfQmbluseqU06BHivCvo0EKAlw5jA+OhV9SpYb0Rrubn/gRNtSDX7fZPOfn/VIBkm3776T6fP3PJa4vwCwxgfWnjaAK/yu6W6VlPyTl63ChywhBaS5esr36fvtgq5NxjGwMsaSpghuqoGsqqLp+nZFyiuxh0FcRGFTT5Vj+waA1Fgh4TzlkYIZoe0dTc5TIb1UvpGAfyMXwIMZ0131QJz9FVraaGvuKyTci6OU2JAMXmXY2kxoVGzkUAvtD2QxQcXQBinza82QiQ3Cyt7m5fWO//oCkqFO+EHhAR5fthrI7OJSht6ZIlqyduaz6PhBDAFCHeiSi3X5UjLuv2HoQheixgyHpq1GUP0mCFuVeI+S898JLbe8EQt/JIuK1BQdY7mWPUcspzHWz7bNspnRIsoI8MKrx9fuFCvd9UxSS+obvKo/ID02hOcHe6tp/58n0qWMUFEwVS0tXy/395x1/Z5nLA4WxMVzkqEj/dKhDjvdxR7vx6kLKsTqCzU7WPkpiQNBAuV+jZxhNxljy2fHw8hg4CrjGbf4pucSouPoweyNGyD+MgLCzTKOXcns+XqmW+lf+7CLzCe7OHVSXgP8fxTitutwP0nhwxt1UXVdisj/MChPpcT9SQCFEmvIYHMhO+cgPAwqMwgoI5gdLwwxOIW0aIMshaAXsP19IpDlcYebRRODz+bBqbDca0NtlUS5hvF6q6Dy+fnPMT4QJU0heI066lx o0w8D+Hu 4x58217tqNRljLeg5TODsG3GCj5dUiOhZ2TuutjRXMJ3m6EvMFefYMHLxux8ANGZFmGXHIzEJzo8boJqhSU8yK8t+TNiGiryGFoM4lws0Ah7wxHtR5RxKQtHw19MZeV5zPTxify8GL+u0xYBguqppMNVAkbvodeZEA62UheNTdDHOtBkhe/NEGSV0AZNCRlAp0H9Q6YlOkG5vxBTyc6NSNAz15lylACJY8B/Cz62QSd6w+ZOviv7GKAq6JFMa5pLpY9hp/J/wD8zaejaGnlQ/mRvKGKoI1a+EWBfHuXRdVE++TQoILQRyYBJoiwWHb9xukoabPjU/1AxJp194CtKP0Cu8G+ei7Wl+dJkOZf028JKJLZbVKyJN/eK6MUzd4eaeGCnztIwOpoyVIstMnxRWruGrhQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 12:15:57AM -0700, Charlie Jenkins wrote: > Some applications rely on placing data in free bits addresses allocated > by mmap. Various architectures (eg. x86, arm64, powerpc) restrict the > address returned by mmap to be less than the 48-bit address space, > unless the hint address uses more than 47 bits (the 48th bit is reserved > for the kernel address space). > > The riscv architecture needs a way to similarly restrict the virtual > address space. On the riscv port of OpenJDK an error is thrown if > attempted to run on the 57-bit address space, called sv57 [1]. golang > has a comment that sv57 support is not complete, but there are some > workarounds to get it to mostly work [2]. > > These applications work on x86 because x86 does an implicit 47-bit > restriction of mmap() address that contain a hint address that is less > than 48 bits. > > Instead of implicitly restricting the address space on riscv (or any > current/future architecture), a flag would allow users to opt-in to this > behavior rather than opt-out as is done on other architectures. This is > desirable because it is a small class of applications that do pointer > masking. This argument looks broken to me. The "small class of applications" is going to be broken unless they got patched to use your new mmap() flag. You are asking for bugs. Consider the case when you write, compile and validate a piece of software on machine that has <=47bit VA. The binary got shipped to customers. Later, customer gets a new shiny machine that supports larger address space and your previously working software is broken. Such binaries might exist today. It is bad idea to use >47bit VA by default. Most of software got tested on x86 with 47bit VA. We can consider more options to opt-in into wider address space like personality or prctl() handle. But opt-out is no-go from what I see. -- Kiryl Shutsemau / Kirill A. Shutemov