From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B4B7CA0EE0 for ; Fri, 30 Aug 2024 05:57:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA4A76B00C1; Fri, 30 Aug 2024 01:57:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2D646B00C2; Fri, 30 Aug 2024 01:57:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9591C6B00C3; Fri, 30 Aug 2024 01:57:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 66E266B00C1 for ; Fri, 30 Aug 2024 01:57:27 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 06445A13EA for ; Fri, 30 Aug 2024 05:57:27 +0000 (UTC) X-FDA: 82507854534.21.86E6FE5 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf13.hostedemail.com (Postfix) with ESMTP id B9B1D20008 for ; Fri, 30 Aug 2024 05:57:24 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="c0oxAE/7"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf13.hostedemail.com: domain of svens@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=svens@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724997371; a=rsa-sha256; cv=none; b=VIVewxI3X+6a4WUju7H/i1hph2k4M0bRUlKthK9m3qVDMV+kN2jD4W9hC/J+yYsCJBWapg fXRqOZrZU+2RnBgX5skVu/+2fRJJgPBTuYB+JQI/PewFfcIxs4M+Q7N2AAheULbZoSfTEe 8CGuZie/U0oaKsK+SAsbtFO2NAaWRtg= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="c0oxAE/7"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf13.hostedemail.com: domain of svens@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=svens@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724997371; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CDUrk3zMv67XAarUr+2bT8akH1i9sGcWkwQ9HwuJ8Nc=; b=JJa8XsvKNfTkA/uvg5XcCHTjH3xR9plwIGg+bVjUv7i2UBp/U/o5ro/O2fIhy/CRNfg+zS rQw5/N/7h5cHPpJT7Zc79PW5D46+HKV2f+a1/Wqbs+zcZgjyLUqU7Dir5D1mk90+R/YTDU Oica7AUU9Phxj+N3V6L3jHUBFQrrhsI= Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 47U3Nt37003367; Fri, 30 Aug 2024 05:57:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type:content-transfer-encoding; s=pp1; bh= CDUrk3zMv67XAarUr+2bT8akH1i9sGcWkwQ9HwuJ8Nc=; b=c0oxAE/71OEMLCBm OdhefJb6N50Gji1bs7gS9c0c6irY+g7o7IS6C3KA1nR0HDzjbbN+gjjhhGKJofOq EhUeFz3wIJ5ooU0N+U3/x6xtzJd+8EIZYYa8np/4W1af93E/PE5zwjDexGcS0+NH m5RxeIR5pCTL9PFmja1OalRcj3K752DrM8DPaTRWLO/vBk91m0JXNhNkWhSEb/XR QBTbSqsbzBZ1wLPAJdHTQOdd2Aln4MWz1rVYwpDrN27N7Mh9JfFhOcCkVpooRObR wJUpr0FVlqe96JFbVpO0mI2hz1mCkl3PorhnK7oX3mDuNBufKi83PGdw2Pk+teqy hzTAXQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 419q8qctcp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Aug 2024 05:57:14 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 47U5vEai006812; Fri, 30 Aug 2024 05:57:14 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 419q8qctcg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Aug 2024 05:57:14 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 47U5klqi003111; Fri, 30 Aug 2024 05:57:13 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 417tuq9rh3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Aug 2024 05:57:13 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 47U5vBib18415966 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Aug 2024 05:57:11 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 25A4B2005A; Fri, 30 Aug 2024 05:57:11 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D559D20040; Fri, 30 Aug 2024 05:57:10 +0000 (GMT) Received: from tuxmaker.linux.ibm.com (unknown [9.152.85.9]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Fri, 30 Aug 2024 05:57:10 +0000 (GMT) From: Sven Schnelle To: Luis Chamberlain Cc: Zi Yan , Matthew Wilcox , "Pankaj Raghav (Samsung)" , brauner@kernel.org, akpm@linux-foundation.org, chandan.babu@oracle.com, linux-fsdevel@vger.kernel.org, djwong@kernel.org, hare@suse.de, gost.dev@samsung.com, linux-xfs@vger.kernel.org, hch@lst.de, david@fromorbit.com, yang@os.amperecomputing.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, john.g.garry@oracle.com, cl@os.amperecomputing.com, p.raghav@samsung.com, ryan.roberts@arm.com, David Howells , linux-s390@vger.kernel.org Subject: Re: [PATCH v13 04/10] mm: split a folio in minimum folio order chunks In-Reply-To: (Luis Chamberlain's message of "Thu, 29 Aug 2024 16:41:48 -0700") References: <20240822135018.1931258-1-kernel@pankajraghav.com> <20240822135018.1931258-5-kernel@pankajraghav.com> <221FAE59-097C-4D31-A500-B09EDB07C285@nvidia.com> Date: Fri, 30 Aug 2024 07:57:10 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 6OIQVdZSEZ307sReg3lqu_l3a05lWqTn X-Proofpoint-ORIG-GUID: byezXyY-9GTyTUd_Mq8392plPJ4YcFf7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-30_02,2024-08-29_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 impostorscore=0 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 mlxlogscore=757 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2408300039 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B9B1D20008 X-Stat-Signature: mcx11n8xaj9khksoffm6egi1p5k7refi X-Rspam-User: X-HE-Tag: 1724997444-933957 X-HE-Meta: U2FsdGVkX1+cqcNYc5juOltTGyPrIilzPTDjfAhRGz1qiymQbqG1TOYjbgFNOWq5dY+vDCkmPSv6jT3U4vcBX+bT4mMgrqHsvj4WbidU5G89J0WnQ/o9m6D1PkqWxGHirnRaNjvVfD5PnRIqDdaNJR8bYKG7iznCzJpGGjftm9h1v/uorSHz8DRVqXd7ZzCsCbDUY4GZC6PWeQQOQk3ofhTSIObdLtccqv5SYWYvYDXcQTvT1nTwnKZljHFLosxP2gyW9WJpOTzrx1R9267dotrbhziSrxryLm0yGhNiXkmh0RAAtwQ6r9+hSWEuIbNqtm4gIPv0wvQQGXON1YkxuNQD7RMhs0F1OJPORx71NH3JCTd6Yzzot4d+2KO/n/4gM67W/rz946vwBDSgInoLtbig+SNW/mdQ9B4G/ztSEYTT3gMaXk5ooQLXe9Mx4zs39V7mD5qI3yLVIMHnAWlNuWZOIwgQet5dM5loFUNI5yhsBex6p1nAi1+XrSdxmDaGD/yYOpjkfNAxVtu/SoeepE41C4PHpElQSF4xFrIUKwhTEf9Q3BG4S4jqCHGO+DBpmWRAL1GwAahwA74a3uroMyqJuJvJhZqXVo8MXbvNk0d4soasysmoKhytTAnvl1w8NkwSVzisrYytmyawKavOS4Tb526+77ksEQ1KET6JqUnWwlwoyCgQL6C1GXDhka05rUNbnvi9be4UfAKmrc4Q60jBb9XcXg0VB7lVPJgJuPLJsmPLSJ02lR7F5mOIf/RMkHciiPitWC+EDU+HuldejKEfBuNpOpYO50mdB8Apkz5N6/ySb32jCwg+t/bTIhwAgZJFPLsvTywiAX/Z9gxpgZq6J2yBivLJd4fcfdOkaePsARfZHmyeZ1vkiDs9jg7eWb46kxNS6Prjek50KuLYiLEvJI10V5zhEa8mzpIpgHSiW2UfdnxVN1TtysABD8GarzDXC+1S/M/lshRZERR sQAatiMn inx3J82J9u2c0UOXjEpQstpqiIyY+lLDuz0lWuyzlkkJWo6+ZIZJ81CvO+OV8BgJRMKDTjfgieg1cyEzBrW+6/D/FWigD6Mjsinz/O0z9+CufQ6lLMtKxRMtfXsJj8IOxpIh7IqmIdbq1wRKLBCrUDBliuwUbJjyhzCpPFqyNMejW2L/Ilw1i3vPzGbcSHbHFpaALiu3pg//XZ+4rNPs94B9+Bix0zHi2VE+zPGSOiec8uw6jcwiXYN1IGg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Luis Chamberlain writes: > On Thu, Aug 29, 2024 at 06:12:26PM -0400, Zi Yan wrote: >> The issue is that the change to split_huge_page() makes split_huge_page_= to_list_to_order() >> unlocks the wrong subpage. split_huge_page() used to pass the =E2=80=9Cp= age=E2=80=9D pointer >> to split_huge_page_to_list_to_order(), which keeps that =E2=80=9Cpage=E2= =80=9D still locked. >> But this patch changes the =E2=80=9Cpage=E2=80=9D passed into split_huge= _page_to_list_to_order() >> always to the head page. >>=20 >> This fixes the crash on my x86 VM, but it can be improved: It also fixes the issue on s390x. Thanks!