From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4FDBC54E94 for ; Wed, 25 Jan 2023 11:00:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F18796B0071; Wed, 25 Jan 2023 06:00:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EC86F6B0072; Wed, 25 Jan 2023 06:00:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D90216B0073; Wed, 25 Jan 2023 06:00:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C99D26B0071 for ; Wed, 25 Jan 2023 06:00:27 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 848E1160620 for ; Wed, 25 Jan 2023 11:00:27 +0000 (UTC) X-FDA: 80393027694.14.ACB21FC Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf10.hostedemail.com (Postfix) with ESMTP id 42DACC000F for ; Wed, 25 Jan 2023 11:00:24 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=c22xrO8U; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf10.hostedemail.com: domain of svens@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=svens@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674644424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PV97j+QpGtIXyVnJleYyfcWoFSAMpegJ7+MrYuplsz4=; b=pQ3MwMJyQ0Xq/WM9Yu3Zz33juj0zbRey7J1lDdeEXfCF3dsg8HpS+92S1cXNZ+eBbFxrxG uJknO8gArIZGB8R9zLa15XjFsB/4VjDUiSHhcXbAfJbSFLes/8HR/BAuFhCYRU/d+z0Ihh zJKtEnmIcVNofBp0aFvaY38jiqmI9WE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=c22xrO8U; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf10.hostedemail.com: domain of svens@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=svens@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674644424; a=rsa-sha256; cv=none; b=24ThFxaHsQQ2oHyOE4qs8KXlt9eYe3goVgach2yJOJG/c9tktpcLKXKi02BraioFUnVspV Y/qzNIkNbM1zaDuAPAACdpDhPsuRpYPDilHQkgv3hZWwePLFcs5x23P9C3zED742Gwf4bp KxveNZiromoTMYN+xlzGJ2rXI4njb+I= Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30P9Dxvb006477; Wed, 25 Jan 2023 11:00:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : mime-version : content-type; s=pp1; bh=PV97j+QpGtIXyVnJleYyfcWoFSAMpegJ7+MrYuplsz4=; b=c22xrO8UF3Oj/J0XO82E2PvTh+ZiHP0o16b4C+J/g/BGpUYhTCpvN9jkYD3u11f+VRE0 Hcpos6E9xH3oY8s+Akt0H/6v4R8IttLlnH0h7cYYEWfkklKMevSa1HH+hBrZfHkB82NB WorVqf4H8sGg42S0cLZu7Rx37ne3kXO3cfrTnpi/tR0aaWBKdDEQm5P27Nf/cw9yP6tS 3QPyn77Ff4JYRS07z9zEqFhFCU3n6dO7zitVzeTgwgEkphcKNrynElNy5Ry+wiOLvd8I wnoQ6LqNrT/JYFfx1vVRkXLi1P3hmVhNuqF7Bv23bt8ellcJYW1tvUHzbD/03kItVzkS Nw== Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3naakpkdup-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Jan 2023 11:00:22 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 30ONDDT2028677; Wed, 25 Jan 2023 11:00:04 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma06ams.nl.ibm.com (PPS) with ESMTPS id 3n87afd0gp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Jan 2023 11:00:04 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 30PB01BW18022796 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jan 2023 11:00:02 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CDBEE20043; Wed, 25 Jan 2023 11:00:01 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 93D2220040; Wed, 25 Jan 2023 11:00:01 +0000 (GMT) Received: from tuxmaker.linux.ibm.com (unknown [9.152.85.9]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 25 Jan 2023 11:00:01 +0000 (GMT) From: Sven Schnelle To: "Liam R. Howlett" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , maple-tree@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH v4 15/49] ipc/shm: Use the vma iterator for munmap calls References: <20230120162650.984577-1-Liam.Howlett@oracle.com> <20230120162650.984577-16-Liam.Howlett@oracle.com> Date: Wed, 25 Jan 2023 12:00:01 +0100 In-Reply-To: <20230120162650.984577-16-Liam.Howlett@oracle.com> (Liam R. Howlett's message of "Fri, 20 Jan 2023 11:26:16 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 1SF-VQ8XaTMWXdqnAj0gHluE9UzoDteO X-Proofpoint-GUID: 1SF-VQ8XaTMWXdqnAj0gHluE9UzoDteO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-25_05,2023-01-24_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 mlxlogscore=999 spamscore=0 adultscore=0 mlxscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301250096 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 42DACC000F X-Stat-Signature: qs894usgjepsb4yfdd46jkdcb5knunr7 X-HE-Tag: 1674644424-307297 X-HE-Meta: U2FsdGVkX18PeMNRs2Rk9aNIaxBP1acTnntxqtEkvzoLG4FPzHn+uHaBSAv+gAMuvj/FJc1ZLzsHM0WbW4cGfCvZ9QVRP8nDNO5rREHtCkrQQlEL8qoXqXHvHXwPeYbd87JBqCPLVe1+XExeRhieNTPKe9I87AiW0t90Cz1bmHITIyQyOV+Ba4betIXlnEOoXhE113cIxbed+qm2Z8CS+7lOn7PV4m8rvdXmsnowQTOIKdtD8lNBTMRwFrjA1MzO2dXvUd23+gTcPQh73pt8gR1+u4ZiHzr+wvw9GHTxwui5Ukwh85/Pa3ywFCgD3D8ECnOxaLGRrA/kUx2+p/h/Bcm5wGTLc3qL0XWPN1mF7wdkbYGCDohUMnoVilWTrd1aawfZZhzVhwEGA3kzwkzu8BM/XtXCnh3HITrRbXP50WysZ3z+xCKfzvGRPpW4dCpPMwkK1eBsZmjnTyRsowZubirspMQ2XUC7geoeVv5jhr4abIPZaXdFn299KK7HLWnr6YHEttBnyQJWQGZSBLFdAmgzkTIe1VthOfALrwLj9dSzroS1WcZgz7zcnXkPTb4EeMBoiWQs8+v0v1qsYjBLLISy0T72pVtdLTWIngE2U+e27BoP0wSq/Iy90M7jWi9AhcM5nb4vIdEthrJuHeqUU4MgCrcYgpveJjV0wmzhg8c2AmqDdclE2FFm1w3SQ77oDDDYZTmstuiNZ/xwn7VGA0etrd6mCY6gumHFWsYylnlnMaG23UB5JfLI7hEe+5HpmFvcQm00xWRJAKPUVCHdw0YnezI2KGmycGZfoIS7ru/AeD3a9QgmY0Lv0o8/3QklFHFzjBF/B5/PzqLmLJINLJm+p8TyptpnhtCeMchH3/+3PiQc8L9Hb00mM2NsGQq1kUkkF9SnbobrLByNSJ0G73bJY6rjvAmo3dxkzlO/8sc5XtR4/D/XDnF3+7Qrugk/ohE8NmhDUAGcM40+h5E iOSB61m+ btCCGUkqLXqeeOXSYpjAcW1aWEvFXrg0KwA+vIh4PIhuIX03E610Ij8/I7YdvIMyCoD+7BDVyESSaRjdKtQrByxyD2dPP3WfLkmCw70FoLI5+ckMc6pDKxQM0gJaDPTAgJ8sbHaWu5/mH8CGiIarqDtgvPY8oB+oYuTqamp6rM0pqf7uzIxBLQevDtg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Liam, "Liam R. Howlett" writes: > From: "Liam R. Howlett" > > Pass through the vma iterator to do_vmi_munmap() to handle the iterator > state internally > > Signed-off-by: Liam R. Howlett > --- > ipc/shm.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) git bisect says this breaks the shm* testcase in ltp on (at least) s390: # ./test.sh tst_test.c:1558: TINFO: Timeout per run is 0h 00m 30s shmat01.c:124: TPASS: shmat() succeeded to attach NULL address shmat01.c:92: TFAIL: shmat() failed: EINVAL (22) shmat01.c:92: TFAIL: shmat() failed: EINVAL (22) shmat01.c:92: TFAIL: shmat() failed: EINVAL (22) Summary: passed 1 failed 3 broken 0 skipped 0 warnings 0 # Can you take a look? Thanks! reverting the above commit fixes the issue. Thanks, Sven