From: Sven Schnelle <svens@linux.ibm.com>
To: Liam Howlett <liam.howlett@oracle.com>
Cc: "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH v2 10/44] mmap: Change do_mas_munmap and do_mas_aligned_munmap() to use vma iterator
Date: Tue, 10 Jan 2023 15:53:46 +0100 [thread overview]
Message-ID: <yt9da62qbfut.fsf@linux.ibm.com> (raw)
In-Reply-To: <20230105191517.3099082-11-Liam.Howlett@oracle.com> (Liam Howlett's message of "Thu, 5 Jan 2023 19:15:55 +0000")
Liam Howlett <liam.howlett@oracle.com> writes:
> From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
>
> Start passing the vma iterator through the mm code. This will allow for
> reuse of the state and cleaner invalidation if necessary.
>
> Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
> include/linux/mm.h | 2 +-
> mm/mmap.c | 77 +++++++++++++++++++++-------------------------
> mm/mremap.c | 6 ++--
> 3 files changed, 39 insertions(+), 46 deletions(-)
>
Starting with this patch i see the following oops on s390:
[ 4.512863] Run /sbin/init as init process
[ 4.519447] Unable to handle kernel pointer dereference in virtual kernel address space
[ 4.519450] Failing address: fbebfffb00000000 TEID: fbebfffb00000803
[ 4.519452] Fault in home space mode while using kernel ASCE.
[ 4.519455] AS:0000000001a60007 R3:0000000000000024
[ 4.519482] Oops: 0038 ilc:2 [#1] SMP
[ 4.519486] Modules linked in:
[ 4.519488] CPU: 7 PID: 1 Comm: init Not tainted 6.2.0-rc1-00179-ga7f83eb601ef #1582
[ 4.519491] Hardware name: IBM 3906 M04 704 (z/VM 7.1.0)
[ 4.519493] Krnl PSW : 0704c00180000000 0000000000929464 (__memcpy+0x24/0x50)
[ 4.519503] R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:3 CC:0 PM:0 RI:0 EA:3
[ 4.519506] Krnl GPRS: 0000000000000000 0000037fffb1f990 0000037fffb1f990 fbebfffb00000008
[ 4.519509] 0000000000000007 0000000000929480 0000000000000008 0000000000000000
[ 4.519517] 0000000000000009 0000037fffb1fb40 0000037fffb1f880 0000037fffb1fc58
[ 4.519519] 0000000080288000 0000000000000001 0000000000cf65da 0000037fffb1f5d8
[ 4.519527] Krnl Code: 0000000000929456: b9040012 lgr %r1,%r2
[ 4.519527] 000000000092945a: a7740008 brc 7,000000000092946a
[ 4.519527] #000000000092945e: c05000000011 larl %r5,0000000000929480
[ 4.519527] >0000000000929464: 44405000 ex %r4,0(%r5)
[ 4.519527] 0000000000929468: 07fe bcr 15,%r14
[ 4.519527] 000000000092946a: d2ff10003000 mvc 0(256,%r1),0(%r3)
[ 4.519527] 0000000000929470: 41101100 la %r1,256(%r1)
[ 4.519527] 0000000000929474: 41303100 la %r3,256(%r3)
[ 4.519547] Call Trace:
[ 4.519548] [<0000000000929464>] __memcpy+0x24/0x50
[ 4.519557] [<0000000000cfd474>] mas_wr_bnode+0x5c/0x14e8
[ 4.519562] [<0000000000cffaf6>] mas_store_prealloc+0x4e/0xf8
[ 4.519569] [<000000000039d262>] mmap_region+0x482/0x8b0
[ 4.519572] [<000000000039da6e>] do_mmap+0x3de/0x4c0
[ 4.519575] [<000000000036aeae>] vm_mmap_pgoff+0xd6/0x188
[ 4.519580] [<000000000039a18a>] ksys_mmap_pgoff+0x62/0x230
[ 4.519584] [<000000000039a522>] __s390x_sys_old_mmap+0x7a/0x98
[ 4.519588] [<0000000000d22650>] __do_syscall+0x1d0/0x1f8
[ 4.519592] [<0000000000d32712>] system_call+0x82/0xb0
[ 4.519596] Last Breaking-Event-Address:
[ 4.519596] [<0000000000cf65d4>] mas_store_b_node+0x3cc/0x6b0
[ 4.519603] Kernel panic - not syncing: Fatal exception: panic_on_oops
This happens on every boot, always killing the init process. The oops
doesn't happen with next-20230110. With next-20230110 i see shmat
testcase failures in ltp (shmat returning with -EINVAL because
find_vma_intersection() tells shmat that there's already a mapping
present).
Trying to bisect that i stumbled above the oops above. Any ideas before
i start trying to understand the patch?
Thanks,
Sven
next prev parent reply other threads:[~2023-01-10 14:53 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 19:15 [PATCH v2 00/44] VMA tree type safety and remove __vma_adjust() Liam Howlett
2023-01-05 19:15 ` [PATCH v2 02/44] maple_tree: Fix potential rcu issue Liam Howlett
2023-01-05 19:15 ` [PATCH v2 01/44] maple_tree: Add mas_init() function Liam Howlett
2023-01-05 19:15 ` [PATCH v2 03/44] maple_tree: Reduce user error potential Liam Howlett
2023-01-05 19:15 ` [PATCH v2 05/44] mm: Expand vma iterator interface Liam Howlett
2023-01-05 19:15 ` [PATCH v2 04/44] test_maple_tree: Test modifications while iterating Liam Howlett
2023-01-05 19:15 ` [PATCH v2 06/44] mm/mmap: convert brk to use vma iterator Liam Howlett
2023-01-09 15:10 ` Vernon Yang
2023-01-09 16:38 ` Liam Howlett
2023-01-05 19:15 ` [PATCH v2 07/44] kernel/fork: Convert forking to using the vmi iterator Liam Howlett
2023-01-05 19:15 ` [PATCH v2 08/44] mmap: Convert vma_link() vma iterator Liam Howlett
2023-01-05 19:15 ` [PATCH v2 09/44] mm/mmap: Remove preallocation from do_mas_align_munmap() Liam Howlett
2023-01-05 19:15 ` [PATCH v2 11/44] mmap: Convert vma_expand() to use vma iterator Liam Howlett
2023-01-05 19:15 ` [PATCH v2 10/44] mmap: Change do_mas_munmap and do_mas_aligned_munmap() " Liam Howlett
2023-01-10 14:53 ` Sven Schnelle [this message]
2023-01-10 17:26 ` Liam Howlett
2023-01-11 6:55 ` Sven Schnelle
2023-01-05 19:15 ` [PATCH v2 12/44] mm: Add temporary vma iterator versions of vma_merge(), split_vma(), and __split_vma() Liam Howlett
2023-01-05 19:15 ` [PATCH v2 15/44] mm: Change mprotect_fixup to vma iterator Liam Howlett
2023-01-05 19:15 ` [PATCH v2 14/44] userfaultfd: Use " Liam Howlett
2023-01-05 19:15 ` [PATCH v2 13/44] ipc/shm: Use the vma iterator for munmap calls Liam Howlett
2023-01-05 19:15 ` [PATCH v2 16/44] mlock: Convert mlock to vma iterator Liam Howlett
2023-01-05 19:15 ` [PATCH v2 18/44] mempolicy: Convert " Liam Howlett
2023-01-05 19:15 ` [PATCH v2 17/44] coredump: " Liam Howlett
2023-01-05 19:15 ` [PATCH v2 19/44] task_mmu: " Liam Howlett
2023-01-05 19:15 ` [PATCH v2 21/44] madvise: Use vmi iterator for __split_vma() and vma_merge() Liam Howlett
2023-01-05 19:15 ` [PATCH v2 20/44] sched: Convert to vma iterator Liam Howlett
2023-01-05 19:15 ` [PATCH v2 22/44] mmap: Pass through vmi iterator to __split_vma() Liam Howlett
2023-01-07 2:01 ` SeongJae Park
2023-01-07 2:39 ` SeongJae Park
2023-01-09 16:45 ` Liam Howlett
2023-01-09 19:28 ` SeongJae Park
2023-01-09 20:30 ` Liam Howlett
2023-01-09 23:07 ` SeongJae Park
2023-01-05 19:15 ` [PATCH v2 25/44] mm: Switch vma_merge(), split_vma(), and __split_vma to vma iterator Liam Howlett
2023-01-06 17:23 ` SeongJae Park
2023-01-06 19:20 ` Liam Howlett
2023-01-05 19:15 ` [PATCH v2 24/44] mm/mremap: Use vmi version of vma_merge() Liam Howlett
2023-01-05 19:15 ` [PATCH v2 23/44] mmap: " Liam Howlett
2023-01-05 19:16 ` [PATCH v2 26/44] mm/damon: Stop using vma_mas_store() for maple tree store Liam Howlett
2023-01-05 19:32 ` SeongJae Park
2023-01-05 19:52 ` Liam Howlett
2023-01-05 20:16 ` SeongJae Park
2023-01-05 19:16 ` [PATCH v2 27/44] mmap: Convert __vma_adjust() to use vma iterator Liam Howlett
2023-01-05 19:16 ` [PATCH v2 29/44] madvise: Use split_vma() instead of __split_vma() Liam Howlett
2023-01-05 19:16 ` [PATCH v2 30/44] mm: Remove unnecessary write to vma iterator in __vma_adjust() Liam Howlett
2023-01-05 19:16 ` [PATCH v2 28/44] mm: Pass through vma iterator to __vma_adjust() Liam Howlett
2023-01-05 19:16 ` [PATCH v2 34/44] mm: Change munmap splitting order and move_vma() Liam Howlett
2023-01-05 19:16 ` [PATCH v2 31/44] mm: Pass vma iterator through to __vma_adjust() Liam Howlett
2023-01-05 19:16 ` [PATCH v2 32/44] mm: Add vma iterator to vma_adjust() arguments Liam Howlett
2023-01-05 19:16 ` [PATCH v2 33/44] mmap: Clean up mmap_region() unrolling Liam Howlett
2023-01-05 19:16 ` [PATCH v2 36/44] mm/mmap: Refactor locking out of __vma_adjust() Liam Howlett
2023-01-05 19:16 ` [PATCH v2 35/44] mm/mmap: move anon_vma setting in __vma_adjust() Liam Howlett
2023-01-05 19:16 ` [PATCH v2 37/44] mm/mmap: Use vma_prepare() and vma_complete() in vma_expand() Liam Howlett
2023-01-05 19:16 ` [PATCH v2 40/44] mm/mmap: Don't use __vma_adjust() in shift_arg_pages() Liam Howlett
2023-01-05 19:16 ` [PATCH v2 39/44] mm: Don't use __vma_adjust() in __split_vma() Liam Howlett
2023-01-05 19:16 ` [PATCH v2 38/44] mm/mmap: Introduce init_vma_prep() and init_multi_vma_prep() Liam Howlett
2023-01-05 19:16 ` [PATCH v2 41/44] mm/mmap: Introduce dup_vma_anon() helper Liam Howlett
2023-01-05 19:16 ` [PATCH v2 44/44] vma_merge: Set vma iterator to correct position Liam Howlett
2023-01-05 19:16 ` [PATCH v2 42/44] mm/mmap: Convert do_brk_flags() to use vma_prepare() and vma_complete() Liam Howlett
2023-01-05 19:16 ` [PATCH v2 43/44] mm/mmap: Remove __vma_adjust() Liam Howlett
2023-01-10 22:51 ` [PATCH v2 00/44] VMA tree type safety and remove __vma_adjust() Mark Brown
2023-01-11 2:22 ` Liam Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yt9da62qbfut.fsf@linux.ibm.com \
--to=svens@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=maple-tree@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox