From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7350C8303D for ; Fri, 4 Jul 2025 12:23:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 759956B02EF; Fri, 4 Jul 2025 08:23:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E25D6B02F0; Fri, 4 Jul 2025 08:23:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A9F16B02F1; Fri, 4 Jul 2025 08:23:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 417E26B02EF for ; Fri, 4 Jul 2025 08:23:40 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BC83B5C86E for ; Fri, 4 Jul 2025 12:23:39 +0000 (UTC) X-FDA: 83626498158.25.CA22D42 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by imf24.hostedemail.com (Postfix) with ESMTP id ECFF118000A for ; Fri, 4 Jul 2025 12:23:36 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=TnhN8PMg; spf=none (imf24.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.16) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=TnhN8PMg; spf=none (imf24.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.16) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751631817; a=rsa-sha256; cv=none; b=travPNA9cJQBzOi0RtO5PF20WHdaW9GFX+cmku0EufwwcncYW1YFZqkg/97QrKDb1rPcpj hiPcnsw+Ykzy6Z6fQ/hISlu9BbVzuX1nB8VUNZayO3ZybptfY65NH51+qPGtA2K1Daayq0 3Xax1RkPgYOO+mWiylRx2V6HWSPfUgU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751631817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9t9E14ZYoqiQdYhw6ehzRptzld9/0bZMSdm756X+r7I=; b=FU0jliRk7+jerljvg7NeeHKU4nT3exBLuR/0+3rDohDUL5oKxVfeucAewbLHyL01LtXni7 aj/+bU/gBor1b/ljYCXHP0OTVguePh0xBQwgfwFEy3uI4BIrOrhrSgEBS5MAXl4nRKHNIt XYBWebt5I5OjS5SgS8A6KuJ+VHfLQvY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751631817; x=1783167817; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=oweq7sEis8OSPxaym3zvDjZpLebm0v2LQsMDtWM7+Zs=; b=TnhN8PMg3rIOoF2ZSXs/p+UNhUH3BWybKerTQLbApkpmXyl5zgU/dLLx wRV35vGd3IJZYKy3sNT4Vu7w3TEzJWw738YLY71iHSbZyvRuyZX0HYYIo 0dTz/0S5OKKc3jH2Yspk7Wj4rost11xpxFbjtyDHpHPoyG2yCZeIQeCEX 7fhSTLZUS1a8OFCVwQJ/SssXIEsdkkXT/o940MdMnvp9cpdNt1TyYDcXQ v/9vAMu8Bm0OZxAEYel6o7P4qlYSJBHAwuVwbjVjQkPB7maZoTU51gf8w enyCniZ9gykCc5Cam2LhTDbZRHy4AQYJGg92BeQKsH4aQgw6tf/T1yAZL w==; X-CSE-ConnectionGUID: PRzD5t4cQniSBZx7pyw2EA== X-CSE-MsgGUID: 6t+VKmESTZOVXVlnAilW/A== X-IronPort-AV: E=McAfee;i="6800,10657,11483"; a="54085573" X-IronPort-AV: E=Sophos;i="6.16,287,1744095600"; d="scan'208";a="54085573" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2025 05:23:36 -0700 X-CSE-ConnectionGUID: h0pPry01S5+0sgbByQeXGQ== X-CSE-MsgGUID: zHTjG05tTGup2BFBFLyhMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,287,1744095600"; d="scan'208";a="155395215" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa010.fm.intel.com with ESMTP; 04 Jul 2025 05:23:24 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id 4B75815D; Fri, 04 Jul 2025 15:23:23 +0300 (EEST) Date: Fri, 4 Jul 2025 15:23:23 +0300 From: "Kirill A. Shutemov" To: Dave Hansen Cc: Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Ard Biesheuvel , "Paul E. McKenney" , Josh Poimboeuf , Xiongwei Song , Xin Li , "Mike Rapoport (IBM)" , Brijesh Singh , Michael Roth , Tony Luck , Alexey Kardashevskiy , Alexander Shishkin , Jonathan Corbet , Sohil Mehta , Ingo Molnar , Pawan Gupta , Daniel Sneddon , Kai Huang , Sandipan Das , Breno Leitao , Rick Edgecombe , Alexei Starovoitov , Hou Tao , Juergen Gross , Vegard Nossum , Kees Cook , Eric Biggers , Jason Gunthorpe , "Masami Hiramatsu (Google)" , Andrew Morton , Luis Chamberlain , Yuntao Wang , Rasmus Villemoes , Christophe Leroy , Tejun Heo , Changbin Du , Huang Shijie , Geert Uytterhoeven , Namhyung Kim , Arnaldo Carvalho de Melo , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv8 04/17] x86/cpu: Defer CR pinning setup until after EFI initialization Message-ID: References: <20250701095849.2360685-1-kirill.shutemov@linux.intel.com> <20250701095849.2360685-5-kirill.shutemov@linux.intel.com> <841a200e-bcf0-4488-acbd-c00396a9ccd2@intel.com> <2n2knq4wkzyfr35udpxawgnc4ykk7s77yavu3crnzf77wjaj4c@njyscphln4gl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2n2knq4wkzyfr35udpxawgnc4ykk7s77yavu3crnzf77wjaj4c@njyscphln4gl> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: ECFF118000A X-Stat-Signature: 78s7cz1ttwohzwfq7kfc94im8jfyxiab X-Rspam-User: X-HE-Tag: 1751631816-817461 X-HE-Meta: U2FsdGVkX1/4LvZtlrxz4hc5xGKL3l//lMgnmrguaUv7Wz7+J7pbj2YiXtSSDIW+dbrWa+zVaK5T7eVqXN/w8Tk7jJ2KhfcZDL8tNVw5VOBobL28rXozNjvi93UtOYbDnNQ7FzvSx4JXz5bx5mDRPa7+UpV0KraAVPH7c3Iywdb14sWyYrhB7eG1K7gYLR16pw4URk1Mcx3RKW3xW8yrToIPpZcpKfybzQZZKDe7X8DbZetBJacj+DhE/sQFtlK4xkChbZK16PbrESRCcf4fF/54x0qvPILEHhYaUImiCnrqFcM8a4rORF+VK8HUOs4/7Aj7pd2C+Es1naTyE5evzQ8fFCGnAeJNjhFxGvxuwZnfFY55AwodKlmWOozRhVZlVvNZgKkTqAuUhs6jtycfn9RzE/+Ay+pglgw+osfKL+DD6MgQzU817ALYHsEhBHTS7TlWc1n0ZGZQnc9PFkHPFvdS19XZ9GedNyBhjaOlN7H7D2rJSQGVX+nbGLqfsWgLGrKNsh8qaRCHAHmviHfvRsTAtTR1wQv9/eOC1W2HhP6TMbXPZnJtsUuoUIRA043XPE6534vkDHUE9QlMYjYRJ+RqDx37q2E6jb3nM7wq7gl01MtGUB2xsEJUXfBk1guceS5bQejQqSMbvbJHA1Mhy8MKdZImivkd4Qn47fy/5rugL0x4vxwo+v/muw9P2c9dmFHI+5eH5oXV7JNBA/24bbSljCwuuNBnIin8VWZHIH0JQuLw3rJwfRA7wCTzKcwDMqawxhQQ/YLvOAG6C8ZdaJ+MmNi0O1V4R0yFBksPHk1LC0Mumr6hAehe8t3uR0W5GfURD60VIdVRRPw0niJAh7GjT0XiYatnvQDojfCXJ3ER5t1bfdNVmRQPYkxwNXYAq8Nryt7m9Jom6f+dnT8oj9chqJ9yg0ZjifhoBNkZYk521jR3IKdfYE2VVm5zFuEiOY7Q7lUKNrVl4Lvwf0Y GCjFRaOg wVUWznIlf02lUk0wqpHiv8cUpTdfqPT/LjzH+h9UE07goNMgvv9sYxF+MrIrcTrId63fsGnthx/sshJv9HVb0CcBMX0cOP0O3jMrupEqqa+y6yUDemeCDQELfVq0iciqgNbJGBGAni1vh75OLv5HCRo7NUOaWLeihyRhg2Y+JqIBIeNZylEUJF93Ft050nySIywvbkw7IvFbkahKFz9WSpYgNv9XzrgZ9IgGKoYs8YaJD12C9SCnJHEOiYPhED2PRx04QgZN5WljF2zc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 02, 2025 at 01:05:23PM +0300, Kirill A. Shutemov wrote: > On Tue, Jul 01, 2025 at 04:10:19PM -0700, Dave Hansen wrote: > > On 7/1/25 02:58, Kirill A. Shutemov wrote: > > > Move CR pinning setup behind the EFI initialization. > > > > I kinda grumble about these one-off solutions. Could we just do this > > once and for all and defer CR pinning as long as possible? For instance, > > could we do it in a late_initcall()? > > > > Do we need pinning before userspace comes up? > > Hm. I operated from an assumption that we want to pin control registers as > early as possible to get most benefit from it. > > I guess we can defer it until later. But I am not sure late_initcall() is > the right place. Do we want random driver to twiddle control registers? I will do it in core_initcall(). -- Kiryl Shutsemau / Kirill A. Shutemov