From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B8B6C27C53 for ; Wed, 19 Jun 2024 22:43:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1B476B030A; Wed, 19 Jun 2024 18:43:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCB536B030B; Wed, 19 Jun 2024 18:43:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B454B6B030C; Wed, 19 Jun 2024 18:43:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 934CB6B030A for ; Wed, 19 Jun 2024 18:43:37 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1691A1A15BD for ; Wed, 19 Jun 2024 22:43:37 +0000 (UTC) X-FDA: 82249116474.06.9C79692 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf29.hostedemail.com (Postfix) with ESMTP id 421F2120010 for ; Wed, 19 Jun 2024 22:43:33 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=RpnrxpTH; spf=pass (imf29.hostedemail.com: domain of gor@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=gor@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718837006; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aT7kqBoByjh7jmnj1TUH3PePjUpWsIOrMkFUws0xZHk=; b=Ho8r0iQKaAi3FmsZ4Yhrcj57XljhSAzfASo+VpJhsbF1OqO1y3nVwid3CHr3EVC7eXNnSb WRLRkZeAEcxkFg4rHVEBhf/keBu3F5SG2OhMbItkUTc+Z2e8mHStMqXpoVab3oz1z/8bHO 5jnnJ2hEHdWXI+difV0ideXA/pOz0x0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718837006; a=rsa-sha256; cv=none; b=UmX8+Q/5z7Zvako3E41yOzbYOMc6IlvKpKm/MzVn+rV18GxelevVf5wURV2iP5BTQiDS5P 0SXW/QYg2Ke6CYikRuzrgWFDq79rOskWm+uwv/7vFUNl8KKCRQbQuY/4fE2dJy7ZIJndiX tDhv16seHqGOGtEb9IjcJFwS+7rSSo8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=RpnrxpTH; spf=pass (imf29.hostedemail.com: domain of gor@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=gor@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45JMSnYW029964; Wed, 19 Jun 2024 22:43:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=pp1; bh=aT7kqBoByjh7jmnj1TUH3PePjUp WsIOrMkFUws0xZHk=; b=RpnrxpTHJtkjFwsI4uZTQoz1QuH3jMcuFDNncrHRrCW rNOuvCDKPGDeryUYDt5DrIW+b46L5nxqE+LysaA829ybyUwH9snKtfSySQt9ZdRD B199Q7m4IAXwuQclPwzRXiFitUvhHOSazZ9ZVksoRZp0owpSmI6e/ZseFTQtG7aw EkyMWKp/51MAaF/QcLOeCdsZpU/7y09VTllS8BMs7fbEUY2nLYT26AigGiMDdzAG YW1X6udENk1W7p9u262v2nnH9quQDAtwnYBuaNkvAeWM/i3tO/PwY63D1fhh5GCZ tgjvMrFUxXyxiQO7MF/gEj+h5qiQggdK7cyiEhGT4gA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yv85cg14g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jun 2024 22:43:29 +0000 (GMT) Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 45JMhTr3019468; Wed, 19 Jun 2024 22:43:29 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yv85cg14e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jun 2024 22:43:29 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45JMSFcp023897; Wed, 19 Jun 2024 22:43:28 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3ysp9qgq05-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Jun 2024 22:43:27 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45JMhMh755902570 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Jun 2024 22:43:24 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 25CC720043; Wed, 19 Jun 2024 22:43:22 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 874DF20040; Wed, 19 Jun 2024 22:43:21 +0000 (GMT) Received: from localhost (unknown [9.171.70.82]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 19 Jun 2024 22:43:21 +0000 (GMT) Date: Thu, 20 Jun 2024 00:43:20 +0200 From: Vasily Gorbik To: David Hildenbrand Cc: Wei Yang , agordeev@linux.ibm.com, gerald.schaefer@linux.ibm.com, hca@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, linux-s390@vger.kernel.org, linux-mm@kvack.org, Mike Rapoport Subject: Re: [PATCH] s390/mm: get total ram pages from memblock Message-ID: References: <20240616013537.20338-1-richard.weiyang@gmail.com> <75ee1ec6-12b0-461e-9dab-6fb6d5cc235f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <75ee1ec6-12b0-461e-9dab-6fb6d5cc235f@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 7VUYnWupo4KNvzh5nz86YPZo-EJk7Bwt X-Proofpoint-GUID: ZdZv4Td3iu8DpTVtM8drgoQlDoai2GQn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-19_02,2024-06-19_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 priorityscore=1501 malwarescore=0 spamscore=0 impostorscore=0 mlxlogscore=908 bulkscore=0 phishscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406190169 X-Stat-Signature: fok3xx45hrdd1njyki36xau1hjokud31 X-Rspamd-Queue-Id: 421F2120010 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1718837013-246390 X-HE-Meta: U2FsdGVkX1/q5fIG+ZXOzd244pLwg1NR5OogCC4nT7cFJK8AshtFFjJWWx/1E0/ysHV2x1eyeN59uivpbvvWXxmjKYeMyuJxsq/y7G/8zy8nn5ZnbUAKHGfY/Qn3zsfj37c9Hkrrq7SJe1vuiWLt6pGjb75ixooFkYsYEEJQWEMtJ5EWJucZedlX7b2aaKGMuldu0jsWsu8NgtSQvS6k+KUWl75AfKOB7vY5KlnWy8toiujAK+YI8Xk2bpNoMFKWbrngFE/nMoVeYW7jmZPDH7i4oGiO5RPgGyereUjUreCRgjv0J6M2By5+bq0ct5LLPchyQbJFewUMvOZ1ZrJiZNHQRnHivZ2qQcTUeWSJN4pOHmiU/xdERN4arp79FrKd0k3B0tWWMxl9ff8jOimvGmTVfz9/d7Km6fNd6zq8+O3jLKTSGAfR+ESwEd2nzZYUt32ztoWOsRik8EYQHHfeHBl6WemxIU1Kyw5FbNF6+70s6r0Kf/G95bTHRC+srmY0cnzqGHb+a5yKCdmWH42ej4FkixHpxZU47Q1fWnZDvr1z1DsTdqlPiq7eGoGQkqCgZiTU3+GHNvKnRnScmbM/IovqctIcEqLtI0D/tTmp0m3mhHSsf4VPhjRz1d1cWEI7xIrxB+qEHyRFBbwDeCRkISToQoK4Koxty89+PdsgVPLBs+VJ6KREJOU9C0Rz34WMjRkDN+HwaZ+kBojFn5nyOKBrRoPkql+rhUZrtuvCkjdcelGwUcHbntD+w6lefPeavF4KmayDnV6bYog7nKNa2Mkams40ydfgx6HdZ/Px3RdM4l0Ki3eMeYBnPriuI38fFVSSqRv1RQ67pBk27Iev6saciX0wYD+h+wOVxa5Ct49HVV8VIVyCfoQs+WJN0C6WKv0yMdehDAu5dOCmWFpP5mh4npxjwIVFOGlEy+DZYS6UM7ZMrkjCI5MWxmeRqHFuV8AiJqvPqzeCdn2ceNh srB+ADjs bnK/mLSdxT5+myKB5UuX7xKsYsNoWAcQQB8VWpKhZfWpBM6uzA/PnJBs6xjhaYG02Wv1PeXJv1waniEavz9gburuQBvLHj4qbVaoCbVkzPwA9L9z8N2K77JkiLEM5sXnnOflg23VzjU1IY2xZA3As3AQTLq6ZB++rGGecJwNhNf9b+NO987LZxP5KJSpYTW4E8nhb0u7hsqCFhJLxr6djjZTKRMo0kYc4znzP5q3QPvF/DQ1qo7tsJNufTplfbOnoHl4VO0TXBvglN1XukqrED+eWbEEL8SPwnvbTQLUTP7le+lyk+Wr+lukfCgk+BgW0bNDA0CR7Hx28R4Y3aJN4qFeh/A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 18, 2024 at 11:57:19AM +0200, David Hildenbrand wrote: > On 16.06.24 03:35, Wei Yang wrote: > > On s390, zero page's size relies on total ram pages. > > > > Since we plan to move the accounting into __free_pages_core(), > > totalram_pages may not represent the total usable pages on system > > at this point when defer_init is enabled. > > > > We can get the total usable pages from memblock directly. The size maybe > > not accurate due to the alignment, but enough for the calculation. > > > > Signed-off-by: Wei Yang > > CC: Mike Rapoport (IBM) > > CC: David Hildenbrand > > > > --- > > Not tested on a machine, hope it is fine. > > --- > > arch/s390/mm/init.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c > > index e769d2726f4e..d811ffa5e147 100644 > > --- a/arch/s390/mm/init.c > > +++ b/arch/s390/mm/init.c > > @@ -65,12 +65,13 @@ static void __init setup_zero_pages(void) > > unsigned int order; > > struct page *page; > > int i; > > + unsigned long total_pages = PHYS_PFN(memblock_phys_mem_size() - memblock_reserved_size()); > > /* Latest machines require a mapping granularity of 512KB */ > > order = 7; > > /* Limit number of empty zero pages for small memory sizes */ > > - while (order > 2 && (totalram_pages() >> 10) < (1UL << order)) > > + while (order > 2 && (total_pages >> 10) < (1UL << order)) > > order--; > > empty_zero_page = __get_free_pages(GFP_KERNEL | __GFP_ZERO, order); > > I suspect that this is good enough as an approximation for that purpose. > > Reviewed-by: David Hildenbrand Applied, thanks!