From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59A3DC36000 for ; Fri, 21 Mar 2025 16:55:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0ABC280002; Fri, 21 Mar 2025 12:55:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBBF2280001; Fri, 21 Mar 2025 12:55:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A83B9280002; Fri, 21 Mar 2025 12:55:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7BAD1280001 for ; Fri, 21 Mar 2025 12:55:33 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D749C80293 for ; Fri, 21 Mar 2025 16:55:33 +0000 (UTC) X-FDA: 83246159346.14.49D2C11 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) by imf28.hostedemail.com (Postfix) with ESMTP id D3596C0010 for ; Fri, 21 Mar 2025 16:55:31 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=IG2le371; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf28.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742576132; a=rsa-sha256; cv=none; b=DLFOalBaD4IotkW7qX/rwg2oAWLStNvoOzPM5nIMOeIDB+TX1UzNqIm7srXYpFAuZnW1al NrERMcc+X8LIttnIXK6xyJEflgR67qJCuDHAJV4ZNnOjCuI9kmavQhCwhsXRpLj7b7E8y1 66ScU5AV50TdpvKMlb4n+CLZWEv05mQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=IG2le371; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf28.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742576132; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0k4BG0pUG6A1oGGXbZDig3252bONMGhq0TL6wCJItwM=; b=DOoa3+sAEMCXfgEa3A299XQcMHbOVLukc0fVnHblhHwW4xNc0wyF9pZFUdacLuQ2cpyMdf 0lGkNTOmZamkR4oveD8YuSpJD1YwcGoe8oLD3LCaWjnGPd+QFJte18Ux4N7UcUYuGbPVES 8R0o5KrIY0BVp/yzNn3f6Lm0kiTbCPw= Date: Fri, 21 Mar 2025 09:55:21 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1742576129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0k4BG0pUG6A1oGGXbZDig3252bONMGhq0TL6wCJItwM=; b=IG2le371hUF+BSyoky5EjdInNnAZOAN3FbWyq17bhJkLgRldYBBGqn6ItUpSnUNkxlj0V2 Pr6c4FemD9GcNp/LhOgmvJSI/qZRRseq9C++gaPtSwRPmNPqlEc7X0RYDyi5A8pbb+tMvB WaataOkAKAl+EW6H6Emf4K40DzGbKQg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Vlastimil Babka Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Sebastian Andrzej Siewior , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH 1/9] memcg: remove root memcg check from refill_stock Message-ID: References: <20250315174930.1769599-1-shakeel.butt@linux.dev> <20250315174930.1769599-2-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: D3596C0010 X-Stat-Signature: xcjtxhczwq4bc4zwcu86peh1fgwxfac1 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1742576131-845567 X-HE-Meta: U2FsdGVkX1+YFlqOSBa8685t4ItRiroX4/Zb0cwuEjrWHf0cA3G1T3wwoaWAjVkPG/mBI2rEuJBhhKRB8HBmcTGfazy1BfD2sT8p2zl3kg/KNB7vYoETPmrvFAYvybnXZ7SrUPDLy66w1G1gLzTKBcGaHZuF+e0dqW4mlZNMBQl3JEyBWWmp07M2NkB4n58avMFIRKpXhR5LoalhqnL2j3tNRDg942STvk/zOapY6ZaJtOA/61sSLIGPvIQjTyY4tzBWIfKy+IdIYPGJNGnY108tajndGtHWrpQS1d2Lv4n+dG0fcgqzMV0CGd4jUYjT2CXPlQErNqZQcrzTySOwfqeRHrvAEyuNAUd6v0alb+CeeiJnrmm2fHx8k3x1fbsyEaC2CKf5L19PwTOIFS+yOMM3s3hc/3A2w/i4md6LzS/yJswujoWFD1WFiI4AGh9Hn5Wt1eTjYa/XdP29x8flZziNb+2nT32arrD+7FaDYnZK+EWbP1rD1fRv75576hd/aG9qb9pTUgJH4eoW2dxSXvEASW3ImSeHCUefmFpzMPX7RymoL6SugO4wDzIMdkFUaLIAuah96gCuXEdQ+o9mQuQvQfDRhEm7OnbE+Sy2Zf7RvcJ1y6Dor8TfpLLdEnQJDTzs1CDn2XQMGYdppyQu6YbqcAitKb6hFn8a66cABdm3XY5MenAAkw3W9xJnQk6mYoa3eH0b7GlwrDtZ94GFiXLZCMLN55R3NLcZkwxjlvJAmESpkjzFeEK55dG6DYI4r/vodR358ge+d5nUd+M39xQX5Eayxt6RevF2/lDAnCU+wlMgLrCzoxqyLo3c0R0Ht5DOEBmir48i9YoTLrgDcJLAO1pRn8Yp1AQROInPm5BkZWk5IKtEd9ZFLWlXevn/5YLJsx8jOWph5Q43sm+xcH3mjZs+nhJeqwuP+JxDJQ4YN/XsrKqANprtaWu/cpDO2X4N5w48CCquGtY0QXS ybwMT1Og 8H8vYjEJ/P34JVvU5QSna4iHXbFQ1Zm9eU+ZYyUYYsmchBMwpLENWgPizEPUttAEOaZXm5Waxq1bEYtTk/89E9meBBSCq1Y4UAF3muEUshUBLFiMIejdZWQ17fkQ4F3KzJQmwwzlnbcbMWAQTpsp/w8J6dIVe9Zsly5d22PNofSKZDplvdpWI1QUkoHjbnbi2BLaFc+QTjZJBPPIXwOfdd8Zu94wcmQDlLUt5r69xXV7rD/aw1w8tBVMRkQXgyWAnq9pD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 18, 2025 at 08:59:59AM +0100, Vlastimil Babka wrote: > On 3/15/25 18:49, Shakeel Butt wrote: > > refill_stock can not be called with root memcg, so there is no need to > > check it. > > > > Signed-off-by: Shakeel Butt > > Acked-by: Vlastimil Babka > > It's not trivial to verify this so I'd add > VM_WARN_ON_ONCE(mem_cgroup_is_root(memcg)); as Roman suggested in patch 4 reply. > Ack, will do in the next version.