From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FA29D3E2C2 for ; Mon, 28 Oct 2024 20:00:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 070396B00A4; Mon, 28 Oct 2024 16:00:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 01EF86B00A5; Mon, 28 Oct 2024 16:00:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8D0F6B00A6; Mon, 28 Oct 2024 16:00:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B08636B00A4 for ; Mon, 28 Oct 2024 16:00:49 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1B4388111C for ; Mon, 28 Oct 2024 20:00:49 +0000 (UTC) X-FDA: 82724078556.04.1A2C56B Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf30.hostedemail.com (Postfix) with ESMTP id 829B280040 for ; Mon, 28 Oct 2024 20:00:00 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=DXnqAOda; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=quF4QnTu; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf30.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730145488; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tW3z49q3pjdZme/Fhj5P7iu2FEcFFHDI7UikbqdQmqc=; b=uZ3pdD5GZ6vsfyMIo1zQlT767zx65XYt+0ODCnvn8zqL51XKb6MEK2BONyHpwDAP5bR9FJ w9RJHGpogcfG25rHSH2LlziZLZEgZkHMjROZVdr5BMqlGcQi+zq369Jvab+h4OMugVEleb jmtm6eTVKahJGYWRW3GxaXR+Oj/duQQ= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1730145488; a=rsa-sha256; cv=pass; b=a/kEiiRd838uGopVngAgPS88vlBZ3OqIUvjFuNOl8a2p6JQpajFeyd/q1fxXWTGnrBmye3 BiNwXXrb2aZR875yGCAzRhpg9HtK/8VUWSq9MCucCg18cDNO/581Ge0RGHPpAEeNwURROV WCA1p0ruiPx3HmBO1bjjUQiP4NFMsjg= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=DXnqAOda; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=quF4QnTu; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf30.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49SEteY1020913; Mon, 28 Oct 2024 20:00:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=tW3z49q3pjdZme/Fhj 5P7iu2FEcFFHDI7UikbqdQmqc=; b=DXnqAOda8lhWdwv34j+KyNWd/ue8n5gD3N LaGxUP7hXxWrQx1EJf6cZtvofuP6dJM7r1zN6I+EMyV6G+DcBF1xMIA3ZkDqGMRh wqhiI0wd+ZSR3GXD8UmaNxYYSc2DmFO3Sef96LTGmRmhR2wIt3Zhjtw+czbQvbX+ GdiuDiQxI8YPyBxmpcmbd/aGPblHZKGiCuK5gRMlMCYIhx5lK3Rfn+iWWiXsISa9 GHfl8cktD0qya0kcqCkQKHNGkHgVj+cB0DCO3waey6ICrAW2/xHbQfnaKDdCm7YK h35KaPvALXxCDjuZfhTwrc3xzEg5pDBRfbr1nFguSqokPlQIodGQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42grys3uh2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Oct 2024 20:00:35 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49SJ7Chn011834; Mon, 28 Oct 2024 20:00:34 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2176.outbound.protection.outlook.com [104.47.59.176]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 42hnabajv0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Oct 2024 20:00:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wHSk47gzq96zAfVcWCQEI2zhj3Bl/z66ooeye60vXVAAFLK+DhgGHm8GSQWJKzgxNfjRuZEDtqDK+p57vwZGT0MCgHuRxESt2ScAz7TqEoWhqchTkUx867vqjG7z5Xr0JhUrl0hzCzBreR721dBYUl3cK52mK9+UvETP4t9FjhIdARfDm7yIZous46/quJhKsTbsLwjmyQSVWnp+k7hkaxnbiqPMbX3WvbJoH4yqe/Uxkj6FoKkFLE5qMKjsHfNtbQGPQyJQvHyS3JXTd1tHm1eEQJt0MJKf/rPxiQmNOgjjNDwLGvDZdD9Ex0YXPnelE3IWa+1PuF8w8U9RmugSbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tW3z49q3pjdZme/Fhj5P7iu2FEcFFHDI7UikbqdQmqc=; b=qAAsQXDM9zyCk32ax9JWHPzFUUZcPmwHxE8DQpdGc2NABI4152ezfQxU83bcziwDG8fICjEagoEvTuiLiyjC58RIZ980rC1IUcS2O6e5Bq8O3ZvFCMahvFUhEjFy+EwE5twxE1Xl3qNtSvk2HYg8NnACI3h9Ox1pJB6o4isBRLjZX8gA9sOAHaKVSShJ40Os9sftniLilO6w5jJuu+NhXaE7uXS+Gh5ZRlJG6P2qD3PjfA7l9574JWMQQMD5Gfd6Pieqxv4jFmdDQlLd3qx8kvq5Ai9re8+CpZPoScbkizpIA83KCgSNaAcrEaMzUVX39BxqcxvSFotuCojbu0ya9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tW3z49q3pjdZme/Fhj5P7iu2FEcFFHDI7UikbqdQmqc=; b=quF4QnTuhVADEJ9OdqnMBFyibu/P45N2S4eChZNsT8EuyOVgK9L4hQGSa0/7aGyTm4xf7AJhbDUwiIbhv5GxgsogNsTukyaOWRlRBGspLnROFsAQopsf+7ZzQa1hgCIGPTXLX9erCzQKS1/HX46/hJZRCmjck+t3gGKM3GhMQzE= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by CH3PR10MB6738.namprd10.prod.outlook.com (2603:10b6:610:149::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.27; Mon, 28 Oct 2024 20:00:31 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%7]) with mapi id 15.20.8093.024; Mon, 28 Oct 2024 20:00:31 +0000 Date: Mon, 28 Oct 2024 16:00:29 -0400 From: "Liam R. Howlett" To: Lorenzo Stoakes , Linus Torvalds , Mark Brown , Andrew Morton , Vlastimil Babka , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Peter Xu , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Aishwarya TCV Subject: Re: [PATCH hotfix 6.12 v2 4/8] mm: resolve faulty mmap_region() error path behaviour Message-ID: Mail-Followup-To: "Liam R. Howlett" , Lorenzo Stoakes , Linus Torvalds , Mark Brown , Andrew Morton , Vlastimil Babka , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Peter Xu , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Aishwarya TCV References: <6e8deda970b982e1e8ffd876e3cef342c292fbb5.1729715266.git.lorenzo.stoakes@oracle.com> <61461dcc-e455-450d-9c01-5465003fc31c@sirena.org.uk> <438f50c5-8b8c-444f-ae85-10e5151f3f24@lucifer.local> <57mgmdx7wgfwci3yo3ggkmcnm3ujamgkwcccm77ypvmer5tegn@opiq3ceh2uvy> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57mgmdx7wgfwci3yo3ggkmcnm3ujamgkwcccm77ypvmer5tegn@opiq3ceh2uvy> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4PR01CA0277.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:109::10) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|CH3PR10MB6738:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f98cd2a-f02d-40d9-c51a-08dcf78b2d46 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?wDYm0YKiIKQLuDMdeW/EDySJy1RyYLc/KjRnmZnLgXSfV3RgKzxmG/cKcil+?= =?us-ascii?Q?kKWGEHWlwasRLH1RRWKzpMIYFZD/Mne8A70WDBkrwBhfDnr1QTSzIb4CbOWS?= =?us-ascii?Q?rh95qNJFP99XLUrEB80Rq9VuWC0TcqeMdHrpcJ1wX1gwp5IYebqE5iUXkYDu?= =?us-ascii?Q?U8Li7wpVHVmasw6RRLZ7GqA1V16NcU4jHDphCSA2S6hEJjQNyIzMYFWh6Cfb?= =?us-ascii?Q?Ir7PLusKnwM+7sGAsKChRQkxUWJrkDGPRP507K/wrNcj0+Epo/Sl71B86CPl?= =?us-ascii?Q?ziE4E/dXTW8sKXcbBIOOO2Aj7Hr/qDfG40hQBMjW+Tm8yEfrH4PKVTxbW+Ee?= =?us-ascii?Q?MciewztRoFDRINmtP0eHFxwa+GTkrFd4K1ZsaPqibY34MKoxEXjQP/P77En4?= =?us-ascii?Q?hC0Q0L3DJjCxVvkHCmFhKZgI/ah4l1Ds2al+MMhNmVScJreW4ZpfGHYeCj3f?= =?us-ascii?Q?grkOxflwHl+dwOHCpZDr3jb8gZspa9wuAG4KMiXadMGcShmlZvX6SpURkXYh?= =?us-ascii?Q?2sP+rFmRzFSyi6FzNC+hkkT9a6IpsuWM48Qn9BblW0kO5z0OEwbXedgXuzm0?= =?us-ascii?Q?iJOZMStFnsas84D87lHWGCfOc22ImIlEpPOnE1nXbcCue6VjWyRas6tw/u0D?= =?us-ascii?Q?Uuv7/EGlE3lmcFl07gtblkJwiQZwlNKDpnn5rTFrNLqIReth0qjQwhZHQ4M5?= =?us-ascii?Q?JjldW0Iy2pHh6qZ5RABJswNvB+r7bmX5A5EYi1h8PRgsoy39lMMcf7EtVHf4?= =?us-ascii?Q?V+w4ZsqqEE86BPTma7LQAvE6rBd/JM/Xp7f10/3LHcy4pntHQK7VchRqSCYB?= =?us-ascii?Q?XtOn7ZWTBwVnM+O3qExUr28QTgq80jPc56M1xfeOR8Q37bT2Bjl8uSDoqy4Q?= =?us-ascii?Q?i4fuwaab5ZZXQPVX06tG2Rm3BVvMbcjqJoimSjmR1aRLvvHKkTfWyA5Pbd8i?= =?us-ascii?Q?ikGs/OY3m803zFsmJ9jKAjx8O0ibiKfSrLPuSEKS6EFUxLolFmJEmXeRwQMR?= =?us-ascii?Q?XVKuPS1QmWqvcPTUqDGXdiiq6Ao8EkA4x+9RlBZstKV+dBvXOAi29sTfqVQy?= =?us-ascii?Q?T/dTJSTN41qcEMtlsaAvq8ybfBlcUlkI15DEr3pAHf+30nefBJzRuxd8ksUO?= =?us-ascii?Q?2QCMXAm1xAIBnjQL35xlfJwec3Dor6h99DkAD0sFz9BHuArTBF5Jt+1DkJzg?= =?us-ascii?Q?i/3arjloQACwPc1VxiyKOSrr5hcyT8J+EyL3VFLdGKy0Y47aVXk9wlOMTNAe?= =?us-ascii?Q?nEpCVHAA9LOrn/xAwc5JY4e/BPTGSqNB5Eee3K8/0JkUByLLarAgzH0X5Y4Y?= =?us-ascii?Q?QBvDtmvq7yFUBoayea+3Cavp4IwjsvZnRTueBiZHnvDJk9/tQtt2DZOJusBP?= =?us-ascii?Q?/lVpFvQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OUZy4C1xwCLOLklEJV4wB75CxEGlrKPeVux53bx9fLdPadsAM5HaLB7mElBd?= =?us-ascii?Q?gVzWft9Fvnl8LbOwsxTBLG+Uv6B2KFMf4x/ryNonNvwRzLAAaHe61DNM639X?= =?us-ascii?Q?ln6ZT/kpxcDoal6ew3eWF95hQbDO7lB2iT36H2cA30KM7an9CY4USYmGdo61?= =?us-ascii?Q?ol+ySnKPo96vWHEYw697GRbYkY7qmTEEuddMXqmW0WU37ezoec/h0qJk3CIm?= =?us-ascii?Q?sSIdfnwc0k3shZwcaF7NAb7dK6MV//arEgHYtgZSOAPWAdbFQudzGi+MdLfV?= =?us-ascii?Q?kzykhMJ9FNFvD4KYRslp3I4Gz+xT0nb39z5FDZeP6KeYcsgVekQBpELVuBRh?= =?us-ascii?Q?GrLT9tRuBZgCZHtFCP4ktNcp6J65oHJ8FCGFVu9iOy9q7LmOtoV65yqkQlPA?= =?us-ascii?Q?yVxVv/sqDRjkpeaJhnILooHR1p0BItx76ulZiCz6LzlJJvWAGmp735BflpLa?= =?us-ascii?Q?OsF0X7uEpkCRj0AcRSAzxMxVnR8wpA8VQRtHE+mC6Ob3Ouw+77qGBcF5ZGxw?= =?us-ascii?Q?njelvwLv7yO+pEkeBV5lCtGloSiWVwY0ElNPEJo+N8gxtaPMJZyfRT5pAG59?= =?us-ascii?Q?xip6z99aipsJwZwgsXWQpoHoNzdM99xnrZiNmUVMcalRPHzA3dmihbgADjQ5?= =?us-ascii?Q?qAiy43clfDnm5FkE9Xy9o0N6BnkX/Xgr+ajM9foPnC7pNkSWOnx44oFwzoic?= =?us-ascii?Q?ME8j3zolFfhDtNt+mHQorwqX6AasMtW+/WSXKPvD2zYDOYrIiVh96Ddv9WAl?= =?us-ascii?Q?D6z66Dv1CenJJvgJDQjaRPGLrNgrUqe7MEGwbQNEmATm9ZPCRgQ6gY2CkwWY?= =?us-ascii?Q?As5aoGkuNUeno94Sd6BTsTRxagTH8XGSrQr+fO9bSQdpoO75YbSXUK9iTIop?= =?us-ascii?Q?hmoAnNAlf69tRiVetrtQsuePymK64VqNeza7KZpT15mMs7Axcdzd7s/hjVLj?= =?us-ascii?Q?FuNFKtDpsT9JAgEI5Bv3yqy0TCFozwnpDS3xu5wTGq+pc5u2oX+W2BRW6RCO?= =?us-ascii?Q?MC3JGJ5uEQ8u97vtyleWIcIy5+s7NtK2v+Xw85L8kqM62K9Ini19P7Vh2eSg?= =?us-ascii?Q?faP7R6hLQemAIuQeJC1X+42mRzkgO3Dfp8m7C2zWa3WjetF9Pa3hcvkbDC6y?= =?us-ascii?Q?8MyvEiNMQVU3K39fCGbMhUh3Tx17CVCj1TSYbiQI7eIF7R8s+6Jd96+p81UW?= =?us-ascii?Q?etZKhIASsAhzBrK8inEMERVUyWXRMA1Z7G3alaCZ9kQRoeuGCkLJrhixck7H?= =?us-ascii?Q?KzX9E+Y+YsqcDKTyLFTIx8i5ltRX7V/4WVIHhuadRDv4ddEN4f6zyUWebMU+?= =?us-ascii?Q?uxX60TfnrqKR5jmxqMWoeGZ252WAkVpqYMhS/IdWvMZQqj5ClX8mbNUShozW?= =?us-ascii?Q?StA2qdknHOdIoIdpY+NYfkEUmu3hlv2t8Ei1YEwJZZIpqqlYFpkP6NYBzVdn?= =?us-ascii?Q?/FQE+2pgulIMY7dctaJX/dSmhPCIHaqA8tvxrt2uRVXojdlZCPCsIAIWDFO8?= =?us-ascii?Q?ilnO/9J9s8Xp4aM+QoRSxrVC7FUNkBJ5TSPw0LqF3mSKldSVD0G7qVp1XwSf?= =?us-ascii?Q?WT3SfJFoxZ0BX/NIP9Gw6Vm2KXiknvcpk8hdBEct3hF+pBT8t/R9/YQs06WJ?= =?us-ascii?Q?aw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: OKaNDiQDmzw9e/tdtJom/xK102o7mxzKAphqdedJWE0NTno8vfqIJ6m85aeUcKIMAS5rspI22f8Ydm3dgtIBAz6nSPayeo6+9bCHaPAVYj9YvUyEfgo67I493CY8Xej+vzQ60NKJH3Day9027MDAaau1Z+Jw+Bi7159e9JFJZVS0Uk4cuMrHoesWvKqQsArJkHY/60VzsOsvzCy6mAUHv/6arj/4k2vK3qd89Bypqk34Ij6/VwFRpgITldqHchkT9qr14j5ikMKTXRgbzIaPvlBSQnx4BM6TlX/7lASBFUhsJ5Csx2KLVYm8crmHoVuH1pg0oqSHhtApj3Mdvmnce9Dmz1m25oTvI/vICUCWTA2COJnFgAEHI1InObLA0e4tfJsoKQ9b8WRxh3hRhn9dHCbQm2Qvw1/mushtgcNgYmeQIiXRhudUc+RPshuDeZHzVZ58ZAkzgO5dMpS36Q5Uu8ybfc9JQg7WhDb9cDX2qaD6/ZbBvgzZ9Glo13PlO2bA78tjYp62l0SRdfEO0AaRcVOovye7T+12uxdkOXqZE0Ob3LQssjsfDcSk/nPfRPua5hJhVzDJCK5aG9zkbFFFOWgmGjgrJJNwb1gnWHRfnfg= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f98cd2a-f02d-40d9-c51a-08dcf78b2d46 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2024 20:00:31.3554 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9F16jiNuxIGDD94n3p6rN4o84sVlr0BX/al01svuPk1o7f/bJ+EMqgR0btoARrajNMXWBbYnX56blv/br+M//A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6738 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-28_09,2024-10-28_02,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 spamscore=0 bulkscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410280155 X-Proofpoint-ORIG-GUID: eAu1oHQ4R3gHvadNA84pYtoRQkXvhrsn X-Proofpoint-GUID: eAu1oHQ4R3gHvadNA84pYtoRQkXvhrsn X-Rspamd-Queue-Id: 829B280040 X-Stat-Signature: r3cjq1annq1xqistog1wxn7xswpf4x1x X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1730145600-336627 X-HE-Meta: U2FsdGVkX1+5u5Tfn6iufYAuTNhEekYOJwhOv05tMWA/QIEUbH3QLmDIJnH9BedrPT0bH5hYDM6qpF2PiKm5vKs6B7RxJYdGSOq5pj1OxmU73Pgx3Luaih3messwRXljeyLl5MuL/wfQH9mOvQMSBsBnfrC8QSRHZCk6KVhNjkXm69nkCfBR4Fwysm4iOq9QlmFMUYw0yEIggUW2TR61q6BNY6D3nTHQN0dFPEDI2R/fJszk/XzqeKv94fE8p1Uh7GatKEMoYgBwK8jufeF7CWf0qsFoSg0e7/ooFoK7cYJD7MLAU12J1cOLcxCAM28fp1hbDhjGAl41ZOLRrrminNjN7A2vLOCtx29mAsVjoeOAKKAfYl8yi6GwvBcml+rj3KjtMukWzL5FUa6tNwHL2hZQymTLiR8O2UgqV76E4t6UTsYxvgNLtIfg/bkr68fMc1Y5YwrFALdIzC3Yw70vDm6pQpqa7QAmiqy+4zAO1w0f/swIMb/6DQhCUCvzhJpb1/ObmZ2W2D0H/CQx0cG9hxC4ZJ4nlkxtIHnvs1g3qO6MzPmrwKSvAbvGRmprtux2nzDZKMPqUJcfZKrRGT59CrksXiUm7adYG/30EYotgBA3Ry2SB9twa972e1v8Tp7zrqy6J0H/PjRj6pYW719F3y93HqK3xbAc/sjbmnaf7jOBBdLtsmfmVSWYeg2VHJ8awMSQWD/rmgVUE2L3TRCRdsT/RgvHTeQoNG2zoHv2H8ZfIqBpea3G6g5IoZCFqmMhs2inBUSX6EDW4m29rrYgHI5KQxgZHKqKD920eaHcfV6ESpb7ZE648tfjQxAnVwKw08symNqE2b/XIdp1ftb/s3clLJjM/NF6kmYJunhRjR55QiqxfK6N2EgE4UzDEKqtj7cKOd7SVVeT8M+UbmwVmfZLis8WVG21JjQhAynRl3oJ2/QgJlNuZDZxyEtmVdH1KJo7Zjtvoadky7NjizL 5Q9+L142 ZpBBgWFnC5spTNuVlkAVsRsgDZ54+IrEXVjPoHHPK3PS70pRJwFLf2qWywVZ7sxtJctCdVKHuevtTGqSw26eAWphKRo5E6xMIPnjKO4rQk2lByZC3rv1Oooabi7Pw0D5K+wqm7iBePdqxNvE4wceYfebQ7hT1o1oIjVxdedlhueJxhNxty5gbcuwb9LNTa2+QppbBP/cRxQzHljGvwUCntfdAtB1KzWY2XP440wZdMyW40Kveus3Sg6cG2hxcdb79FkxYwm9JxByP5nueCIY3iPl714+MXtcrsc52IJKLj11Rq6GGKOr4MMVOeYTSK6kO56pN4B4hgWymF6iriy++BnriHj/NVxSbq5o4EDau75K4zqjlgZxSVqhO8QIK/YtNgCxr3pQvKDqEt6GxgUt82D+Rx8FP1JZaYFnwWQ5Vad63NVQLVb8mI6SbZA2gROm9gREh89RjuLrYXSvbb2rMhvcKqucUU3Rw17nWXpEPr4COrFUq24bmOa8Yka8Gjhi8Xhe7UtHl9Z6yVlIz9YuQDQRg4M4zuZXk634rLiGubVUkmuS7HGRrNU8IzY862hcdZZhG2Nvn9PJGBsOgA1v1bzxOO0hz0XCmZyitqgyOMSVs41s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Liam R. Howlett [241028 15:50]: > * Lorenzo Stoakes [241028 15:14]: > > On Mon, Oct 28, 2024 at 09:05:44AM -1000, Linus Torvalds wrote: > > > On Mon, 28 Oct 2024 at 08:57, Lorenzo Stoakes > > > wrote: > > > > > > > > So likely hook on your mapping changes flags to set VM_MTE | VM_MTE_ALLOWED and > > > > expects this to be checked after (ugh). > > > > > > Gaah. Yes. mm/shmem.c: shmem_mmap() does > > > > > > /* arm64 - allow memory tagging on RAM-based files */ > > > vm_flags_set(vma, VM_MTE_ALLOWED); > > > > > > and while I found the equivalent hack for the VM_SPARC_ADI case, I > > > hadn't noticed that MTE thing. > > > > > > How very annoying. > > > > > > So the arch_validate_flags() case does need to be done after the ->mmap() call. > > > > > > How about just finalizing everything, and then doing a regular > > > munmap() afterwards and returning an error (all still holding the mmap > > > semaphore, of course). > > > > > > That still avoids the whole "partially completed mmap" case. > > > > > > Linus > > > > Yeah I was thinking the same... just bite the bullet, go through the whole damn > > process and revert if arch_validate_flags() chokes. It also removes the ugly > > #ifdef CONFIG_SPARC64 hack... > > > > This will litearlly only be applicable for these two cases and (hopefully) most > > of the time you'd not fail it. > > > > I mean by then it'll be added into the rmap and such but nothing will be > > populated yet and we shouldn't be able to fault as vma_start_write() should have > > incremented the vma lock seqnum. > > > > Any issues from the RCU visibility stuff Liam? > > It is probably fine? We would see a mapping appear then disappear. > We'd have a (benign) race with rmap for truncating the PTEs (but it's > safe). Page faults would be stopped though. > > Unfortunately, we'd have to write to the vma tree so that we could... > write to the vma tree. We'd have to somehow ensure munmap() is done > with a gfp flag to ensure no failures as well... > > Maybe we should just call close on the vma again (and do whatever > call_mmap() needs to undo)? I take it back, that won't work. > > > > > Any security problems Jann...? > > > > It'd suck to have to bring back a partial complete case. Though I do note we > > handle errors from mmap_file() ok so we could still potentially handle that > > there, but would sort of semi-undo some of the point of the series.