From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27AA9C27C4F for ; Wed, 26 Jun 2024 18:05:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D4316B0085; Wed, 26 Jun 2024 14:05:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05B2A6B0088; Wed, 26 Jun 2024 14:05:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA1BE6B0092; Wed, 26 Jun 2024 14:05:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B8D376B0085 for ; Wed, 26 Jun 2024 14:05:13 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 52C87C1540 for ; Wed, 26 Jun 2024 18:05:13 +0000 (UTC) X-FDA: 82273816506.28.00A7CDB Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf20.hostedemail.com (Postfix) with ESMTP id DD0DA1C0016 for ; Wed, 26 Jun 2024 18:05:09 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=bqHbJZv5; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=YLRBajLJ; spf=pass (imf20.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719425102; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2vDpv6WYj26CbywHCEgq9yCHVLy0T/ZyIt/0e5gfn9o=; b=2tfZpYaUILlhpEkSkGIetub67XCU8cF82Bx49LnSDkuaTLYKulimMZqdQXjqbEkyftCxZ1 KPLsgdUsdVGm2uCPekFzBRiLoLPRVKrNLwKKCGxPAiWLv+TMZeKS7xj+vYpccqeV1N2pqk QmvwZXoCUcWXryHO8Nngh7KCUywh/zs= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=bqHbJZv5; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=YLRBajLJ; spf=pass (imf20.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1719425102; a=rsa-sha256; cv=pass; b=35WOB6nsb1wL0b2iflq3A4mUq5hFSwgyNsXRODp1zJelMxiBLMrfhXZszEVYxQH1FUFtqf nj3WUSgdrF/E0s32HTtUvJ4xsik8bK9x17BnRuUOF21OWmGnTBK74P65O0Lc4/IIFKYYjV Sct33nZzwP20OwYwNROFai+acmdgCJU= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45QEtWoQ019688; Wed, 26 Jun 2024 18:05:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=corp-2023-11-20; bh=2vDpv6WYj26Cbyw HCEgq9yCHVLy0T/ZyIt/0e5gfn9o=; b=bqHbJZv58Md0X8WdENBVgHpxqaIIgBS aQB/1+wnh6nfl52jL4ZoZFtx9uiS1W4iUMfIqf8F5cR/pKsDnPyxbhYafSwDBJyR FQz0veMx7wF1IMXDy0EwbyQmZo3ldQ+5kC1ouLXAoEn99cS5RXdrFlxQ9M5R9xEU KD7IT+5JGqPdZPTjCuOAp01Nlt1Z8R/rRJges7CIETS+O4ALwENrnomd+bsv5uGr CajwV034VBx2gGeWQDlPY79JwkmJ54vHGb/Qp58pRgaYRBcOoKPXhc7rH+91TRqW 9HYzAfC0daFuoWWeFdE9cF+SgCdpMLckHjCUsKpAUKsIgLoWycpkJ+w== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ywp7sm039-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Jun 2024 18:05:00 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 45QGxJEp017872; Wed, 26 Jun 2024 18:04:59 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2040.outbound.protection.outlook.com [104.47.73.40]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ywn29ajbc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Jun 2024 18:04:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ARrkk7ZZ3wm8AQo9ofi2acObfNmsesVnAGdXpKM7fYqMEyvGfb7gceUwopz3AAEKMayRvDhxOMbIK3PCDMAjqD3jpML3rx3V6tMkreaHzZnSIEsCybPYCZcvAZ/JDSZbLHg0dirZ9Lc+wO9R8BVmkZ8rqmYnIezkC5lrXQhC50iFKhbmEM7Q4aKtQh1/yZ62JdAfWjUbhTDtD0GIN8tEpPru+E3hwlkk0h4e6w+RKALlAKnOAhWKEdx52z0+BtGxiZUCGfWhLoCIkif2TDj0SlJtgd4r4bE8R/8uAR2EyUj89cOLkETQkO/g94H4ZccZMyoomaK5VzDkF9Wrt5Ma0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2vDpv6WYj26CbywHCEgq9yCHVLy0T/ZyIt/0e5gfn9o=; b=jJ/LA1IO85WJDRP8FjWPTGt/WNEIMmLBFtGN/yGfBr8BXFv0MMtXOB5B6Z34oqPYuhgVYspgWAmWK0Vk6Q/hegVhgCZy+AD2UGHBQaAJvQYZtGR/ylaj24X/iEjVWN61VUsJh+LGYAZmmH3xd5trzqtFwTrH7Z/zqp29gux8HtifBnV9FBGjvB/S4xSgJCYjZwKdqxBLZ3Wqw6BTVYWikDeSxL5YM7qzq5L5E7Spv01RbxnaZgevvHOZ8E3oG+/NKUjxJK845p4DYF5MCNXcwL1liK9iz9s+fMM1Ab8D10+MdxM3j2d2Z5TkuDw9fbQIGWgq3m1R3MtBmV71IrT6hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2vDpv6WYj26CbywHCEgq9yCHVLy0T/ZyIt/0e5gfn9o=; b=YLRBajLJAAaalvF5cuEu1vFBaxycFpJvYuwSrRmjhxAySE47hcjHqr1Qb1l14PP/4XH5qXCeOtixkAkQ+KCRS8dnoFYnV/gMI47bdlz8z23Fvtlc/Ohsf0JEIkt/CgeIJYt8sq01WP+3d259OVW1TSCv7rBYgaeXLzcY/R8JqJY= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by SJ0PR10MB4461.namprd10.prod.outlook.com (2603:10b6:a03:2d8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.32; Wed, 26 Jun 2024 18:04:56 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%4]) with mapi id 15.20.7698.032; Wed, 26 Jun 2024 18:04:56 +0000 Date: Wed, 26 Jun 2024 14:04:53 -0400 From: "Liam R. Howlett" To: Kees Cook Cc: linux-mm@kvack.org, Andrew Morton , Suren Baghdasaryan , Vlastimil Babka , Lorenzo Stoakes , Matthew Wilcox , sidhartha.kumar@oracle.com, "Paul E . McKenney" , Bert Karwatzki , Jiri Olsa , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH v2 14/15] mm/mmap: Use vms accounted pages in mmap_region() Message-ID: Mail-Followup-To: "Liam R. Howlett" , Kees Cook , linux-mm@kvack.org, Andrew Morton , Suren Baghdasaryan , Vlastimil Babka , Lorenzo Stoakes , Matthew Wilcox , sidhartha.kumar@oracle.com, "Paul E . McKenney" , Bert Karwatzki , Jiri Olsa , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org References: <20240625191145.3382793-1-Liam.Howlett@oracle.com> <20240625191145.3382793-15-Liam.Howlett@oracle.com> <202406260928.0A22BB0F0@keescook> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202406260928.0A22BB0F0@keescook> User-Agent: NeoMutt/20231103 X-ClientProxiedBy: YT4PR01CA0294.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:10e::18) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|SJ0PR10MB4461:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ddfacdf-cf51-4232-346a-08dc960a7c61 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230038|366014|1800799022|7416012|376012; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?xgdQO0iPhY4SrPWh4F6DI6GVd+b5FRICU/aUhnF9iYz2DIZMja5WI9hsQ+UY?= =?us-ascii?Q?JKAHXMKg8HsTMZI0YQkag1YEbPA5+B2XEueqRUWrXO25/JWMipnWAvhP8PjK?= =?us-ascii?Q?GKWCMXfw/bGxnPcO1rrjF1cHUmoaKbZ9xBaUFvZTLuvaCQs0LUueZzVF+RNt?= =?us-ascii?Q?Q9TfHsmk5qpvd16ltxQO3665uIeuSgpjxmMqcoZ5fp+Jnt3JgueMHTaShKbj?= =?us-ascii?Q?8XiNhcS7X5XbJK+uaYjJimZWarc1vejNueew3lNaELbV3NMi0UJ6nfRgd37w?= =?us-ascii?Q?tDJcXqG63hRxQ7D+IOqsOZOhBuahqmVUC2Jzd1l3qcvoc7+2mQBB5OEr1CnC?= =?us-ascii?Q?02wvKTgd0i0dIJD0GgV3tBnTINc7EdwR9vOimq+6gCDe7UWUYklvM0Bzu6/L?= =?us-ascii?Q?DK62ukW6aUOdDTkfZC83uKm0wBoM3XhGLIoOhgNCq77209eLl0GGSgVJ2GKb?= =?us-ascii?Q?rp9kHQpJq2tZJBsAfQZ42qsf189PAQKqPEjASPBWztCVbhjr5GAXY6EsBgj5?= =?us-ascii?Q?KXF43V3ElPnjyHJIYkaTj01onJp3uOOHqkEW+Enh6s6numVo8f+PgOo63UGJ?= =?us-ascii?Q?ub/86RBO6VlF+vcWyT0BoICw88BP6jAf4H39dG7y+lgNyTJtmdJHg6WNVuUY?= =?us-ascii?Q?3/QsZbc8JZ7rOOGzsj8X8DvpkDxDUYiM92AhNLH6kIx0CH3TbonluMv2caMw?= =?us-ascii?Q?9kxm3u1Gken0lVvdoCwn8zT9HPz4OPGNamfmtOtGYVD309LsDOWpEaSDFOxZ?= =?us-ascii?Q?PCvtawLYlExgQiPqvwJPkES8JDRWKoju+6tlG+fQjAjUcvHAWQvWGCteXvJ2?= =?us-ascii?Q?7YSKRlOFxsJpr3rBpx7P+35FVzOTehPHJ21MdhOzJDcmFzoRtHhKi+e5D9ZD?= =?us-ascii?Q?LgjBOSKbl5gFt3BXoGXbUuhPjxkqkVrhQ7TAXLCfnVBPDIZvDzpH2HJ0ae5G?= =?us-ascii?Q?dWVZ3Fd2YTclqOj+9dgV3oP3Y1A3xsnCWTwZ2f+WEqpAht+/ZiO/6eWTug6t?= =?us-ascii?Q?lbkOyw53o1R7f0roYKSvdsXViQMEwZGljj74PGNxQ8moLgMb52nFJeZC6Kyh?= =?us-ascii?Q?KBfK4tiGy37bYMuE1RicJRWa/BiR6dlTHmupoUaeMBuBoJC14hiA2nzavAOz?= =?us-ascii?Q?9D1IEwWFgKEyCJUq2D3hFr9sbcEcZl19zX3hI0F8EzcOn2U7SySjKWA6bTlg?= =?us-ascii?Q?zVK6xvTWxWNuNa1fWbUDHeSKlONCPzKK/RTB0wJdekD6uvddgh+dqTNEtvBx?= =?us-ascii?Q?GKULc3NkUDsP4tCYwGwC9nQHXgnTX0LXv5MpZxJx95Gjj0VJjnOVCGCsvXhn?= =?us-ascii?Q?ieKEVf0jUSLEeReiBOD7xlrN?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230038)(366014)(1800799022)(7416012)(376012);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WqclZekgRLO22lCt0i6TKZqWZjm+aH8A8Yb/fseFtl+HAgn5ik/zmkn0u0tz?= =?us-ascii?Q?9t3mXccTjAw3wi6EIJZd2yE9fmeGI6bFFcV24NaKR7fiiZsDRE+tWDm9xkNq?= =?us-ascii?Q?PKJXUVBOXRKIdTFnzx0xC4EXL9RyBgQGVhVyH1zYKiQIKsiCSGmxmy40bxjP?= =?us-ascii?Q?U52i52YCI2yx6bcUh/icaK4AtN5WxnyoR75H4J7HspvaUSkAXrDGzWfUzuLV?= =?us-ascii?Q?RcqbCIf2yGcYR/4yzuXi3YieouEnJJZN0zx+E0r9tbzYuYsmhc/0CBLQReIO?= =?us-ascii?Q?XXk/USojglUvLSDat0RxddZ2yCiWpPZVxvW6y8fxvEnZpKYFVrPS0OlU0AI0?= =?us-ascii?Q?LUjYVndOKhRejs7Zrd/1yg95vI3COE0kiES8CQrygv1s2oWDssUPx0EvI5AG?= =?us-ascii?Q?SY1GnMJbKhmF5a848dppLtAIsooPGGOJ8C0JCupO3EVDB3ZuBiVIPgTE53ah?= =?us-ascii?Q?axNOT3Mg8lTffD/bXl2p2hO3ot/c55DXUcua38dxF7al0+TpBXCs/0WiA+Qj?= =?us-ascii?Q?J7CLF4inegy4sG/Wz97UDWthfzv5hD5y3x5SF5G9H75y+IizPvHwQCYfbKcY?= =?us-ascii?Q?DsuZD19xee5t1btlJ/h3eTbWDA2rNevLvOdtolaXRKoLraWo82g5ytnP0aMv?= =?us-ascii?Q?YeygFXL3LJzq/fsCpZd0N5VyDQNthbRCMLYDl4yrtdL0gOrjVTunf8mOjekw?= =?us-ascii?Q?ka/Yz6e61BvZYPtglehPTKMnhF/+AS0+rFARmD4BMnzV6Eff3tlVM4xOO3gi?= =?us-ascii?Q?MXfBJ3b71Acos6wEga8rHRseSA8wSP/5UuhwFMKlsyZQDTsp9DPiCOjhXY6L?= =?us-ascii?Q?jSbFvkMcltyd1utXX27O0Jai5yp4ic3nCQsZsLDTMg3S31NbG3JL3y9q2BOl?= =?us-ascii?Q?0MNGbt0bxohn4XGLtkBUiWZA4TYFhOM7KQOAqr3ihpdgMGHvYnbuVMEOFzsg?= =?us-ascii?Q?n0NOICR77xGb1hnAz74joVjRtz1tl+FDDzgDPh12wrJimLLBBq71DBn1qeuz?= =?us-ascii?Q?2Z8ujeCAHbTB3u1AsGY7J7PHQHKZo0A1DX8B0QcqcHtklFPb8JdA8+dECXtD?= =?us-ascii?Q?7VSkLzFzVkj6qMLGHZ2lTJuxTOUd56NfF63CcMRx6mSr9VbgJ07YEyTytKDd?= =?us-ascii?Q?llzfZyK325G8JG6P3FBC2sgicXHN+PUlVTmuCDS6GH6IUHHGtCa4pgaKv1+1?= =?us-ascii?Q?Z3cl7aU9hy5j+SfdpY2ESdIAnNFsNhFnI/BV/fhlAOjI80Ijt1qGWdwhL/pc?= =?us-ascii?Q?7xif+GTi82oa9iv3S4o3ONlHoNtoX07fm80TMPZWVtqhIKQH51XWKCT+GhF1?= =?us-ascii?Q?DPTA6OCxbib9GUYNuYpEGulXeqgbcK1nZzhS7NaHfzEubfcaNq69tzt8d7fl?= =?us-ascii?Q?8EMy7txJSEdjuSBwF8nFWYdDEAadTgmfzVOh7YEP7au9pcGvdypSCgTD/iYr?= =?us-ascii?Q?ciGUSoPTd5hbxGG4gm3gcGP+CXaRYXFtztHkzkG7eM1+F0aYNuuimb2Gqokr?= =?us-ascii?Q?azyrR5/NG0tjsRLvtDCNj9n8KWW7I4zTnPycCjqnmmoryMHCHAiXvc0wK90i?= =?us-ascii?Q?DFa23RMkN57jCPpHDgmNhLbHkZpCKgD0rEOWv9aFAeTbC7TC4cYYP+EIy3D0?= =?us-ascii?Q?XA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: jNiJKZm3wt7tmBx6nS7axRy4EuOCwF6Xn5vj+olwKtrl+1ddqM6BL5jMm2RtETSZZaymZu2fRw/Vd8VC7yv9Gnd30trOxCEwpxc1uiomlKTt8ILvSSmTa8rPfK3ceBTt9uV1UTZrL3+fjR3NGokqcEXSMuI8ASrsfMruXuSdIrQbtzJy9OOQ14BlqY3Mo7OOFzqxceZmf0RzgPUfVZlFR89AG2wKdnTDYbGOg21HYS1tAB6Q7ngNSkjWJUtqOY28DYxJUVxumy3xodgFfvUiTFL+piMuSO08d8s+QkJs5ytfGoIlwuU/0UtcVpAQ13JyPI5nxrWkGGpWSMxcJ+JwOcOSadCNVeOJu4CRiODf79BAOGQan8WP2ICFEJ3haURQ/DBqHQOh/4O9qCO8qyvbth7qvO2a++hTEe1NJ/vzrJv08rd5FubjuIuamuSNGvHSDbyxQyY3MLdDwhhM4qivdyvtUOh+tI2oYCgZeei6ePOFEVGWpmb4L7ULbZd/cGFgBqwPMTc0KN2cycOhyxoVfXXXvqGPupRgIdxhz7MRC2WtHOEmWD5xxoyPZrV2E0/1AIzt7Glaa8JOX4BlQdDf/fB1uOvSKxuFuLu4Oeg0bKc= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ddfacdf-cf51-4232-346a-08dc960a7c61 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2024 18:04:56.1813 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZVTzEHUb2iVJkCrik+07pC6cieQsM52NatRyF6hvpvWDrmZbKN6TRovUz8Mydppfv08DuLMlzVExkCwFqQXpAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4461 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-26_10,2024-06-25_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 adultscore=0 phishscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2406180000 definitions=main-2406260132 X-Proofpoint-GUID: RUpS5G4AsbIUCFYqXeDqk5k66FqqqAo3 X-Proofpoint-ORIG-GUID: RUpS5G4AsbIUCFYqXeDqk5k66FqqqAo3 X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: DD0DA1C0016 X-Stat-Signature: ah11ehu9gzt8x8539kohgeosd7tgj9wr X-HE-Tag: 1719425109-99353 X-HE-Meta: U2FsdGVkX1/3DH4NkIgqJ7/p9tvhs1dIdSp85NA2yQ5u8E4zvU4JKjwXJUOGJeon/1/rQKVxKqAgWvNogE6VUVP0c4NYqfnMuegyhtquRR3xPVVsPyAu7CI+m/LaMasBZ1ceCU+9v0gc/zqdKPjJLrLHY1ubj1Jbn2cYYX7BNCaKwLMnAdxJW3jOfAK6A0eJQysQfAmzji+2APqPSXv/nwSQzK8vcIa+h9+8nY5W32wJNZcybIilCatCFKZuO8lHPojGRrUlLTCyBdkOhxZoBONz8/OgTg7StPYfsrM1MFrSqgaVheB/18Br38S1i9FGTq1kfIfkx6bg2X+Ru+/0h6n8kpN/My2H9vPGBtQPO69NmWuv12IqypqLLaQTUP2RH/l1WsM3I0FmeWKNSpR1SwW6uwe5yKFa2OiDQmO6Xs9/Nt1F0kGYBxPOpVTiQk86XEubV87FBN+lyqGlqdGEWfCc/JANs4SDtQsm8cI45TVYVZiaJUvwQH1T0/LLNoBPPjOgQefThl0yZNFdaJcI/o2Rnt6CU8bDRk0ep2i63DqWnjXXJXLortuRnF7wVXs0VxO6EGwj9+pgGSPOM/q0RVrXgLemKaL4MFfw8HfAHMpmuBj4BD8zt6pgapzupWzOIQ7Be5z3+n0vYjX8eWU2AU9EIXtzG25i5TXr29II1WoPIUn/gW+ZI/pOQhxMh1S3/0nJtcY8dUIP/qBeemIHytI8xUuXDJRERW3dPqQbmbntLtHzMJqBEoaBTgTEj8TeJSuEOH3PJ9K6rsUwAR7FNrqDTMdukXEsMW08WQRX3v5f/+S3RyD59MRgurF5jWFm9+HEN+EFqiSbdhI1y0GFwIYnu/BeCleWXh6hNtVHcz0d2wg1VwzW2XZEBWhWFJ9BcVmljNphtiCcvF1SmESjvYaHbXTKJMVGsw1rCl/KqkWn74C4x7XFcojSDXCofKLDMQvS1C3n7Uta31erCay 2mcuMsbw JqqVsSVHZOuAgX8CObNr1NOO1GmdVJCR+WOvxSJSTDvwy9KUOc8Cq1SJMRWtx+yULcfBMHwYnUv4kN1/OaHT6v6WRX0b0P+mwz70JQ3KH0PUp4bwpz1YbClUHP6rZK7gSpPcq61+DsedGThyFzeT7IF5LZcGhOuXeVnVBvrzW31icrL3vQJz3LiREgfMusxCdXTxQ/IN20MPstUa73/0nDvbhqbqFeXAyjbVy+VAe+PDmDXAjM/GO92JH4RPOrEy6a6jhZeAx+kWMWmMwEp/LsqyF3I7duKTCC1L6Mv3IA47fgqgAy4pBJloYAuCXHbWe1nDkj8iIwYcH6UfIKqp3U64GCeXWViRWb3H8WR3JVRF42R0/e+PLAptW4aulai12Q8IENNGb6N3PRA1iRdol3x/KAQ8E7JyLsBJpyyFOrSfFKlRp0Rp/1VO7/ZfgWQDB8nrjOMANwhGujIzGWouPiAjCP0XFypa4tK2Bvc//hrfopdXH+4F1L4yTjX66IRacrTewFAKJScujvqebfSEdKD+16w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Kees Cook [240626 12:32]: > On Tue, Jun 25, 2024 at 03:11:44PM -0400, Liam R. Howlett wrote: > > From: "Liam R. Howlett" > > > > Change from nr_pages variable to vms.nr_accounted for the charged pages > > calculation. This is necessary for a future patch. > > > > This also avoids checking security_vm_enough_memory_mm() if the amount > > of memory won't change. > > Is there a reason for making this change? (I.e. why not leave off the > "charged" test?) Before, the munmap() completed prior to mmap()'ing the MAP_FIXED vma. If we don't remove the nr_accounted from the charged, we risk hitting the maximum limit. > > Looking at the callbacks in the LSM, only capabilities and SELinux are > hooking this, and both are checking whether a process has elevated privs > and are ignoring the "pages" argument entirely, so I'm not sure it's > safe to change the logic for whether to make the call based on an unused > argument (i.e. the LSM may want to _always_ know about this). On the > other hand, it looks like it's purely an accounting issue, and if the > page count didn't change, there's no reason to bother calling into all > this to make no changes to the accounting. I didn't see any reason not to avoid the call, but your statement is valid. I didn't see anything looking at the callbacks that would have issue with skipping it - but I'd like to hear what LSM has to say. I don't have any objections to removing the extra check, if anyone thinks it could be an issue. > > I've added the LSM list to CC... Thank you, and thanks for looking at this. > > -Kees > > > > > Signed-off-by: Liam R. Howlett > > Cc: Kees Cook > > --- > > mm/mmap.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/mm/mmap.c b/mm/mmap.c > > index f3edabf83975..adb0bb5ea344 100644 > > --- a/mm/mmap.c > > +++ b/mm/mmap.c > > @@ -2970,6 +2970,7 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > > } else { > > /* Minimal setup of vms */ > > vms.nr_pages = 0; > > + vms.nr_accounted = 0; > > next = vma_next(&vmi); > > prev = vma_prev(&vmi); > > if (prev) > > @@ -2981,9 +2982,10 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > > */ > > if (accountable_mapping(file, vm_flags)) { > > charged = pglen; > > - charged -= nr_accounted; > > - if (security_vm_enough_memory_mm(mm, charged)) > > + charged -= vms.nr_accounted; > > + if (charged && security_vm_enough_memory_mm(mm, charged)) > > goto abort_munmap; > > + > > vms.nr_accounted = 0; > > vm_flags |= VM_ACCOUNT; > > } > > -- > > 2.43.0 > > > > -- > Kees Cook