From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92E08C3600B for ; Mon, 31 Mar 2025 16:44:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D81F4280003; Mon, 31 Mar 2025 12:43:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D09A9280001; Mon, 31 Mar 2025 12:43:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0E8E280003; Mon, 31 Mar 2025 12:43:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8F735280001 for ; Mon, 31 Mar 2025 12:43:59 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 40242A8E90 for ; Mon, 31 Mar 2025 16:44:00 +0000 (UTC) X-FDA: 83282418240.05.1BA2368 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf17.hostedemail.com (Postfix) with ESMTP id A5CDA4000D for ; Mon, 31 Mar 2025 16:43:56 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=PEzKVyDt; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=JY1r+ZpY; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf17.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743439436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zfOI7h/kHflaKKnn9zm4am4kVa4XIGvagIfieSVjKp8=; b=q/JppC29daNBcl/X/OSTcV/smakieV2aqFo+4O19Jf+gNrrDsk+lIjBeLJ/7B34/mZaoha TtF7NHPvOnCidY5aLgGSkVFJ/bwDV5/95qcsJ8K26qratAKdrer8fhnc8W07tXYJjZx9UX d4FIXcgzBzoGqfQ/PVvIzos2BzhHp+k= ARC-Authentication-Results: i=2; imf17.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=PEzKVyDt; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=JY1r+ZpY; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf17.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1743439436; a=rsa-sha256; cv=pass; b=nUfQaYm0MnFKKFu1eB8Hj73SI3hRDjy9gizbblwwwPQ/hkV2aaCloQthZ7//slQYCEF9Iz PcgT262B8MOGqPP1MwTa8ikgI4dkigeD7ZW4XPKNxdmLVp+EVG9sNyEgvUUCXANGxYMrIW lvTy0b7KzpdMdatOoraXPY6LJHxhpZk= Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52VFuiR8010202; Mon, 31 Mar 2025 16:43:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=zfOI7h/kHflaKKnn9zm4am4kVa4XIGvagIfieSVjKp8=; b= PEzKVyDt3cMR5IWQYavFU3XJm4CR43bR6z+7j2Q2wdE9PL3NkLpx8tLghGYQCUy3 H2SdPshNey16qLHsAQ2U1AjlUvfuvrpGLsMAhVNPMKR79VFchvVVcVmUcPW64GN3 15zfnTDLS8VGMpNkqbtdk2NT6mlQ7uEv1SQjGd+0hThmF8KlbmpvfWdDxAdZMKhd Ytb26aAtI9NkrHrydRE+pgi/tgBA9SDfBa/0lcMzNrcFBgdrl2RwWbOS92y5+kss Tm8MQNcrKwjcqtLL4fUIkM2fmKIjdUnbcpHJu9zgd3BpNW7bGuZ8517JiUw/kYJe JniLg1moEZXpvXN8zX/pIw== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 45p7sakp6g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 31 Mar 2025 16:43:47 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 52VFUDi7002793; Mon, 31 Mar 2025 16:43:47 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2043.outbound.protection.outlook.com [104.47.55.43]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 45pr8p2d72-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 31 Mar 2025 16:43:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=w/DUH/fIBomGfi5smL3x1JkD1ZhLvV+5GhC/MHi666FQ0m3ByB01wxEiSuECJTj4dJs9+AUF6xjKH1UVXEhXt+jGg3YWVa9KE0p4id4wB2XureL0Q5rDXIE8IO0MHVOFqDhF+VLO7+SbW5MVgIIQIOZJ2W2MxEfSIxI/aOtXIQ13JQden9rfQlBkZcaRw1i2Lc5ScNnSJbVGEeC5fFvwW+jvGmH/NVtE34nIy9T6WzIE8PJIwN+/r00mo6uHW2RK+lRLVGBVTqaIYSYaVHwLwX3I/TwcTAl8jvTcptZ8+6rHahqHeYaYDdo1eRFbkArE1kgrExBbLU3Pr6pqXRhDrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zfOI7h/kHflaKKnn9zm4am4kVa4XIGvagIfieSVjKp8=; b=dk9r9kmI8FGc2vGKWzoc/A/niqWvL8lIeIFF7QYjeinL6RMuU+uIrY7zH++ruqjnxRbp+rNpxQxHr+EZS3YLZyC8WRwJUeYjldLz3dy9ZOSklL5zyREBFZzGcZCGyv7xwlFsZySHtqaHCrNcXNViS/O6kJHmEhJwmg4fRv4W+ei0aBxFVJdG5NJYeyspOHg24MZWKkGHNufo6OJcACCc91kv4su7qbeD0A/U5EjYmcK0kK8MneojBfdPejJ0b9Piyi4uv5AAAFi1O6ynRIIWhSrWGc+Tw2MzxSl0P5260wOWHn4t3lxeY9qk6a3Arj8fA0EQZpYv0TaPk1d2hRSmfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zfOI7h/kHflaKKnn9zm4am4kVa4XIGvagIfieSVjKp8=; b=JY1r+ZpYERYls9yW0c0zEIAfNy5LyKmbHhA/h28V0ccPaO6UDg5ZvG56l8UuOXIo3h6XENLAcfjr/WhwSNXwvL0TSasi9xiCURn3yASC5p+51un3kcv1TB6npk5n43HtW7P1F/mbxRK4lK4PZby0rzCN1SUUM0QJIUHkuTtobZw= Received: from PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) by DM3PPF3D2127785.namprd10.prod.outlook.com (2603:10b6:f:fc00::c20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8583.29; Mon, 31 Mar 2025 16:43:43 +0000 Received: from PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c]) by PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c%7]) with mapi id 15.20.8583.030; Mon, 31 Mar 2025 16:43:43 +0000 Date: Mon, 31 Mar 2025 12:43:40 -0400 From: "Liam R. Howlett" To: Mateusz Guzik Cc: Suren Baghdasaryan , linux-mm , Lorenzo Stoakes , Matthew Wilcox Subject: Re: not issuing vma_start_write() in dup_mmap() if the caller is single-threaded Message-ID: Mail-Followup-To: "Liam R. Howlett" , Mateusz Guzik , Suren Baghdasaryan , linux-mm , Lorenzo Stoakes , Matthew Wilcox References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT3PR01CA0115.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:85::26) To PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR10MB5777:EE_|DM3PPF3D2127785:EE_ X-MS-Office365-Filtering-Correlation-Id: 080dec4e-7c04-41bf-c3b7-08dd707332d3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?djFrTXJyNVJ3SWJ3SXU3Q0JyUVFYSzJtb3N0aXhzazNyeW5BRFRmdUlLYmFt?= =?utf-8?B?ZWpDQkNSZE4xVjljTUNKbkk5b2E2TVJIVlA0MkV1ZDd3K0pjSWxPQmZUTU5H?= =?utf-8?B?L1BVaFY2ay9OQldTdTBSS2xNWHFuUnMxczh6ZFJqSHVuQnl3THZqTmlrWC9F?= =?utf-8?B?R1dtOFBXdEc4c2JqY283MFNUM0p2cGVXbDExeG5aOHl1elVaZTZvK09rZUF4?= =?utf-8?B?VE1DK1RmYktieU9vdWNWSFlyNHNYVEhRbUhWNWlSOGdnWEJIQXdaNzQ0eC9n?= =?utf-8?B?WXIxWWUxM1pjclhjdWRFbnI5aE44QnpRL0tOTFZOczhNNkwreFFyZnFYK29k?= =?utf-8?B?dzJpUzZjZ1dYb1QzQmRwU3VkTXBodEhKZnRldHlLQzUyd29HNmpQblFlWVpu?= =?utf-8?B?dmx1R2Y3ZWpQVG05MlRueUJIWHF6aVJDNDZUdUVlemJ5Zytqa3M1WDNQVysr?= =?utf-8?B?UEFLV3ZHK3dVZzJEcDVRQ1N5SUM4bEVuTXJiQWxSUEI1cDZRYjJJM3Rsai9r?= =?utf-8?B?SDhaaHF5eXY1QVNnQ3lkL2ppZ3lzUkl3N1ZLbWpkM2Fwdmo2UDFlUXhKOW1h?= =?utf-8?B?UTczemxRMWlPbDgxVi9zeEFKWG9ZOHBoMVYzeVlTTndPNTFmZlYvblJZUE95?= =?utf-8?B?WkNiWktkRTI4NGZ1dVN6RUNNSDBweHZ1MkZiNGZsaUdteFlmZkx4UlhKSVV3?= =?utf-8?B?RS9SbjduZXRxVjNFT3FuZWQ4M0VGK0FGTHVXUGJNV3JORG9lQnpoUE9QVThr?= =?utf-8?B?YVVaQ21HRlBxRVM1T2Q5OEIvdkhzN0Nxa3lyQTAyMFZpMG95dE0xOXhJNFUz?= =?utf-8?B?M0t2RGdDTk1DcU1yRmJRVnlXVXJOcG0xWGc5Y25yRHlhaktEcWxRZEN0ZTlv?= =?utf-8?B?V055WVdnWDhCL2lZbDZWdXA3UXUvSHVQWkhSWkVpZXhMNTZuQ0hYbGJUQ1Mx?= =?utf-8?B?VVN6V0kxSEZpUkV0VmZaMVZCVEZWZE1JYzN0VFplU2ZwQmxPazdSOEpOalVH?= =?utf-8?B?a2w4SFRQalBzWURGUStwRzNpbW4vSHlvbU5zTHFCM3FHMmRNQzZlckd2ZHgz?= =?utf-8?B?ZHZPNEtvSGxzV0VVRWxCb2g2aWxiWUNhRUR6Mnl0aGlXZUU3SmV1L0hJQTNu?= =?utf-8?B?Y3p0WnJYaGJyUEJWVk81UWsyZGlwWFpITjB6VWZwT2d2aFJBallzY1F1TlZs?= =?utf-8?B?RnJvT3lKOFZtWVg0RDBHdHE3WVBTdFdPRzJOci8wM0xrK3hRaG9vb0RxeGlB?= =?utf-8?B?cUcyM3c1cjYzTnZzcjdYMXJkSFBnMVJHTHp6U1hDYis5Rll1azFSWk5iNWxR?= =?utf-8?B?ZUVqdkdhUHkvN3kvVngya3Y0RzR2WHlhMkpHaW44ZVVwRnhBd1dXclMxWFph?= =?utf-8?B?d2cyd3FqMmJsVDJkbis2YjNjZ3dtWjRDVUNVcnJYZlB2V2E4RUNZV21MOXI0?= =?utf-8?B?dFZEKy9BZGltQTFoYUt0WnEzL0ZDeEpSaEtuQVR2NVg1UEdicW1IUlJwZjh1?= =?utf-8?B?OVZqK3dJZ1VpR0IxYy84bkNiOUlRRmtGLzR4RWhZRVN4QndsUWpYMGVhaVd6?= =?utf-8?B?U041TVd2NzBlZUxNeTdmcWVxNGJCYm03aVJBZ090RitRN3VTcWw3L3BGRlZy?= =?utf-8?B?ODJUSXVwQVNOTkZ0TTFEVGpyVU5xVGp6WHloNjJMMXhCYmZrWHl1ajAvWXdi?= =?utf-8?B?NW12cE9iTG9lSktvTG5wcUQzUGV0Qy80T0hvWmJ2MWJGOHNZcDJkRkNVRlVz?= =?utf-8?B?OFRsSE84cEdSSkNKdW91NGdXMndGMkVxWHhHYjdDZy9pNjFTS1d0SG9Wa2V5?= =?utf-8?B?WklldHFyNGoweDhhZjZ5aDBUYnJhbWlXejZxbHlWUUl3ejVBdG4vMFpFcklm?= =?utf-8?B?VmttZUtwSXcvaE9LblBmWFRxaXJSdlArcFU0Q1IvY2pzVnJZTlpXTkgvYzBP?= =?utf-8?Q?FDIInOr7Elc=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB5777.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ajhPbk85aGFxck54N20xdVJlaXFwdVlVMkFGeHdqU2hFeXgyMVBsWXgzOHB6?= =?utf-8?B?cjNDMlIzRXJqVnRUaHV5Ujk3MlJNNUZMZTV2R1gvTUZaS2s5N1hxTGgxa3hP?= =?utf-8?B?L1FjcHpyMUFleC9zTHUzR0NFSmQ0R2F2MFozTGZCV3dYZjdxUEJMdG9PcU5S?= =?utf-8?B?SVNFVTJRYlRwR0V0ejJHRE8yTnhOdy9YRXpzbEVVQjZIaVNTcmRxdDRkZTRO?= =?utf-8?B?TVNNY2lCWStKcjhKUG52RjBSNGIra2xZTXZNenllZ1pHNTBEcHF4NXdDajVI?= =?utf-8?B?RjJRMzdKNVIzOHNXc05zcVdPUDgweCt0NXJlcHZVYldlSFRmTzJzU0pDYUt6?= =?utf-8?B?UklPTnlYNWpxZ1RvRmIxYzRwMm1DRlk1SjE0LzQzYTV5VGYxSXNqZ2lXM0Fj?= =?utf-8?B?SU9HUGo1RmEvYWhkbjRMYTEzUGZDSi9mZU1OK05MSFZUd3g0QkorSGtnZUpV?= =?utf-8?B?eDA4R2l4OWxkdHVtU2oycDVXUHZENWVQZUpEUGpRM0d5ZTVPMktXeDdJWXhD?= =?utf-8?B?bmcydFp4ZmI5TWdVdEJsMEJrVDRLSkZKQlljL1lQZTNYei9qbkVCUm5RQlFL?= =?utf-8?B?eW0yYWcyQy9UaExVdWE5MXBGUG80NXF2bytkb1lWZGI1M2ZNMkpYQnRWL0hK?= =?utf-8?B?K2ljWWwwdHVleEwzMllMQ2ZPb2Z0WTJpREVLWWpkZEx3Mm42a3FsYld0ckY5?= =?utf-8?B?bjZ0ei9reEErVXJkMEJMSGRGWXBMSnVhcHZ2ajhMeGYvOVp4WEhFK1lCTHFV?= =?utf-8?B?SHJXTUtzS1FHM2RnS1c2NlQ4NjJhYjdMWTJKdy9xT1pyZUcvVDM0eFJ0RXlw?= =?utf-8?B?MDhWUHEzckFiQ3NweGpjZTcrWE5YaGp1YkVJOE03NmxZaFNDZEhiaGdBSTVr?= =?utf-8?B?MnRLVkpqOXBjN1FnQkdBYVlmYlBEUHV1VHR3UGJKZkZWcDlnckFlTjVYOVhL?= =?utf-8?B?QitDeHc2SnQ2NU9NV2JBdUVWM3lWZm9XdmpSNFZsQ1pGZ3IxZ0hISGVCZHQy?= =?utf-8?B?Z05Za0x4Q2FqTXBRK2dQM0o3c1JqMG1WRXA1M1RocXhxTi92SUZ1T01FVDRJ?= =?utf-8?B?YnhwQlNzOHlVK2ljRmUvb0IzaEJYRzBSQ3ExOXRTWmVnSVgrY080S2dYSGVQ?= =?utf-8?B?eXlFVVNYbStFT0owbGpPU0xHbnhTNENwWCt0cWxTVFIraHduUDBjVzVuWEE3?= =?utf-8?B?b052YzV6VjNnd2ZocFROT2pMUDlSM3hUcG1CU3BvQ0ExeGVjT1kwS3kxWERm?= =?utf-8?B?MWlrRVdkcll4UmVid1UrNE96RVRvRStJd1VrMkRma2ZwRHRXTDA0emxKczZz?= =?utf-8?B?ZTg4ZWtWSWFGMjNzeDg0VGtzK3A2K0x0VDZqTVAxYUFPbkRwZlkvLzVhblVW?= =?utf-8?B?bjZvMi9sUXRETlVYNjFweS9PMm1kdVM4VkhHYUxrbW13cUd0cHJhNXIxL0p6?= =?utf-8?B?S21zcEQvMXZZT2VOTUNJRE5IK3ZFRnJ4S0d2SWFDSXZ5MlRwR2xsMFF5ZHlK?= =?utf-8?B?dFJIcEw1L2hNS2wvWGNPK0FtN2JrMjB2amYvSmxIUHRpenk1N1BTMjA0MFVX?= =?utf-8?B?VXNiSHY0ZDZkQkZ4aXhCWjY4TWhlMm1NeXZaN21Ya0NxakpNdXFVQ1JGR3Iy?= =?utf-8?B?Qmd2U25lS3B2T2tqTWtUcVJCOWxWVnNjVElsaFdVM3puV3YrcExiSDZoS1Fq?= =?utf-8?B?alB3MXo4WExwR0RMb2dla01xTCtaY1c4VzNrOEI0Q2V2TTZwLzI2eUlFZTFQ?= =?utf-8?B?RGV1TlRlMk5yVEthTnQ4bkVaUWU1UWUvMmJJSU1aY05NcnlwT1FlQnAvcER4?= =?utf-8?B?VGowUDVXSm51M2VUb1JnZGI0eEd0Snd4OVNHR2JkMXdqcnQ0UWZ0V0E3U0Zu?= =?utf-8?B?Q1V6U25XeEZRL3hxVGFUVnBlbzBlUEltU3VNS05Ia20wZ1lRUm9teDlzUFRs?= =?utf-8?B?VDJKTTV1RHpYbWFGZ0RFalNCS2F0Q2tFNDRrZ0FScDdsc29uUk5WZ3lmZ2FG?= =?utf-8?B?NWtuT01rdG1DeWhPV3RlanRBcDRiQ1RuL0lBbSsrZ2VNNnFub1Z6UXNidTRx?= =?utf-8?B?RVdxaXpiRkM2c2Vrb2ZaWGQxbFNyRk5aTUV2b25mOHhDWnhVbElNcSsrVGNY?= =?utf-8?Q?hpnQVaCIOVkPcuC61tOtITz9k?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: WzWelaGtgYDe196Z93PUNTg/3MojhrXkTgfVlhsIPWdcrycG8EQAU8uGTkRTf0MtjJmkNoxOPVaPECOyKFkItvZPb5o/qFPeCqFOBSXeL/niqjUXThGJnWyrwvDN3aKXoVf77gh4Y4QPKRbi6iS8TeiYh1LS2n7MF2MC9eisu1VBS+qe0h/Z+8Zi1i9pyTrAt3C5NYTfNUxqvRAA06wUprBMM7W/g+M/UxpzVe8quiYc686Rxuei7NA4oUvyeobO68RgRx7XBkzxgGv6jnZZ5JBvFTBp5Yrr0Ka3FHEym/kd28UzLo//reQ4ncEz0XEzsrQZQzyLjA2rDfhRY3aSrVEg50jYUfV9wvl5rNCp7GvgXhIUyqGBokMeW75uDPPceAGA03t+qYKgVVLLzl91jTThbQn4YCh46vBTbe9iucS3R/1uNTl7bNC6lRC33ZDarfCEmqpWEvYp76BOsnyCYezIjdXPCyX2TVe5GXUbE/3fGPbcNncohb/AwlJ0IaLBgYbdZ73ywCCWnIwo1hKMLJGW3/Lc8WoLSOrsfJc1h1yrW1fRwoj+L3+49rxwZbW4sFr/WKhQJU6TcJtPI8rjUQBa0kBMAFsM5E7dbyUB+sw= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 080dec4e-7c04-41bf-c3b7-08dd707332d3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5777.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2025 16:43:43.4331 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vuSxMOm9yCSSBk83PgwQp7x6B05YCM8I5PBxjaPgreWkMmiZsQj5mVK1Lj1V802T02QRDop6WW2QCfzSbla+aA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PPF3D2127785 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-31_07,2025-03-27_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 mlxlogscore=775 mlxscore=0 phishscore=0 suspectscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2502280000 definitions=main-2503310118 X-Proofpoint-GUID: cNX4at-j0inLjdq6P7FtdrJc7CMLHi3J X-Proofpoint-ORIG-GUID: cNX4at-j0inLjdq6P7FtdrJc7CMLHi3J X-Rspamd-Server: rspam01 X-Stat-Signature: gqikihb3a5azna4t73mpnbdmg6xdeykb X-Rspam-User: X-Rspamd-Queue-Id: A5CDA4000D X-HE-Tag: 1743439436-886960 X-HE-Meta: U2FsdGVkX18B6FKG25K4oy08yjGe2T7XdScQiUO2pniwRInBJqBJN6xZ8gqC5rWdfl0U3IVqgx5FbIBlAo33gQDfctlMVZlgAc38SNeFtHqBc1ZDTgoTGQslbyFyMhRkKvw+MdzxbeRvcnL8ajHGGzsAXVxLOvqGN9vqT+//oUHEaqY45tVcp72jdj8Pr8QGvbyWiiR682hDzoYszj8xpkewa+6RLLKSz6exWTsvEyCtuOuR+vcr/7NhTZ8Znl486y8Ro2C+4mB30zyu/ESVCmAegZC9L8EQDB0VT3iN6KMv1vgvpJIdEl7p4HBBy0z56SB+ESC7GKjp8M7mJnNLLDUp2LJs5TK4FwhxB5xLG8h4+9hj+BU9iAecLCg5vNj21cu7GVFbCQ8IU9UaIQoCQKe5hrzhhiDZY1UYJBolBvdS1GlutoXAElwpDqEgxlAvTf+g1Jv0B5OqEHVmfBRoIeIf+KbtLdG1qUxJDbiutQqz1UANHwxbvq/Yw9dN1g9fHw5Ee3++VG8NxNNYjjcCEtHIHrxPpOsbJhCf94osJknX1gWEorYh2ImA7s0gEKA5SaxEw+mlg/oYBA377L6Po19g8ZwKoYCVnFXaHjCxnldKehNjSgpGTAflJgKV8iksJ21ZA/sHfWsCSQTdfDtcmSmY8Kd1IKZIo5J0vju/G9Y1RFsCnulgPw9qR4oyNv3on5Tfah8+bG4UyRS4+j965/f4dF+pj5s6Wc1YahLftz+ALUWEwhjAoc1uJ/4U7g2Izl4lSBImcK0x2GTWGHOIAUQz6p9BE2aPHa8es90lPtQGlQTHfgS6YwuKhq47IJczcCd2IqOwebg972Ekm62+g8cKfuRzZ2nxmtbckqWPGjAPYVN1JGVoRjleUg48VzkFG/S5BqdfQ5CqirJVfYGrBVj/UP0eWs4LV0Ijx93ndNAMhW6KuXsFvqOxibkAT2tsSVQCYBdswsE0Kjlvhiq ROjyKp+5 y/+OWVAG0UfAMJevkjAY1RSzPhNKALw7yGCnTwFZauG3/UKg+TugZLTc92vQKilW5jBZX6zLN287Q3tKuF6MOU7eElcKI0DnfK44SinjyoARztEBIBlEJAMXDZ88GTfVQ2VjFiS0sNXBIO7eCOqEjSaN7A1Z+UNJ9+vsKfCGn738K5UF9o7hcO2wO0s3uPNin6K+3I0wZL7DxVu1TiWDY4z1BQeTUA7SThiivO7MZntYULgpW+GoF9qUmooQGsK3oByqi2ks3vUY+TRvCCC6gA5KjC66ObwRpN2simte9fAEbRTsDfFmXxEupUXk9z25P9UN69ws59weihIcqAR61V3RESyboSDDO62hzgaiIOBrvJmKBy1qml2MWojb9ImDvkgNefdt9oyHbJC6/kyBSYKcJAsZqDm3RapJFGPBU+Gqr60DX3hM1sy+37d8G+p0E72Jgo7sEADz/Iy/6s63p0LGpcWBUD/0WYXO3B5BogeJjzWn3W61CDIA6yzr7HBijokf5RiGHctpMM39sOssNVhNBS/FsFFE7nqxGuKVox563NfQw5dcx7R33rgK+cqqAAw/l5EBTjeoJD4v09pdGjqJy8YnL3Jew/LR/n1YSyZ46XGG/GEx7H3Uo70dGK2FMaoZR1cVpufQJrOhKRzV1W9AhlYc6DhPUFrTc8e9TJSmTx+GavjkOnuo9DA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.445596, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Mateusz Guzik [250330 15:43]: > On Sun, Mar 30, 2025 at 9:23=E2=80=AFPM Suren Baghdasaryan wrote: > > > However, the good news is that mm_count tends to be 1. If both > > > mm_count and mm_users are 1, then there is no usefaultfd in use and > > > nobody to add it either. > > > > I'm not sure... IIUC new_userfaultfd() does not take mmap_lock while > > calling mmgrab(), therefore I think it can race with the code checking > > its value. > > Considering the mm struct isn't the only way to find the vmas and there are users who use other locks to ensure the mm and vma don't go away (rmap, for example). It is reasonable to think that other users may use the vma lock to avoid mm_struct accesses racing. Although I don't know of a way this is unsafe today, we are complicating the locking story of the mm with this change and no data has been given on the benefit. I don't recall any regression caused by the addition of per-vma locking? >=20 > It issues: > ctx->mm =3D current->mm; > ... > mmgrab(ctx->mm); >=20 > Thus I claim if mm_count is 1 *and* mm_users is 1 *and* we are in > dup_mmap(), nobody has a userfaultfd for our mm and there is nobody to > create it either and the optimization is saved. mm_count is lazy, so I am not entirely sure we can trust what it says. But maybe that's only true of mmgrab_lazy_tlb() now? Thanks, Liam