From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E0EBC3DA61 for ; Wed, 24 Jul 2024 20:52:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E23C76B0082; Wed, 24 Jul 2024 16:52:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD4706B0088; Wed, 24 Jul 2024 16:52:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9C166B008C; Wed, 24 Jul 2024 16:52:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AC2A16B0088 for ; Wed, 24 Jul 2024 16:52:47 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 55A1EC024C for ; Wed, 24 Jul 2024 20:52:47 +0000 (UTC) X-FDA: 82375845174.27.641BD5F Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) by imf07.hostedemail.com (Postfix) with ESMTP id 74A134000F for ; Wed, 24 Jul 2024 20:52:45 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qXqOq+iG; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721854330; a=rsa-sha256; cv=none; b=CViyTi1QgBvD8HWcln5uGNMmEQSTxPZZAfsHgO5SsBVSjeFUs3PB9fzA4FxQ3pLj5ZjEI9 B4q6rOCF9Clo2qALdTuEdwvC/C3hxPLqB2R9D0ut9si47Dng+F9EiC0GIVzuu68+N2DBE9 jULk6wPfVXkp1FdvxGImZC+6+abBuwc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qXqOq+iG; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721854330; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8oEYtDqRCidvl1ML54l/KCYLGkWbzzfgqJgJQTvbIpY=; b=52S0x67sAI/D8GpRj2VkJnbcgIOQB6pYPmecnRqnBd3MgK1N/zypFrcZptN33ibh/UwrYs rZoQjkFUs/AARFblGZis6ZWVJl6CpAtHSBsw/8HDYadviyCStmAK8gXoiRzTW0qlPzMYI1 gH1eAJqaxSdhLcxiQ0EYuDj3W1rPnQw= Date: Wed, 24 Jul 2024 13:52:38 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1721854363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8oEYtDqRCidvl1ML54l/KCYLGkWbzzfgqJgJQTvbIpY=; b=qXqOq+iG+uE2WNLgXhMeANfi5WvBS/kCYyPjYvuWsR/+KoFccSAvjouCt1Yjb7ZbD0r1yo 6Wg0am5KfKyv9w3xv9Jf+gjOFqGqj/w+sVaHS2jNtqkoLCFqPFGYAiX3Cpn2vFRUkG6O1h yicmIqA8lJCNpdeGUnZBSCKt43ijEqQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Muchun Song Subject: Re: [PATCH v2 1/5] mm: memcg: don't call propagate_protected_usage() needlessly Message-ID: References: <20240724202103.1210065-1-roman.gushchin@linux.dev> <20240724202103.1210065-2-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240724202103.1210065-2-roman.gushchin@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 74A134000F X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: rhhtwnshysr7n7qoyc5gpfgsjnxpqbf7 X-HE-Tag: 1721854365-501578 X-HE-Meta: U2FsdGVkX19hotrtlE/uH/0K/sFV19JMG05ndkr0Uu4PqRuX4DdKoiz4Hlaoh9i0hVl7mWeqBnQB8sWUvJvrRwVhwJsY1iVwrUjlXeOU4oqQaAabEG1u6GxzZBemSnXjAy77F+qLiFrg2C5nVhV4PRn9+HhpQIFVtw8ju1+OgXIkxG0IvnKvnzsSOAJ5BqcQ+C7Qmk37Uxv5HeoI98l4YJXuIe+5+rnrwXgO9YV4F45E0ltu3A+PL69cX5qpDNX5T/AdHsOilBLHnVRVkRr9NHawu6gsAAQMB+uWPXThW1AWinLCHpbBrsg0+NAiP657lR+dbp7XxjiFAxgGyRAOVWcIotOxYzqsEo/EyIm3ox+Mo14h8NIO5dqEj3O1PqihBiIrdxQ/y/9ymyLZCCIvn6NdUgzMjG83VcOfgTinqHv75jJXDMgG9FA3Z6qLmQAgwubChAop/NGG1zd2LsHd9203+CGUtHQeiY07cS9AJTPfRGYkkoDflB98WUplbzsUIkvnbLxxIdFhPHKnPUBHdJ9087GJIGIx4dC0CDL9nDaYOofKteHHwo7aW7mItSFQwdj8FLR+WGjmiTjAgbwy1LZKFV3pEXYW5+TQ5M38Xvr5DfZMGSbiHCVexa1xchF89fFlBoJDSgLeDw2zW7lWUjQ8odFf9y5/Q4rrl219KVx+5UmP5ccMkzCzj3vy9bw/1tHxa54xkGhH5rzXbH1trKUHY/IEOCJNA+BZ7zDogAztsqr/8FrbDCkyYMAnHkbpTJ65MnTNspuK+WBJgYRu697ocga0oB/f64PtCWvCMz3/HbnYbDmS+JAWAbIbPagfVEuL9efukwmO/WrPDdPxPMEdBUKdjjh/9WFTMkNZehO86pQVmCRY2t9ybBuCC2+3p1QbeHUrK/2FncknGXuyTjx9VwRcR6ucW8s0hc+YYhVzt/gjNWu6vloOk/rVn8kFsf338B/zE8IyjY02ioB LuTEJlLK 75FpoGuK+Xeaaf8RFRjPPQ9WryUhypNwNvcat0Rv5y3SY0BCei7cYHkw2XjXwQjkDwGtSJ4ACjUwQgMsu5Wfvq8NadxCPKLoIJPnNPjLLxpsKca34dyLarJDUV1QABxL40Qi7pEKH06lzKpBjATNmwzoGq1+kue9NEpvr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 24, 2024 at 08:20:59PM GMT, Roman Gushchin wrote: > Memory protection (min/low) requires a constant tracking of > protected memory usage. propagate_protected_usage() is called > on each page counters update and does a number of operations > even in cases when the actual memory protection functionality > is not supported (e.g. hugetlb cgroups or memcg swap counters). > > It's obviously inefficient and leads to a waste of CPU cycles. > It can be addressed by calling propagate_protected_usage() only > for the counters which do support memory guarantees. As of now > it's only memcg->memory - the unified memory memcg counter. > > Signed-off-by: Roman Gushchin Acked-by: Shakeel Butt