From: Soeren Sandmann <sandmann@daimi.au.dk>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, a.p.zijlstra@chello.nl
Subject: [PATCH 1/2] Fix race in debug_kmap_atomic() which could cause warn_count to underflow
Date: 28 Oct 2009 18:55:36 +0100 [thread overview]
Message-ID: <ye8zl7b8ktj.fsf@camel23.daimi.au.dk> (raw)
In-Reply-To: <ye84opj9zgs.fsf@camel23.daimi.au.dk>
debug_kmap_atomic() tries to prevent ever printing more than 10
warnings, but it does so by testing whether an unsigned integer is
equal to 0. However, if the warning is caused by a nested IRQ, then
this counter may underflow and the stream of warnings will never end.
Fix that by using a signed integer instead.
Signed-off-by: Søren Sandmann Pedersen <sandmann@redhat.com>
---
mm/highmem.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/highmem.c b/mm/highmem.c
index 25878cc..33587de 100644
--- a/mm/highmem.c
+++ b/mm/highmem.c
@@ -426,9 +426,9 @@ void __init page_address_init(void)
void debug_kmap_atomic(enum km_type type)
{
- static unsigned warn_count = 10;
+ static int warn_count = 10;
- if (unlikely(warn_count == 0))
+ if (unlikely(warn_count < 0))
return;
if (unlikely(in_interrupt())) {
--
1.6.5.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-10-28 17:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 17:53 [PATCH 0/2] Some fixes to debug_kmap_atomic() Soeren Sandmann
2009-10-28 17:55 ` Soeren Sandmann [this message]
2009-10-28 17:56 ` [PATCH 2/2] Fix debug_kmap_atomic() to also handle KM_IRQ_PTE, KM_NMI, and KM_NMI_PTE Soeren Sandmann
2009-10-29 9:07 ` [PATCH 0/2] Some fixes to debug_kmap_atomic() Ingo Molnar
2009-10-29 14:33 ` Soeren Sandmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ye8zl7b8ktj.fsf@camel23.daimi.au.dk \
--to=sandmann@daimi.au.dk \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox