From: Soeren Sandmann <sandmann@daimi.au.dk>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, a.p.zijlstra@chello.nl
Subject: [PATCH 0/2] Some fixes to debug_kmap_atomic()
Date: 28 Oct 2009 18:53:55 +0100 [thread overview]
Message-ID: <ye84opj9zgs.fsf@camel23.daimi.au.dk> (raw)
Hi,
Here are two patches that fix an issue with debug_kmap_atomic().
The first one is a pretty straightforward fix for a race that can
cause an underflow, which in turn causes the stream of warnings to
never end.
The second patch extends debug_kmap_atomic() to deal with KM_IRQ_PTE,
KM_NMI, and KM_NMI_PTE.
I was seeing this because the __get_user_pages_fast() in
arch/x86/kernel/cpu/perf_events.c ends up eventually calling
kmap_atomic() with KM_PTE, which, with CONFIG_HIGHPTE enabled, ends up
expanding to:
#define __KM_PTE \
(in_nmi() ? KM_NMI_PTE : \
in_irq() ? KM_IRQ_PTE : \
KM_PTE0)
and those KM_* types are not handled
For the second patch, I am basically pattern matching, so I might be
completely wrong.
Thanks,
Soren
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2009-10-28 17:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 17:53 Soeren Sandmann [this message]
2009-10-28 17:55 ` [PATCH 1/2] Fix race in debug_kmap_atomic() which could cause warn_count to underflow Soeren Sandmann
2009-10-28 17:56 ` [PATCH 2/2] Fix debug_kmap_atomic() to also handle KM_IRQ_PTE, KM_NMI, and KM_NMI_PTE Soeren Sandmann
2009-10-29 9:07 ` [PATCH 0/2] Some fixes to debug_kmap_atomic() Ingo Molnar
2009-10-29 14:33 ` Soeren Sandmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ye84opj9zgs.fsf@camel23.daimi.au.dk \
--to=sandmann@daimi.au.dk \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox