From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5367FCFA779 for ; Fri, 4 Oct 2024 13:47:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C55056B0406; Fri, 4 Oct 2024 09:47:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C05386B0407; Fri, 4 Oct 2024 09:47:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACCC46B0408; Fri, 4 Oct 2024 09:47:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8E9B06B0406 for ; Fri, 4 Oct 2024 09:47:47 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 188411418A9 for ; Fri, 4 Oct 2024 13:47:47 +0000 (UTC) X-FDA: 82636047774.29.7DEA8C2 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf04.hostedemail.com (Postfix) with ESMTP id AA5D140006 for ; Fri, 4 Oct 2024 13:47:44 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=iiitd.ac.in header.s=google header.b=j97In0ut; dmarc=none; spf=pass (imf04.hostedemail.com: domain of manas18244@iiitd.ac.in designates 209.85.216.44 as permitted sender) smtp.mailfrom=manas18244@iiitd.ac.in ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728049642; a=rsa-sha256; cv=none; b=a4M95UgR0s7l7DWz2SXO4Af6ZzOQSgNhmMZK4ro++8ZKKvmgY6Q0rMUXIqVeY6AQWbkyaI JFA7pOhfejd1Yra2a2Ut0O3XZxn1ewZOrYdlkt3h4eBqGIu1I2GGXe0xR9z92JvYYILWPk auvQGYj0tOqy+WA96b/KwkZMy+IyhGI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=iiitd.ac.in header.s=google header.b=j97In0ut; dmarc=none; spf=pass (imf04.hostedemail.com: domain of manas18244@iiitd.ac.in designates 209.85.216.44 as permitted sender) smtp.mailfrom=manas18244@iiitd.ac.in ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728049642; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r4NZSSOmxpJgVIXotODKT8B64hShlAJiNZdC5IU4kIQ=; b=axf3TFqyFI2l7Pr/ZhzZsyHk0AHUT8KAwp2lvkEfqCKSYdiqx5iSKMllPdVEpBQ/BRuIt/ WoGvgRDBLjwNCtYImcpWjVEYuRVe02jc/fZtus46ndydFnCuFhszZb+Zn/rzFraxoKgoC4 jB6rN+RUP2BjsZbQM0YMjc3upgIO774= Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2e18aa9f06dso1571632a91.0 for ; Fri, 04 Oct 2024 06:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iiitd.ac.in; s=google; t=1728049663; x=1728654463; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=r4NZSSOmxpJgVIXotODKT8B64hShlAJiNZdC5IU4kIQ=; b=j97In0utAjv5LKxP5T9TWxIfekwz+IiG2Yi0qSv7cHddlstuXm2FLTWtzdVFDe4z/A T3L6y29rfBg0/24/HoTxVGY9IT5yggb1k0vBBZSOeSXiIj0dqhY3qHReEsYUrykqV6+y JRulUArJ5fCMehKimToA9CSpzyssQdQgINcwY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728049663; x=1728654463; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=r4NZSSOmxpJgVIXotODKT8B64hShlAJiNZdC5IU4kIQ=; b=wyybAsHDumqIlIQNhgEGwjRaNQNVKXf6hHhqHnhXSzF1PBrdX42gRRMUFsVwghSGXH y/0UWyKGaDspwoY5th92jQCXaWYqTAjsgfE66GDaihUzEyYAc3lgt6n0JOqkBPF7xRLs dTo5I8NtWUueVQNHyF5o79ZQYgWhka3+LgZkdbAs2kIR5XYX/UxbA2ayJ9ain1A/BdpI EstIVasaE3a695ygjNxg5Q/jicCgsXFb/9tnXO9sy892Ma8rfXRtP6RJzZpB3IAQLLEu Z2FWsvKNu8rZ7DatoBtcsbFucQFCcUyZdsWG8RWB6v9nlaNkgmEIsQWUrI8UwF1+z0Hu +/Cw== X-Forwarded-Encrypted: i=1; AJvYcCWMLGBpunxH9QF0jPzVpl733vRhpbOaqI8hNou6xALDsEjH74pltCRuzNtFnVP4WXchC4I/gfBWzw==@kvack.org X-Gm-Message-State: AOJu0YxYtm2bka6rmJvIg2WITT6GulKf0lUf2wSa2M7R+/SfGTBy86kW Bj2/bEkV2z1ETTbI48zMA+kI6QxJn2y+8WWBnHj3VVo69r0OET+BDzLs2taKO/jJ6plPJFP125U piPR2Og== X-Google-Smtp-Source: AGHT+IEeTrdPnfpDQVPKQQ/gxSDhFGcv7qtEq3cmWRZs8r+EwWAAhjIc0+E+WS/byji6CzuShsADmQ== X-Received: by 2002:a17:90b:109:b0:2e0:89f2:f60c with SMTP id 98e67ed59e1d1-2e1e5d63376mr4226145a91.11.1728049662954; Fri, 04 Oct 2024 06:47:42 -0700 (PDT) Received: from fedora ([103.3.204.140]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e1e83c9f60sm1618424a91.6.2024.10.04.06.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 06:47:42 -0700 (PDT) Date: Fri, 4 Oct 2024 19:17:37 +0530 From: Manas To: Andrew Morton , Peter Xu , Shuah Khan , Anup Sharma , linux-mm@kvack.org, linux-kernel@vger.kernel.org, syzbot+093d096417e7038a689b@syzkaller.appspotmail.com Subject: Re: [PATCH v3] Fixes: null pointer dereference in pfnmap_lockdep_assert Message-ID: References: <20241004-fix-null-deref-v3-1-f9459b1cc95f@iiitd.ac.in> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <20241004-fix-null-deref-v3-1-f9459b1cc95f@iiitd.ac.in> X-Rspam-User: X-Stat-Signature: 3om6sptjzhat3a4ks41917h3jf3fr56q X-Rspamd-Queue-Id: AA5D140006 X-Rspamd-Server: rspam02 X-HE-Tag: 1728049664-276289 X-HE-Meta: U2FsdGVkX1+Zn0u9AhHNjt6uf/XC08jqnhVfY/Xp+QFjawlac1ZbloiVH46IXGuuX3aOo79gELs2nae+a5ZShe36S+uDd0kPNL0jFoS21ot5wgJ1WRWn7itBZOoWgB9I/8NtpAiDZ5dV1dMWQ34l/tNN2nxvOmqvQxBfwlAuK2ynR3jrivLYwmNwQvKOQzXKm6bB08Z6gfMYv3x9hrXbJwOTnzTRS3o4fRHRVoeJCWK7fuGy7d88ym29EYAyqBewJ4e0lqfUgDMtHNTtpWxLG29uR4jrFVEl4RniUVmaKV9qhC9J7KnZ2fJuUIjlg2ept2RnTGMK/unDH4PUnQhmG8iZDbEK5pFPexxDACXWRGycq7LKNfwF8KsZ6C0hi4d3KbezPNF/LnnLN4dxXfH35CfQY9vnmKCWUDCpCK6Iw0BgG3/k/prIPpgXYpBNwL80HyMyAb99T7kUUetm4mCbLfH23RgTLM9U6/3LCQ29wVfmc6ymTVsVD17R3LCsF164jueTAP19FJxw9FDvcxPPpn7xx8kx4XUS/vFXUNZo/CWp+Rwb+93s/0vbuKyeaD1z3rxLkNpVGh1rWsMjq7zJSgeINaFXbO+I6V+EADcE2QCLoDeYqyd799bLg9cc2Avjb+XlNRRdOX1fAGAqh8WCOm4nz8/V0WOSD8VYL2m5ITqOUN775Kj538eZUkF5e2S4pJFIQQGRqlw25+5rt70KmLdnbQwj/TIBnBZjaTLi2X5WnwqXd9wYNew5XmXhkC05tHtnjkLy9qGh18wJtzLPPQpxcb52ut4AHMMI5d9+XhRAATuLWgkU4pY4AxCI3i/2sfgjoP4NRXS2KdntJaxy+JlGUMjjLoenoAjdY3LipRTCQuU+TmnzHEhmnT1lvmW7U1D2JSlGalAjH4u+7UE6obyZ0Q20SYhC55mMdsF3EAu+mAkmWJPiUgLrOa31JpVFOTsdjPy8xrCID5NCD3+ hcRimkmo xSQ7j7qh6iEqLLENJzyNqniJAetJ1z/Ck/nrA4OML1OJpQvWhx3fP49v1W8a1PEPfV4so4bU274//7Zxjqpa6waCo4ROaxDagdcLlUfZmMtRaKDxb4TezX4ROTUMAjP4I1w0tomzwvnugIRkcY0RY8eKeK/Ekr7xteAc9AnwSG9P4Dcyu3JNfRM8c8//iRB/v2MoneUjOMemb+HW9FtAtorv1sa7JrPb546ERJct6xdGcxwMa3PtzFe1qGg7hf4sisnm1y0aP9TISyfIOiU0EIpGN3PJWwCrZylRkv/PjG8C5MjQBt7i8Mq68TI3JCmoIhA29f6nt3bzSHZt4/dp6Q74lBparJRV5n0Oe5+eVyk4BgWsuTTIbiDuyDcu5OnMYdxQ/1ABiDB6kV6D+jUQpTrWGR2rIjN5ueZSoqmsGNymNcVQVjjbKH2rX9LS9Ojsw6/gFbyq7IGHHQCDeT7DLGW2XGe+2zkpTg3nijhfWSl1weJQjg4l5eDYvDRXMcrqdT2/JAdvEO56/5Dc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.10.2024 19:15, Manas via B4 Relay wrote: >From: Manas > >syzbot has pointed to a possible null pointer dereference in >pfnmap_lockdep_assert. vm_file member of vm_area_struct is being >dereferenced without any checks. > >This fix assigns mapping only if vm_file is not NULL. I also edited the commit message (and cover letter) slightly to tell about the newer fix, instead of the v1 fix of returning. I hope this is okay. -- Manas