From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE435EE49A3 for ; Tue, 22 Aug 2023 13:01:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41B72280012; Tue, 22 Aug 2023 09:01:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CA9690000D; Tue, 22 Aug 2023 09:01:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26B91280012; Tue, 22 Aug 2023 09:01:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0A28690000D for ; Tue, 22 Aug 2023 09:01:09 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 87888A0283 for ; Tue, 22 Aug 2023 13:01:08 +0000 (UTC) X-FDA: 81151751016.08.E3533E0 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf12.hostedemail.com (Postfix) with ESMTP id 4CDA740029 for ; Tue, 22 Aug 2023 13:01:06 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=BSDgSSZy; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf12.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692709266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nPC9oXTPWIOvWWqbloyF9hpx3Cia2d5N+O5LkxGdFhc=; b=6VdUjM40HVWVGAeGbc7hOrQL9su9Kc5yuvRFs10nNMAY5Y6k7O3zARaGLD9qDivdcuC7ed 5KKeWmcDNyviG+JmKxdLqPDs/odzWwVYiMofJd7sjZI7hQB0mE+gciDj1KKETvuMd+22VR vBcWDMguqqZLXXX3G45T1BwSjEKNALU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=BSDgSSZy; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf12.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692709266; a=rsa-sha256; cv=none; b=DywDELbQO0zSPUd6KSSbmLBMyTI/SGu+YkyP0l2R/g4lYt1uKqwCFmhziUJah7gxOwRHjU qIpzA35FwyBBEyfBgnL50HTNgziQQ9ixROVwC9CE8gmsIq/kZaah9TvRxfwk6eyLssYbQV Bxt8gPe2yGn3wN7vnZ5LKantK51eqm8= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4F13022C28; Tue, 22 Aug 2023 13:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1692709263; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nPC9oXTPWIOvWWqbloyF9hpx3Cia2d5N+O5LkxGdFhc=; b=BSDgSSZyu2C+dtWRJVdM6RBEYpTsn5ecB93MOzrEO0y4G8bQ1lk/06vcv0UhQeGeSwo6ph AhtGAT4BNUtYS1CUT/E1rW1SiHS4RgTgDxzcU5pLf/jq337dypvzCNbK8Xe4QWXlzqDXSg SNyg4lfKK56Xuo6ORmPYg3KFZA3BxsY= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1D363132B9; Tue, 22 Aug 2023 13:01:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ydRgBo+x5GQqdQAAMHmgww (envelope-from ); Tue, 22 Aug 2023 13:01:03 +0000 Date: Tue, 22 Aug 2023 15:01:01 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Ivan Babrou , Tejun Heo , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] mm: memcg: add a helper for non-unified stats flushing Message-ID: References: <20230821205458.1764662-1-yosryahmed@google.com> <20230821205458.1764662-3-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nkqic6iypcnygsam" Content-Disposition: inline In-Reply-To: <20230821205458.1764662-3-yosryahmed@google.com> X-Rspamd-Queue-Id: 4CDA740029 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: x4kbwatfgxmrgcpbf13e1bndcdd8yaag X-HE-Tag: 1692709266-409305 X-HE-Meta: U2FsdGVkX190b38KOUy3XTlJYXXn+xfFtUzreKe4N8PZ5eoXP9mXm/JR3mDGH62hWrAtocS3A8d/PwgC7rVJqQYJBWw+knjpwpRQr2Ck+/MVe5k8A+G4WbyeojxWUyx97i1ly7lEtPDrj6CavxsjtsNFCwxGGp9TIXUiERC7DB5vuZm0+jj1JTaEGLYyWTYwJeNF+4AvV/m5Zupcs2E3q4e8g6EpQODJ9gNQq4m1M3ZrnIeTmu506vuP2O3k+cING+kU2iDI0nbI7kqUfAoP503bUMLW3vWaPwrl2RoC8kJZ5b4xdwBiysiFGXWYOOPdhmL3yZTcDysm1142h7ZVhJEB2lVjBkcKWw/9I0jC5Q/WSXbzGPMgbcOpDPqBxB3bW2RO8X4p7GFLuva7rglXaDmwRx4SkisFIV3JDmZVVI+LtFNZeRQ/IsjoHqh/xcaL4IjHA3wdIWR3Py3xcF4NsYIP8P3Ruk8joetd1v9Nyk68E6SeTRUIGrOfYU6MRPmy8P+7IikMBmEy3T453ct0SPCO9FDdMtJ7W9dnSuPzLZEGwybWveCC/jzs9T2RnVBaHAqWyBll3vgBIxYbl7qnVP2rljdvB4IERm2GTlrXHeIxL0z9td4mUMzKisHc+huyWhUSyifMcP5wdDU90vfUvvlvcY2/as2CsPZN+nKhgJVjywb9HSpF4Jlqs+4J7mqx5IMmqkgDsHaeErsyFvhx4fezDgZKBPDjCsXwXLvWJpPhZD91gWmLtEHKFHfevXHiAHfu0H4XEXZibPQ3edUKjKGF494qMcZdNDrUSrijow6AI3TvC0eArqoOc8dq+bJsxLz3WuHRkWM+7uvkraBG3dLgyz1P9ZN4MWWbvTkuDTG3X9bwEqNfDl+xwpIG5+BpNE1aUp2ybw3asMFoPkhNfab8dYPnjgxg0Gb46bczt3TNgLRc5Sswcgt1COQmbsyHNfvnvIs0F0nvRrALkB4 rw/w9kST 9kg8pnfdxMv6JHv0cBnTJtwd/ZvyghKEpAZXV6klQddDHsna3nSv57CeSvaalEMuRid2Rw9wK4V57YT6f/akSooLzsZ8JVeQmwuImYaiKvxEP4olp/eiE09KeUj+76OGzsbMvCZExaSI8Iy6UN/GAkt/iqq0/Z3aVahJit/UfigmZB8e/VBh13UUyhFYGX76amI+siJDBK2SHvg5wMsCsmjK5AIKUI0r4IwD+KJPow0t2fNq1//udMGpruNUqmfQVpfkWRXB41fs34TBZp4RqOQrKGfokVbbJRicfbt80tPPN0H6bS1sQmpCQ4XC1PibaND4SxQvaLLQrdYGwvLizkncnI1BZ0SPTuEt7J5zbH7Pb+JA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --nkqic6iypcnygsam Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 21, 2023 at 08:54:57PM +0000, Yosry Ahmed wrote: > +static void do_stats_flush(struct mem_cgroup *memcg) > +{ > + cgroup_rstat_flush(memcg->css.cgroup); if(memcg =3D=3D root_mem_cgroup) atomic_set(&stats_flush_threshold, 0); > +} > + > /* > * do_unified_stats_flush - do a unified flush of memory cgroup statisti= cs > * > @@ -656,7 +667,7 @@ static void do_unified_stats_flush(void) > =20 > WRITE_ONCE(flush_next_time, jiffies_64 + 2*FLUSH_TIME); > =20 > - cgroup_rstat_flush(root_mem_cgroup->css.cgroup); > + do_stats_flush(root_mem_cgroup); > =20 - atomic_set(&stats_flush_threshold, 0); > atomic_set(&stats_flush_ongoing, 0); You may reset stats_flush_threshold to save the unified flushers some work. Michal --nkqic6iypcnygsam Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZOSxiwAKCRAGvrMr/1gc jm71AQCt7WNfujH/Pjh8YjVKcytjG329tBz6ofp30cTENZIrxQD7BQe9CMXaQ46H Ryr2cNLw9Zi0Z5DRW4nF1r5TaJyJ3Ac= =k+uV -----END PGP SIGNATURE----- --nkqic6iypcnygsam--