From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3A8DC0219D for ; Thu, 13 Feb 2025 08:22:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 445D3280001; Thu, 13 Feb 2025 03:22:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F5956B008A; Thu, 13 Feb 2025 03:22:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 297A7280001; Thu, 13 Feb 2025 03:22:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 09DA26B0085 for ; Thu, 13 Feb 2025 03:22:30 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9811F46E92 for ; Thu, 13 Feb 2025 08:22:29 +0000 (UTC) X-FDA: 83114229618.24.9B2EEC5 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf12.hostedemail.com (Postfix) with ESMTP id 9C87340003 for ; Thu, 13 Feb 2025 08:22:27 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=EfO1wk8G; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf12.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739434947; a=rsa-sha256; cv=none; b=tK7O3kzePYGN6SKvo/iOmRxDsjVLy0bkNZwI5ugzlTYQ6ecVhkaLFHT0Qk6CR4Trrq77y9 ViJ662ubcHt9Fy7Uk4A350wGaJoANvG81Dznm+szVIM+a5Yvcrm2D8H8mXClr31GpKgVh0 39cS2LTwviDa6xBWI9kydxF/3bB+Alc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=EfO1wk8G; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf12.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739434947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=el37H95Ti0G7XNGLIK1QP9vWYFy2OzwJJ+Ft/L8FLdE=; b=HHHbyoWL0kLA+9hlwTPSRxYP9p2AEOUYf2Gw8iERF78VP4S8iEiQ4cDfvjL8X1bOVzuedY 8/HpS5leAu1XahQI7dIAEsU7D8ytOvCdilM1mDoWKt7Ru92BNyl3FsMQVkvno6v+n+184h 2ajgz9AGrzGmLrOUW6ZjXA137dej0Uc= Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-21f48ebaadfso10986655ad.2 for ; Thu, 13 Feb 2025 00:22:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1739434946; x=1740039746; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=el37H95Ti0G7XNGLIK1QP9vWYFy2OzwJJ+Ft/L8FLdE=; b=EfO1wk8GDyZyVv81Tk6pUrxVnZwWYPeiiDO9d4do0df+c5ErwszEQPIQ/vHqjifDlx 7ABjn1eAfPLLdIni1WS9nhSTP0ZFR3OHhAs+IePeYX15OVmFH8JAdtd8nG5BIOLyPVfi x5cB2qTFQG0t02AEdb6hBmSx/qSQQae65VL7k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739434946; x=1740039746; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=el37H95Ti0G7XNGLIK1QP9vWYFy2OzwJJ+Ft/L8FLdE=; b=FO8EbwvNHH1DsDyW0/r6O3vTu8jWP+bNSbeX3Fny8k/dkRmIIkkvxKhuu5UO2M+0Jo ROeSgM/1UASFavdxrwM28pvuj544iywrNEJfn0SxygVePXVPoBja29pe/utEj3xpqEGr RBpxieFdo5fdN5bc9b5RyQykfiRMch3cxEeRnRpLINvTyluTFnZ87vZAnLnYDpVU8ScR vJnT6aUA2lbQ/mxllheDNakVyH3KHbujVWsOQRxH3y0J3MVDOQvv5GHBAQ2e2H4yCT/p agK4C5H/ro66i0bRzkF8PXjT11VZNlYKdTseceM2ShuZIL8pTMXG5haO3jVEx/vXgA5x q/Ng== X-Forwarded-Encrypted: i=1; AJvYcCWk9fDz592GWpkCcQ295PUCHQWuFOH3HquKK2ur7lZscIQqL8QSvUupxoVJjgAq15rUzkjywzxpaA==@kvack.org X-Gm-Message-State: AOJu0YwszQF9aI8QxFKNJW5GDm+zCznCJ5EwryNOFQ9b5aEMT1mn2R/p pWMzxspTBK17UkxrdiZYN2G5IpJnuLmVkaVPr0ZsPV5t3AagGJ0DFubARxpcYw== X-Gm-Gg: ASbGncusuOsUdaBm7fp+2Kfx726tvv0d/y9oFNvyQ9kwyurM7Js65Q+iI3qDw0r5PKz GNEmE3d/C4YrW7Ex5jaA8G1VKemgkqLG3A1JB6SFhGmBxiLZuwRXlRrP5aj5bPs7PfbmpPIkoAt 1TOegN52CDCWzF8Zw7mkl7oB9qkkFqeWSX3hWM/Y5jKPqZlljGtdwPyIK6J8LwGTXFdeZA+1Wrk YOWeRPQP+JdBIeRmxH+jTm5JgLKynwUpnJzJosoouJBSD95EEBG06UQeSmVcP0FbdMAkEDf4v9O 1c5XjK/n3ZoILpVigoo= X-Google-Smtp-Source: AGHT+IGMCaQ7jEqGYb/dNVjb8sIoODFN2dM+ydbX1/RuoKXY9x64CCsWG6ItNnsUtcKBOcrmjFKtew== X-Received: by 2002:a05:6a00:cd2:b0:730:9801:d3e2 with SMTP id d2e1a72fcca58-7322c380e4bmr625117b3a.8.1739434946381; Thu, 13 Feb 2025 00:22:26 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:3ed3:97ce:5f5f:1f61]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73242568af8sm723384b3a.48.2025.02.13.00.22.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2025 00:22:25 -0800 (PST) Date: Thu, 13 Feb 2025 17:22:20 +0900 From: Sergey Senozhatsky To: Yosry Ahmed Cc: Andrew Morton , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kairui Song , Sergey Senozhatsky Subject: Re: [PATCHv4 14/17] zsmalloc: make zspage lock preemptible Message-ID: References: <6uhsj4bckhursiblkxe54azfgyqal6tq2de3lpkxw6omkised6@uylodcjruuei> <25268fbedb82a06ba0c13e2c490b164846ef508b@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 9C87340003 X-Rspamd-Server: rspam12 X-Stat-Signature: og8at3bkmyhm85eqicwdcnkndh7nszi6 X-HE-Tag: 1739434947-95744 X-HE-Meta: U2FsdGVkX19FBywQm6dWsKBKWlF1bMNOkiSJk3s0uY0zdij0dwY4+8mHKex/b3QEirXHOtTJtn065QiJr/s6hOsc4UdswI5zp0tp/7h/qDWGdVdWEhqloWOZ6Gh1af3/4u1FIC4qb2pLGKWd/vOQOm+UzDlckXFH54mB+AhqKZAD9Xor9J+z4hs8j9GOY5jN0D8KIblN16qW3hzKoLbYEFvp/5330NwyjQPrCr8z3J3DXCTDA7GzTB68/pymTsqo1kwnFSUiPt2bO4duNDfL6vEiKgjhebGCoyNR7fIPbpN1vIvjuVCqmXBW/D6oWLJBGShrirr+MLqR2+zGDlidKXsopKAp1TpBgKcqm5ySRrJPMUuD/Vq5ZCN4YLpDKXSWGe7NDoWou5bjV0bOQCj5ZXlC9r3eTVATMjj/pDpP/gfsoYdphhS6rlESQ+O37OuBHnKmBCvvSm/q/t8DiYi/7ixKBCoK8s2rmG2CSzRngM1/U/DbQYr5rL2LrIRUkxGZgKOxSPlMokpE+FTJKYSYIZeZC7s8iSuekDvIjOZRegpCQv5z3PJxPw8ZZqZq/manO2isMLrOLQSNIss/qCivFwbXCh2HtHE8FHt5QWXU9e1MRQxFtHobCYLILupTZVW2sYzxQPhsJFoTuEOv14YqDdtP5LzwJqzogdqnKf0j4yG7v4uJ3Ci9zUkPBpmrY83fzC2t4avQe+5KzAwyHsFDYRPl3awScaATgDwOzceEqKZ88VNH1624axpmjZR5NHFOg0QUXYD98BJiOdjAWKZqYb9mksxHyGjP6joYNjUqfAAqoAcjE1il5/KnHanaOLVw6uCkGvT8dYFj45cwO03yRgJ4eAopmO0Nn/xYG+ptohUXisnCd+JO11mnXf2tklovqCQJMLwzYSjnP3DlLTSMhsCMgNJMSk8NzPiC71gS+fZQ6K2ZhqUn6XzRxj3Cz/zlS85DtxzK+WaXQoORdMh 9m97pkrF w6eGCL1puJ5TtGTBHhwfrcmWq8GMeYgoVeGp2sQinOQb3HiAzXjKbYAomuxDuj+iEcjoIXMwiRHvLeJ745xY7GrdqulqVn9Ed3TjLu82/PdypJ5yGATIbY1UU2DHCAXr9W8joCKTx1HRZSwx5F+kH0jsgliu3dufnHDkCyzifwqQMZXNv2LZpyWLoDUKxmDNSQgAyJNT80Dt9Md5lK5lWO3caUuCUAI75r4lsVvE8x0w5AvjTTofVD+r0ovu007SMi7+AjZH66gqhQ/IbC27LO66O9Nt7sRvUAdQ2dpALb9U/L+Jqu7hJwDwelzTWF+xxLi20f1wzmVeRLP5aH4vEU7zpPSYDVh/91h1hMr3Eb+vL+V4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.249916, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/02/13 16:21), Sergey Senozhatsky wrote: > BASE > ==== > > 1363.64user 157.08system 1:30.89elapsed 1673%CPU (0avgtext+0avgdata 825692maxresident)k > > lock stats > > class name con-bounces contentions waittime-min waittime-max waittime-total waittime-avg acq-bounces acquisitions holdtime-min holdtime-max holdtime-total holdtime-avg > &pool->migrate_lock-R: 0 0 0.00 0.00 0.00 0.00 10001 702081 0.14 104.74 125571.64 0.18 > &class->lock: 1 1 0.25 0.25 0.25 0.25 6320 840542 0.06 809.72 191214.87 0.23 > &zspage->lock-R: 0 0 0.00 0.00 0.00 0.00 6452 664129 0.12 660.24 201888.61 0.30 > &zram->table[index].lock: 0 0 0.00 0.00 0.00 0.00 1716362 3096466 0.07 811.10 365551.24 0.12 > &zstrm->lock: 0 0 0.00 0.00 0.00 0.00 0 664129 1.68 1004.80 14853571.32 22.37 > > PATCHED > ======= > > 1366.50user 154.89system 1:30.33elapsed 1684%CPU (0avgtext+0avgdata 825692maxresident)k > > lock stats > > class name con-bounces contentions waittime-min waittime-max waittime-total waittime-avg acq-bounces acquisitions holdtime-min holdtime-max holdtime-total holdtime-avg > &pool->lock#3-R: 0 0 0.00 0.00 0.00 0.00 3648 701979 0.12 44.09 107333.02 0.15 > &class->lock: 0 0 0.00 0.00 0.00 0.00 5038 840434 0.06 1245.90 211814.60 0.25 > zsmalloc-page-R: 0 0 0.00 0.00 0.00 0.00 0 664078 0.05 699.35 236641.75 0.36 > zram-entry->lock: 0 0 0.00 0.00 0.00 0.00 0 3098328 0.06 2987.02 313339.11 0.10 > &per_cpu_ptr(comp->stream, cpu)->lock: 0 0 0.00 0.00 0.00 0.00 23 664078 1.77 7071.30 14838397.61 22.34 So... I added lock-stat handling to zspage->lock and to zram (in zram it's only trylock that we can track, but it doesn't really bother me). I also renamed zsmalloc-page-R to old zspage->lock-R and zram-entry->lock to old zram->table[index].lock, just in case if anyone cares. Now bounces stats for zspage->lock and zram->table[index].lock look pretty much like in BASE case. PATCHED ======= class name con-bounces contentions waittime-min waittime-max waittime-total waittime-avg acq-bounces acquisitions holdtime-min holdtime-max holdtime-total holdtime-avg &pool->lock#3-R: 0 0 0.00 0.00 0.00 0.00 2702 703841 0.22 873.90 197110.49 0.28 &class->lock: 0 0 0.00 0.00 0.00 0.00 4590 842336 0.10 3329.63 256595.70 0.30 zspage->lock-R: 0 0 0.00 0.00 0.00 0.00 4750 665011 0.08 3360.60 258402.21 0.39 zram->table[index].lock: 0 0 0.00 0.00 0.00 0.00 1722291 3099346 0.12 6943.09 721282.34 0.23 &per_cpu_ptr(comp->stream, cpu)->lock: 0 0 0.00 0.00 0.00 0.00 23 665011 2.84 7062.18 14896206.16 22.40