From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4936AC0218D for ; Wed, 29 Jan 2025 19:22:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABFC5280089; Wed, 29 Jan 2025 14:22:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A6FFD280087; Wed, 29 Jan 2025 14:22:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93755280089; Wed, 29 Jan 2025 14:22:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 76AD1280087 for ; Wed, 29 Jan 2025 14:22:42 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 01A4A12029B for ; Wed, 29 Jan 2025 19:22:41 +0000 (UTC) X-FDA: 83061461364.09.8237044 Received: from out-175.mta0.migadu.com (out-175.mta0.migadu.com [91.218.175.175]) by imf19.hostedemail.com (Postfix) with ESMTP id 3186C1A000C for ; Wed, 29 Jan 2025 19:22:39 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=h94XJfV9; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf19.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738178560; a=rsa-sha256; cv=none; b=ycxpL2Z5IELc/iX3yHl4cq0cBikJSbMk7goTyPHxhPEsT9yXd8w+9mk+AK5QIXvWMig4Xo f5otlfKm4qq6PwCmNRuDAA5ilLb+fD4+tkYM9ffB1Jhd6bPur8TMDFBuNsKrJMZy5GmfvM aAiFca7Z2E02BzO/l+scO/VNLYNbwjo= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=h94XJfV9; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf19.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738178560; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xHx7NUaKl67feMKL1c6LfNBNfIUnKeNxzwJaogB1wFw=; b=bF/h/0GCJZWKZJIGz5yVzVfH9lEUiiqnZHftWNknEeY74mS0GLa7RaUzJHE+miALGVkL+7 aZeiIAshq+HJWv+I9hGUt5YmmHMx/4vehQ/z7yjB9dETA93h4Hbyz76x18jFoUS7eyJTUC Nxxs4OKZElWqnL4ARekArP2GW3o6aqs= Date: Wed, 29 Jan 2025 11:22:29 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1738178553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xHx7NUaKl67feMKL1c6LfNBNfIUnKeNxzwJaogB1wFw=; b=h94XJfV9I/IQc8jD6BPy6IsmxjCrGQFtDn9MmwA5GpWBsvkNsUWrknHYHVOpT7SR/YrP3T 7VgX2Xqd77DjqpM4MlbqncRg/dks4RBjM0ZLGg7Tm9XGbNm3mTEC4uBpaM0iwL4notCCS7 2ybVSVyF8LwDymRABki/nhtBqx7SlD8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: SeongJae Park Cc: "Liam R. Howlett" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v2 0/4] mm/madvise: remove redundant mmap_lock operations from process_madvise() Message-ID: References: <20250117013058.1843-1-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250117013058.1843-1-sj@kernel.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3186C1A000C X-Stat-Signature: byfpfwr7dqp1igybai9t7xc9oixucp85 X-Rspam-User: X-HE-Tag: 1738178559-706496 X-HE-Meta: U2FsdGVkX19LKXeufjvar7pvMJMo2LpxYW7Z4E+UKQXiWronxbbBdlbE8NYpNYQBoE97ZOOk7XQkQlP6/GLKZ2pvOEGJdw28m9zKnjNCp1Q/7I29r8hsB9RchEVl9pgyx2KUHcLGl7q+nTU+Cx6PS5odyyl6VRoXD0ApRuZsMHmzPSqJdS7gCwKmzBhlnnPGtdLf1w+nW1UuGacN2+1MweWLdE5KORSFZ32570PTP/od+SMcvYA/3dfTQZRcu56385wexMpa/oNcNW4rbqFs8usR9sxO6OSu6pn2+Zhl3vqsEAGwpkcoFEogHy+xtNYcgcthSz9+lVvCiDf+N+kDib50pJ0j0DrToJ/Yq4bHjxgl/eJtAfWRPpI3ctGhQPAS21ArF6letI3nmC4EZFIUWVgbhVm1O7JWoHVtSgTYJ2M5crMQ1IxsfsF/Ts6TkTiEsdZNQvoHzbPzIwNb6z4ZnS7gM7RuaWfkowiNMHqr8OE6kA8427NnDLBYcW+wYfAwacWOSZ38j6RCH9Pi8vXSh64nK8WKk9QciHO3/xKD2HEW/qOPZbDzp5gfa74yoVPDFaqUeJ6ZahdmtuRK+uCyUe3yDHpsgSbokiQAOO8DtRGUg4bHnN/ehibBxKypr3imuZ8fsLZMe4LU0j/Gj7TdIR6/bfFP5KzBVB59+FbuQsoMcut96sfYLwA7yBFGgLshg8/vh7NhHLrUPzkic5NA3VBFt+Oo9l8AU35a9Ra840UlDozYmYdgNVirHaZJFEOh1hxQeAnn7vG9JGA+qiYNMWHO0SFmsAlat5Qlec6JovT3+IaA1+v19s9XpNXLpmnTdbrHjKxmS6CQaPMyVNWuOGwxNFxnWhPf36tnB1yNc91mp9lpEXbw7Ox5YR2lfqiMcodRkUDE1092eaYNqOnFCMqRcq0QJMocj6cid3yTnBJngNdqjXj7VjVRIQgV/eBP655VwnkqSUWvGeiSJd/ BVSxvfDs Ecs8ifUmC3sjueyWCnVjo64skdyklQ7/kAjxOLhYZ8mCWv+6D0Rn3G7foVERTmSERkC2ono7ZIZNFmJJMKlUonhvLIZ+ATYzIzf68/UIqnX0+p2+POfziJrC5gKyJZ/G+7vGaVnana6WelweleDjvam3uF15Ql+w3DeVIrRFcbY88mdIDB8WHvFnU7ZSBJo8UbuRX0EKDMs5Vqe/Slrj+bOEC6dlpX2NmvdzsdP3oI9z4GBS1t8FdZhuKkfcB/MOSbY46 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 16, 2025 at 05:30:54PM -0800, SeongJae Park wrote: > process_madvise() calls do_madvise() for each address range. Then, each > do_madvise() invocation holds and releases same mmap_lock. Optimize the > redundant lock operations by splitting do_madvise() internal logics > including the mmap_lock operations, and calling the small logics > directly from process_madvise() in a sequence that removes the redundant > locking. > You skipped the evaluation section which was present in the v1. If you decide to post a new version, please include that otherwise we can ask Andrew to pickup the evaluation section from the v1 [1]. [1] https://lore.kernel.org/all/20250111004618.1566-1-sj@kernel.org/