From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FEC0C27C4F for ; Tue, 18 Jun 2024 21:45:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 643866B0351; Tue, 18 Jun 2024 17:45:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F4556B0352; Tue, 18 Jun 2024 17:45:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BB926B0353; Tue, 18 Jun 2024 17:45:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2C2BF6B0351 for ; Tue, 18 Jun 2024 17:45:01 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C07AA80B27 for ; Tue, 18 Jun 2024 21:45:00 +0000 (UTC) X-FDA: 82245339960.26.815D140 Received: from out-181.mta0.migadu.com (out-181.mta0.migadu.com [91.218.175.181]) by imf06.hostedemail.com (Postfix) with ESMTP id 2235218000C for ; Tue, 18 Jun 2024 21:44:56 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vz7l7V0c; spf=pass (imf06.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.181 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718747093; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sl3r7qFXSTfIPLR6mrssV5UaH6X9IXUMqBHU7WeHJiA=; b=Iv191W8NdTORfcPq6dHivePPH+0POH/SqmdUHPrRJ4758A48MATfdly5LEbvyeu/gDwl8s jK6SawB19AGWCoZP6msEvg2M4AvuTo12K0Y6y5elicjfbMkGp/svlIHe0ri48pa9OdYhi7 DQNxZ+1rphEp16Ap5D5Ol2v13M/4Z44= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vz7l7V0c; spf=pass (imf06.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.181 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718747093; a=rsa-sha256; cv=none; b=ZAxfro36N5ZplOQ6o3fUS9fFtkLE37I20l3jnjS7HWcWQVzj0kW09+79zg8s0xpx0CCXOW ZQTF9eGP38OhtKJTkL6zaCt8HnnZ1OyAcm1Fu4nJFVt36eFlsX1tVcTAknMNjL0vNTlvso e/T5NTpUE6SxgOZFX9m/WYnOocvHg4w= X-Envelope-To: torvalds@linux-foundation.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1718747095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sl3r7qFXSTfIPLR6mrssV5UaH6X9IXUMqBHU7WeHJiA=; b=vz7l7V0cdcctJxk18BaT07puv2bpFnkpUzjI8VF23NSsUxJIADWGEbrhzaU1rwqRhcVD4U ib04qbRyhfEIIGF43Q98gfZNJfgfnh1Xn/R5eUQkIQrOxRsMAuxNWxJqLIqT5MSKooNCF3 CL8wvyat2gK4h/VlaebogM3Wfu9DUk8= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: kernel-team@meta.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: kyle@infradead.org Date: Tue, 18 Jun 2024 14:44:50 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Linus Torvalds Cc: Andrew Morton , Michal Hocko , kernel-team@meta.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kyle McMartin Subject: Re: [PATCH] mm: ratelimit oversized kvmalloc warnings instead of once Message-ID: References: <20240618213421.282381-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 2235218000C X-Stat-Signature: if9rbdidbbsqern1kws4whg5pnjorpcf X-Rspam-User: X-HE-Tag: 1718747096-828489 X-HE-Meta: U2FsdGVkX19hT3dyKE4z2HQw3tcacfrZbf3fax1K5TCIT7nMUmrITXpQ6zhBqtmy5K2GtmJFDihXTa9QxOVlVhcShaJ3AR7YAN4EIelZaJWmbHUyFgwjXFx5/TH+tVW9fRm03S4wWUnI0jmW3iuyzLYVmiL4REq7Co6OCSVfam6Xzio3So2NAJPcsPixLHdDx7dqkc35qnRvHEqwAH4eI8ENSDMz2SpMCIK9h0c+AK6wkSSs+Adkxio2i2ifLQ/EcK3sxjxBVlZDoeIGukJaJBDQXE9K/Uvx6gBeyXuJy+98CASoAN7WgkEP9gRc7dcsMdusmOnSnT6w9eLdjE57x/7qKGegZpAqcOiGocPKqFDogjXAO4SMuysfJQLKrVqls0C4KksYduuPTnCXyo5NokbmRTq2wcwkXT9LXtGEgp4NGODiFzfDmkQ8b38gRtZ4XdaEOW+VcTSeKXO5yfQGO1L6HPlqph7V5+nBq/A19c326gExr19cJOfElpNRzytprBTbAyjxcrNZ7AFVK8rC+sBf4uHnLjFXjomShG8xM1c/ciQCWKhh1fwlShS3L01d/XBSeUR6WriFIj4SYP697HalyJj8PRbl1igjbDGlUNU96HpOXb3JhQZ4rcoNHh+2DL0ezDFL/741Hp/Ib0xMSfShJtH8v0Z5Gx8DRR6oEEAYra7SwsgmvkscRSrAHWCI+jJSMrPm8aN/4RQ+NhrRsVfzj8Hu5R4TfXn0XBm55EAWMAS2jmzlLqOgGUKhXpFtTP7LJEWSZi/WgRzU8y82HqWevyDfyVd6QUtjer+6qeXBFiFJgfrDnUqU0kgl1uKNLVj7FxQNt9JdxqgJ+aGyPN7qI/LHM/T14vTu2bF0Fvueja7wRFVXIOVXDKiV7hVn5Ub81xq/jCWFvvZ8UJIn7yR+EeSaMxd8SdJTFV/SoBYd2x44ZukdluYOp4jFSnW4u6lBIG+Xx8JI4hqwE6K F7qmRN92 pmaNPlgShaP4Nitn3HUERt99/TSZ5fOpp4dqyNhmwocVXiDijBJ3wOdrMSCdvwwOkXHTTzIZYEHerbWQVs7bIzxJU+MROAdrAq+rA6VyynoaD6RYlyZNCiiXxbg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 18, 2024 at 02:40:10PM GMT, Linus Torvalds wrote: > On Tue, 18 Jun 2024 at 14:34, Shakeel Butt wrote: > > > > Simply replace WARN_ON_ONCE with WARN_RATELIMIT. > > NAK. > > Sadly, the RATELIMIT cases are useless. > > The normal rate limiting is basically "burst of up to ten, every five seconds". > > That's going to completely swamp things and hide any other issue. > > If we ratelimit it to "at most 1 per hour", maybe something like that > would be acceptable. "at most 1 per hour" sounds good. > > But honestly, I do not understand your "first abuser only" complaint. > There should not be *any* abusers. So just fix that first one already. > > If you have more than one, you have bigger issues. So what is the real > reason for this broken patch? Why didn't you fix the first one? > The issue is the turnaround time to fix the first abuser and deploy the fixed kernel to big enough fleet to find the remaining abusers. Usually this turnaround time is in months.