From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CABDEC25B74 for ; Thu, 30 May 2024 20:05:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 623606B00A1; Thu, 30 May 2024 16:05:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D3266B00A2; Thu, 30 May 2024 16:05:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49A986B00A3; Thu, 30 May 2024 16:05:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2BAD46B00A1 for ; Thu, 30 May 2024 16:05:24 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B65CC160CB4 for ; Thu, 30 May 2024 20:05:23 +0000 (UTC) X-FDA: 82176141726.09.B165D26 Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) by imf07.hostedemail.com (Postfix) with ESMTP id 14C6E40008 for ; Thu, 30 May 2024 20:05:18 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CFML5l7C; spf=pass (imf07.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717099521; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YpFa3Bx0Tf5ODURqiaCwQwbuuk80x2jm9JeNzuE+FHQ=; b=RWEwrEQnR9X8CATotjnUNV2ICzG70g+J3fTQ5COcIx0S7BXYpGmdHgRNY3HVF09C3CXVV2 xH3ehvigffMAf2KIJ2WOOmFwKyuaKvGxnHHehL5RXKRnD/W6hszNy5Wfrxn/nsXl1JMnQj LC+vr1S1nxFra/OWwf8fBI/fx8M99a4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717099521; a=rsa-sha256; cv=none; b=Scn35lw8iEfUlWvux2icdcsOr/wm89UrNnjiLf3bsFZqWGSr8kXa0IWPkOfKjHgDicUZ/c cn53/G9r0Wc4BfYsGaQ/oPSX2NBRuJ55BA4Ur1r6cBo4tC88sT15Xsrpplasn/keqms4bR Vfe8sMAEDvBTwJAf4tZatWIz79hWS6o= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=CFML5l7C; spf=pass (imf07.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Envelope-To: josef@toxicpanda.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717099516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YpFa3Bx0Tf5ODURqiaCwQwbuuk80x2jm9JeNzuE+FHQ=; b=CFML5l7CVOz1FXmbeETe96hrRrhe/PJtIKJsSTChVh39w4jduf8c/47tK1+T73RK0dv2wx SEgPlBbaXiqxTEoMNxn1LGta3shETyBcQHP5W8ke/pxY+c6XWvNgJE1sAmJPzG87v3hOZN KxS7ZI1aS1ORKvOITQKMETs+oHdI5yc= X-Envelope-To: bernd.schubert@fastmail.fm X-Envelope-To: bschubert@ddn.com X-Envelope-To: miklos@szeredi.hu X-Envelope-To: amir73il@gmail.com X-Envelope-To: linux-fsdevel@vger.kernel.org X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: mingo@redhat.com X-Envelope-To: peterz@infradead.org X-Envelope-To: avagin@google.com X-Envelope-To: io-uring@vger.kernel.org X-Envelope-To: axboe@kernel.dk X-Envelope-To: ming.lei@redhat.com X-Envelope-To: asml.silence@gmail.com Date: Thu, 30 May 2024 16:05:12 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Josef Bacik Cc: Bernd Schubert , Bernd Schubert , Miklos Szeredi , Amir Goldstein , linux-fsdevel@vger.kernel.org, Andrew Morton , linux-mm@kvack.org, Ingo Molnar , Peter Zijlstra , Andrei Vagin , io-uring@vger.kernel.org, Jens Axboe , Ming Lei , Pavel Begunkov Subject: Re: [PATCH RFC v2 00/19] fuse: fuse-over-io-uring Message-ID: References: <20240529-fuse-uring-for-6-9-rfc2-out-v1-0-d149476b1d65@ddn.com> <5mimjjxul2sc2g7x6pttnit46pbw3astwj2giqfr4xayp63el2@fb5bgtiavwgv> <8c3548a9-3b15-49c4-9e38-68d81433144a@fastmail.fm> <20240530190941.GA2210558@perftesting> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240530190941.GA2210558@perftesting> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 14C6E40008 X-Rspam-User: X-Stat-Signature: j7e75qu9kjjek76u793unrh18xjoxciz X-HE-Tag: 1717099518-449158 X-HE-Meta: U2FsdGVkX1+zqjWQdoaW+n7tE4QSBaFIidyboQibD8JSEUdSZ0e7MG/gcDlI14hj+8vK9yLYlpL0i0YyFI1VOVtgdDtzx3pA4qfEaSoyCCyuEIjFxV5OXv6E62PGmc83xHrq7SuhKlnW66bFqkfMdl66E+kiO83vr+w4YwJ9eQMMAvJyqs5ViUX4t+rJhbLnDB8AR8YgQ/KgF9keo+9dEPB/mo3LVy7Jc7v3jmzB1EyVBtPmJc1/a2Wdv8joCmA8itPHmBTaFh0V4S2Crvi476QMAYJocd/1RoFL8ABTTQbhIL71R+wjgkF23hU+/5sJKl1oQHvGQjJwpUAM1KB6aPaQ1dB4zHivuLlIbUOFqXKlIWVASJU4amxFoYwAd98c9z3OFZZHiafXv/0UBMeQ29l2bgildfcBnvwTMT2d+IwpolhbN3KtdbgDp75FYNt0e0aZ9sjtnFsT89VK4nqIw8S1bbX5wOWAb59OxMIvqxyewILiT7ri4Mgf2V/6KRxriEEvomijf1acJt4rLS8rCEfyfadPAPBbH7SzfCpVe8pkuNKuheEpj3J7iDxw+aRu52rYHNLt0GXJpa1a9uqo4l0y5fIIoowjtEMWLlzqtsLOaN+WfhA85S3YittJpKLr3zoadKabMoTaOslI93BV6cyzyLuYadFXpmV1HJ8MSfkiAabXhU9x4B8Rn31TvOHXrnkjrX56Yc1qAuzAJuxeMV/AnV0S8cN3EJnPlqq8nJjc411jE5JffNKAvsd4fOv1ypkLCbhS7pRmmX0vVWdP8JxUHUg/SeirYg8eLl9kwKjBsoDF/LE/RKee+QsRK5UwFD+bMrOTNE14i3A35hvCkv5p28tCsy3ulFmHwt+5bCnYfam4ch3tV1JD5Q7qK4qHEBaNEgrF0xHdVjPEp/OyN+laVHVpFbcZKBOHl4KYKcGaT71dw1FNFT4MD1nZ0e6zoIWI4pvuWOVb4/PO83P G+fnv+qX YQ6CHUnrV3thOALvAet6bihoiUt0xSASJCJrWLCTa77UFcV9l2R2LFStHhU1J3QGHm6bVIvmSRqCbzN4I+cwYnDrGd/ZKkxLHaOcYkZEFxTX1yDbTYKIZQr4oS8V+Z4x9CqKpD4TDUctRO/U7dbQ8UHaPkwCnbBzx2rJ+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 30, 2024 at 03:09:41PM -0400, Josef Bacik wrote: > On Thu, May 30, 2024 at 06:17:29PM +0200, Bernd Schubert wrote: > > > > > > On 5/30/24 18:10, Kent Overstreet wrote: > > > On Thu, May 30, 2024 at 06:02:21PM +0200, Bernd Schubert wrote: > > >> Hmm, initially I had thought about writing my own ring buffer, but then > > >> io-uring got IORING_OP_URING_CMD, which seems to have exactly what we > > >> need? From interface point of view, io-uring seems easy to use here, > > >> has everything we need and kind of the same thing is used for ublk - > > >> what speaks against io-uring? And what other suggestion do you have? > > >> > > >> I guess the same concern would also apply to ublk_drv. > > >> > > >> Well, decoupling from io-uring might help to get for zero-copy, as there > > >> doesn't seem to be an agreement with Mings approaches (sorry I'm only > > >> silently following for now). > > >> > > >> From our side, a customer has pointed out security concerns for io-uring. > > >> My thinking so far was to implemented the required io-uring pieces into > > >> an module and access it with ioctls... Which would also allow to > > >> backport it to RHEL8/RHEL9. > > > > > > Well, I've been starting to sketch out a ringbuffer() syscall, which > > > would work on any (supported) file descriptor and give you a ringbuffer > > > for reading or writing (or call it twice for both). > > > > > > That seems to be what fuse really wants, no? You're already using a file > > > descriptor and your own RPC format, you just want a faster > > > communications channel. > > > > Fine with me, if you have something better/simpler with less security > > concerns - why not. We just need a community agreement on that. > > > > Do you have something I could look at? > > FWIW I have no strong feelings between using iouring vs any other ringbuffer > mechanism we come up with in the future. > > That being said iouring is here now, is proven to work, and these are good > performance improvements. If in the future something else comes along that > gives us better performance then absolutely we should explore adding that > functionality. But this solves the problem today, and I need the problem solved > yesterday, so continuing with this patchset is very much a worthwhile > investment, one that I'm very happy you're tackling Bernd instead of me ;). > Thanks, I suspect a ringbuffer syscall will actually be simpler than switching to io_uring. Let me see if I can cook something up quickly - there's no rocket science here and this all stuff we've done before so it shouldn't take too long (famous last works...)