From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68D7EC83F09 for ; Wed, 9 Jul 2025 09:31:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B38946B00AD; Wed, 9 Jul 2025 05:31:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC26E6B00AF; Wed, 9 Jul 2025 05:31:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 989F06B00BA; Wed, 9 Jul 2025 05:31:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7E6A46B00AD for ; Wed, 9 Jul 2025 05:31:23 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F2D72B4D26 for ; Wed, 9 Jul 2025 09:31:22 +0000 (UTC) X-FDA: 83644208004.22.093D270 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf11.hostedemail.com (Postfix) with ESMTP id 4691340004 for ; Wed, 9 Jul 2025 09:31:20 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Vq91mazs; spf=none (imf11.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.198.163.11) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752053480; a=rsa-sha256; cv=none; b=w3CAxOgzGMolkBJKGyRFQd2PeyyMtiAWlAs5HqB5Ko/+nJS6vwKIZRo1CvDqLT0Kafp8rM WsnCUh91Le/5vkmXoigD+8sUxEzeUDMHY/uHSyDnTLyMLn5Il8Awy6sF6JZwg2Cz4dvve2 RpdeXDZThKdAHcq6FTK4Muell3cL4T8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752053480; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E/sdjC/6pPRN7IsU9E/BlApZdndVVNsB493xGYqxq8Q=; b=cuj5Xq+ldHs2IfjPMzXhpIviWXxSTHQ9AAIpcnHxUG+ES3H5PV+y/LuV1Cs5aop7KeiTcc SGqJMMscYjWye/OJtobOYoVOf5FPShuKMw17GJ5wUgzaTnM0I4FDk3MbEYWqKKO+/DFg6U 0mJFBGZgKvevva88z8ImWpgT5kZteB0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Vq91mazs; spf=none (imf11.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.198.163.11) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1752053480; x=1783589480; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7doOlnxD9JaiUSo7LiM2on6/rPenpaNcpZ5d8eKOqco=; b=Vq91mazsmCAdbqgUD070VE9gJmip0ZfbF+JNzImJFw9ZDlTLC23ov6jx 0wHuaNPgQc7txmwYPJsS0TrY+gYQOg5JTLPDmavtvWLaeKLKiWvKb4SY9 or0MM6laHv6BtsVgX8K4sFhUrS6A4mUmHvdb5j68IsMWVUgluVK5v5cQ3 UubxiuYTaOd7edBzyjyF2/NF8toIsXJrgmsnQmvkJF1auEP80bX/5MrXK 8QKnTfL18SbZ5QF9AQEvTNouQG9miU2NZDSbWGAtXsd38/k+4haroRBNH ajuFF3ypPflRVnhofPye7mK6h4viWRrrhJAeC9Pr51OYjopTvGQ0btpS9 A==; X-CSE-ConnectionGUID: 4K9LklwWTyaWR0cgto6DiQ== X-CSE-MsgGUID: lVw+80ixRoaODl8l0JbAsw== X-IronPort-AV: E=McAfee;i="6800,10657,11487"; a="64890351" X-IronPort-AV: E=Sophos;i="6.16,298,1744095600"; d="scan'208";a="64890351" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2025 02:31:19 -0700 X-CSE-ConnectionGUID: dGiTkdOURO+ZzuWOXq9ziA== X-CSE-MsgGUID: hTsbpswkSJ2/o6uOxAgJ0w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,298,1744095600"; d="scan'208";a="155139190" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa010.jf.intel.com with ESMTP; 09 Jul 2025 02:31:06 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id 7F9331B7; Wed, 09 Jul 2025 12:31:04 +0300 (EEST) Date: Wed, 9 Jul 2025 12:31:04 +0300 From: "Kirill A. Shutemov" To: Sohil Mehta Cc: Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Ard Biesheuvel , "Paul E. McKenney" , Josh Poimboeuf , Xiongwei Song , Xin Li , "Mike Rapoport (IBM)" , Brijesh Singh , Michael Roth , Tony Luck , Alexey Kardashevskiy , Alexander Shishkin , Jonathan Corbet , Ingo Molnar , Pawan Gupta , Daniel Sneddon , Kai Huang , Sandipan Das , Breno Leitao , Rick Edgecombe , Alexei Starovoitov , Hou Tao , Juergen Gross , Vegard Nossum , Kees Cook , Eric Biggers , Jason Gunthorpe , "Masami Hiramatsu (Google)" , Andrew Morton , Luis Chamberlain , Yuntao Wang , Rasmus Villemoes , Christophe Leroy , Tejun Heo , Changbin Du , Huang Shijie , Geert Uytterhoeven , Namhyung Kim , Arnaldo Carvalho de Melo , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv9 11/16] x86/traps: Communicate a LASS violation in #GP message Message-ID: References: <20250707080317.3791624-1-kirill.shutemov@linux.intel.com> <20250707080317.3791624-12-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4691340004 X-Stat-Signature: 8qphinhskke74ak3kufind3s4fk3iuh6 X-HE-Tag: 1752053480-514851 X-HE-Meta: U2FsdGVkX19p7vccV9PPJ97SW6gsmmB9FPoqQjaAcrimxbMQDcjaCq5bamDxdRkT9Q2d55kGHfV2DgbqKTqfPLhswhpDmhOTCxJ0/wGbDXb6nrff1ycB7/Lzd5/VqZuVWmyAPEPoQbLsAufofKt/K9Tno4w93MLC33ACXluthRgT9bnwT1fW3RPXa3v9H1y7QtAFwj0+PIDM4D8PfFoZ7Qzk0z6EIYK87x9ASZIjXev4VkRAqMAO0xZvarhrj6YqUx2/OFWpb0CTK1pGpk4sNrGVgAN/M6nBcriT7wOkU/bpfUuL9cX6ujDOamiyndXnzzZXnegmRLWTjZv3xcS9tozC94YeJAU8sygVh5fwzJve33++lOXMsPb5WcGJt/AEHs6DpOwiLLeH5IraTqmM3HzbEvlGWsBHjrM/teYgzWeFmVORdKAptJR9V/BCned5TBEccYFeCxbFc8+atSna9zgRK00YXtHFuM2KKV8YODLMfY6WegSEyW5LxbpVicTE5+S2FIk9ul3A0W0lM+8du/oorJabrX8p/iRyq18JJAlxvp4lu3nQ+mVL2KP2/7pbX8PRtzStkfSJz0LzWdGhnXtV5fMRndbSh99KsYVOOwjDuhzAbdEWoly3xvB5bpidILs7fiY8jDZ0HlwjT0XZrnd0IYlD/yhXVfCsL5f3tfS8ALNIRvsSh4Hj7yTbK5Raq3Jzx9/rGU+giJ5pfOhaED6+RS5BPFsVUssAu+jUEM8Q3yXo7JdOP2wBF1FsPDZPH5WDPlcaLINmFkW0Y6Z3Tc18TWZOtt3VZsQCtDPDeFyAhUGrLUle8yk3xnYdetnpuM5jJURehnOBrAeMC3/PMkD6DrEp1j+GzAGdS/vRoGmkWHJ0exrwuBj4Vf+1y2Y5IZGNbfqMKP2b6LuWn1f/Rub38TM9bSn+Z5/89sYCuB6ZLGb888RefdbRQOI+l2Kwcv4YKTl1ZPgHgjrVfC3 wQv2g2tx E9fGnmmC5GpFImFFLxjxX0icJmCC8KQIeNyPSVdkiCP5i6WBFYSAiAc1H9B2GMcu6Yxc+EC2efeOwtPnHlAoinDVlnYRkiUfBOQ7nX+fr0ihcMPVmwj3oWGoaSmxD9V8qQkVH0fnJxjJWEsYaB1V6bPAyZdco8NmR4y7u1KpN2cwp4mcim5F4ywIivVS3MTyC9yV9mL+14UDfsju0Mu0IBCI7EysaYsqX9VvClcOC8L+P+vqUAJCtnJq9Vw9cVw2BuJlgNVidoqycfxA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 08, 2025 at 07:40:35PM -0700, Sohil Mehta wrote: > > @@ -664,14 +673,23 @@ static enum kernel_gp_hint get_kernel_gp_address(struct pt_regs *regs, > > return GP_NO_HINT; > > > > #ifdef CONFIG_X86_64 > > Might as well get rid of the #ifdef in C code, if possible. > > if (!IS_ENABLED(CONFIG_X86_64) > return GP_CANONICAL; > > or combine it with the next check. I tried this before. It triggers compiler error on 32-bit: arch/x86/kernel/traps.c:673:16: error: shift count >= width of type [-Werror,-Wshift-count-overflow] 673 | if (*addr >= ~__VIRTUAL_MASK) | ^~~~~~~~~~~~~~ __VIRTUAL_MASK is not usable on 32-bit configs. -- Kiryl Shutsemau / Kirill A. Shutemov