From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFE0BC021B3 for ; Fri, 21 Feb 2025 22:35:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7880C280014; Fri, 21 Feb 2025 17:35:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 70F4A280013; Fri, 21 Feb 2025 17:35:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AFD1280014; Fri, 21 Feb 2025 17:35:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3C9D8280013 for ; Fri, 21 Feb 2025 17:35:14 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 02E9D120878 for ; Fri, 21 Feb 2025 22:35:13 +0000 (UTC) X-FDA: 83145408948.28.D7CB6A5 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) by imf22.hostedemail.com (Postfix) with ESMTP id AAD49C0007 for ; Fri, 21 Feb 2025 22:35:10 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ZK41wm8Q; spf=pass (imf22.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740177312; a=rsa-sha256; cv=none; b=Fkh/WnIJbM7ffND3y1C1OVrtcLh569r7DzXoL4Nw+5JcWWS84yIj0O5OpyNqUjsKKxnjNT M7kwaVFKxybyZjjhXUJxPe6fwDNK8yE+oUYYfUey5SWq8jnC9Py2fAUcov06jGUFtxBqUe 7hUDztlz2RZQXptsRDIgoSr8kcHx3sc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ZK41wm8Q; spf=pass (imf22.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740177312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xs77vC/PVoARFTdf9n/vZqIqUAf3IrQqyMH7Gt+c4Dk=; b=2Ho3pt1a0LeruuWQ66yroFYXhHTS2GqspMF5Ap9c1iqx1ykr93O3mfjkYU4mxeJ6J81Tg7 /y886LOOiIeYGBXVdVxsw9oqcDjdYPe0FE0g0hkGnShWkJmL/5UY1J4AC7TV1mGSN69Hb4 pkhtd44dni9FWW96OhZqIJVXCM9cSdI= Date: Fri, 21 Feb 2025 14:35:02 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1740177306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xs77vC/PVoARFTdf9n/vZqIqUAf3IrQqyMH7Gt+c4Dk=; b=ZK41wm8Qf/wpKZKCYmE6bx6zefFTfuiHUs0BpXUaeMzjI3VmZ9dYzMhWXnixDbqKTQRnyC iDTIxb7E3h9veAt+IXeovgBu3WMVj1BHsiEzOq033FwtoM5qHMiIYQjFBLTfuvXzviB1Bq oiNjpSGryAZy7rcm9R/yIAyGTAFIJIQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: JP Kobryn Cc: tj@kernel.org, mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 07/11] cgroup: fetch cpu-specific lock in rstat cpu lock helpers Message-ID: References: <20250218031448.46951-1-inwardvessel@gmail.com> <20250218031448.46951-8-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250218031448.46951-8-inwardvessel@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: AAD49C0007 X-Stat-Signature: gw3otmkk8pcz9fgu39b7oubtzcsrsdar X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740177310-161979 X-HE-Meta: U2FsdGVkX190rShdanN77l+UQJKlqEb1q2j1fQh/zdkoxuhPtfiQmdJVu9Ul4x5jLuPEZPj19S2GLbHdeyc3WjA7nia8l6nDAreCb02zt/1P8B5CogXaNGGxvUjgwlkFLAhB/1NS9aRSAbMhzpSPtd0T7N/ty3qoQ0YT5vW34OrbiequLoQL164HocWasjIO15p3kcvMi09CUFAMjIgFqnVwUZ49t+E9uDW2sCZyQZW0/RZiQ/25NTqXg7sJ/ep2CFgoJpZhgv9+F8D4/6tkYW2GEiuIZCg4ThfEeT/J7sGUbE/1otQN6h6yOGvVaf8jnTpzowbCUhW9dpTGIt+n560yt9i9bxLRuG5q5jtJS9cO8IqTk7j8/s36wD5hC1FM2709C9sus4q3yYoXj0m2UVQrKOSrewtYG4tZL30sy97E+9OtWtNgPWEEi6VErVFapyzAi7AVgKsjXE7Q/twsoKZCnRsXpuC99l3x+/cYO71EWPnHQ4VtqfFlsbYM61A33Q+om4ualj72EAcK8nfdECNicGycxDCjV9pE2PgvsHPlTqjD40OFf0J4T8oB/FSUHlcBesBuCpfjB+w1ssleeJWqdHe6QhsL+3TkNKyE2hg2nC1u1JnCcH4sm9UGCJcs8jaaZk/3Y8Hg4lOc5iUXc4ZkIfCMTIuL3vlsM+CXBEBFbx7vyPgXHy5YN7YydApWcWS8ZBayScVuP+udO2QuFNVvVihieBC8CJ2dBRb5X3SVMS2LTvSV42Xoyvtaj3W7qmVByw1LIGpHVocTGre3SMUGVSOkMIncj9fmSsHl/fAhoCrgS8Gif+R2Pk6TUAufJaeLdCwu0BLj7eZzbIuxbJK7bURUdej/6Eg5bJw7LhDqf5oRPKbNDP/dRDUGaqHZptRa1liDRd3CGwn/idi57dt4dfBNOYL+Q/w2Jws8amBaT33ttJ0IhHrTezc98EGl4LaHHV9rq9byuR2rHgz t6U1osvK pYF87h8AvkqbQcHnE8jtRU9LiL1iGa1Q8tKnfTzs1V87aCo043dQfYnCxQtQaJrHZj0rsN5ejFJcggvgBu7hTf7nlgsigO6siuyMkqqrB8kb+/1+/s2Qtftyt5ErI4fE9dNHTiPUIwygTVsvPb2n+P0sClTW/yG58VZ6T3LkYVZVZPhai9jy7W1eCPkLVtbkRGmSaOkXdewAMR0I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 07:14:44PM -0800, JP Kobryn wrote: > The lock/unlock helper functions for per-cpu locks accept a cpu > argument. This makes them appear as if the cpu will be used as the > offset off of the base per-cpu pointer. But in fact, the cpu is only > used as a tracepoint argument. Change the functions so that the cpu is > also used primarily for looking up the lock specific to this cpu. This > means the call sites can be adjusted to not have to perform the offset > prior to calling this function. Note that this follows suit with other > functions in the rstat source - functions that accept a cpu argument > perform the per-cpu pointer lookup within as opposed to having clients > lookup in advance. > > Signed-off-by: JP Kobryn Reviewed-by: Shakeel Butt