From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4258EC48BC3 for ; Wed, 14 Feb 2024 16:40:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C42A06B0080; Wed, 14 Feb 2024 11:40:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BCCE46B0083; Wed, 14 Feb 2024 11:40:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6A046B0085; Wed, 14 Feb 2024 11:40:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8E2EB6B0080 for ; Wed, 14 Feb 2024 11:40:35 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 634CA160798 for ; Wed, 14 Feb 2024 16:40:35 +0000 (UTC) X-FDA: 81790972830.23.A41B732 Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by imf30.hostedemail.com (Postfix) with ESMTP id 8CE278001D for ; Wed, 14 Feb 2024 16:40:33 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=VEyoFOYw; dmarc=none; spf=pass (imf30.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707928833; a=rsa-sha256; cv=none; b=UVziBj45ikivKhCcDdPk6yW+cCDpS0InHmJmOHMGIjxTBwT1HI4eMxG0l1axFdiKIscJVt f96oqCjNrAMMq4M2nk4zgpfRBHb4dgOX5PJQy5tOfG9GlXDJIgfF/x5BvHo/vW/RaTJ9sx gDerUNhyOZqxUSCixiXvnNshKjiEM6c= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=VEyoFOYw; dmarc=none; spf=pass (imf30.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707928833; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/9YHWSbadLnJWGEqHTooBoi7E54ANCQ9igquOTCLUds=; b=twIzjHrDekRppJGs1MzKUMwy1QHa6IiR7o0VpysgA/cCm271VBQ82WLGcvzkkkpJ9t5jCj TM0/J4CRVdp/rU7MjCLkSqbr101GZgdGzmR5pU+ifIU+oyyZ5TGIImRlorCQpZzlOE/3Ev 5GxmFEaUG+mMQjdiDJcj3y75kLjLyGQ= Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4TZkTB0Qm6z9sZq; Wed, 14 Feb 2024 17:40:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1707928830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/9YHWSbadLnJWGEqHTooBoi7E54ANCQ9igquOTCLUds=; b=VEyoFOYwpHKy9ZK2Xd71CGUCOFK4ZJpTi4cZWFN5uoYVxe6TPUV62Pu6R+tX3mlY55vKZk LkWylql3iXvZrkerovzWe4GsQH8T5gJy5BThVq4LIzg5QaKmsHqi1OloCARGkkt46MLoSL UiqphhAZ6CXQOss30tc0OXaxkMz/0+aLvBR4fpLdsm17fR6XThEFuDBgznkRJyVfTAtpyo KXDlY0PgEVWDvuyg5lNT0k5KvzNb1pJa18mxSzY6QC79T/SGcYfIROUCok9Aswxes5HE2q AZqBJeZgvZmqw8A54qIiBzfOQKm2cbuXL9dtFf8Wfv82SWuWbECu8C7P621jhw== Date: Wed, 14 Feb 2024 17:40:26 +0100 From: "Pankaj Raghav (Samsung)" To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, akpm@linux-foundation.org, kbusch@kernel.org, chandan.babu@oracle.com, p.raghav@samsung.com, linux-kernel@vger.kernel.org, hare@suse.de, willy@infradead.org, linux-mm@kvack.org, david@fromorbit.com Subject: Re: [RFC v2 14/14] xfs: enable block size larger than page size support Message-ID: References: <20240213093713.1753368-1-kernel@pankajraghav.com> <20240213093713.1753368-15-kernel@pankajraghav.com> <20240213162007.GO6184@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240213162007.GO6184@frogsfrogsfrogs> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8CE278001D X-Stat-Signature: dand61dqzbq3k54q86zq6csuk9p938ys X-HE-Tag: 1707928833-111868 X-HE-Meta: U2FsdGVkX18sUfneinwI1E+R7LB6WkXcUBfYNtgJKjh/0kZL0rCdC8dKqske3cT7h54bhMmMAj1qNsJV6oYpedtWgQOmWK9h92cDlUJ6relsV3y1ufGdX5EWXDSLVhtWIGV3taMSzii3+JohPoPu63ufVxdgnsZhGGVXr/VxhyQnXM/NWdAJYNTuFWBrElJzKT8OTyCnXUxJZZZhz+KaW/izV/OENMxemLMoz33Xg6dNilPKd5kJKsRgmtl+JTTHVsB9vCx9d9qIqmeWfQWGTUdHgs801mIFXLAECTiDrnbLeiQuKz3bTZJVIEeWokzIcYnTvO1Ksbi/b8EsgbRzKC7/NHBqJIAO8pmO9kJ0sDxRf+KwAsRaxXGeoXKtr/m92UEycAFwnVvIMa9dL5mViO6i+Rww8n6uSEqZUmf+PKCDGsGxz+cTrEjAGIg9BgPECjQfV8lXMLRa6AQjDpUWvj7FwoAmcoDOu22bMZvnEA0wrTreVm1apm+4TrwXIv32ZVlE26B6sxtarPbWJ+OzyNae9ULNM8YjY8fv8HiUqaCZ2P1OODqXwoKMjzQZZwtfQcru//TMrECpUZ7yt+Tg3+fQktrbimRltLErAgHmi6gARHaWLcmd/4rCHwJiX3tAhulPma9brAEEeSpaNxx0ZkzicZ1ujZQ51079TewwpmVOXusc+L1ag4567iuypxsEOeDKDCm+R79mAsmJnNP21clxiZLd7PD2NmJIvlfy83whJrSVGcdXA3h1BvgBVOxfB5zHCoum7M9DnLpkgF9W63c2JN83xqqGwdAmCyy5TFo9hAdKVSxRUWIhSk6mHU9xcAqpA3ZXpfhFFKIck5odnkpSyCtoqR39Iu9j9tQRc/apansPo3Dzud5eo3SKpOVcYHdEBTDoE5xCVnTy0OpH8D56zObZwFlODEvxFfPehiw2VV+ojpng/76rAAif391OvdiC5e06rNB50XTi3LR A5ZuDTie IqDiNCcWB73CNxl1kUmpqIyzXOODSGli9DSZZKK7Bx+uQ3FLzaiHI15VqqrTxvmzoZQ6aab7KKPVMNA2Hf3oVgNl4L0AElou0IyNnqUNqqY4mrVHNaRIG2Co7SaiOrap6ismtUjkvLS0MnLEKJLh/SItB3DUee2tDL/B5wyYv6vX0pY0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > @@ -323,7 +326,8 @@ xfs_reinit_inode( > > inode->i_rdev = dev; > > inode->i_uid = uid; > > inode->i_gid = gid; > > - mapping_set_large_folios(inode->i_mapping); > > + min_order = max(min_order, ilog2(mp->m_sb.sb_blocksize) - PAGE_SHIFT); > > + mapping_set_folio_orders(inode->i_mapping, min_order, MAX_PAGECACHE_ORDER); > > Twice now I've seen this, which makes me think "refactor this into a > single function." > > But then, this is really just: > > mapping_set_folio_orders(inode->i_mapping, > max(0, inode->i_sb->s_blocksize_bits - PAGE_SHIFT), > MAX_PAGECACHE_ORDER); > > Can we make that a generic inode_set_pagecache_orders helper? Chinner suggested an alternative to stuff the min_order value in mp->m_ino_geo. Then it will just be a call to: mapping_set_folio_orders(VFS_I(ip)->i_mapping, M_IGEO(mp)->min_folio_order, MAX_PAGECACHE_ORDER); > > > return error; > > } > > > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > > index 5a2512d20bd0..6a3f0f6727eb 100644 > > --- a/fs/xfs/xfs_super.c > > +++ b/fs/xfs/xfs_super.c > > @@ -1625,13 +1625,11 @@ xfs_fs_fill_super( > > goto out_free_sb; > > } > > > > - /* > > - * Until this is fixed only page-sized or smaller data blocks work. > > - */ > > - if (mp->m_sb.sb_blocksize > PAGE_SIZE) { > > + if (!IS_ENABLED(CONFIG_XFS_LBS) && mp->m_sb.sb_blocksize > PAGE_SIZE) { > > xfs_warn(mp, > > "File system with blocksize %d bytes. " > > - "Only pagesize (%ld) or less will currently work.", > > + "Only pagesize (%ld) or less will currently work. " > > + "Enable Experimental CONFIG_XFS_LBS for this support", > > mp->m_sb.sb_blocksize, PAGE_SIZE); > > Please log a warning about the EXPERIMENTAL bs>ps feature being used > on this mount for the CONFIG_XFS_LBS=y case. > Yes! I will do it as a part of the next revision.