From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE145E77173 for ; Fri, 6 Dec 2024 21:20:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37BC28D0010; Fri, 6 Dec 2024 16:20:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 32B788D000B; Fri, 6 Dec 2024 16:20:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F3518D0010; Fri, 6 Dec 2024 16:20:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 020D18D000B for ; Fri, 6 Dec 2024 16:20:34 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C190916034A for ; Fri, 6 Dec 2024 21:20:34 +0000 (UTC) X-FDA: 82865802516.07.43258B5 Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) by imf13.hostedemail.com (Postfix) with ESMTP id 3D8BD2000D for ; Fri, 6 Dec 2024 21:20:14 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=LPQ7V0FC; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf13.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733520024; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XrpWAnhs6ZQvQvyxIqn9Hy0WnK1+L1jfbuNM5R/qsyM=; b=ToU1ir+xQNZyuyxfRYbhMOv5dXGj+qX2uYe0//UFhT5l1xOszouyRu7b2rjfgmmtmu0hVB PKCW6uNi6nq+BBF9rJqfQ9VY08a8r+WcqdZ14BtZV8tL3R8yDXob0HKsitkPP0qcqYXTvc lAzDs/xGVTjRbIFK9drzBbttylJfKFc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733520024; a=rsa-sha256; cv=none; b=ohMvNB6WFt06EZvr5YRcDvHLXZstda5NNnEByelxtZZjvkR+a71LApATx7wik49YkZCE1K LE2RqxI0521JIDXkSYD4RTwKtAYW8JNwKMD9P0vV5pSwHvlvTlu3ZZG9xp4p+Kbm0F7MX4 VjBhsmwo54F6SJLfLX1fAD+XkCgFR88= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=LPQ7V0FC; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf13.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev Date: Fri, 6 Dec 2024 13:20:23 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1733520030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XrpWAnhs6ZQvQvyxIqn9Hy0WnK1+L1jfbuNM5R/qsyM=; b=LPQ7V0FCg8YdnNhBd1fDSqLT45vBjJiaBvCuucjXf4BCu1dGQTSDHnScayMny9j48hDHox cMHoYhYDC8O3UzonV0esj2hOmy3KGZqQxnI8CRpK6ZBe6bJCp8a9vpPb7dXD6FETnLMFVQ msrNSQ9M2mtxUkzXSpF3vLLgKwTCras= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Hugh Dickins Cc: Chen Ridong , Yu Zhao , akpm@linux-foundation.org, mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, roman.gushchin@linux.dev, muchun.song@linux.dev, davidf@vimeo.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com Subject: Re: [next -v1 3/5] memcg: simplify the mem_cgroup_update_lru_size function Message-ID: References: <20241206013512.2883617-1-chenridong@huaweicloud.com> <20241206013512.2883617-4-chenridong@huaweicloud.com> <897b04c9-dba3-44ae-8113-145ca3457cb3@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: dkzjwon6dt91chic5mrmayy8xdkh131k X-Rspamd-Queue-Id: 3D8BD2000D X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1733520014-333722 X-HE-Meta: U2FsdGVkX19CGmhC04Qwip9X5kkaK2EqLEG/ZARqPKUSjCPoJOmEv+318S1mFJdO730g9D6m6Zz4jJZscCbUU3rmWrz/GkzEZfwva0AgnCn+jvhqZcrjxdDgxPhd5qte1gK+j/E62dmUwD98VvPsXastE9+u5zCW22fAfyI9pW9pUcAmJ9ufRxXT8JTWyJlMwYy0MwfI85mPubOGQhuqTw4wl7lngZDf5z8c+lmCT/CozaFD1mTH3aZxHwa7p7qBjqMp+3lj9mARh0zNcv5rFiLE0q8zT/VfWk3J9pTrhoSLicIM2oKDPIi4WD5oQQ8T0QsrsT4szMTPFr2wOUiFcak9NFxk7c2X8Iw3pFfHr8cS7beqNgzGz7y1bzDmAiB7fyT8W4+SajypU9MuNEhzhMLMGggmbKSEL/Lzi5Zt1lRedTx8f7WhHVxgTkCLvNpQXMKcXgU05MmtEG5Niu6mlaJsMVH08Bs0AbfrNDcLiSyF454VZcGbMxDWE2E0x5jLNXGxtx32m5mbeLx2EiLlyUz7ryQ80Sa9qXImWhIX0MZ79uFI1bhpYBjtQ9k4Fb5U92+OlaeY2dxp5Qb3sZGdHA78G0wmpyvlJRL65Q7ZKG/nLPuqWBqUCfWAzEy+XuJ3GXgGTR1xtysiBZZ3gupmiSRvcvN8NYsn9TemTnkE9dFLK+GOdeg4/oB7+d7SPy5/gMgMJ8SoLOvrT6ueTf1M0iMVmQk4NRfNwVKsyh2RdRFl1ZxH6J0yfukPShY+SFOu3PPXYu4UXTtxabNFAlLAC71ubCjSooRjT4/fxo51VGIZNAdeVbLxCbhpqBBNYH9KRfAMSwslhxnJso3WqAFieOovtcr8rWJ5WSFrffijNnLk6MAIdXt/3hWFfJ0DPIJs2rd7eFNc7nUx6bD54kLjFYr4Rf0nBlGIfkfIO63y8PFfz7HlDsRGe67ZOi63Z4+ybJE8LhT9gVmjyNSgKlf hQvnHBPA AzXLcaKtV5r/KcdIZVj9SJcYv7ixlC1N8F28Ga1uCw5rV5gKE1kypqh1tbJb5ciLkguTALodajjowXFY6a+zSNpCjNKtBWfrabEJrO7CSTAbC20pk8GMqkJ/WXOs86eA2oeEL/ltLirjEqO2sCgj3W5qAqiYQFcBs7FZr12FSGoxmh3yypV8oVfaKlH8VsrpAJwBK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 06, 2024 at 12:24:54AM -0800, Hugh Dickins wrote: [...] > Another thing to understand: it's called before adding folio to list, > but after removing folio from list: when it can usefully compare whether > the emptiness of the list correctly matches lru_size 0. I think one source of confusion might be that this "emptiness" check has been removed by commit b4536f0c829c because of maintaining the list size per-zone and actual list is shared between zones of a node. > It cannot do so > when adding if you "simplify" it in the way that you did. >