Re: [PATCH 03/10] memcg: create extensible page stat update routines

[Greg Thelen <gthelen@google.com>]

Ciju Rajan K <ciju@linux.vnet.ibm.com> writes:

> Greg Thelen wrote:
>> Replace usage of the mem_cgroup_update_file_mapped() memcg
>> statistic update routine with two new routines:
>> * mem_cgroup_inc_page_stat()
>> * mem_cgroup_dec_page_stat()
>>
>> As before, only the file_mapped statistic is managed.  However,
>> these more general interfaces allow for new statistics to be
>> more easily added.  New statistics are added with memcg dirty
>> page accounting.
>>
>>
>>
>> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
>> index 512cb12..f4259f4 100644
>> --- a/mm/memcontrol.c
>> +++ b/mm/memcontrol.c
>> @@ -1592,7 +1592,9 @@ bool mem_cgroup_handle_oom(struct mem_cgroup *mem, gfp_t mask)
>>   * possibility of race condition. If there is, we take a lock.
>>   */
>>
>>   -static void mem_cgroup_update_file_stat(struct page *page, int idx, int
>> val)
>>   
> Not seeing this function in mmotm 28/09. So not able to apply this patch.
> Am I missing anything?

How are you getting mmotm?

I see the mem_cgroup_update_file_stat() routine added in mmotm
(stamp-2010-09-28-16-13) using patch file:
  http://userweb.kernel.org/~akpm/mmotm/broken-out/memcg-generic-filestat-update-interface.patch

  Author: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
  Date:   Tue Sep 28 21:48:19 2010 -0700
  
      This patch extracts the core logic from mem_cgroup_update_file_mapped() as
      mem_cgroup_update_file_stat() and adds a wrapper.
  
      As a planned future update, memory cgroup has to count dirty pages to
      implement dirty_ratio/limit.  And more, the number of dirty pages is
      required to kick flusher thread to start writeback.  (Now, no kick.)
  
      This patch is preparation for it and makes other statistics implementation
      clearer.  Just a clean up.
  
      Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
      Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
      Reviewed-by: Greg Thelen <gthelen@google.com>
      Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
      Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

If you are using the zen mmotm repository,
git://zen-kernel.org/kernel/mmotm.git, the commit id of
memcg-generic-filestat-update-interface.patch is
616960dc0cb0172a5e5adc9e2b83e668e1255b50.

>> +void mem_cgroup_update_page_stat(struct page *page,
>> +				 enum mem_cgroup_write_page_stat_item idx,
>> +				 int val)
>>  {
>>  	struct mem_cgroup *mem;
>>
>>   

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>