From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx171.postini.com [74.125.245.171]) by kanga.kvack.org (Postfix) with SMTP id 689DF6B0002 for ; Thu, 25 Apr 2013 14:34:08 -0400 (EDT) Received: by mail-ve0-f201.google.com with SMTP id m1so159744ves.2 for ; Thu, 25 Apr 2013 11:34:07 -0700 (PDT) From: Greg Thelen Subject: Re: [PATCH 1/2] vmpressure: in-kernel notifications References: <1366705329-9426-1-git-send-email-glommer@openvz.org> <1366705329-9426-2-git-send-email-glommer@openvz.org> <51790A73.3030805@parallels.com> Date: Thu, 25 Apr 2013 11:34:05 -0700 In-Reply-To: <51790A73.3030805@parallels.com> (Glauber Costa's message of "Thu, 25 Apr 2013 14:50:27 +0400") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: Glauber Costa , linux-mm@kvack.org, cgroups@vger.kernel.org, Andrew Morton , Dave Chinner , Anton Vorontsov , John Stultz , Joonsoo Kim , Michal Hocko , Kamezawa Hiroyuki , Johannes Weiner On Thu, Apr 25 2013, Glauber Costa wrote: > On 04/24/2013 11:42 PM, Greg Thelen wrote: >>> + vmpr->notify_userspace = true; >> Should notify_userspace get cleared sometime? Seems like we might need >> to clear or decrement notify_userspace in vmpressure_event() when >> calling eventfd_signal(). >> > I am folding the attached patch and keeping the acks unless the ackers > oppose. > > Greg, any other problem you spot here? Thanks for the review BTW. Looks good to me. Feel free to add my tag to the patch with vmpressure.diff folded in. Reviewed-by: Greg Thelen -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org