From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 399D7C369AB for ; Mon, 21 Apr 2025 17:06:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 132D16B0005; Mon, 21 Apr 2025 13:06:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E56E6B0007; Mon, 21 Apr 2025 13:06:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEC2C6B0008; Mon, 21 Apr 2025 13:06:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D09736B0005 for ; Mon, 21 Apr 2025 13:06:17 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D4B3F1C6AC9 for ; Mon, 21 Apr 2025 17:06:18 +0000 (UTC) X-FDA: 83358679236.02.094F285 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) by imf27.hostedemail.com (Postfix) with ESMTP id 406A64000E for ; Mon, 21 Apr 2025 17:06:17 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=EwUXENVm; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of 3B3sGaAcKCF4CPDAHAJCKKCHA.8KIHEJQT-IIGR68G.KNC@flex--gthelen.bounces.google.com designates 209.85.216.73 as permitted sender) smtp.mailfrom=3B3sGaAcKCF4CPDAHAJCKKCHA.8KIHEJQT-IIGR68G.KNC@flex--gthelen.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745255177; a=rsa-sha256; cv=none; b=aH8OdeR2ii5zVh+YQAe1y0rAbWQVBZ4zN2B7EAJ9SG7g09jycLvqLmIp8bcDwm6b/Vc5pr 0jgzmzXqj2x9tep0V6xXhikcPdDG8GAk0tEXYR8E/gZsh8fmnea4jMNI+5cFOKcc9130gs 1SqgLzVBlhT0QitwQ5Q0VsAOqWrYX6o= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=EwUXENVm; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of 3B3sGaAcKCF4CPDAHAJCKKCHA.8KIHEJQT-IIGR68G.KNC@flex--gthelen.bounces.google.com designates 209.85.216.73 as permitted sender) smtp.mailfrom=3B3sGaAcKCF4CPDAHAJCKKCHA.8KIHEJQT-IIGR68G.KNC@flex--gthelen.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745255177; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zGVm6Iz284Y0SobVO77Gr/vtAHZx6PoDVFWOgbVwgEA=; b=PWiSvWpycdO2MmWsCjOBCWayvbQAG3P7MH1bKhIw+fTuXa4+sj/q21AnjYRadnEZpZ6dak 4WNAHR6HhjLWveLiUfXLBOSfJkJAxql52nCyXR4jDv8aizwPf5YQODZQdPShDEEP1QisN9 FgorFlWY/j75fliNEGjJotiBgIsvpoY= Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-2ff8119b436so3678863a91.0 for ; Mon, 21 Apr 2025 10:06:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1745255176; x=1745859976; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=zGVm6Iz284Y0SobVO77Gr/vtAHZx6PoDVFWOgbVwgEA=; b=EwUXENVmxWFl9MAy4AOU7M2pFPTWW9VX9vwVUFL40x177vNtI+T126uFw16n8OB1Ju Gk99OphMNH90gkmnmDX46q1CAFs6mnxTrzuJ3mdDu6MhGoQO3oCOWxqIP6SCWk/ihr8q QuFU6uhjMVSfC/fgXYow+SjvQnoBFSUn3NboArswOKQccxzWSRSriPTWxmdvQR28q5vr R+SHzmyUxWmOjuVe88ZEjiHxNmGinETCNwiV2Q47qSQby3VMJcx8lfjkKaWvSy6dFQs1 ni9flEylrxMmbXP/dYapJM9opAuDG5jVEsc0HzqmeKOKv9fPctPLlpaFGYddQogJb6rN fWZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745255176; x=1745859976; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zGVm6Iz284Y0SobVO77Gr/vtAHZx6PoDVFWOgbVwgEA=; b=Lt808UtWaQps2NKUdOKU2zGQ8AX3HAZpUKYBYCy80lGjV6c3SxGYVRCogrWAEPCgpj vw+a13ijfIoTV2FWKFiqwNIlaIHse9oGIXLPGr8TrVdB/OPCZ05YdcCCNJEl/X7CIxjK efj9vyw9SqxinVq692XFP4HRxHQwLH3KXKqKOwA7Dn/abEwcKvVAt1jJ8tq+k48nHPFg JhBxgATHt34tibwJLVn7CknuZcQrC3NQ0XepkXIMtoLBqvcaINUKJtkpmEgeGyJ1BjU3 cWM14GmyE6ZrQtmIVpfdUaHCAoI1FaJ3jVCWRScBakQplFwTlRZ7j4ykEx5EHXd4ATH2 2WXw== X-Forwarded-Encrypted: i=1; AJvYcCUbb0vRv7FcVau6fX6Ex7gXzLo2hpE6J7rBKC5PFQsKAO8avFxXENsbfdfUiOYMtf7Lp18LkK7TRA==@kvack.org X-Gm-Message-State: AOJu0YxuYXwSuo5qMg1PnkHw8JFdlTo2X0mbtPmh40BlqagL8qML5MRG GOZx2DJpjcQcAwKwANmuCblWh7RUNx1ahVTOp3ebxNs0U8ozIHgSMHJ9ropmIr0jEf/t4Qz+VJx dUomUaw== X-Google-Smtp-Source: AGHT+IGJnoJr8pRxSRD/hhwYoroUkE+lGUx4/nXUcE18/FUK3RmYB2FZoc725vebNXgkeUgU5nmSHFss5Hw7 X-Received: from pfij16.prod.google.com ([2002:aa7:8010:0:b0:73d:65cb:b18b]) (user=gthelen job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2704:b0:2ee:94d1:7a89 with SMTP id 98e67ed59e1d1-3087bb36bb4mr16771781a91.1.1745255175978; Mon, 21 Apr 2025 10:06:15 -0700 (PDT) Date: Mon, 21 Apr 2025 10:06:13 -0700 In-Reply-To: Mime-Version: 1.0 References: <20250418195956.64824-1-shakeel.butt@linux.dev> Message-ID: Subject: Re: [PATCH] memcg: introduce non-blocking limit setting interfaces From: Greg Thelen To: Shakeel Butt , Tejun Heo Cc: Roman Gushchin , Andrew Morton , Johannes Weiner , Michal Hocko , Muchun Song , Yosry Ahmed , "Michal =?utf-8?Q?Koutn=C3=BD?=" , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 406A64000E X-Stat-Signature: 88rji8x587am1d3psxidinfwobundkwt X-Rspam-User: X-HE-Tag: 1745255177-650066 X-HE-Meta: U2FsdGVkX19Hn5GBJ77gnyx7OIkR0TF6MYNFiW9kPOLTHON2GIF8C7zIn6bWphBFrHoVRVQ5nBtRlWNcqRIJaC4CM3i7yhdYSzTQhRg6hpX88YtQ4qNzzhSqJAtub4bIUgWyU6ZJ7X6qhFzMA8OIi+8+4f+gabt1hLGoUC7nGuD2IBSLIKs04dRObFY+m1s5HIlenDUioMV5F/eb5kYKOkszzkU/pb3oXvYu4lc9L4VIVRhuj+04h9XYpCtSk3oDNRHh+ipiZze/GQJR+YfBhdROnTipIsCPwhyLu+RkEYfgD6udIzLcNoYtZbUp9icEKKPpDGY/5tLz+Yjd7Fvxq0cbnHZMTuZiozRtYHuCIaCnC+FGzvMuo7SmF4Z1LLW3C6ntkaFSfJu+30IdhYn9TQsamN/acXm5Kmnc5sw8lfXsknHFMkI9putnajduNSu+u7czAXjVg4A2gUumkrt1n3/jAns/SdYd58UbgsqCH8J9gh05+4qLvYzsgxeLl20xdhzLvkgoRA8f7hsT/DUZRmFGwc4t+CDYjc/B4uZw1/5X5nrFsafoiXUK75p/qegw/G1bhDLIqWMS0XwBn0IqPmQ2w3FZEBAKVXEalV0lvw069cP9+RebAzqjiPDmyAWwpX/qCj84DEMdxsOIwKnhgNwqCJ9EFXqmYD/wjWFoOtLGAtHlYnIX0hLBTOCN1rtBhah0Rlr9/2Epxe2gl0tNMesVBxZW1Dq/wsh2WC3Ty6nsvbPLsllfm+qQAuNtrnccA7wFSgD6pCQCxk+XOY6mFJxO2EAmgAoVvUbqEzDRSOm/+8RKxZB6+CZzf8okO/037xBCzR2pSnPOZ+pgaxREYcXlGxMprL7b+FSGFIGvqN4DEmyEvp/Cypd5+60v+fLxTYY0Z3sVJ4J6Byj3etmdFPb2NzgKYO5Dfr5+kKWTxc5MqrFlcMiQVg0vLrdf28OeKbCfRPsJX6/A1Nunww3 TdMjKXU9 6fHM2p3lPShCkElL9n7nt0iYmyzSz+RtrqVCPdDTm6QYRP/8P0+PmWJUdjo4l7jL6xjHufVKD6tQ9CITziKfzCCpAM+Je4BFrd2OjG36tlUcmf85j8pZR2JQuBDRfcS0BDtpVSErrJOpnMF65f7+xe0WbkbGXS4r8ZfcFo0mpoyqows3OBlDdZWLyE5cnTKJJNWzEkYcB5WT3Iv/jqGOQ4RSagsMlzwZiEQxJpWtnoplbnOpIcNrXW+Jm3Nwl4L4SUqE8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Shakeel Butt wrote: > On Fri, Apr 18, 2025 at 05:15:38PM -1000, Tejun Heo wrote: >> On Fri, Apr 18, 2025 at 04:08:42PM -0700, Shakeel Butt wrote: >> > Any reasons to prefer one over the other? To me having separate >> > files/interfaces seem more clean and are more script friendly. Also >> > let's see what others have to say or prefer. >> I kinda like O_NONBLOCK. The subtlety level of the interface seems to >> match >> that of the implemented behavior. > Ok, it seems like more people prefer O_NONBLOCK, so be it. I will send > v2 soon. > Also I would request to backport to stable kernels. Let me know if > anyone have concerns. I don't feel strongly, but I thought LTS was generally intended for bug fixes. So I assume that this new O_NONBLOCK support would not be LTS worthy. > I asked AI how to do the nonblock write in a script and got following: > $ echo 10G | dd of=memory.max oflag=nonblock > Shakeel