From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91E1DC4345F for ; Tue, 30 Apr 2024 17:49:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 274646B00C5; Tue, 30 Apr 2024 13:49:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 223296B00C6; Tue, 30 Apr 2024 13:49:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EAC66B00C7; Tue, 30 Apr 2024 13:49:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E36EC6B00C5 for ; Tue, 30 Apr 2024 13:49:29 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8F2A81407A9 for ; Tue, 30 Apr 2024 17:49:29 +0000 (UTC) X-FDA: 82066935258.03.7FE2476 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) by imf05.hostedemail.com (Postfix) with ESMTP id B10D0100003 for ; Tue, 30 Apr 2024 17:49:26 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DeMrA98n; spf=pass (imf05.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.174 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714499367; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MPJon94WVPTCJVxAuwEzMFjgEeJu/W5zYuiZ8N8gwdE=; b=HQmQ7hn8nGJ4oYe4BOuA0TPnyGsrdapVJLv2JR9GEL1YC4jgtVo5910pWl81Q2652iUrkP vpxBu7lffhpa9OjCB+CkgXh4ji+14rYvMb6vIcqfCN0MrwOoeQsisz3OoLX12ShrkN3V3/ f9jvYjkvZJgBBSvz+E8dSdIVQrnSvxg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DeMrA98n; spf=pass (imf05.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.174 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714499367; a=rsa-sha256; cv=none; b=kxl/fCMGto/VM5F6TwLR7BK+BqaokatLbUmjW3J3VIXKkHZ4QnyPU5o/+wKccXguMOGfTM 9BlzJymJ+k9bnSpfjfybofa2G7YNSnVxd+YVT8O9KnyA6siIdQKtN7AxgacyUAGwuaSJ0I KoLHpOHXYqWHMWv2lsqbsZFPR4Jmt5o= Date: Tue, 30 Apr 2024 10:49:19 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714499363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MPJon94WVPTCJVxAuwEzMFjgEeJu/W5zYuiZ8N8gwdE=; b=DeMrA98nCGYXATxJeF3wx0DmqLgugaO1+GZRkfQf58xLwmlOH5vQIilQzcUHN3h/58EfUd nXesSNChK8Jgr0r+NHyJq+d/ZhBANoWk2e0ks40G+b3nTNMPTv04DyzncucEmQAtNTF0zJ W5az2Zf0YENBLvcJUS8gtUTvQ3782V0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , "T . J . Mercier" , kernel-team@meta.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/8] memcg: reduce memory for the lruvec and memcg stats Message-ID: References: <20240430060612.2171650-1-shakeel.butt@linux.dev> <20240430060612.2171650-5-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: qanenjgdyamxg3wot6t9u61x7ekddw1o X-Rspamd-Queue-Id: B10D0100003 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1714499366-196377 X-HE-Meta: U2FsdGVkX1/UrZNCxTPbh4khQrgshqGJY4CWgX/l/Le/M8y9zndrKfvp/ggm9YCvQ9JNhKLD0IXujUzRtU7/S7EBc58lcZPTgRlgfYGrGCQ0cI67vGLzOzFXYXQZIkpjSUKk31+I/NRyJg78y4bE8eUlc3avR3CZui0Z98H2jBxR7EToUVy9UTOzHSVw/BeE81pF/yfTIOHoJmb2kgOEzs+iTe1yeiySPT9sgXp5FZZy/bOeOI0frR358flsrQp9y8fydFurRT9AFwAuaU33AZCBkoyuqPvUUBF+5CgiKF28WDjoS5uQptZJd8xzKelS4yVl7nM006rq8nP6Cdy+C+VBOLbOle5XCLc618z+Su9Pd7jHwi5uKel4KZ7J03UDw1eIKghblzKfH1yg4RGfVTnM3MwhxDe8JKX4HgrwjWtFg6GX6ufaATS8Uv0FLHBc+6I7i+z/OMamCJwqgJ+g8CPcL75CDjLw7i6/vKm8a1MP8Qb/ZtAKLNWGIQHMSNBAa1QpjJlBRswMxX1fDc71lf+Ukbo2Mt1oNXACnNaiJLRv0+6oHGZc7tIFL4BO5DN1SZ9lNopKrMUH50YXx6MyBOoUye2nKYSkpAcWSAUagZkQ9GXYdYQMXoJxdcYCAPlsWPOfd1p98+KdCi3+P3qBmSXSsl7mclZIln7J38Bf/xyOv767ZD0w1WHrIZ9tqU0oyhiXftzB/lc/Kt4C4qjQDdGCz3iK0HDv9nZs/MR5K0F8FsmfFH68twiWyF6410r0K5TAxAEg+kGURTOMjAGYGwo3xGREqq7f4EYQlIqJ8kio2IUrZTEZEH5zjPeh/LQrUC9tzJK4TAFH5Mud9pxMcUpXUDaug+bhT5Uxa7R8fCbl9RXz6pRXvfaPRc7vws3Wf1/wKIDJS4go62rrS+RWY/vagIMe2E8mvKqf7wF0pxICVQgFCihHjvdSnJ+Mw8lLL+n136gNfk6JIuYgVu0 AnCIqH1s 4XZMT3yPOBSSQ4S8pTPM9QwMOfKyEt/KobEAxEYrYXdq0i6qk7JZ+nZR9/CLyUmDUujrZMoZgZLrKRrZrcB3aY9/7RbHNKBTUIcPCfQhGwjT17fYjfdzr3XlPmA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 30, 2024 at 10:41:01AM -0700, Yosry Ahmed wrote: > On Tue, Apr 30, 2024 at 10:38 AM Shakeel Butt wrote: > > > > On Tue, Apr 30, 2024 at 01:41:38AM -0700, Yosry Ahmed wrote: > > > On Mon, Apr 29, 2024 at 11:06 PM Shakeel Butt wrote: [...] > > > > > > nit: we could return here if (i < 0) like you did in > > > memcg_page_state() and others below, less indentation. Same for > > > lruvec_page_state_local(). > > > > > > > I have fixed this in the following patch which adds warnings. > > Yeah I saw that after reviewing this one. > > FWIW, *if* you respin this, fixing this here would reduce the diff > noise in the patch that adds the warnings. Yeah, if I need to respin, I will change this.