From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E85ACF34C3 for ; Thu, 3 Oct 2024 20:11:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 183F46B043E; Thu, 3 Oct 2024 16:11:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 133CE6B0441; Thu, 3 Oct 2024 16:11:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 022116B0442; Thu, 3 Oct 2024 16:11:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D92356B043E for ; Thu, 3 Oct 2024 16:11:27 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5ACC21608E1 for ; Thu, 3 Oct 2024 20:11:27 +0000 (UTC) X-FDA: 82633385814.26.12236CB Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) by imf05.hostedemail.com (Postfix) with ESMTP id 89EC010000A for ; Thu, 3 Oct 2024 20:11:24 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=oOhqwgUa; spf=pass (imf05.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727986156; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rhPQoJlakqquoI5upZw/takDi1T+3w/Qo6IA9str170=; b=B0BmfswexPzM2rD1biJco1ySXgo9cy/roP2W9E5nUyl1Iqhgebp8curGNZ6h76OnnmmnXj ExQZDDyZU+wufKpTrP7EXPX2ZpLeYWMGwW8WliQZQCE9cEvjqpov+4TyWxus6ck14BnD/J 7BZuDZNnRx+VSwfUWSEGLO8k8dK0fuc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727986156; a=rsa-sha256; cv=none; b=GjiTK4qDAb07W75pNC8HICZrogIWOx1Y44L+hkvR/JYbrbnwg6uKE6KP92Unm1klcEx3eb AVc/E8CSm2YTxGfrcXx9q/WYX/2NxnwxEznzPm2oM8xjhd+4Y/xzZWiXCBqcgyfUpftvvo Czm2VguWOPq0EDFKoNGe6MUXcB5N8o0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=oOhqwgUa; spf=pass (imf05.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Thu, 3 Oct 2024 13:11:14 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1727986279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rhPQoJlakqquoI5upZw/takDi1T+3w/Qo6IA9str170=; b=oOhqwgUa1OJ93qlI1jFlbG6VY4hEtaMvKCrc4n3X9JM7tjnbO53noxUwy13usv9VckJRIz sNnHvu8j30Fsec5oODrdK8tYi6TxSKomXKdXJo0x5c4wzMWO9KQyC+gcvE1POr+Ssomhqb suDyzmPDAeswetTnn9/IPbT2WpFhBeo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Andrew Morton Cc: Johannes Weiner , Matthew Wilcox , Yu Zhao , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH] mm/truncate: reset xa_has_values flag on each iteration Message-ID: References: <20241002225150.2334504-1-shakeel.butt@linux.dev> <20241002155555.7fc4c6e294c75e2510426598@linux-foundation.org> <20241003130133.afb8e8bbdfa8f638b0343473@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241003130133.afb8e8bbdfa8f638b0343473@linux-foundation.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 89EC010000A X-Stat-Signature: n5uocb5snboqf5ruiwxqnii6p7gqhtts X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727986284-378743 X-HE-Meta: U2FsdGVkX18iLocmTlXc81rkVEnHebi8fwu9+0U8/ejroTaVnhV3Mbi827SFQ4YqY0YvyTOBlrxgG4bNrde0mwr45mdQBcmT+skuDeXxJnPCkPvvBkXqXKkGd6FSo7sKzPPZw3dG6sa/93Q2G3Vy06L3Sjqa1d7GDSTVows4ckJ67E8Nrf91mKeLPJJJxqaY4v7DlRgXsssdui+NOlRomqCEC2ozUsUCYQ3jd+INFB/sTSoimgc4F4SnhZisnjjvBwkhlS50kfPHtvxUnb31YOQT+djwvevm8PsGEQnLbJde3Wr4QtED3U5llfmlN8BPF2r8RvAieG2sVHlnIzRpdIa9Y06vyqtbvKDvwz58RU5cLHQ/3/Bp8uNVZjfE/kt8jtFeW/PJMZsRk9fNtT1DEosCuVK7OZ+lIqwtI3EyDuQnWgjjIQEv8nOKMsB/MH/ojOKZdoPLl09TtMjV/u3/4AvjC8Jx2k/+4rhsDJxr1UsT/jioiS37rzUzxaUJv1tyHIuP4o9pvRUp22VyPUHJcx2qxbwWSK8j8e5PVmo9bfJE1tVj2zoYTHvw1W7Qig3XF91LgKIylKYthE+aRTTEGAwAWPJPhK+4zTX01VtCNO0U4ZZHhT/KK/3QeD/YWgL9sT5p4V3xwiEkwcq0KPzUNeSy3rqRzmDIFxsE//cXF3UXPBZcc9IdH0+dhiCmVXL3RnvBMJByw7Hes9bQhGkmEePee9VHJ/PK2pAs/c/4WCPW9rUbTBJWLvOeQ6UOJVzckRlzwe//bK3Lihw9ALLMmwaXh/UQpJ+i6S05D8Z12XAYZf3l6uHM+WjnvCNQCRmInv0ccYd2g2PCfRjtdO2EWFtAxqb6FhfWG3riWq4sHzyNBAvbShqYc8rINKKiCD8gJ++DHxIuqJ8Rye5xj4g7LsasdEzxUspD0b9RzUqMWRwHUtFN3knTlM66+MukvU/Y4iEntccSG6qdIgP+bYH ZTqRGroi IcPoSCkMn2ClvKfxFunDnWnJ7xm+k2rgwN+wy1rvdTTyGI+dTyjMNasv11He8lFNlxaLcwbTGoxe7r48crdYYm9PkrBEpzBBQXgmVRDhGVTEa/OQFDeNfqiulLn6qGtcQBm/k4MmTcIB+pJ8CdN+nU/nIdz9gaNSbnDH5mIrQWN+tQCMPXdURZEP07D44T15woDFC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 03, 2024 at 01:01:33PM GMT, Andrew Morton wrote: > On Wed, 2 Oct 2024 16:09:11 -0700 Shakeel Butt wrote: > > > On Wed, Oct 02, 2024 at 03:55:55PM GMT, Andrew Morton wrote: > > > On Wed, 2 Oct 2024 15:51:50 -0700 Shakeel Butt wrote: > > > > > > > Currently mapping_try_invalidate() and invalidate_inode_pages2_range() > > > > traverses the xarray in batches and then for each batch, maintains and > > > > set the flag named xa_has_values if the batch has a shadow entry to > > > > clear the entries at the end of the iteration. However they forgot to > > > > reset the flag at the end of the iteration which cause them to always > > > > try to clear the shadow entries in the subsequent iterations where > > > > there might not be any shadow entries. Fixing it. > > > > > > > > > > So this is an efficiency thing, no other effects expected? > > > > > > > Correct, just an efficiency thing. > > Thanks. I'm assuming the benfits are sufficiently small that a > backport is inappropriate. I agree.