From: Shakeel Butt <shakeel.butt@linux.dev>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Matthew Wilcox <willy@infradead.org>,
Yu Zhao <yuzhao@google.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Meta kernel team <kernel-team@meta.com>
Subject: Re: [PATCH] mm/truncate: reset xa_has_values flag on each iteration
Date: Thu, 3 Oct 2024 13:11:14 -0700 [thread overview]
Message-ID: <xqpohu2prms6cdhasdwup7dgkj6jsnnal7rx4t4i2qddownomf@gtx42zkp2n7t> (raw)
In-Reply-To: <20241003130133.afb8e8bbdfa8f638b0343473@linux-foundation.org>
On Thu, Oct 03, 2024 at 01:01:33PM GMT, Andrew Morton wrote:
> On Wed, 2 Oct 2024 16:09:11 -0700 Shakeel Butt <shakeel.butt@linux.dev> wrote:
>
> > On Wed, Oct 02, 2024 at 03:55:55PM GMT, Andrew Morton wrote:
> > > On Wed, 2 Oct 2024 15:51:50 -0700 Shakeel Butt <shakeel.butt@linux.dev> wrote:
> > >
> > > > Currently mapping_try_invalidate() and invalidate_inode_pages2_range()
> > > > traverses the xarray in batches and then for each batch, maintains and
> > > > set the flag named xa_has_values if the batch has a shadow entry to
> > > > clear the entries at the end of the iteration. However they forgot to
> > > > reset the flag at the end of the iteration which cause them to always
> > > > try to clear the shadow entries in the subsequent iterations where
> > > > there might not be any shadow entries. Fixing it.
> > > >
> > >
> > > So this is an efficiency thing, no other effects expected?
> > >
> >
> > Correct, just an efficiency thing.
>
> Thanks. I'm assuming the benfits are sufficiently small that a
> backport is inappropriate.
I agree.
next prev parent reply other threads:[~2024-10-03 20:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 22:51 Shakeel Butt
2024-10-02 22:55 ` Andrew Morton
2024-10-02 23:09 ` Shakeel Butt
2024-10-03 20:01 ` Andrew Morton
2024-10-03 20:11 ` Shakeel Butt [this message]
2024-10-06 22:03 ` Yu Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xqpohu2prms6cdhasdwup7dgkj6jsnnal7rx4t4i2qddownomf@gtx42zkp2n7t \
--to=shakeel.butt@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox