From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6491C369AB for ; Fri, 25 Apr 2025 01:31:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DE116B0030; Thu, 24 Apr 2025 21:31:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 865A16B0031; Thu, 24 Apr 2025 21:31:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7062A6B0032; Thu, 24 Apr 2025 21:31:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 52A606B0030 for ; Thu, 24 Apr 2025 21:31:09 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 83969B7565 for ; Fri, 25 Apr 2025 01:31:09 +0000 (UTC) X-FDA: 83370837858.12.60AFF80 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) by imf28.hostedemail.com (Postfix) with ESMTP id 0A8F1C0003 for ; Fri, 25 Apr 2025 01:31:05 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qV95+FlY; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf28.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745544667; a=rsa-sha256; cv=none; b=bkEM2JAHvLOXXEbiBXmPGwzqgay/Y51CHCjDGDQ+8sJ/ap8U8QlL8r+hCj+Rf5qwXrjfq4 e8CKsaOBWuwIsowQHHLP5oMk4PieQQyeiDzjh9MZuWgYaKBbTlyNBzFq5oeDuKVBbkZHQj cNyRVNXeewQtuKJ8Tku8tvaOg6VP7tc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=qV95+FlY; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf28.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745544667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4IB9vcqcWEcdWM+TiwthXAvk5swmCTNCTycnWuqUskI=; b=y9Ji6nc0xpVY7ntT2FUMEsB0owGoZad+6WyQTwaM0aoIX8noRbWMdkuOIbVBWgi38wuRqV cJke9C2ORdlci3xuyPWFJCcjECS0WFFNEefsh++AY80snoOIhG621Xxr2bwKuimv3pSb9I NHQI7eO6NMTQ8Jry8efM5bGmjeITLno= Date: Thu, 24 Apr 2025 18:30:55 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1745544663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4IB9vcqcWEcdWM+TiwthXAvk5swmCTNCTycnWuqUskI=; b=qV95+FlYn8SobZ5BuSXOCJzTrDGmBOkAgnTti0qDzmaIKe2DANG0lZaBqd6a3Kf5XhV2Os 5p5HwcOeqyiwHRCE9cwrjRNyvZAP4q2w0OAtVGyPndXjEeIMuSjzB/lrQBKcuvFtio8TLp xcHtHCMXdYHd+lxm4jTH3QMBCzCHEuc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Huan Yang Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , Petr Mladek , Sebastian Andrzej Siewior , Francesco Valla , Huang Shijie , KP Singh , "Paul E. McKenney" , Rasmus Villemoes , "Uladzislau Rezki (Sony)" , Guo Weikang , Raul E Rangel , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Boqun Feng , Geert Uytterhoeven , Paul Moore , "Mike Rapoport (Microsoft)" , opensource.kernel@vivo.com Subject: Re: [PATCH v2 3/3] mm/memcg: introduce mem_cgroup_early_init Message-ID: References: <20250424120937.96164-1-link@vivo.com> <20250424120937.96164-4-link@vivo.com> <2u4vpqa6do7tgtukqb7orgxmlixguexsxilhnsiwv7atssnht4@o4cwziz26wrs> <1166b629-92a0-47d5-8cba-01aafd928e25@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1166b629-92a0-47d5-8cba-01aafd928e25@vivo.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0A8F1C0003 X-Stat-Signature: knt71pkxjn95xrgguib8gc4jezmqcw4h X-Rspam-User: X-HE-Tag: 1745544665-61138 X-HE-Meta: U2FsdGVkX1++oFM6gnO/Wm5fte+TIES94IKOiAZHoNycirVseVOPbJa6XSaSUv0LQaogU/6m/bIgbBR8lzvyC/yQkt1qUuaoDhmVqNvTDQrCMGlZt4Qa5CB7n3TJzcaw4rGUYbPMoGSpEMhODzIIUSKlCwrVdE923apa9YYDxqy2u5HCJooDhKU5KzBgy6B6A5qppJ6THt3ACrqreyCA9qUF/zn0wVe/G+yHZySrB2lWBElkRWT9FNPF3qaOvZUMHENXwFn1+z5GkilnuUCG067/4bNdAH/rQJenEcnhNwZFMzV2zvrNWHdjh80Fd8XFk300TcA5Ayf+o7DhnoltsIZC5u+YwyjVYNBYMH49UmOpFZsixfBXFsROBEU0kwWgal0ZYi1HI+8VBoxZhD4AVRolorbvZNnBohTWhugvnoxhL3nYXwzzL8d6ri2Kb3Rqr2se8wQ+PxFru7/Axvx6J8a+BCP6OO5sE2Mgq9R54qE2NFGmjo5tmKxT09SDjmE4eYHG6OycKQAvvAKn2GWirD7bMPBg8IB7p2pLhqMg8DAb6GcN/bwCMZPsvUNfxialdNyfn93vUJdGeTlQAgz06QU1QuTzhvPGH4DSqQObsziaSI4j9swVUB05koybwesFEzp/Xg9dHr6qzNWQ8DQgIYuYqHw/+90LqXUBeDMp4SGR3QZbJtGDrdpg9pP3NSSIUkVsfx5c7BR/7xwHWEfAOd/785cxYWYgjQdXPkEwbHE70D6nshMIwIIcgdd1raxmnKamN1h81etB6bCImUQIfZnDJXwlH/jC0qu5OycaKCqY7G0k7vk3NFrOAIcTjf3El48lqs/VN1wxlqAApWMSL8Eh5X5wAUC12TWGB26hTiYqEjq1krT11DDd9ZZztD0+TYR5uVCniqjvkC5wlJbrCxjPrwqBdUzz7ED1+Pyfft8NKR7j3RWZSNZk65D5tkpOSqRbqdrwi8KnAFcPj1M ZGVXQlwi zo7PhY1CFZUZDgPPa1S83ToHnyRuzkyrQ/ExMJHvBsIoz+KolxRFX/HzaH1ZXWrbDyDMnsxCSQ4xbai6MfSWZiMIvHsf9kNn+6iTRG/9vLzB5MtMXd3dA8JI7sSSm6+iLZFiFW4mJ0Z+Ni9p4wB/TgUMVMUmkHbrjqGiIn1JyQ0h8Q4u88XNGX+isWBbQFvRdZJbfE+YIfuITteprjbaa3jPySShPNsUDZKb/o3RrgA1pcr4b8R4xAEAeJN7UJ+AEmhVrPP3jXB0F50TlThTkT6CjHEPANtSMVxdu75UzxAWwxA2ircs2HLI7f5ZlBKxW+/SfyLfrMLH/LpljGIGXJWjGQ3IAmGcEUEWK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 25, 2025 at 09:11:01AM +0800, Huan Yang wrote: > Hi Shakeel > > 在 2025/4/25 07:00, Shakeel Butt 写道: > > On Thu, Apr 24, 2025 at 09:00:01AM -0700, Shakeel Butt wrote: > > > On Thu, Apr 24, 2025 at 08:09:29PM +0800, Huan Yang wrote: > > > > When cgroup_init() creates root_mem_cgroup through css_online callback, > > > > some critical resources might not be fully initialized, forcing later > > > > operations to perform conditional checks for resource availability. > > > > > > > > This patch introduces mem_cgroup_early_init() to address the init order, > > > > it invoke before cgroup_init, so, compare mem_cgroup_init which invoked > > > > by initcall, mem_cgroup_early_init can use to prepare some key resources > > > > before root_mem_cgroup alloc. > > > > > > > > Signed-off-by: Huan Yang > > > > Suggested-by: Shakeel Butt > > > Please move this patch as the first patch of the series and also remove > > > the "early" from the function name as it has a different meaning in the > > > context of cgroup init. Something like either memcg_init() or > > > memcg_kmem_caches_init(). > > BTW I think just putting this kmem cache creation in mem_cgroup_init() > > and explicitly calling it before cgroup_init() would be fine. In that > > case there would be a single memcg init function. > > Maybe someone also need init something after cgroup init done? > > Currently no, but for furture may need? If that is needed in future then that can be done in future. I would say simply call mem_cgroup_init() before cgroup_init() for now.